Peerplays_Blockchain/peerplays-fc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove websocket_server::synchronous_close

Browse source 
It doesn't work as expected, so get rid of it.
This commit is contained in:
Nathan Hourt 2019-05-07 07:55:40 -05:00
parent b8a03d3a51
commit 0a50ac23e0
3 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
include/fc/network/http/websocket.hpp
View file

@ -55,7 +55,6 @@ namespace fc { namespace http {
void stop_listening();
void close();
void synchronous_close();
private:
friend class detail::websocket_server_impl;

8
src/network/http/websocket.cpp
View file

@ -649,14 +649,6 @@ namespace fc { namespace http {
my->_server.close(connection.first, websocketpp::close::status::normal, "Goodbye");
}
void websocket_server::synchronous_close()
{
close();
if (my->_closed)
my->_closed->wait();
}
websocket_tls_server::websocket_tls_server( const string& server_pem, const string& ssl_password ):my( new detail::websocket_tls_server_impl(server_pem, ssl_password) ) {}

4
tests/api_tests.cpp
View file

@ -90,7 +90,7 @@ BOOST_AUTO_TEST_CASE(login_test) {
BOOST_CHECK(remote_triggered);
client->synchronous_close();
server->synchronous_close();
server->close();
fc::usleep(fc::milliseconds(50));
client.reset();
server.reset();
@ -131,7 +131,7 @@ BOOST_AUTO_TEST_CASE(optionals_test) {
BOOST_CHECK_EQUAL(remote_optionals->foo("a", {}, "c"), "[\"a\",null,\"c\"]");
client->synchronous_close();
server->synchronous_close();
server->close();
fc::usleep(fc::milliseconds(50));
client.reset();
server.reset();