Peerplays_Blockchain/peerplays-fc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

variant.cpp: Tighten bool parsing in variant::as_bool() cryptonomex/graphene#525

Browse source
This commit is contained in:
theoreticalbts 2016-01-21 15:29:41 -05:00
parent 9128edb0d6
commit 46ed830373
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/variant.cpp
View file

@ -431,7 +431,14 @@ bool variant::as_bool()const
switch( get_type() )
{
case string_type:
return **reinterpret_cast<const const_string_ptr*>(this) == "true";
{
const string& s = **reinterpret_cast<const const_string_ptr*>(this);
if( s == "true" )
return true;
if( s == "false" )
return false;
FC_THROW_EXCEPTION( bad_cast_exception, "Cannot convert string to bool (only \"true\" or \"false\" can be converted)" );
}
case double_type:
return *reinterpret_cast<const double*>(this) != 0.0;
case int64_type: