From d5b2be278206ca2251afbbeda0b0dd21b59d620a Mon Sep 17 00:00:00 2001 From: John Jones Date: Mon, 4 Mar 2019 17:02:14 -0500 Subject: [PATCH 1/3] Equality check does not work on Windows --- tests/variant_test.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/variant_test.cpp b/tests/variant_test.cpp index 12c66bc..8aca32c 100644 --- a/tests/variant_test.cpp +++ b/tests/variant_test.cpp @@ -70,7 +70,10 @@ BOOST_AUTO_TEST_CASE( types_edge_cases_test ) sv::tag_type current_value = variant_with_tagtype.get(); BOOST_CHECK_EQUAL( current_value, init_value ); +#ifndef _WIN32 + // this does not work in Windows. See Issue #1593 BOOST_CHECK( variant_with_tagtype == init_value ); +#endif for (sv::tag_type i = variant_with_tagtype.count(); i-->0;) { From d9634f8755b9c8648af74c884d2ee437c13e4748 Mon Sep 17 00:00:00 2001 From: John Jones Date: Tue, 5 Mar 2019 13:03:09 -0500 Subject: [PATCH 2/3] assist MSVC with comparison --- tests/variant_test.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/variant_test.cpp b/tests/variant_test.cpp index 8aca32c..9e12cd5 100644 --- a/tests/variant_test.cpp +++ b/tests/variant_test.cpp @@ -70,10 +70,7 @@ BOOST_AUTO_TEST_CASE( types_edge_cases_test ) sv::tag_type current_value = variant_with_tagtype.get(); BOOST_CHECK_EQUAL( current_value, init_value ); -#ifndef _WIN32 - // this does not work in Windows. See Issue #1593 - BOOST_CHECK( variant_with_tagtype == init_value ); -#endif + BOOST_CHECK(variant_with_tagtype.get() == init_value); for (sv::tag_type i = variant_with_tagtype.count(); i-->0;) { From d22f9ed6346c68cc8117057042739e04201fbe49 Mon Sep 17 00:00:00 2001 From: John Jones Date: Tue, 5 Mar 2019 13:04:44 -0500 Subject: [PATCH 3/3] whitespace fix --- tests/variant_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/variant_test.cpp b/tests/variant_test.cpp index 9e12cd5..96e62b5 100644 --- a/tests/variant_test.cpp +++ b/tests/variant_test.cpp @@ -70,7 +70,7 @@ BOOST_AUTO_TEST_CASE( types_edge_cases_test ) sv::tag_type current_value = variant_with_tagtype.get(); BOOST_CHECK_EQUAL( current_value, init_value ); - BOOST_CHECK(variant_with_tagtype.get() == init_value); + BOOST_CHECK( variant_with_tagtype.get() == init_value ); for (sv::tag_type i = variant_with_tagtype.count(); i-->0;) {