From 769dd980b7f08d4aab9cec79871ba3f5720b4059 Mon Sep 17 00:00:00 2001
From: abitmore <abitmore@users.noreply.github.com>
Date: Wed, 14 Mar 2018 05:32:42 -0400
Subject: [PATCH] Add tests for nested class object serialization

---
 tests/serialization_test.cpp | 102 ++++++++++++++++++++++++++++++++---
 1 file changed, 94 insertions(+), 8 deletions(-)

diff --git a/tests/serialization_test.cpp b/tests/serialization_test.cpp
index 1e35f86..eedc982 100644
--- a/tests/serialization_test.cpp
+++ b/tests/serialization_test.cpp
@@ -7,8 +7,8 @@
 namespace fc { namespace test {
 
    struct item;
-   inline bool operator < ( const item& a, const item& b );
    inline bool operator == ( const item& a, const item& b );
+   inline bool operator < ( const item& a, const item& b );
 
    struct item_wrapper
    {
@@ -16,8 +16,11 @@ namespace fc { namespace test {
       item_wrapper(item&& it) { v.reserve(1); v.insert( it ); }
       boost::container::flat_set<struct item> v;
    };
-   inline bool operator < ( const item_wrapper& a, const item_wrapper& b );
-   inline bool operator == ( const item_wrapper& a, const item_wrapper& b );
+
+   inline bool operator == ( const item_wrapper& a, const item_wrapper& b )
+   { return ( std::tie( a.v ) == std::tie( b.v ) ); }
+   inline bool operator < ( const item_wrapper& a, const item_wrapper& b )
+   { return ( std::tie( a.v ) < std::tie( b.v ) ); }
 
    struct item
    {
@@ -29,17 +32,62 @@ namespace fc { namespace test {
 
    inline bool operator == ( const item& a, const item& b )
    { return ( std::tie( a.level, a.w ) == std::tie( b.level, b.w ) ); }
-
    inline bool operator < ( const item& a, const item& b )
    { return ( std::tie( a.level, a.w ) < std::tie( b.level, b.w ) ); }
 
-   inline bool operator == ( const item_wrapper& a, const item_wrapper& b )
+   class class_item;
+
+   class class_item_wrapper
+   {
+      public:
+         class_item_wrapper() {}
+         class_item_wrapper(class_item&& it) { v.reserve(1); v.emplace_back( it ); }
+         std::vector<class class_item> v;
+   };
+   inline bool operator == ( const class_item_wrapper& a, const class_item_wrapper& b )
    { return ( std::tie( a.v ) == std::tie( b.v ) ); }
 
-   inline bool operator < ( const item_wrapper& a, const item_wrapper& b )
-   { return ( std::tie( a.v ) < std::tie( b.v ) ); }
+   class class_item
+   {
+      public:
+         class_item(int32_t lvl = 0) : level(lvl) {}
+         class_item(class_item_wrapper&& wp, int32_t lvl = 0) : level(lvl), w(wp) {}
+         int32_t            level;
+         class_item_wrapper w;
+   };
+   inline bool operator == ( const class_item& a, const class_item& b )
+   { return ( std::tie( a.level, a.w ) == std::tie( b.level, b.w ) ); }
 
-} }
+   template<typename Stream>
+   void operator >> ( Stream& s, class_item_wrapper& w )
+   {
+      fc::raw::unpack( s, w.v );
+   }
+   template<typename Stream>
+   void operator << ( Stream& s, const class_item_wrapper& w )
+   {
+      fc::raw::pack( s, w.v );
+   }
+
+   template<typename Stream>
+   void operator >> ( Stream& s, class_item& it )
+   {
+      fc::raw::unpack( s, it.level );
+      fc::raw::unpack( s, it.w );
+   }
+   template<typename Stream>
+   void operator << ( Stream& s, const class_item& it )
+   {
+      fc::raw::pack( s, it.level );
+      fc::raw::pack( s, it.w );
+   }
+
+} } // namespace fc::test
+
+namespace fc {
+   template<> struct get_typename<fc::test::class_item>  { static const char* name()  { return "class_item";  } };
+   template<> struct get_typename<fc::test::class_item_wrapper>  { static const char* name()  { return "class_item_wrapper";  } };
+}
 
 FC_REFLECT( fc::test::item_wrapper, (v) );
 FC_REFLECT( fc::test::item, (level)(w) );
@@ -63,6 +111,20 @@ BOOST_AUTO_TEST_CASE( nested_objects_test )
       return nested;
    };
 
+   auto create_nested_class_object = []( uint32_t level )
+   {
+      ilog( "Creating nested class object with ${lv} level(s)", ("lv",level) );
+      fc::test::class_item nested;
+      for( uint32_t i = 1; i <= level; i++ )
+      {
+         if( i % 100 == 0 )
+            ilog( "Creating level ${lv}", ("lv",i) );
+         fc::test::class_item_wrapper wp( std::move(nested) );
+         nested = fc::test::class_item( std::move(wp), i );
+      }
+      return nested;
+   };
+
    // 100 levels, should be allowed
    {
       auto nested = create_nested_object( 100 );
@@ -103,6 +165,30 @@ BOOST_AUTO_TEST_CASE( nested_objects_test )
       BOOST_CHECK_THROW( fc::raw::unpack( ss, unpacked ), fc::assert_exception );
    }
 
+   // 150 levels, by default packing will fail
+   {
+      auto nested = create_nested_class_object( 150 );
+
+      std::stringstream ss;
+
+      BOOST_TEST_MESSAGE( "About to pack." );
+      BOOST_CHECK_THROW( fc::raw::pack( ss, nested ), fc::assert_exception );
+   }
+
+   // 150 levels and allow packing, unpacking will fail
+   {
+      auto nested = create_nested_object( 150 );
+
+      std::stringstream ss;
+
+      BOOST_TEST_MESSAGE( "About to pack." );
+      fc::raw::pack( ss, nested, 1500 );
+
+      BOOST_TEST_MESSAGE( "About to unpack as class object." );
+      fc::test::class_item unpacked;
+      BOOST_CHECK_THROW( fc::raw::unpack( ss, unpacked ), fc::assert_exception );
+   }
+
 } FC_CAPTURE_LOG_AND_RETHROW ( (0) ) }
 
 BOOST_AUTO_TEST_SUITE_END()