From cce644f686f78491e6823845dd585fcb1e52ef49 Mon Sep 17 00:00:00 2001 From: Nathan Hourt Date: Thu, 29 Aug 2019 11:26:34 -0500 Subject: [PATCH] Fix warnings The `appender` class is intended to be inherited and used polymorphically, but does not have a virtual destructor, which causes warnings. This adds a virtual destructor to fix these warnings. --- include/fc/log/appender.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/include/fc/log/appender.hpp b/include/fc/log/appender.hpp index f8f442f..518c734 100644 --- a/include/fc/log/appender.hpp +++ b/include/fc/log/appender.hpp @@ -34,6 +34,7 @@ namespace fc { return register_appender( type, appender_factory::ptr( new detail::appender_factory_impl() ) ); } + virtual ~appender() = default; static appender::ptr create( const std::string& name, const std::string& type, const variant& args ); static appender::ptr get( const std::string& name ); static bool register_appender( const std::string& type, const appender_factory::ptr& f );