Peerplays_Blockchain/peerplays-fc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Issue-13-fix (websocket shutdown) #17

Merged
pblockc merged 1 commit from issue-13-fix-websocket into latest-fc 2020-08-11 14:53:57 +00:00
Conversation 6 Commits 1 Files changed 2 +27 -19
pblockc commented 2020-07-06 01:31:22 +00:00 (Migrated from gitlab.com)
Copy link

Initial fix for hang or crash of websocket has been submitted. But this won't address actual issue.

Note: Peerplays fc library is out of sync to port any fixes from bitshares. After 18.04 upgrade, there has been lot of improvements made on the fc library which needs to be brought into Peerplays for better performance and avoid black swans.
Before testing current websocket fix, the changes need to be brought in along with any applicable fixes on application layer.

Initial fix for hang or crash of websocket has been submitted. But this won't address actual issue. Note: Peerplays fc library is out of sync to port any fixes from bitshares. After 18.04 upgrade, there has been lot of improvements made on the fc library which needs to be brought into Peerplays for better performance and avoid black swans. Before testing current websocket fix, the changes need to be brought in along with any applicable fixes on application layer.
bobinson (Migrated from gitlab.com) approved these changes 2020-07-06 01:31:22 +00:00
pblockc commented 2020-07-06 01:33:54 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue PBSA/peerplays#13

mentioned in issue PBSA/peerplays#13
bobinson commented 2020-07-08 17:32:51 +00:00 (Migrated from gitlab.com)
Copy link

Note: Peerplays fc library is out of sync to port any fixes from bitshares. After 18.04 upgrade, there has been lot of improvements made on the fc library which needs to be brought into Peerplays for better performance and avoid black swans. Before testing current websocket fix, the changes need to be brought in along with any applicable fixes on application layer.

@pblockc - can you create a new issue with

  1. list of changes required for FC
  2. List of changes required of Websocket library
  3. The lists can be partial and we can repeat the process multiple times and complete the fixes.
> Note: Peerplays fc library is out of sync to port any fixes from bitshares. After 18.04 upgrade, there has been lot of improvements made on the fc library which needs to be brought into Peerplays for better performance and avoid black swans. Before testing current websocket fix, the changes need to be brought in along with any applicable fixes on application layer. @pblockc - can you create a new issue with 1. list of changes required for FC 2. List of changes required of Websocket library 3. The lists can be partial and we can repeat the process multiple times and complete the fixes.
bobinson commented 2020-07-08 17:37:39 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue PBSA/PeerplaysIO/house-keeping/renumeration#2

mentioned in issue PBSA/PeerplaysIO/house-keeping/renumeration#2
pblockc commented 2020-07-09 14:15:21 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue PBSA/peerplays#15

mentioned in issue PBSA/peerplays#15
bobinson commented 2020-08-11 14:53:43 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
bobinson commented 2020-08-11 14:53:57 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 8dd2fbe1b6

mentioned in commit 8dd2fbe1b6a669b72dadfaa1ccb52f2f04a72f5b
bobinson (Migrated from gitlab.com) merged commit 8dd2fbe1b6 into latest-fc 2020-08-11 14:53:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
bobinson
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays-fc#17
No description provided.
Delete branch "issue-13-fix-websocket"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?