Peerplays_Blockchain/peerplays-fc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix memory leak. Not all tasks are deleted in thread_d dtor #8

Merged
pbsa-gitlab merged 1 commit from feature/GRPH-147 into latest-fc 2019-11-21 16:26:52 +00:00
Conversation 3 Commits 1 Files changed 2 +16 -5
pbsa-gitlab commented 2019-11-12 08:18:14 +00:00 (Migrated from gitlab.com)
Copy link

Created by: srpatel19590

In thread::quit()
{
...
my->start_next_fiber(true)
...
}
my->start_next_fiber(true) - an exception is raised from here and a context has yet a pointer to the task that will never released and memory will not freed.
So to avoid such situation in ~thread_d() lets release it.

Reference: https://github.com/bitshares/bitshares-fc/pull/130

*Created by: srpatel19590* In thread::quit() { ... my->start_next_fiber(true) ... } my->start_next_fiber(true) - an exception is raised from here and a context has yet a pointer to the task that will never released and memory will not freed. So to avoid such situation in ~thread_d() lets release it. Reference: https://github.com/bitshares/bitshares-fc/pull/130
pbsa-gitlab commented 2019-11-21 07:58:27 +00:00 (Migrated from gitlab.com)
Copy link

Created by: srpatel19590

@oxarbitrage I've been instructed to raise PR in latest-fc. @pbattu123 please share the FC Gitflow

*Created by: srpatel19590* @oxarbitrage I've been instructed to raise PR in `latest-fc`. @pbattu123 please share the FC Gitflow
pbsa-gitlab commented 2019-11-21 14:34:45 +00:00 (Migrated from gitlab.com)
Copy link

Created by: pbattu123

Unsure if latest-fc is the branch we want to merge this or just directly master. Please explain briefly for the record the FC flow.

Code looks good.

Git flow for fc:

  • Any updates would go into latest-fc branch as there might be a relevant code changes on develop. Develop(fc submodule) branch would always point to latest-fc.
  • During the testnet/mainnet releases, fc/latest-fc branch would be merged with fc/develop and Devops guy will push the changes to master.
*Created by: pbattu123* > Unsure if `latest-fc` is the branch we want to merge this or just directly `master`. Please explain briefly for the record the FC flow. > > Code looks good. Git flow for fc: - Any updates would go into latest-fc branch as there might be a relevant code changes on develop. Develop(fc submodule) branch would always point to latest-fc. - During the testnet/mainnet releases, fc/latest-fc branch would be merged with fc/develop and Devops guy will push the changes to master.
pbsa-gitlab commented 2019-11-21 16:26:52 +00:00 (Migrated from gitlab.com)
Copy link

Created by: oxarbitrage

Thank you @pbattu123

*Created by: oxarbitrage* Thank you @pbattu123
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays-fc#8
No description provided.
Delete branch "feature/GRPH-147"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?