Peerplays_Blockchain/peerplays-fc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GRPH-46-AddQuitCommandToCliWallet - Add Quit command to CLI Wallet #9

Merged
gladcow merged 1 commit from feature/GRPH-46 into latest-fc 2019-12-06 16:34:34 +00:00
Conversation 3 Commits 1 Files changed 1 +5
gladcow commented 2019-11-12 10:53:12 +00:00 (Migrated from gitlab.com)
Copy link

Add quit command to the CLI Wallet.
Required for https://github.com/peerplays-network/peerplays/pull/90.
Backport of the Bitshares https://github.com/bitshares/bitshares-fc/pull/63

Add `quit` command to the CLI Wallet. Required for https://github.com/peerplays-network/peerplays/pull/90. Backport of the Bitshares https://github.com/bitshares/bitshares-fc/pull/63
pbsa-gitlab commented 2019-11-16 13:32:31 +00:00 (Migrated from gitlab.com)
Copy link

Created by: oxarbitrage

There were some additional problems with this command in bitshares iirc.
Check for example: https://github.com/bitshares/bitshares-fc/blob/master/src/rpc/cli.cpp#L114
I will make some tests but i think something could be missing for the command to work properly.

*Created by: oxarbitrage* There were some additional problems with this command in bitshares iirc. Check for example: https://github.com/bitshares/bitshares-fc/blob/master/src/rpc/cli.cpp#L114 I will make some tests but i think something could be missing for the command to work properly.
gladcow commented 2019-12-02 09:31:22 +00:00 (Migrated from gitlab.com)
Copy link

@oxarbitrage , Bitshares has much more complex CLI than Peerplays, that's why it has more complex exit procedure. In particular, the code you are talking about is added in https://github.com/bitshares/bitshares-core/pull/1695, that is not backported by the Peerplays. We should add this code after we adopt additional CLI features from Bitshares (complex command completion and command history). I've tested the current implementation and haven't reproduced any issues with CLI wallet exit.

@oxarbitrage , Bitshares has much more complex CLI than Peerplays, that's why it has more complex exit procedure. In particular, the code you are talking about is added in https://github.com/bitshares/bitshares-core/pull/1695, that is not backported by the Peerplays. We should add this code after we adopt additional CLI features from Bitshares (complex command completion and command history). I've tested the current implementation and haven't reproduced any issues with CLI wallet exit.
pbsa-gitlab commented 2019-12-02 13:37:00 +00:00 (Migrated from gitlab.com)
Copy link

Created by: oxarbitrage

ok, that makes sense. thanks. lets do it then.

*Created by: oxarbitrage* ok, that makes sense. thanks. lets do it then.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays-fc#9
No description provided.
Delete branch "feature/GRPH-46"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?