peerplays_migrated/libraries/chain/db_balance.cpp

266 lines
9 KiB
C++
Raw Normal View History

2017-05-25 09:13:59 +00:00
/*
* Copyright (c) 2015 Cryptonomex, Inc., and contributors.
*
* The MIT License
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
#include <graphene/chain/database.hpp>
#include <graphene/chain/account_object.hpp>
#include <graphene/chain/asset_object.hpp>
2017-12-06 07:40:52 +00:00
#include <graphene/chain/balance_object.hpp>
2017-05-25 09:13:59 +00:00
#include <graphene/chain/vesting_balance_object.hpp>
#include <graphene/chain/witness_object.hpp>
namespace graphene { namespace chain {
asset database::get_balance(account_id_type owner, asset_id_type asset_id) const
{
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
auto& index = get_index_type< primary_index< account_balance_index > >().get_secondary_index<balances_by_account_index>();
auto abo = index.get_account_balance( owner, asset_id );
if( !abo )
2017-05-25 09:13:59 +00:00
return asset(0, asset_id);
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
return abo->get_balance();
2017-05-25 09:13:59 +00:00
}
asset database::get_balance(const account_object& owner, const asset_object& asset_obj) const
{
return get_balance(owner.get_id(), asset_obj.get_id());
}
2017-12-06 07:40:52 +00:00
asset database::get_balance(asset_id_type lottery_id)const
{
auto& index = get_index_type<lottery_balance_index>().indices().get<by_owner>();
auto itr = index.find( lottery_id );
if( itr == index.end() )
return asset(0, asset_id_type( ));
return itr->get_balance();
}
2017-05-25 09:13:59 +00:00
string database::to_pretty_string( const asset& a )const
{
return a.asset_id(*this).amount_to_pretty_string(a.amount);
}
void database::adjust_balance(account_id_type account, asset delta )
{ try {
if( delta.amount == 0 )
return;
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
auto& index = get_index_type< primary_index< account_balance_index > >().get_secondary_index<balances_by_account_index>();
auto abo = index.get_account_balance( account, delta.asset_id );
if( !abo )
2017-05-25 09:13:59 +00:00
{
FC_ASSERT( delta.amount > 0, "Insufficient Balance: ${a}'s balance of ${b} is less than required ${r}",
("a",account(*this).name)
("b",to_pretty_string(asset(0,delta.asset_id)))
("r",to_pretty_string(-delta)));
create<account_balance_object>([account,&delta](account_balance_object& b) {
b.owner = account;
b.asset_type = delta.asset_id;
b.balance = delta.amount.value;
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
if( b.asset_type == asset_id_type() ) // CORE asset
b.maintenance_flag = true;
2017-05-25 09:13:59 +00:00
});
} else {
if( delta.amount < 0 )
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
FC_ASSERT( abo->get_balance() >= -delta, "Insufficient Balance: ${a}'s balance of ${b} is less than required ${r}",
("a",account(*this).name)("b",to_pretty_string(abo->get_balance()))("r",to_pretty_string(-delta)));
modify(*abo, [delta](account_balance_object& b) {
2017-05-25 09:13:59 +00:00
b.adjust_balance(delta);
});
}
} FC_CAPTURE_AND_RETHROW( (account)(delta) ) }
2017-12-06 07:40:52 +00:00
void database::adjust_balance(asset_id_type lottery_id, asset delta)
{
if( delta.amount == 0 )
return;
auto& index = get_index_type<lottery_balance_index>().indices().get<by_owner>();
auto itr = index.find(lottery_id);
if(itr == index.end())
{
FC_ASSERT( delta.amount > 0, "Insufficient Balance: ${a}'s balance is less than required ${r}",
("a",lottery_id)
("b","test")
("r",to_pretty_string(-delta)));
create<lottery_balance_object>([lottery_id,&delta](lottery_balance_object& b) {
b.lottery_id = lottery_id;
b.balance = asset(delta.amount, delta.asset_id);
});
} else {
if( delta.amount < 0 )
FC_ASSERT( itr->get_balance() >= -delta, "Insufficient Balance: ${a}'s balance of ${b} is less than required ${r}", ("a",lottery_id)("b",to_pretty_string(itr->get_balance()))("r",to_pretty_string(-delta)));
modify(*itr, [delta](lottery_balance_object& b) {
b.adjust_balance(delta);
});
}
}
void database::adjust_sweeps_vesting_balance(account_id_type account, int64_t delta)
{
if( delta == 0 )
return;
2019-08-02 13:47:32 +00:00
asset_id_type asset_id = get_global_properties().parameters.sweeps_distribution_asset();
2017-12-06 07:40:52 +00:00
auto& index = get_index_type<sweeps_vesting_balance_index>().indices().get<by_owner>();
auto itr = index.find(account);
if(itr == index.end())
{
FC_ASSERT( delta > 0, "Insufficient Balance: ${a}'s balance of ${b} is less than required ${r}",
("a",account)
("b","test")
("r",-delta));
create<sweeps_vesting_balance_object>([account,&delta,&asset_id](sweeps_vesting_balance_object& b) {
b.owner = account;
b.asset_id = asset_id;
b.balance = delta;
});
} else {
if( delta < 0 )
FC_ASSERT( itr->get_balance() >= -delta, "Insufficient Balance: ${a}'s balance of ${b} is less than required ${r}", ("a",account)("b",itr->get_balance())("r",-delta));
2017-12-12 12:37:58 +00:00
modify(*itr, [&delta,&asset_id,this](sweeps_vesting_balance_object& b) {
2017-12-06 07:40:52 +00:00
b.adjust_balance( asset( delta, asset_id ) );
2017-12-12 12:37:58 +00:00
b.last_claim_date = head_block_time();
2017-12-06 07:40:52 +00:00
});
}
}
2017-05-25 09:13:59 +00:00
optional< vesting_balance_id_type > database::deposit_lazy_vesting(
const optional< vesting_balance_id_type >& ovbid,
share_type amount, uint32_t req_vesting_seconds,
account_id_type req_owner,
bool require_vesting )
{
if( amount == 0 )
return optional< vesting_balance_id_type >();
fc::time_point_sec now = head_block_time();
while( true )
{
if( !ovbid.valid() )
break;
const vesting_balance_object& vbo = (*ovbid)(*this);
if( vbo.owner != req_owner )
break;
if( vbo.policy.which() != vesting_policy::tag< cdd_vesting_policy >::value )
break;
if( vbo.policy.get< cdd_vesting_policy >().vesting_seconds != req_vesting_seconds )
break;
modify( vbo, [&]( vesting_balance_object& _vbo )
{
if( require_vesting )
_vbo.deposit(now, amount);
else
_vbo.deposit_vested(now, amount);
} );
return optional< vesting_balance_id_type >();
}
const vesting_balance_object& vbo = create< vesting_balance_object >( [&]( vesting_balance_object& _vbo )
{
_vbo.owner = req_owner;
_vbo.balance = amount;
cdd_vesting_policy policy;
policy.vesting_seconds = req_vesting_seconds;
policy.coin_seconds_earned = require_vesting ? 0 : amount.value * policy.vesting_seconds;
policy.coin_seconds_earned_last_update = now;
_vbo.policy = policy;
} );
return vbo.id;
}
void database::deposit_cashback(const account_object& acct, share_type amount, bool require_vesting)
{
// If we don't have a VBO, or if it has the wrong maturity
// due to a policy change, cut it loose.
if( amount == 0 )
return;
if( acct.get_id() == GRAPHENE_COMMITTEE_ACCOUNT || acct.get_id() == GRAPHENE_WITNESS_ACCOUNT ||
acct.get_id() == GRAPHENE_RELAXED_COMMITTEE_ACCOUNT || acct.get_id() == GRAPHENE_NULL_ACCOUNT ||
acct.get_id() == GRAPHENE_TEMP_ACCOUNT )
{
// The blockchain's accounts do not get cashback; it simply goes to the reserve pool.
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
modify( get_core_dynamic_data(), [amount](asset_dynamic_data_object& d) {
2017-05-25 09:13:59 +00:00
d.current_supply -= amount;
});
return;
}
optional< vesting_balance_id_type > new_vbid = deposit_lazy_vesting(
acct.cashback_vb,
amount,
get_global_properties().parameters.cashback_vesting_period_seconds,
acct.id,
require_vesting );
if( new_vbid.valid() )
{
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
modify( acct, [&new_vbid]( account_object& _acct )
2017-05-25 09:13:59 +00:00
{
_acct.cashback_vb = *new_vbid;
} );
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
modify( acct.statistics( *this ), []( account_statistics_object& aso )
{
aso.has_cashback_vb = true;
} );
2017-05-25 09:13:59 +00:00
}
return;
}
void database::deposit_witness_pay(const witness_object& wit, share_type amount)
{
if( amount == 0 )
return;
optional< vesting_balance_id_type > new_vbid = deposit_lazy_vesting(
wit.pay_vb,
amount,
get_global_properties().parameters.witness_pay_vesting_seconds,
wit.witness_account,
true );
if( new_vbid.valid() )
{
modify( wit, [&]( witness_object& _wit )
{
_wit.pay_vb = *new_vbid;
} );
}
return;
}
} }