peerplays_migrated/libraries/chain/proposal_evaluator.cpp

326 lines
14 KiB
C++
Raw Normal View History

2015-06-08 15:50:35 +00:00
/*
2015-10-12 17:48:40 +00:00
* Copyright (c) 2015 Cryptonomex, Inc., and contributors.
*
* The MIT License
2015-10-12 17:48:40 +00:00
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
2015-10-12 17:48:40 +00:00
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
2015-10-12 17:02:59 +00:00
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
2015-06-08 15:50:35 +00:00
*/
#include <graphene/chain/hardfork.hpp>
2015-06-08 15:50:35 +00:00
#include <graphene/chain/proposal_evaluator.hpp>
#include <graphene/chain/proposal_object.hpp>
#include <graphene/chain/account_object.hpp>
2018-03-22 18:01:56 +00:00
#include <graphene/chain/protocol/account.hpp>
#include <graphene/chain/protocol/fee_schedule.hpp>
#include <graphene/chain/protocol/tournament.hpp>
2015-07-08 20:30:32 +00:00
#include <graphene/chain/exceptions.hpp>
2018-03-22 18:01:56 +00:00
#include <graphene/chain/hardfork.hpp>
2015-06-08 15:50:35 +00:00
#include <fc/smart_ref_impl.hpp>
2015-06-08 15:50:35 +00:00
namespace graphene { namespace chain {
struct proposal_operation_hardfork_visitor
{
typedef void result_type;
const fc::time_point_sec block_time;
proposal_operation_hardfork_visitor( const fc::time_point_sec bt ) : block_time(bt) {}
template<typename T>
void operator()(const T &v) const {}
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
void operator()(const committee_member_update_global_parameters_operation &op) const {}
2018-10-11 11:36:49 +00:00
void operator()(const graphene::chain::tournament_payout_operation &o) const {
// TODO: move check into tournament_payout_operation::validate after HARDFORK_999_TIME
FC_ASSERT( block_time < HARDFORK_999_TIME, "Not allowed!" );
}
void operator()(const graphene::chain::asset_settle_cancel_operation &o) const {
// TODO: move check into asset_settle_cancel_operation::validate after HARDFORK_999_TIME
FC_ASSERT( block_time < HARDFORK_999_TIME, "Not allowed!" );
}
void operator()(const graphene::chain::account_create_operation &aco) const {
// TODO: remove after HARDFORK_999_TIME
if (block_time < HARDFORK_999_TIME)
FC_ASSERT( !aco.extensions.value.affiliate_distributions.valid(), "Affiliate reward distributions not allowed yet" );
}
void operator()(const sport_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "sport_create_operation not allowed yet!" );
}
void operator()(const sport_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "sport_update_operation not allowed yet!" );
}
void operator()(const sport_delete_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "sport_delete_operation not allowed yet!" );
}
void operator()(const event_group_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_group_create_operation not allowed yet!" );
}
void operator()(const event_group_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_group_update_operation not allowed yet!" );
}
void operator()(const event_group_delete_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_group_delete_operation not allowed yet!" );
}
void operator()(const event_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_create_operation not allowed yet!" );
}
void operator()(const event_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_update_operation not allowed yet!" );
}
void operator()(const betting_market_rules_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_rules_create_operation not allowed yet!" );
}
void operator()(const betting_market_rules_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_rules_update_operation not allowed yet!" );
}
void operator()(const betting_market_group_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_create_operation not allowed yet!" );
}
void operator()(const betting_market_create_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_create_operation not allowed yet!" );
}
void operator()(const bet_place_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "bet_place_operation not allowed yet!" );
}
void operator()(const betting_market_group_resolve_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_resolve_operation not allowed yet!" );
}
void operator()(const betting_market_group_cancel_unmatched_bets_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_cancel_unmatched_bets_operation not allowed yet!" );
}
void operator()(const bet_cancel_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "bet_cancel_operation not allowed yet!" );
}
void operator()(const betting_market_group_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_update_operation not allowed yet!" );
}
void operator()(const betting_market_update_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_update_operation not allowed yet!" );
}
void operator()(const event_update_status_operation &v) const {
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_update_status_operation not allowed yet!" );
}
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
void operator()(const vesting_balance_create_operation &vbco) const {
if(block_time < HARDFORK_GPOS_TIME)
FC_ASSERT( vbco.balance_type == vesting_balance_type::normal, "balance_type in vesting create not allowed yet!" );
}
// loop and self visit in proposals
void operator()(const proposal_create_operation &v) const {
for (const op_wrapper &op : v.proposed_ops)
op.op.visit(*this);
}
};
2015-06-23 21:33:06 +00:00
void_result proposal_create_evaluator::do_evaluate(const proposal_create_operation& o)
{ try {
2015-06-08 15:50:35 +00:00
const database& d = db();
proposal_operation_hardfork_visitor vtor( d.head_block_time() );
vtor( o );
2015-06-08 15:50:35 +00:00
const auto& global_parameters = d.get_global_properties().parameters;
FC_ASSERT( o.expiration_time > d.head_block_time(), "Proposal has already expired on creation." );
FC_ASSERT( o.expiration_time <= d.head_block_time() + global_parameters.maximum_proposal_lifetime,
"Proposal expiration time is too far in the future.");
FC_ASSERT( !o.review_period_seconds || fc::seconds(*o.review_period_seconds) < (o.expiration_time - d.head_block_time()),
"Proposal review period must be less than its overall lifetime." );
{
// If we're dealing with the committee authority, make sure this transaction has a sufficient review period.
2015-06-08 15:50:35 +00:00
flat_set<account_id_type> auths;
vector<authority> other;
2015-06-08 15:50:35 +00:00
for( auto& op : o.proposed_ops )
{
operation_get_required_authorities(op.op, auths, auths, other);
}
FC_ASSERT( other.size() == 0 ); // TODO: what about other???
if( auths.find(GRAPHENE_COMMITTEE_ACCOUNT) != auths.end() )
2015-07-08 20:30:32 +00:00
{
GRAPHENE_ASSERT(
o.review_period_seconds.valid(),
proposal_create_review_period_required,
"Review period not given, but at least ${min} required",
("min", global_parameters.committee_proposal_review_period)
);
GRAPHENE_ASSERT(
*o.review_period_seconds >= global_parameters.committee_proposal_review_period,
proposal_create_review_period_insufficient,
"Review period of ${t} specified, but at least ${min} required",
2015-07-08 20:30:32 +00:00
("t", *o.review_period_seconds)
("min", global_parameters.committee_proposal_review_period)
);
}
2015-06-08 15:50:35 +00:00
}
for( const op_wrapper& op : o.proposed_ops )
_proposed_trx.operations.push_back(op.op);
_proposed_trx.validate();
2015-06-23 21:33:06 +00:00
return void_result();
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
object_id_type proposal_create_evaluator::do_apply(const proposal_create_operation& o)
2015-06-23 21:33:06 +00:00
{ try {
2015-06-08 15:50:35 +00:00
database& d = db();
const proposal_object& proposal = d.create<proposal_object>([&](proposal_object& proposal) {
_proposed_trx.expiration = o.expiration_time;
2015-06-08 15:50:35 +00:00
proposal.proposed_transaction = _proposed_trx;
2018-01-29 13:19:38 +00:00
proposal.proposer = o.fee_paying_account;
2015-06-08 15:50:35 +00:00
proposal.expiration_time = o.expiration_time;
if( o.review_period_seconds )
proposal.review_period_time = o.expiration_time - *o.review_period_seconds;
//Populate the required approval sets
flat_set<account_id_type> required_active;
vector<authority> other;
// TODO: consider caching values from evaluate?
for( auto& op : _proposed_trx.operations )
operation_get_required_authorities(op, required_active, proposal.required_owner_approvals, other);
2015-06-08 15:50:35 +00:00
//All accounts which must provide both owner and active authority should be omitted from the active authority set;
//owner authority approval implies active authority approval.
std::set_difference(required_active.begin(), required_active.end(),
proposal.required_owner_approvals.begin(), proposal.required_owner_approvals.end(),
std::inserter(proposal.required_active_approvals, proposal.required_active_approvals.begin()));
});
return proposal.id;
2015-06-23 21:33:06 +00:00
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
2015-06-15 19:24:58 +00:00
void_result proposal_update_evaluator::do_evaluate(const proposal_update_operation& o)
2015-06-23 21:33:06 +00:00
{ try {
2015-06-08 15:50:35 +00:00
database& d = db();
_proposal = &o.proposal(d);
if( _proposal->review_period_time && d.head_block_time() >= *_proposal->review_period_time )
FC_ASSERT( o.active_approvals_to_add.empty() && o.owner_approvals_to_add.empty(),
"This proposal is in its review period. No new approvals may be added." );
for( account_id_type id : o.active_approvals_to_remove )
{
FC_ASSERT( _proposal->available_active_approvals.find(id) != _proposal->available_active_approvals.end(),
"", ("id", id)("available", _proposal->available_active_approvals) );
}
for( account_id_type id : o.owner_approvals_to_remove )
{
FC_ASSERT( _proposal->available_owner_approvals.find(id) != _proposal->available_owner_approvals.end(),
"", ("id", id)("available", _proposal->available_owner_approvals) );
}
2015-06-15 19:24:58 +00:00
return void_result();
2015-06-23 21:33:06 +00:00
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
2015-06-15 19:24:58 +00:00
void_result proposal_update_evaluator::do_apply(const proposal_update_operation& o)
2015-06-23 21:33:06 +00:00
{ try {
2015-06-08 15:50:35 +00:00
database& d = db();
// Potential optimization: if _executed_proposal is true, we can skip the modify step and make push_proposal skip
// signature checks. This isn't done now because I just wrote all the proposals code, and I'm not yet 100% sure the
// required approvals are sufficient to authorize the transaction.
d.modify(*_proposal, [&o, &d](proposal_object& p) {
p.available_active_approvals.insert(o.active_approvals_to_add.begin(), o.active_approvals_to_add.end());
p.available_owner_approvals.insert(o.owner_approvals_to_add.begin(), o.owner_approvals_to_add.end());
for( account_id_type id : o.active_approvals_to_remove )
p.available_active_approvals.erase(id);
for( account_id_type id : o.owner_approvals_to_remove )
p.available_owner_approvals.erase(id);
for( const auto& id : o.key_approvals_to_add )
2015-06-08 15:50:35 +00:00
p.available_key_approvals.insert(id);
for( const auto& id : o.key_approvals_to_remove )
2015-06-08 15:50:35 +00:00
p.available_key_approvals.erase(id);
});
// If the proposal has a review period, don't bother attempting to authorize/execute it.
// Proposals with a review period may never be executed except at their expiration.
if( _proposal->review_period_time )
2015-06-15 19:24:58 +00:00
return void_result();
2015-06-08 15:50:35 +00:00
if( _proposal->is_authorized_to_execute(d) )
2015-06-08 15:50:35 +00:00
{
// All required approvals are satisfied. Execute!
_executed_proposal = true;
try {
_processed_transaction = d.push_proposal(*_proposal);
} catch(fc::exception& e) {
Merge beatrice(GPOS changes) with master (#270) * Created unit test for #325 * remove needless find() * issue - 154: Don't allow to vote when vesting balance is 0 * Increase block creation timeout to 2500ms * increase delay for node connection * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Improved resilience of block database against corruption * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Updated GitLab CI * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed test failures and compilation issue * minor performance improvement * Added comment * Fix compilation in debug mode * Fixed duplicate ops returned from get_account_history * Fixed account_history_pagination test * Removed unrelated comment * Update to fixed version of fc * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * Remove leftover comment from merge * fix for get_vesting_balance API call * braces update * Allow sufficient space for new undo_session * Throw for deep nesting * node.cpp: Check the attacker/buggy client before updating items ids The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case. * Create .gitlab-ci.yml * Added cli_test to CI * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * use random port numbers in app_test (#154) * Changes to compiple with GCC 7(Ubuntu 18.04) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Support/gitlab develop (#168) * Added code_quality to CI * Update .gitlab-ci.yml * Point to PBSA/peerplays-fc commit f13d063 (#167) * [GRPH-3] Additional cli tests (#155) * Additional cli tests * Compatible with latest fc changes * Fixed Spacing issues * [GRPH-106] Added voting tests (#136) * Added more voting tests * Added additional option * Adjust p2p log level (#180) * merge gpos to develop (#186) * issue - 154: Don't allow to vote when vesting balance is 0 * changes to withdraw_vesting feature(for both cdd and GPOS) * Comments update * update to GPOS hardfork ref * fix for get_vesting_balance API call * braces update * Create .gitlab-ci.yml * fixing build errors (#150) * fixing build errors vest type correction * fixing build errors vest type correction * fixes new Dockerfile * vesting_balance_type correction vesting_balance_type changed to normal * gcc5 support to Dockerfile gcc5 support to Dockerfile * Changes to compiple with GCC 7(Ubuntu 18.04) * changes to have separate methods and single withdrawl fee for multiple vest objects * 163-fix, Return only non-zero vesting balances * Revert "Revert "GPOS protocol"" This reverts commit 67616417b7f0b5d087b9862de0e48b2d8ccc1bca. * add new line needed to gpos hardfork file * comment temporally cli_vote_for_2_witnesses until refactor or delete * fix gpos tests * fix gitlab-ci conflict * Fixed few error messages * error message corrections at other places * Updated FC repository to peerplays-network/peerplays-fc (#189) Point to fc commit hash 6096e94 [latest-fc branch] * Project name update in Doxyfile (#146) * changes to allow user to vote in each sub-period * Fixed GPOS vesting factor issue when proxy is set * Added unit test for proxy voting * Review changes * changes to update last voting time * resolve merge conflict * unit test changes and also separated GPOS test suite * delete unused variables * removed witness check * eliminate time gap between two consecutive vesting periods * deleted GPOS specific test suite and updated gpos tests * updated GPOS hf * Fixed dividend distribution issue and added test case * fix flag * clean newlines gpos_tests * adapt gpos_tests to changed flag * Fix to roll in GPOS rules, carry votes from 6th sub-period * check was already modified * comments updated * updated comments to the benefit of reviewer * Added token symbol name in error messages * Added token symbol name in error messages (#204) * case 1: Fixed last voting time issue * get_account bug fixed * Fixed flag issue * Fixed spelling issue * remove non needed gcc5 changes to dockerfile * GRPH134- High CPU Issue, websocket changes (#213) * update submodule branch to refer to the latest commit on latest-fc branch (#214) * Improve account maintenance performance (#130) * Improve account maintenance performance * merge fixes * Fixed merge issue * Fixed indentations and extra ';' * Update CI for syncing gitmodules (#216) * Added logging for the old update_expired_feeds bug The old bug is https://github.com/cryptonomex/graphene/issues/615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * https://github.com/bitshares/bitshares-core/issues/453 * Minor performance improvement for price::is_null() * Use static refs in db_getter for immutable objects * Minor performance improvement for db_maint * Minor code updates for asset_evaluator.cpp * changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda * Improve update_expired_feeds performance #1093 * Change static refs to member pointers of db class * Added getter for witness schedule object * Added getter for core dynamic data object * Use getters * Removed unused variable * Add comments for update_expired_feeds in db_block * Minor refactory asset_create_evaluator::do_apply() * Added FC_ASSERT for dynamic data id of core asset * Added header inclusions in db_management.cpp * fix global objects usage during replay * Logging config parsing issue * added new files * compilation fix * Simplified code in database::pay_workers() * issue with withdrawl * Added unit test for empty account history * set extensions default values * Update GPOS hardfork date and don't allow GPOS features before hardfork time * refer to latest commit of latest-fc branch (#224) * account name or id support in all database api * asset id or name support in all asset APIs * Fixed compilation issues * Fixed alignment issues * Externalized some API templates * Externalize serialization of blocks, tx, ops * Externalized db objects * Externalized genesis serialization * Externalized serialization in protocol library * Undo superfluous change * remove default value for extension parameter * fix compilation issues * GRPH-46-Quit_command_cliwallet * removed multiple function definition * Fixed chainparameter update proposal issue * Move GPOS withdraw logic to have single transaction(also single fee) and update API * Added log for authorization failure of proposal operations * Votes consideration on GPOS activation * bump fc version * fix gpos tests * Bump fc version * Updated gpos/voting_tests * Fixed withdraw vesting bug * Added unit test * Update hardfork date for TESTNET, sync fc module and update logs * avoid wlog as it filling up space * Beatrice hot fix(sync issue fix) * gpos tests fix * Set hardfork date to Jan5th on TESTNET Co-authored-by: Peter Conrad <github.com@quisquis.de> Co-authored-by: John M. Jones <jmjatlanta@gmail.com> Co-authored-by: obucinac <obucinac@users.noreply.github.com> Co-authored-by: Bobinson K B <bobinson@gmail.com> Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> Co-authored-by: Miha Čančula <miha@noughmad.eu> Co-authored-by: Abit <abitmore@users.noreply.github.com> Co-authored-by: Roshan Syed <r.syed@pbsa.info> Co-authored-by: Sandip Patel <sandip@knackroot.com> Co-authored-by: RichardWeiYang <richard.weiyang@gmail.com> Co-authored-by: gladcow <jahr@yandex.ru> Co-authored-by: satyakoneru <satyakoneru.iiith@gmail.com>
2020-02-07 15:53:08 +00:00
d.modify(*_proposal, [&e](proposal_object& p) {
p.fail_reason = e.to_string(fc::log_level(fc::log_level::all));
});
2015-06-08 15:50:35 +00:00
wlog("Proposed transaction ${id} failed to apply once approved with exception:\n----\n${reason}\n----\nWill try again when it expires.",
("id", o.proposal)("reason", e.to_detail_string()));
_proposal_failed = true;
}
}
2015-06-15 19:24:58 +00:00
return void_result();
2015-06-23 21:33:06 +00:00
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
2015-06-15 19:24:58 +00:00
void_result proposal_delete_evaluator::do_evaluate(const proposal_delete_operation& o)
2015-06-23 21:33:06 +00:00
{ try {
2015-06-08 15:50:35 +00:00
database& d = db();
_proposal = &o.proposal(d);
auto required_approvals = o.using_owner_authority? &_proposal->required_owner_approvals
: &_proposal->required_active_approvals;
FC_ASSERT( required_approvals->find(o.fee_paying_account) != required_approvals->end(),
"Provided authority is not authoritative for this proposal.",
("provided", o.fee_paying_account)("required", *required_approvals));
2015-06-15 19:24:58 +00:00
return void_result();
2015-06-23 21:33:06 +00:00
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
2015-06-23 21:33:06 +00:00
void_result proposal_delete_evaluator::do_apply(const proposal_delete_operation& o)
{ try {
2015-06-08 15:50:35 +00:00
db().remove(*_proposal);
2015-06-15 19:24:58 +00:00
return void_result();
2015-06-23 21:33:06 +00:00
} FC_CAPTURE_AND_RETHROW( (o) ) }
2015-06-08 15:50:35 +00:00
} } // graphene::chain