Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

Added logging for the old update_expired_feeds bug

Browse source 
The old bug is https://github.com/cryptonomex/graphene/issues/615 .

Due to the bug, `update_median_feeds()` and `check_call_orders()`
will be called when a feed is not actually expired, normally this
should not affect consensus since calling them should not change
any data in the state.

However, the logging indicates that `check_call_orders()` did
change some data under certain circumstances, specifically, when
multiple limit order matching issue (#453) occurred at same block.
* https://github.com/bitshares/bitshares-core/issues/453
This commit is contained in:
abitmore 2018-07-01 15:01:31 -04:00 committed by gladcow
parent 2f4830a778
commit 8a9d3e7775
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
libraries/chain/db_update.cpp
View file

@ -466,6 +466,9 @@ void database::clear_expired_orders()
void database::update_expired_feeds() void database::update_expired_feeds()
{ {
const auto head_num = head_block_num();
const auto head_time = head_block_time();
bool before_hf_615 = ( head_time < HARDFORK_615_TIME );
auto& asset_idx = get_index_type<asset_index>().indices().get<by_type>(); auto& asset_idx = get_index_type<asset_index>().indices().get<by_type>();
auto itr = asset_idx.lower_bound( true /** market issued */ ); auto itr = asset_idx.lower_bound( true /** market issued */ );
while( itr != asset_idx.end() ) while( itr != asset_idx.end() )
@ -476,16 +479,21 @@ void database::update_expired_feeds()
const asset_bitasset_data_object& b = a.bitasset_data(*this); const asset_bitasset_data_object& b = a.bitasset_data(*this);
bool feed_is_expired; bool feed_is_expired;
if( head_block_time() < HARDFORK_615_TIME ) if( before_hf_615 )
feed_is_expired = b.feed_is_expired_before_hardfork_615( head_block_time() ); feed_is_expired = b.feed_is_expired_before_hardfork_615( head_time );
else else
feed_is_expired = b.feed_is_expired( head_block_time() ); feed_is_expired = b.feed_is_expired( head_time );
if( feed_is_expired ) if( feed_is_expired )
{ {
modify(b, [this](asset_bitasset_data_object& a) { modify(b, [head_time](asset_bitasset_data_object& a) {
a.update_median_feeds(head_block_time()); a.update_median_feeds(head_time);
}); });
check_call_orders(b.current_feed.settlement_price.base.asset_id(*this)); bool called_some = check_call_orders(b.current_feed.settlement_price.base.asset_id(*this));
if( called_some && before_hf_615 )
{
wlog( "Graphene issue #615: called some for asset ${a} on block #${b}, feed really expired: ${f}",
("a", a.symbol) ("b", head_num) ("f", b.feed_is_expired(head_time)) );
}
} }
if( !b.current_feed.core_exchange_rate.is_null() && if( !b.current_feed.core_exchange_rate.is_null() &&
a.options.core_exchange_rate != b.current_feed.core_exchange_rate ) a.options.core_exchange_rate != b.current_feed.core_exchange_rate )