Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

Add compile-time sanity check to generic_index

Browse source 
generic_index::find fails at runtime if the boost multi_index_container's first index is not an index of object_id_type, and the cause of this failure is nonobvious from the error message. This compile-time check will fail if any generic_index is created around a multi_index_container whose first index is not an index on object_id_type, with a helpful error message explaining the problem, so no one else will ever have to debug this issue. :)
This commit is contained in:
Nathan Hourt 2016-07-06 18:18:41 -05:00 committed by GitHub
parent 006d548633
commit a22e628910
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/db/include/graphene/db/generic_index.hpp
View file

@ -80,6 +80,8 @@ namespace graphene { namespace chain {
virtual const object* find( object_id_type id )const override virtual const object* find( object_id_type id )const override
{ {
static_assert(std::is_same<typename MultiIndexType::key_type, object_id_type>::value,
"First index of MultiIndexType MUST be object_id_type!");
auto itr = _indices.find( id ); auto itr = _indices.find( id );
if( itr == _indices.end() ) return nullptr; if( itr == _indices.end() ) return nullptr;
return &*itr; return &*itr;