* Resolve#210: [HF] Check authorities on custom_operation
The required_auths field on custom_operation was being ignored during authority checking. This commit causes it to be checked correctly, and adds a unit test verifying as much.
* Ref #381: Fixes
Build and logic fixes for Pull Request #381
* Ref #381: Fix bad merge
During merge conflict resolution, I accidentally broke custom
authorities. This fixes it.
* compilation fix
Co-authored-by: Nathan Hourt <nathan@followmyvote.com>
Replace all object refs in macros with IDs, and fix affected tests to look
up objects by ID rather than using invalidated refs.
A full audit of all tests should be performed to eliminate any further
usage of invalidated object references.
The CMakeLists.txt declared this project as BitShares and not Peerplays,
which makes it confusing in IDEs. Rename it to be clear which project is
open.
I'm pretty sure this didn't break from what I did... But I can't build
the original code, so I can't tell. Anyways, this one now passes...
Others still fail...
Delete a couple of ghost files that were in the tree but not part
of the project (I accidentally added them to CMakeLists while
merging, but they're broken and not part of the Peerplays code), and
add several files that got dropped from the build during merge.
Define macros to fully de-boilerplate ID type definitions.
Externalities:
- Rename transaction_object -> transaction_history_object
- Rename impl_asset_dynamic_data_type ->
impl_asset_dynamic_data_object_type
- Rename impl_asset_bitasset_data_type ->
impl_asset_bitasset_data_object_type
The first is to avoid a naming collision on transaction_id_type, and the
other two are to maintain consistency with the naming of the other
types.
The ID types, object_id and object_id_type, were defined in the db
library, and the protocol library depends on db to get these types.
Technically, the ID types are defined by the protocol and used by the
database, and not vice versa. Therefore these types should be in the
protocol library, and db should depend on protocol to get them.
This commit makes it so.
