Merge branch 'feature/son-for-ethereum' into feature/420-ethereum-unit-tests

2) get_gas_price
3) get_gas_limit

.gitlab-ci.yml

@@ -9,8 +9,6 @@ stages:
   - build
   - test
   - dockerize
-  - python-test
-  - deploy
 
 build-mainnet:
   stage: build
@@ -46,11 +44,12 @@ test-mainnet:
 
 dockerize-mainnet:
   stage: dockerize
+  dependencies:
+    - test-mainnet
   variables:
     IMAGE: $CI_REGISTRY_IMAGE/mainnet/$CI_COMMIT_REF_SLUG:$CI_COMMIT_SHA
   before_script:
     - docker info
-    - docker builder prune -a -f
     - docker login -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD" $CI_REGISTRY
   script:
     - docker build --no-cache -t $IMAGE .
@@ -59,6 +58,8 @@ dockerize-mainnet:
     - docker rmi $IMAGE
   tags:
     - builder
+  when:
+    manual
   timeout:
     3h
 
@@ -79,27 +80,12 @@ build-testnet:
       - build/libraries/
       - build/programs/
       - build/tests/
-  when: manual
   tags:
     - builder
-
+  when:
-deploy-testnet:
+    manual
-  stage: deploy
+  timeout:
-  dependencies:
+    3h
-    - build-testnet
-  script:
-    - sudo systemctl stop witness
-    - rm $WORK_DIR/peerplays/witness_node || true
-    - cp build/programs/witness_node/witness_node $WORK_DIR/peerplays/
-    - sudo systemctl restart witness
-  rules:
-    - if: $CI_COMMIT_BRANCH == "master"
-      when: always
-  environment:
-    name: devnet
-    url: $DEVNET_URL
-  tags: 
-    - devnet
 
 test-testnet:
   stage: test
@@ -119,6 +105,8 @@ test-testnet:
 
 dockerize-testnet:
   stage: dockerize
+  dependencies:
+    - test-testnet
   variables:
     IMAGE: $CI_REGISTRY_IMAGE/testnet/$CI_COMMIT_REF_SLUG:$CI_COMMIT_SHA
   before_script:
@@ -135,37 +123,3 @@ dockerize-testnet:
     manual
   timeout:
     3h
-
-test-e2e:
-  stage: python-test
-  variables:
-    IMAGE: $CI_REGISTRY_IMAGE/mainnet/$CI_COMMIT_REF_SLUG:$CI_COMMIT_SHA
-  before_script:
-    - docker info
-    - docker login -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD" $CI_REGISTRY
-  script:
-    - git clone https://gitlab.com/PBSA/tools-libs/peerplays-utils.git
-    - cd peerplays-utils/peerplays-qa-environment
-    - git checkout origin/feature/python-e2e-tests-for-CI
-    - cd e2e-tests/
-    - python3 -m venv venv
-    - source venv/bin/activate
-    - pip3 install -r requirements.txt
-    - docker-compose down --remove-orphans
-    - docker ps -a
-    - docker pull $IMAGE
-    - docker tag $IMAGE peerplays-base:latest
-    - docker image ls -a
-    - docker-compose build
-    - python3 main.py --start all
-    - docker ps -a
-    - python3 -m pytest test_btc_init_state.py test_hive_inital_state.py test_pp_inital_state.py
-    - python3 main.py --stop
-    - deactivate
-    - docker ps -a
-  after_script:
-    - docker rmi $(docker images -a | grep -v 'hive-for-peerplays\|ethereum-for-peerplays\|bitcoin-for-peerplays\|ubuntu-for-peerplays' | awk '{print $3}')
-  tags:
-    - python-tests
-  when:
-    manual

Dockerfile

@@ -1,4 +1,5 @@
 FROM ubuntu:20.04
+MAINTAINER Peerplays Blockchain Standards Association
 
 #===============================================================================
 # Ubuntu setup
@@ -10,14 +11,15 @@ RUN \
       apt-utils \
       autoconf \
       bash \
-      bison \
       build-essential \
       ca-certificates \
+      cmake \
       dnsutils \
+      doxygen \
       expect \
-      flex \
       git \
       graphviz \
+      libboost-all-dev \
       libbz2-dev \
       libcurl4-openssl-dev \
       libncurses-dev \
@@ -33,6 +35,7 @@ RUN \
       ntp \
       openssh-server \
       pkg-config \
+      perl \
       python3 \
       python3-jinja2 \
       sudo \
@@ -50,120 +53,35 @@ RUN echo 'peerplays:peerplays' | chpasswd
 # SSH
 EXPOSE 22
 
-WORKDIR /home/peerplays/src
-
-#===============================================================================
-# Boost setup
-#===============================================================================
-
-RUN \
-    wget https://boostorg.jfrog.io/artifactory/main/release/1.72.0/source/boost_1_72_0.tar.gz && \
-    tar -xzf boost_1_72_0.tar.gz && \
-    cd boost_1_72_0 && \
-    ./bootstrap.sh && \
-    ./b2 install && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# cmake setup
-#===============================================================================
-
-RUN \
-    wget https://github.com/Kitware/CMake/releases/download/v3.24.2/cmake-3.24.2-linux-x86_64.sh && \
-    chmod 755 ./cmake-3.24.2-linux-x86_64.sh && \
-    ./cmake-3.24.2-linux-x86_64.sh --prefix=/usr --skip-license && \
-    cmake --version && \
-    rm -rf /home/peerplays/src/*
-
 #===============================================================================
 # libzmq setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.tar.gz && \
+    wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.zip && \
-    tar -xzvf v4.3.4.tar.gz && \
+    unzip v4.3.4.zip && \
     cd libzmq-4.3.4 && \
     mkdir build && \
     cd build && \
     cmake .. && \
-    make -j$(nproc) && \
-    make install && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# cppzmq setup
-#===============================================================================
-
-RUN \
-    wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.9.0.tar.gz && \
-    tar -xzvf v4.9.0.tar.gz && \
-    cd cppzmq-4.9.0 && \
-    mkdir build && \
-    cd build && \
-    cmake .. && \
-    make -j$(nproc) && \
-    make install && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# gsl setup
-#===============================================================================
-
-RUN \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y \
-      libpcre3-dev
-
-RUN \
-    wget https://github.com/imatix/gsl/archive/refs/tags/v4.1.4.tar.gz && \
-    tar -xzvf v4.1.4.tar.gz && \
-    cd gsl-4.1.4 && \
-    make -j$(nproc) && \
-    make install && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# libbitcoin-build setup
-# libbitcoin-explorer setup
-#===============================================================================
-
-RUN \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y \
-      libsodium-dev
-
-RUN \
-    git clone --branch version3.8.0 --depth 1 https://gitlab.com/PBSA/peerplays-1.0/libbitcoin-explorer.git && \
-    cd libbitcoin-explorer && \
-    ./install.sh && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# Doxygen setup
-#===============================================================================
-
-RUN \
-    sudo apt install -y bison flex && \
-    wget https://github.com/doxygen/doxygen/archive/refs/tags/Release_1_8_17.tar.gz && \
-    tar -xvf Release_1_8_17.tar.gz && \
-    cd doxygen-Release_1_8_17 && \
-    mkdir build && \
-    cd build && \
-    cmake .. && \
     make -j$(nproc) install && \
     ldconfig
 
 #===============================================================================
-# Perl setup
+# cppzmq setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://github.com/Perl/perl5/archive/refs/tags/v5.30.0.tar.gz && \
+    wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.8.1.zip && \
-    tar -xvf v5.30.0.tar.gz && \
+    unzip v4.8.1.zip && \
-    cd perl5-5.30.0 && \
+    cd cppzmq-4.8.1 && \
-    ./Configure -des && \
+    mkdir build && \
+    cd build && \
+    cmake .. && \
     make -j$(nproc) install && \
     ldconfig
 
@@ -171,6 +89,8 @@ RUN \
 # Peerplays setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 ## Clone Peerplays
 #RUN \
 #    git clone https://gitlab.com/PBSA/peerplays.git && \
@@ -186,8 +106,6 @@ ADD . peerplays
 # Configure Peerplays
 RUN \
     cd peerplays && \
-    git submodule update --init --recursive && \
-    git log --oneline -n 5 && \
     mkdir build && \
     cd build && \
     cmake -DCMAKE_BUILD_TYPE=Release ..
@@ -201,8 +119,8 @@ WORKDIR /home/peerplays/peerplays-network
 
 # Setup Peerplays runimage
 RUN \
-    ln -s /home/peerplays/src/peerplays/build/programs/cli_wallet/cli_wallet ./ && \
+    ln -s /home/peerplays/peerplays/build/programs/cli_wallet/cli_wallet ./ && \
-    ln -s /home/peerplays/src/peerplays/build/programs/witness_node/witness_node ./
+    ln -s /home/peerplays/peerplays/build/programs/witness_node/witness_node ./
 
 RUN ./witness_node --create-genesis-json genesis.json && \
     rm genesis.json

Dockerfile.18.04

@@ -1,4 +1,5 @@
 FROM ubuntu:18.04
+MAINTAINER Peerplays Blockchain Standards Association
 
 #===============================================================================
 # Ubuntu setup
@@ -10,12 +11,11 @@ RUN \
       apt-utils \
       autoconf \
       bash \
-      bison \
       build-essential \
       ca-certificates \
       dnsutils \
+      doxygen \
       expect \
-      flex \
       git \
       graphviz \
       libbz2-dev \
@@ -33,6 +33,7 @@ RUN \
       ntp \
       openssh-server \
       pkg-config \
+      perl \
       python3 \
       python3-jinja2 \
       sudo \
@@ -50,120 +51,60 @@ RUN echo 'peerplays:peerplays' | chpasswd
 # SSH
 EXPOSE 22
 
-WORKDIR /home/peerplays/src
-
 #===============================================================================
 # Boost setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://boostorg.jfrog.io/artifactory/main/release/1.72.0/source/boost_1_72_0.tar.gz && \
+    wget -c 'https://boostorg.jfrog.io/artifactory/main/release/1.71.0/source/boost_1_71_0.tar.bz2' -O boost_1_71_0.tar.bz2 && \
-    tar -xzf boost_1_72_0.tar.gz && \
+    tar xjf boost_1_71_0.tar.bz2 && \
-    cd boost_1_72_0 && \
+    cd boost_1_71_0/ && \
     ./bootstrap.sh && \
-    ./b2 install && \
+    ./b2 install
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
 
 #===============================================================================
 # cmake setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://github.com/Kitware/CMake/releases/download/v3.24.2/cmake-3.24.2-linux-x86_64.sh && \
+    wget -c 'https://cmake.org/files/v3.23/cmake-3.23.1-linux-x86_64.sh' -O cmake-3.23.1-linux-x86_64.sh && \
-    chmod 755 ./cmake-3.24.2-linux-x86_64.sh && \
+    chmod 755 ./cmake-3.23.1-linux-x86_64.sh && \
-    ./cmake-3.24.2-linux-x86_64.sh --prefix=/usr --skip-license && \
+    ./cmake-3.23.1-linux-x86_64.sh --prefix=/usr/ --skip-license && \
-    cmake --version && \
+    cmake --version
-    rm -rf /home/peerplays/src/*
 
 #===============================================================================
 # libzmq setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.tar.gz && \
+    wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.zip && \
-    tar -xzvf v4.3.4.tar.gz && \
+    unzip v4.3.4.zip && \
     cd libzmq-4.3.4 && \
     mkdir build && \
     cd build && \
     cmake .. && \
-    make -j$(nproc) && \
-    make install && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# cppzmq setup
-#===============================================================================
-
-RUN \
-    wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.9.0.tar.gz && \
-    tar -xzvf v4.9.0.tar.gz && \
-    cd cppzmq-4.9.0 && \
-    mkdir build && \
-    cd build && \
-    cmake .. && \
-    make -j$(nproc) && \
-    make install && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# gsl setup
-#===============================================================================
-
-RUN \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y \
-      libpcre3-dev
-
-RUN \
-    wget https://github.com/imatix/gsl/archive/refs/tags/v4.1.4.tar.gz && \
-    tar -xzvf v4.1.4.tar.gz && \
-    cd gsl-4.1.4 && \
-    make -j$(nproc) && \
-    make install && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# libbitcoin-build setup
-# libbitcoin-explorer setup
-#===============================================================================
-
-RUN \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y \
-      libsodium-dev
-
-RUN \
-    git clone --branch version3.8.0 --depth 1 https://gitlab.com/PBSA/peerplays-1.0/libbitcoin-explorer.git && \
-    cd libbitcoin-explorer && \
-    ./install.sh && \
-    ldconfig && \
-    rm -rf /home/peerplays/src/*
-
-#===============================================================================
-# Doxygen setup
-#===============================================================================
-
-RUN \
-    sudo apt install -y bison flex && \
-    wget https://github.com/doxygen/doxygen/archive/refs/tags/Release_1_8_17.tar.gz && \
-    tar -xvf Release_1_8_17.tar.gz && \
-    cd doxygen-Release_1_8_17 && \
-    mkdir build && \
-    cd build && \
-    cmake .. && \
     make -j$(nproc) install && \
     ldconfig
 
 #===============================================================================
-# Perl setup
+# cppzmq setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 RUN \
-    wget https://github.com/Perl/perl5/archive/refs/tags/v5.30.0.tar.gz && \
+    wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.8.1.zip && \
-    tar -xvf v5.30.0.tar.gz && \
+    unzip v4.8.1.zip && \
-    cd perl5-5.30.0 && \
+    cd cppzmq-4.8.1 && \
-    ./Configure -des && \
+    mkdir build && \
+    cd build && \
+    cmake .. && \
     make -j$(nproc) install && \
     ldconfig
 
@@ -171,6 +112,8 @@ RUN \
 # Peerplays setup
 #===============================================================================
 
+WORKDIR /home/peerplays/
+
 ## Clone Peerplays
 #RUN \
 #    git clone https://gitlab.com/PBSA/peerplays.git && \
@@ -186,9 +129,6 @@ ADD . peerplays
 # Configure Peerplays
 RUN \
     cd peerplays && \
-    git submodule update --init --recursive && \
-    git symbolic-ref --short HEAD && \
-    git log --oneline -n 5 && \
     mkdir build && \
     cd build && \
     cmake -DCMAKE_BUILD_TYPE=Release ..
@@ -202,8 +142,8 @@ WORKDIR /home/peerplays/peerplays-network
 
 # Setup Peerplays runimage
 RUN \
-    ln -s /home/peerplays/src/peerplays/build/programs/cli_wallet/cli_wallet ./ && \
+    ln -s /home/peerplays/peerplays/build/programs/cli_wallet/cli_wallet ./ && \
-    ln -s /home/peerplays/src/peerplays/build/programs/witness_node/witness_node ./
+    ln -s /home/peerplays/peerplays/build/programs/witness_node/witness_node ./
 
 RUN ./witness_node --create-genesis-json genesis.json && \
     rm genesis.json

README.md

@@ -8,41 +8,23 @@ This is a quick introduction to get new developers and witnesses up to speed on
 
 Officially supported OS are Ubuntu 20.04 and Ubuntu 18.04.
 
-## Ubuntu 20.04 and 18.04
+## Ubuntu 20.04
 
-Following dependencies are needed for a clean install of Ubuntu 20.04 and Ubuntu 18.04:
+Following dependencies are needed for a clean install of Ubuntu 20.04:
 ```
 sudo apt-get install \
-    autoconf bash bison build-essential ca-certificates dnsutils expect flex git \
+    apt-utils autoconf bash build-essential ca-certificates clang-format cmake \
-    graphviz libbz2-dev libcurl4-openssl-dev libncurses-dev libpcre3-dev \
+    dnsutils doxygen expect git graphviz libboost-all-dev libbz2-dev \
-    libsnappy-dev libsodium-dev libssl-dev libtool libzip-dev locales lsb-release \
+    libcurl4-openssl-dev libncurses-dev libsnappy-dev \
-    mc nano net-tools ntp openssh-server pkg-config python3 python3-jinja2 sudo \
+    libssl-dev libtool libzip-dev locales lsb-release mc nano net-tools ntp \
+    openssh-server pkg-config perl python3 python3-jinja2 sudo \
     systemd-coredump wget
 ```
 
-Boost libraries setup:
+Install libzmq from source:
 ```
-wget https://boostorg.jfrog.io/artifactory/main/release/1.72.0/source/boost_1_72_0.tar.gz
+wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.zip
-tar -xzf boost_1_72_0.tar.gz boost_1_72_0
+unzip v4.3.4.zip
-cd boost_1_72_0
-./bootstrap.sh
-./b2
-sudo ./b2 install
-sudo ldconfig
-```
-
-cmake setup:
-```
-wget https://github.com/Kitware/CMake/releases/download/v3.24.2/cmake-3.24.2-linux-x86_64.sh
-chmod 755 ./cmake-3.24.2-linux-x86_64.sh
-sudo ./cmake-3.24.2-linux-x86_64.sh --prefix=/usr --skip-license
-cmake --version
-```
-
-libzmq setup:
-```
-wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.tar.gz
-tar -xzvf v4.3.4.tar.gz
 cd libzmq-4.3.4
 mkdir build
 cd build
@@ -52,11 +34,11 @@ sudo make install
 sudo ldconfig
 ```
 
-cppzmq setup:
+Install cppzmq from source:
 ```
-wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.9.0.tar.gz
+wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.8.1.zip
-tar -xzvf v4.9.0.tar.gz
+unzip v4.8.1.zip
-cd cppzmq-4.9.0
+cd cppzmq-4.8.1
 mkdir build
 cd build
 cmake ..
@@ -65,48 +47,6 @@ sudo make install
 sudo ldconfig
 ```
 
-gsl setup:
-```
-wget https://github.com/imatix/gsl/archive/refs/tags/v4.1.4.tar.gz
-tar -xzvf v4.1.4.tar.gz
-cd gsl-4.1.4
-make -j$(nproc)
-sudo make install
-sudo ldconfig
-```
-
-libbitcoin-explorer setup:
-```
-git clone --branch version3.8.0 --depth 1 https://gitlab.com/PBSA/peerplays-1.0/libbitcoin-explorer.git
-cd libbitcoin-explorer
-sudo ./install.sh
-sudo ldconfig
-```
-
-Doxygen setup:
-```
-wget https://github.com/doxygen/doxygen/archive/refs/tags/Release_1_8_17.tar.gz
-tar -xvf Release_1_8_17.tar.gz
-cd doxygen-Release_1_8_17
-mkdir build
-cd build
-cmake ..
-make -j$(nproc)
-sudo make install
-sudo ldconfig
-```
-
-Perl setup:
-```
-wget https://github.com/Perl/perl5/archive/refs/tags/v5.30.0.tar.gz
-tar -xvf v5.30.0.tar.gz
-cd perl5-5.30.0
-./Configure -des
-make -j$(nproc)
-sudo make install
-sudo ldconfig
-```
-
 Building Peerplays
 ```
 git clone https://gitlab.com/PBSA/peerplays.git
@@ -129,6 +69,84 @@ make -j$(nproc)
 sudo make install # this can install the executable files under /usr/local
 ```
 
+## Ubuntu 18.04
+
+Following dependencies are needed for a clean install of Ubuntu 18.04:
+```
+sudo apt-get install \
+    apt-utils autoconf bash build-essential ca-certificates clang-format \
+    dnsutils doxygen expect git graphviz libbz2-dev \
+    libcurl4-openssl-dev libncurses-dev libsnappy-dev \
+    libssl-dev libtool libzip-dev locales lsb-release mc nano net-tools ntp \
+    openssh-server pkg-config perl python3 python3-jinja2 sudo \
+    systemd-coredump wget
+```
+
+Install Boost libraries from source
+```
+wget -c 'https://boostorg.jfrog.io/artifactory/main/release/1.71.0/source/boost_1_71_0.tar.bz2' -O boost_1_71_0.tar.bz2
+tar xjf boost_1_71_0.tar.bz2
+cd boost_1_71_0/
+./bootstrap.sh
+sudo ./b2 install
+```
+
+Install cmake
+```
+wget -c 'https://cmake.org/files/v3.23/cmake-3.23.1-linux-x86_64.sh' -O cmake-3.23.1-linux-x86_64.sh
+chmod 755 ./cmake-3.23.1-linux-x86_64.sh
+sudo ./cmake-3.23.1-linux-x86_64.sh --prefix=/usr/ --skip-license
+```
+
+Install libzmq from source:
+```
+wget https://github.com/zeromq/libzmq/archive/refs/tags/v4.3.4.zip
+unzip v4.3.4.zip
+cd libzmq-4.3.4
+mkdir build
+cd build
+cmake ..
+make -j$(nproc)
+sudo make install
+sudo ldconfig
+```
+
+Install cppzmq from source:
+```
+wget https://github.com/zeromq/cppzmq/archive/refs/tags/v4.8.1.zip
+unzip v4.8.1.zip
+cd cppzmq-4.8.1
+mkdir build
+cd build
+cmake ..
+make -j$(nproc)
+sudo make install
+sudo ldconfig
+```
+
+Building Peerplays
+```
+git clone https://gitlab.com/PBSA/peerplays.git
+cd peerplays
+git submodule update --init --recursive
+
+# If you want to build Mainnet node
+cmake -DCMAKE_BUILD_TYPE=Release
+
+# If you want to build Testnet node
+cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_PEERPLAYS_TESTNET=1
+
+# Update -j flag depending on your current system specs;
+# Recommended 4GB of RAM per 1 CPU core
+# make -j2 for 8GB RAM
+# make -j4 for 16GB RAM
+# make -j8 for 32GB RAM
+make -j$(nproc)
+
+sudo make install # this can install the executable files under /usr/local
+```
+
+
 ## Docker images
 
 Install docker, and add current user to docker group.

libraries/app/api.cpp

@@ -210,8 +210,8 @@ network_node_api::network_node_api(application &a) :
       }
 
       /*
-       * Remove expired transactions from pending_transactions
+             * Remove expired transactions from pending_transactions
-       */
+             */
       for (const auto &transaction : _pending_transactions) {
          if (transaction.second.expiration < block.timestamp) {
             auto transaction_it = _pending_transactions.find(transaction.second.id());

libraries/app/application.cpp

@@ -391,8 +391,8 @@ public:
    }
 
    /**
-    * If delegate has the item, the network has no need to fetch it.
+       * If delegate has the item, the network has no need to fetch it.
-    */
+       */
    virtual bool has_item(const net::item_id &id) override {
       try {
          if (id.item_type == graphene::net::block_message_type)
@@ -404,13 +404,13 @@ public:
    }
 
    /**
-    * @brief allows the application to validate an item prior to broadcasting to peers.
+       * @brief allows the application to validate an item prior to broadcasting to peers.
-    *
+       *
-    * @param sync_mode true if the message was fetched through the sync process, false during normal operation
+       * @param sync_mode true if the message was fetched through the sync process, false during normal operation
-    * @returns true if this message caused the blockchain to switch forks, false if it did not
+       * @returns true if this message caused the blockchain to switch forks, false if it did not
-    *
+       *
-    * @throws exception if error validating the item, otherwise the item is safe to broadcast on.
+       * @throws exception if error validating the item, otherwise the item is safe to broadcast on.
-    */
+       */
    virtual bool handle_block(const graphene::net::block_message &blk_msg, bool sync_mode,
                              std::vector<fc::uint160_t> &contained_transaction_message_ids) override {
 
@@ -498,14 +498,14 @@ public:
    }
 
    /**
-    * Assuming all data elements are ordered in some way, this method should
+       * Assuming all data elements are ordered in some way, this method should
-    * return up to limit ids that occur *after* the last ID in synopsis that
+       * return up to limit ids that occur *after* the last ID in synopsis that
-    * we recognize.
+       * we recognize.
-    *
+       *
-    * On return, remaining_item_count will be set to the number of items
+       * On return, remaining_item_count will be set to the number of items
-    * in our blockchain after the last item returned in the result,
+       * in our blockchain after the last item returned in the result,
-    * or 0 if the result contains the last item in the blockchain
+       * or 0 if the result contains the last item in the blockchain
-    */
+       */
    virtual std::vector<item_hash_t> get_block_ids(const std::vector<item_hash_t> &blockchain_synopsis,
                                                   uint32_t &remaining_item_count,
                                                   uint32_t limit) override {
@@ -552,8 +552,8 @@ public:
    }
 
    /**
-    * Given the hash of the requested data, fetch the body.
+       * Given the hash of the requested data, fetch the body.
-    */
+       */
    virtual message get_item(const item_id &id) override {
       try {
          // ilog("Request for item ${id}", ("id", id));
@@ -576,63 +576,63 @@ public:
    }
 
    /**
-    * Returns a synopsis of the blockchain used for syncing.  This consists of a list of
+       * Returns a synopsis of the blockchain used for syncing.  This consists of a list of
-    * block hashes at intervals exponentially increasing towards the genesis block.
+       * block hashes at intervals exponentially increasing towards the genesis block.
-    * When syncing to a peer, the peer uses this data to determine if we're on the same
+       * When syncing to a peer, the peer uses this data to determine if we're on the same
-    * fork as they are, and if not, what blocks they need to send us to get us on their
+       * fork as they are, and if not, what blocks they need to send us to get us on their
-    * fork.
+       * fork.
-    *
+       *
-    * In the over-simplified case, this is a straighforward synopsis of our current
+       * In the over-simplified case, this is a straighforward synopsis of our current
-    * preferred blockchain; when we first connect up to a peer, this is what we will be sending.
+       * preferred blockchain; when we first connect up to a peer, this is what we will be sending.
-    * It looks like this:
+       * It looks like this:
-    *   If the blockchain is empty, it will return the empty list.
+       *   If the blockchain is empty, it will return the empty list.
-    *   If the blockchain has one block, it will return a list containing just that block.
+       *   If the blockchain has one block, it will return a list containing just that block.
-    *   If it contains more than one block:
+       *   If it contains more than one block:
-    *     the first element in the list will be the hash of the highest numbered block that
+       *     the first element in the list will be the hash of the highest numbered block that
-    *         we cannot undo
+       *         we cannot undo
-    *     the second element will be the hash of an item at the half way point in the undoable
+       *     the second element will be the hash of an item at the half way point in the undoable
-    *         segment of the blockchain
+       *         segment of the blockchain
-    *     the third will be ~3/4 of the way through the undoable segment of the block chain
+       *     the third will be ~3/4 of the way through the undoable segment of the block chain
-    *     the fourth will be at ~7/8...
+       *     the fourth will be at ~7/8...
-    *       &c.
+       *       &c.
-    *     the last item in the list will be the hash of the most recent block on our preferred chain
+       *     the last item in the list will be the hash of the most recent block on our preferred chain
-    * so if the blockchain had 26 blocks labeled a - z, the synopsis would be:
+       * so if the blockchain had 26 blocks labeled a - z, the synopsis would be:
-    *    a n u x z
+       *    a n u x z
-    * the idea being that by sending a small (<30) number of block ids, we can summarize a huge
+       * the idea being that by sending a small (<30) number of block ids, we can summarize a huge
-    * blockchain.  The block ids are more dense near the end of the chain where because we are
+       * blockchain.  The block ids are more dense near the end of the chain where because we are
-    * more likely to be almost in sync when we first connect, and forks are likely to be short.
+       * more likely to be almost in sync when we first connect, and forks are likely to be short.
-    * If the peer we're syncing with in our example is on a fork that started at block 'v',
+       * If the peer we're syncing with in our example is on a fork that started at block 'v',
-    * then they will reply to our synopsis with a list of all blocks starting from block 'u',
+       * then they will reply to our synopsis with a list of all blocks starting from block 'u',
-    * the last block they know that we had in common.
+       * the last block they know that we had in common.
-    *
+       *
-    * In the real code, there are several complications.
+       * In the real code, there are several complications.
-    *
+       *
-    * First, as an optimization, we don't usually send a synopsis of the entire blockchain, we
+       * First, as an optimization, we don't usually send a synopsis of the entire blockchain, we
-    * send a synopsis of only the segment of the blockchain that we have undo data for.  If their
+       * send a synopsis of only the segment of the blockchain that we have undo data for.  If their
-    * fork doesn't build off of something in our undo history, we would be unable to switch, so there's
+       * fork doesn't build off of something in our undo history, we would be unable to switch, so there's
-    * no reason to fetch the blocks.
+       * no reason to fetch the blocks.
-    *
+       *
-    * Second, when a peer replies to our initial synopsis and gives us a list of the blocks they think
+       * Second, when a peer replies to our initial synopsis and gives us a list of the blocks they think
-    * we are missing, they only send a chunk of a few thousand blocks at once.  After we get those
+       * we are missing, they only send a chunk of a few thousand blocks at once.  After we get those
-    * block ids, we need to request more blocks by sending another synopsis (we can't just say "send me
+       * block ids, we need to request more blocks by sending another synopsis (we can't just say "send me
-    * the next 2000 ids" because they may have switched forks themselves and they don't track what
+       * the next 2000 ids" because they may have switched forks themselves and they don't track what
-    * they've sent us).  For faster performance, we want to get a fairly long list of block ids first,
+       * they've sent us).  For faster performance, we want to get a fairly long list of block ids first,
-    * then start downloading the blocks.
+       * then start downloading the blocks.
-    * The peer doesn't handle these follow-up block id requests any different from the initial request;
+       * The peer doesn't handle these follow-up block id requests any different from the initial request;
-    * it treats the synopsis we send as our blockchain and bases its response entirely off that.  So to
+       * it treats the synopsis we send as our blockchain and bases its response entirely off that.  So to
-    * get the response we want (the next chunk of block ids following the last one they sent us, or,
+       * get the response we want (the next chunk of block ids following the last one they sent us, or,
-    * failing that, the shortest fork off of the last list of block ids they sent), we need to construct
+       * failing that, the shortest fork off of the last list of block ids they sent), we need to construct
-    * a synopsis as if our blockchain was made up of:
+       * a synopsis as if our blockchain was made up of:
-    *    1. the blocks in our block chain up to the fork point (if there is a fork) or the head block (if no fork)
+       *    1. the blocks in our block chain up to the fork point (if there is a fork) or the head block (if no fork)
-    *    2. the blocks we've already pushed from their fork (if there's a fork)
+       *    2. the blocks we've already pushed from their fork (if there's a fork)
-    *    3. the block ids they've previously sent us
+       *    3. the block ids they've previously sent us
-    * Segment 3 is handled in the p2p code, it just tells us the number of blocks it has (in
+       * Segment 3 is handled in the p2p code, it just tells us the number of blocks it has (in
-    * number_of_blocks_after_reference_point) so we can leave space in the synopsis for them.
+       * number_of_blocks_after_reference_point) so we can leave space in the synopsis for them.
-    * We're responsible for constructing the synopsis of Segments 1 and 2 from our active blockchain and
+       * We're responsible for constructing the synopsis of Segments 1 and 2 from our active blockchain and
-    * fork database.  The reference_point parameter is the last block from that peer that has been
+       * fork database.  The reference_point parameter is the last block from that peer that has been
-    * successfully pushed to the blockchain, so that tells us whether the peer is on a fork or on
+       * successfully pushed to the blockchain, so that tells us whether the peer is on a fork or on
-    * the main chain.
+       * the main chain.
-    */
+       */
    virtual std::vector<item_hash_t> get_blockchain_synopsis(const item_hash_t &reference_point,
                                                             uint32_t number_of_blocks_after_reference_point) override {
       try {
@@ -733,26 +733,26 @@ public:
             low_block_num += (true_high_block_num - low_block_num + 2) / 2;
          } while (low_block_num <= high_block_num);
 
-         // idump((synopsis));
+         //idump((synopsis));
          return synopsis;
       }
       FC_CAPTURE_AND_RETHROW()
    }
 
    /**
-    * Call this after the call to handle_message succeeds.
+       * Call this after the call to handle_message succeeds.
-    *
+       *
-    * @param item_type the type of the item we're synchronizing, will be the same as item passed to the sync_from() call
+       * @param item_type the type of the item we're synchronizing, will be the same as item passed to the sync_from() call
-    * @param item_count the number of items known to the node that haven't been sent to handle_item() yet.
+       * @param item_count the number of items known to the node that haven't been sent to handle_item() yet.
-    *                   After `item_count` more calls to handle_item(), the node will be in sync
+       *                   After `item_count` more calls to handle_item(), the node will be in sync
-    */
+       */
    virtual void sync_status(uint32_t item_type, uint32_t item_count) override {
       // any status reports to GUI go here
    }
 
    /**
-    * Call any time the number of connected peers changes.
+       * Call any time the number of connected peers changes.
-    */
+       */
    virtual void connection_count_changed(uint32_t c) override {
       // any status reports to GUI go here
    }
@@ -769,9 +769,9 @@ public:
    }
 
    /**
-    * Returns the time a block was produced (if block_id = 0, returns genesis time).
+       * Returns the time a block was produced (if block_id = 0, returns genesis time).
-    * If we don't know about the block, returns time_point_sec::min()
+       * If we don't know about the block, returns time_point_sec::min()
-    */
+       */
    virtual fc::time_point_sec get_block_time(const item_hash_t &block_id) override {
       try {
          auto opt_block = _chain_db->fetch_block_by_id(block_id);
@@ -917,8 +917,7 @@ void application::initialize(const fc::path &data_dir, const boost::program_opti
       wanted.insert("accounts_list");
       wanted.insert("affiliate_stats");
    }
-   if (!wanted.count("delayed_node") && !wanted.count("debug_witness") && !wanted.count("witness")) // explicitly requested delayed_node or debug_witness functionality suppresses witness functions
+   wanted.insert("witness");
-      wanted.insert("witness");
    wanted.insert("bookie");
 
    int es_ah_conflict_counter = 0;
@@ -950,7 +949,7 @@ void application::startup() {
 }
 
 std::shared_ptr<abstract_plugin> application::get_plugin(const string &name) const {
-   return is_plugin_enabled(name) ? my->_active_plugins[name] : nullptr;
+   return my->_active_plugins[name];
 }
 
 bool application::is_plugin_enabled(const string &name) const {

libraries/app/database_api.cpp

@@ -71,17 +71,6 @@ std::string object_id_to_string(object_id_type id) {
    return object_id;
 }
 
-signed_block_with_info::signed_block_with_info(){};
-
-signed_block_with_info::signed_block_with_info(const signed_block &block) :
-      signed_block(block) {
-   block_id = id();
-   signing_key = signee();
-   transaction_ids.reserve(transactions.size());
-   for (const processed_transaction &tx : transactions)
-      transaction_ids.push_back(tx.id());
-}
-
 class database_api_impl : public std::enable_shared_from_this<database_api_impl> {
 public:
    database_api_impl(graphene::chain::database &db);
@@ -100,7 +89,6 @@ public:
    optional<block_header> get_block_header(uint32_t block_num) const;
    map<uint32_t, optional<block_header>> get_block_header_batch(const vector<uint32_t> block_nums) const;
    optional<signed_block> get_block(uint32_t block_num) const;
-   optional<signed_block_with_info> get_block2(uint32_t block_num) const;
    vector<optional<signed_block>> get_blocks(uint32_t block_num_from, uint32_t block_num_to) const;
    processed_transaction get_transaction(uint32_t block_num, uint32_t trx_in_block) const;
 
@@ -196,10 +184,6 @@ public:
    fc::optional<son_object> get_son_by_account(const std::string account_id_or_name) const;
    map<string, son_id_type> lookup_son_accounts(const string &lower_bound_name, uint32_t limit) const;
    uint64_t get_son_count() const;
-   flat_map<sidechain_type, vector<son_sidechain_info>> get_active_sons();
-   vector<son_sidechain_info> get_active_sons_by_sidechain(sidechain_type sidechain);
-   map<sidechain_type, map<son_id_type, string>> get_son_network_status();
-   map<son_id_type, string> get_son_network_status_by_sidechain(sidechain_type sidechain);
 
    // SON wallets
    optional<son_wallet_object> get_active_son_wallet();
@@ -281,9 +265,8 @@ public:
    uint64_t nft_get_total_supply(const nft_metadata_id_type nft_metadata_id) const;
    nft_object nft_token_by_index(const nft_metadata_id_type nft_metadata_id, const uint64_t token_idx) const;
    nft_object nft_token_of_owner_by_index(const nft_metadata_id_type nft_metadata_id, const account_id_type owner, const uint64_t token_idx) const;
-   vector<nft_object> nft_get_all_tokens(const nft_id_type lower_id, uint32_t limit) const;
+   vector<nft_object> nft_get_all_tokens() const;
-   vector<nft_object> nft_get_tokens_by_owner(const account_id_type owner, const nft_id_type lower_id, uint32_t limit) const;
+   vector<nft_object> nft_get_tokens_by_owner(const account_id_type owner) const;
-   vector<nft_metadata_object> nft_get_metadata_by_owner(const account_id_type owner, const nft_metadata_id_type lower_id, uint32_t limit) const;
 
    // Marketplace
    vector<offer_object> list_offers(const offer_id_type lower_id, uint32_t limit) const;
@@ -304,7 +287,6 @@ public:
    uint32_t api_limit_get_limit_orders_by_account = 101;
    uint32_t api_limit_get_order_book = 50;
    uint32_t api_limit_all_offers_count = 100;
-   uint32_t api_limit_nft_tokens = 100;
    uint32_t api_limit_lookup_accounts = 1000;
    uint32_t api_limit_lookup_witness_accounts = 1000;
    uint32_t api_limit_lookup_committee_member_accounts = 1000;
@@ -313,7 +295,7 @@ public:
    uint32_t api_limit_get_trade_history = 100;
    uint32_t api_limit_get_trade_history_by_sequence = 100;
 
-   // private:
+   //private:
    const account_object *get_account_from_string(const std::string &name_or_id,
                                                  bool throw_if_not_found = true) const;
    const asset_object *get_asset_from_string(const std::string &symbol_or_id,
@@ -470,7 +452,7 @@ void database_api::set_subscribe_callback(std::function<void(const variant &)> c
 }
 
 void database_api_impl::set_subscribe_callback(std::function<void(const variant &)> cb, bool notify_remove_create) {
-   // edump((clear_filter));
+   //edump((clear_filter));
    _subscribe_callback = cb;
    _notify_remove_create = notify_remove_create;
    _subscribed_accounts.clear();
@@ -544,17 +526,6 @@ optional<signed_block> database_api_impl::get_block(uint32_t block_num) const {
    return _db.fetch_block_by_number(block_num);
 }
 
-optional<signed_block_with_info> database_api::get_block2(uint32_t block_num) const {
-   return my->get_block2(block_num);
-}
-
-optional<signed_block_with_info> database_api_impl::get_block2(uint32_t block_num) const {
-   auto result = _db.fetch_block_by_number(block_num);
-   if (result)
-      return signed_block_with_info(*result);
-   return {};
-}
-
 vector<optional<signed_block>> database_api::get_blocks(uint32_t block_num_from, uint32_t block_num_to) const {
    return my->get_blocks(block_num_from, block_num_to);
 }
@@ -1877,80 +1848,6 @@ uint64_t database_api_impl::get_son_count() const {
    return _db.get_index_type<son_index>().indices().size();
 }
 
-flat_map<sidechain_type, vector<son_sidechain_info>> database_api::get_active_sons() {
-   return my->get_active_sons();
-}
-
-flat_map<sidechain_type, vector<son_sidechain_info>> database_api_impl::get_active_sons() {
-   return get_global_properties().active_sons;
-}
-
-vector<son_sidechain_info> database_api::get_active_sons_by_sidechain(sidechain_type sidechain) {
-   return my->get_active_sons_by_sidechain(sidechain);
-}
-
-vector<son_sidechain_info> database_api_impl::get_active_sons_by_sidechain(sidechain_type sidechain) {
-   const global_property_object &gpo = get_global_properties();
-
-   vector<son_sidechain_info> result;
-
-   if (gpo.active_sons.find(sidechain) != gpo.active_sons.end()) {
-      result = gpo.active_sons.at(sidechain);
-   }
-
-   return result;
-}
-
-map<sidechain_type, map<son_id_type, string>> database_api::get_son_network_status() {
-   return my->get_son_network_status();
-}
-
-map<sidechain_type, map<son_id_type, string>> database_api_impl::get_son_network_status() {
-   map<sidechain_type, map<son_id_type, string>> result;
-
-   for (auto active_sidechain_type : active_sidechain_types(_db.head_block_time())) {
-      result[active_sidechain_type] = get_son_network_status_by_sidechain(active_sidechain_type);
-   }
-
-   return result;
-}
-
-map<son_id_type, string> database_api::get_son_network_status_by_sidechain(sidechain_type sidechain) {
-   return my->get_son_network_status_by_sidechain(sidechain);
-}
-
-map<son_id_type, string> database_api_impl::get_son_network_status_by_sidechain(sidechain_type sidechain) {
-   const global_property_object &gpo = get_global_properties();
-
-   map<son_id_type, string> result;
-
-   if (gpo.active_sons.find(sidechain) != gpo.active_sons.end()) {
-      for (const auto si : gpo.active_sons.at(sidechain)) {
-         const auto son_obj = si.son_id(_db);
-         const auto sso = son_obj.statistics(_db);
-         string status;
-
-         if (sso.last_active_timestamp.find(sidechain) != sso.last_active_timestamp.end()) {
-            if (time_point_sec(sso.last_active_timestamp.at(sidechain) + fc::seconds(gpo.parameters.son_heartbeat_frequency())) > _db.head_block_time()) {
-               status = "OK, regular SON heartbeat";
-            } else {
-               if (time_point_sec(sso.last_active_timestamp.at(sidechain) + fc::seconds(gpo.parameters.son_down_time())) > _db.head_block_time()) {
-                  status = "OK, irregular SON heartbeat, but not triggering SON down proposal";
-               } else {
-                  status = "NOT OK, irregular SON heartbeat, triggering SON down proposal";
-               }
-            }
-         } else {
-            status = "No heartbeats sent";
-         }
-
-         result[si.son_id] = status;
-      }
-   }
-
-   return result;
-}
-
 //////////////////////////////////////////////////////////////////////
 //                                                                  //
 // SON Wallets                                                      //
@@ -2186,9 +2083,7 @@ vector<variant> database_api_impl::lookup_vote_ids(const vector<vote_id_type> &v
    const auto &committee_idx = _db.get_index_type<committee_member_index>().indices().get<by_vote_id>();
    const auto &for_worker_idx = _db.get_index_type<worker_index>().indices().get<by_vote_for>();
    const auto &against_worker_idx = _db.get_index_type<worker_index>().indices().get<by_vote_against>();
-   const auto &son_bictoin_idx = _db.get_index_type<son_index>().indices().get<by_vote_id_bitcoin>();
+   const auto &son_idx = _db.get_index_type<son_index>().indices().get<by_vote_id>();
-   const auto &son_hive_idx = _db.get_index_type<son_index>().indices().get<by_vote_id_hive>();
-   const auto &son_ethereum_idx = _db.get_index_type<son_index>().indices().get<by_vote_id_ethereum>();
 
    vector<variant> result;
    result.reserve(votes.size());
@@ -2197,7 +2092,7 @@ vector<variant> database_api_impl::lookup_vote_ids(const vector<vote_id_type> &v
       case vote_id_type::committee: {
          auto itr = committee_idx.find(id);
          if (itr != committee_idx.end())
-            result.emplace_back(variant(*itr, 2)); // Depth of committee_member_object is 1, add 1 to be safe
+            result.emplace_back(variant(*itr, 1));
          else
             result.emplace_back(variant());
          break;
@@ -2205,7 +2100,7 @@ vector<variant> database_api_impl::lookup_vote_ids(const vector<vote_id_type> &v
       case vote_id_type::witness: {
          auto itr = witness_idx.find(id);
          if (itr != witness_idx.end())
-            result.emplace_back(variant(*itr, 2)); // Depth of witness_object is 1, add 1 here to be safe
+            result.emplace_back(variant(*itr, 1));
          else
             result.emplace_back(variant());
          break;
@@ -2213,45 +2108,26 @@ vector<variant> database_api_impl::lookup_vote_ids(const vector<vote_id_type> &v
       case vote_id_type::worker: {
          auto itr = for_worker_idx.find(id);
          if (itr != for_worker_idx.end()) {
-            result.emplace_back(variant(*itr, 4)); // Depth of worker_object is 3, add 1 here to be safe.
+            result.emplace_back(variant(*itr, 1));
-                                                   // If we want to extract the balance object inside,
-                                                   //   need to increase this value
          } else {
             auto itr = against_worker_idx.find(id);
             if (itr != against_worker_idx.end()) {
-               result.emplace_back(variant(*itr, 4)); // Depth of worker_object is 3, add 1 here to be safe.
+               result.emplace_back(variant(*itr, 1));
-                                                      // If we want to extract the balance object inside,
-                                                      //   need to increase this value
             } else {
                result.emplace_back(variant());
             }
          }
          break;
       }
-      case vote_id_type::son_bitcoin: {
+      case vote_id_type::son: {
-         auto itr = son_bictoin_idx.find(id);
+         auto itr = son_idx.find(id);
-         if (itr != son_bictoin_idx.end())
+         if (itr != son_idx.end())
-            result.emplace_back(variant(*itr, 5));
-         else
-            result.emplace_back(variant());
-         break;
-      }
-      case vote_id_type::son_hive: {
-         auto itr = son_hive_idx.find(id);
-         if (itr != son_hive_idx.end())
-            result.emplace_back(variant(*itr, 5));
-         else
-            result.emplace_back(variant());
-         break;
-      }
-      case vote_id_type::son_ethereum: {
-         auto itr = son_ethereum_idx.find(id);
-         if (itr != son_ethereum_idx.end())
             result.emplace_back(variant(*itr, 5));
          else
             result.emplace_back(variant());
          break;
       }
+
       case vote_id_type::VOTE_TYPE_COUNT:
          break; // supress unused enum value warnings
       default:
@@ -2276,24 +2152,12 @@ vector<vote_id_type> database_api_impl::get_votes_ids(const string &account_name
 votes_info database_api_impl::get_votes(const string &account_name_or_id) const {
    votes_info result;
 
-   const auto votes_ids = get_votes_ids(account_name_or_id);
+   const auto &votes_ids = get_votes_ids(account_name_or_id);
-   const auto committee_ids = get_votes_objects<committee_member_index, by_vote_id>(votes_ids);
+   const auto &committee_ids = get_votes_objects<committee_member_index, by_vote_id>(votes_ids);
-   const auto witness_ids = get_votes_objects<witness_index, by_vote_id>(votes_ids);
+   const auto &witness_ids = get_votes_objects<witness_index, by_vote_id>(votes_ids);
-   const auto for_worker_ids = get_votes_objects<worker_index, by_vote_for>(votes_ids);
+   const auto &for_worker_ids = get_votes_objects<worker_index, by_vote_for>(votes_ids);
-   const auto against_worker_ids = get_votes_objects<worker_index, by_vote_against>(votes_ids);
+   const auto &against_worker_ids = get_votes_objects<worker_index, by_vote_against>(votes_ids);
-   const auto son_ids = [this, &votes_ids]() {
+   const auto &son_ids = get_votes_objects<son_index, by_vote_id>(votes_ids, 5);
-      flat_map<sidechain_type, vector<variant>> son_ids;
-      const auto son_bitcoin_ids = get_votes_objects<son_index, by_vote_id_bitcoin>(votes_ids, 5);
-      if (!son_bitcoin_ids.empty())
-         son_ids[sidechain_type::bitcoin] = std::move(son_bitcoin_ids);
-      const auto son_hive_ids = get_votes_objects<son_index, by_vote_id_hive>(votes_ids, 5);
-      if (!son_hive_ids.empty())
-         son_ids[sidechain_type::hive] = std::move(son_hive_ids);
-      const auto son_ethereum_ids = get_votes_objects<son_index, by_vote_id_ethereum>(votes_ids, 5);
-      if (!son_ethereum_ids.empty())
-         son_ids[sidechain_type::ethereum] = std::move(son_ethereum_ids);
-      return son_ids;
-   }();
 
    //! Fill votes info
    if (!committee_ids.empty()) {
@@ -2337,17 +2201,11 @@ votes_info database_api_impl::get_votes(const string &account_name_or_id) const
    }
 
    if (!son_ids.empty()) {
-      flat_map<sidechain_type, vector<votes_info_object>> votes_for_sons;
+      vector<votes_info_object> votes_for_sons;
-      for (const auto &son_sidechain_ids : son_ids) {
+      votes_for_sons.reserve(son_ids.size());
-         const auto &sidechain = son_sidechain_ids.first;
+      for (const auto &son : son_ids) {
-         const auto &sidechain_ids = son_sidechain_ids.second;
+         const auto &son_obj = son.as<son_object>(6);
-         votes_for_sons[sidechain].reserve(sidechain_ids.size());
+         votes_for_sons.emplace_back(votes_info_object{son_obj.vote_id, son_obj.id});
-         for (const auto &son : sidechain_ids) {
-            const auto &son_obj = son.as<son_object>(6);
-            if (son_obj.get_sidechain_vote_id(sidechain).valid()) {
-               votes_for_sons[sidechain].emplace_back(votes_info_object{*son_obj.get_sidechain_vote_id(sidechain), son_obj.id});
-            }
-         }
       }
       result.votes_for_sons = std::move(votes_for_sons);
    }
@@ -2521,16 +2379,12 @@ voters_info database_api_impl::get_voters(const string &account_name_or_id) cons
 
    //! Info for son voters
    if (son_object) {
-      flat_map<sidechain_type, voters_info_object> voters_for_son;
+      const auto &son_voters = get_voters_by_id(son_object->vote_id);
-      for (const auto &vote_id : son_object->sidechain_vote_ids) {
+      voters_info_object voters_for_son;
-         const auto &son_voters = get_voters_by_id(vote_id.second);
+      voters_for_son.vote_id = son_object->vote_id;
-         voters_info_object voters_for_sidechain_son;
+      voters_for_son.voters.reserve(son_voters.size());
-         voters_for_sidechain_son.vote_id = vote_id.second;
+      for (const auto &voter : son_voters) {
-         voters_for_sidechain_son.voters.reserve(son_voters.size());
+         voters_for_son.voters.emplace_back(voter.get_id());
-         for (const auto &voter : son_voters) {
-            voters_for_sidechain_son.voters.emplace_back(voter.get_id());
-         }
-         voters_for_son[vote_id.first] = std::move(voters_for_sidechain_son);
       }
       result.voters_for_son = std::move(voters_for_son);
    }
@@ -2907,7 +2761,7 @@ graphene::app::gpos_info database_api::get_gpos_info(const account_id_type accou
 }
 
 graphene::app::gpos_info database_api_impl::get_gpos_info(const account_id_type account) const {
-   FC_ASSERT(_db.head_block_time() > HARDFORK_GPOS_TIME); // Can be deleted after GPOS hardfork time
+   FC_ASSERT(_db.head_block_time() > HARDFORK_GPOS_TIME); //Can be deleted after GPOS hardfork time
    gpos_info result;
 
    result.vesting_factor = _db.calculate_vesting_factor(account(_db));
@@ -3133,61 +2987,30 @@ nft_object database_api_impl::nft_token_of_owner_by_index(const nft_metadata_id_
    return {};
 }
 
-vector<nft_object> database_api::nft_get_all_tokens(const nft_id_type lower_id, uint32_t limit) const {
+vector<nft_object> database_api::nft_get_all_tokens() const {
-   return my->nft_get_all_tokens(lower_id, limit);
+   return my->nft_get_all_tokens();
 }
 
-vector<nft_object> database_api_impl::nft_get_all_tokens(const nft_id_type lower_id, uint32_t limit) const {
+vector<nft_object> database_api_impl::nft_get_all_tokens() const {
-   FC_ASSERT(limit <= api_limit_nft_tokens,
-             "Number of queried nft tokens can not be greater than ${configured_limit}",
-             ("configured_limit", api_limit_nft_tokens));
-
    const auto &idx_nft = _db.get_index_type<nft_index>().indices().get<by_id>();
    vector<nft_object> result;
-   result.reserve(limit);
+   for (auto itr = idx_nft.begin(); itr != idx_nft.end(); ++itr) {
-   auto itr = idx_nft.lower_bound(lower_id);
+      result.push_back(*itr);
-   while (limit-- && itr != idx_nft.end())
+   }
-      result.emplace_back(*itr++);
    return result;
 }
 
-vector<nft_object> database_api::nft_get_tokens_by_owner(const account_id_type owner, const nft_id_type lower_id, uint32_t limit) const {
+vector<nft_object> database_api::nft_get_tokens_by_owner(const account_id_type owner) const {
-   return my->nft_get_tokens_by_owner(owner, lower_id, limit);
+   return my->nft_get_tokens_by_owner(owner);
 }
 
-vector<nft_object> database_api_impl::nft_get_tokens_by_owner(const account_id_type owner, const nft_id_type lower_id, uint32_t limit) const {
+vector<nft_object> database_api_impl::nft_get_tokens_by_owner(const account_id_type owner) const {
-   FC_ASSERT(limit <= api_limit_nft_tokens,
-             "Number of queried nft tokens can not be greater than ${configured_limit}",
-             ("configured_limit", api_limit_nft_tokens));
    const auto &idx_nft = _db.get_index_type<nft_index>().indices().get<by_owner>();
    auto idx_nft_range = idx_nft.equal_range(owner);
    vector<nft_object> result;
-   result.reserve(limit);
+   for (auto itr = idx_nft_range.first; itr != idx_nft_range.second; ++itr) {
-   auto itr = std::find_if(idx_nft_range.first, idx_nft_range.second, [&lower_id](const nft_object &obj) {
+      result.push_back(*itr);
-      return !(obj.id.instance() < lower_id.instance);
+   }
-   });
-   while (limit-- && itr != idx_nft_range.second)
-      result.emplace_back(*itr++);
-   return result;
-}
-
-vector<nft_metadata_object> database_api::nft_get_metadata_by_owner(const account_id_type owner, const nft_metadata_id_type lower_id, uint32_t limit) const {
-   return my->nft_get_metadata_by_owner(owner, lower_id, limit);
-}
-
-vector<nft_metadata_object> database_api_impl::nft_get_metadata_by_owner(const account_id_type owner, const nft_metadata_id_type lower_id, uint32_t limit) const {
-   FC_ASSERT(limit <= api_limit_nft_tokens,
-             "Number of queried nft metadata objects can not be greater than ${configured_limit}",
-             ("configured_limit", api_limit_nft_tokens));
-   const auto &idx_nft = _db.get_index_type<nft_metadata_index>().indices().get<by_owner>();
-   auto idx_nft_range = idx_nft.equal_range(owner);
-   vector<nft_metadata_object> result;
-   result.reserve(limit);
-   auto itr = std::find_if(idx_nft_range.first, idx_nft_range.second, [&lower_id](const nft_metadata_object &obj) {
-      return !(obj.id.instance() < lower_id.instance);
-   });
-   while (limit-- && itr != idx_nft_range.second)
-      result.emplace_back(*itr++);
    return result;
 }
 
@@ -3554,9 +3377,9 @@ void database_api_impl::handle_object_changed(bool force_notify, bool full_objec
       /// pushing the future back / popping the prior future if it is complete.
       /// if a connection hangs then this could get backed up and result in
       /// a failure to exit cleanly.
-      // fc::async([capture_this,this,updates,market_broadcast_queue](){
+      //fc::async([capture_this,this,updates,market_broadcast_queue](){
-      // if( _subscribe_callback )
+      //if( _subscribe_callback )
-      //          _subscribe_callback( updates );
+      //         _subscribe_callback( updates );
 
       for (auto id : ids) {
          if (id.is<call_order_object>()) {

libraries/app/include/graphene/app/api.hpp

@@ -85,10 +85,10 @@ struct asset_holders {
 };
 
 /**
- * @brief The history_api class implements the RPC API for account history
+    * @brief The history_api class implements the RPC API for account history
- *
+    *
- * This API contains methods to access account histories
+    * This API contains methods to access account histories
- */
+    */
 class history_api {
 public:
    history_api(application &app) :
@@ -97,27 +97,27 @@ public:
    }
 
    /**
-    * @brief Get operations relevant to the specificed account
+          * @brief Get operations relevant to the specificed account
-    * @param account_id_or_name The account ID or name whose history should be queried
+          * @param account_id_or_name The account ID or name whose history should be queried
-    * @param stop ID of the earliest operation to retrieve
+          * @param stop ID of the earliest operation to retrieve
-    * @param limit Maximum number of operations to retrieve (must not exceed 100)
+          * @param limit Maximum number of operations to retrieve (must not exceed 100)
-    * @param start ID of the most recent operation to retrieve
+          * @param start ID of the most recent operation to retrieve
-    * @return A list of operations performed by account, ordered from most recent to oldest.
+          * @return A list of operations performed by account, ordered from most recent to oldest.
-    */
+          */
    vector<operation_history_object> get_account_history(const std::string account_id_or_name,
                                                         operation_history_id_type stop = operation_history_id_type(),
                                                         unsigned limit = 100,
                                                         operation_history_id_type start = operation_history_id_type()) const;
 
    /**
-    * @brief Get only asked operations relevant to the specified account
+          * @brief Get only asked operations relevant to the specified account
-    * @param account_id_or_name The account ID or name whose history should be queried
+          * @param account_id_or_name The account ID or name whose history should be queried
-    * @param operation_id The ID of the operation we want to get operations in the account( 0 = transfer , 1 = limit order create, ...)
+          * @param operation_id The ID of the operation we want to get operations in the account( 0 = transfer , 1 = limit order create, ...)
-    * @param stop ID of the earliest operation to retrieve
+          * @param stop ID of the earliest operation to retrieve
-    * @param limit Maximum number of operations to retrieve (must not exceed 100)
+          * @param limit Maximum number of operations to retrieve (must not exceed 100)
-    * @param start ID of the most recent operation to retrieve
+          * @param start ID of the most recent operation to retrieve
-    * @return A list of operations performed by account, ordered from most recent to oldest.
+          * @return A list of operations performed by account, ordered from most recent to oldest.
-    */
+          */
    vector<operation_history_object> get_account_history_operations(const std::string account_id_or_name,
                                                                    int operation_id,
                                                                    operation_history_id_type start = operation_history_id_type(),
@@ -125,17 +125,17 @@ public:
                                                                    unsigned limit = 100) const;
 
    /**
-    * @breif Get operations relevant to the specified account referenced
+          * @breif Get operations relevant to the specified account referenced
-    * by an event numbering specific to the account. The current number of operations
+          * by an event numbering specific to the account. The current number of operations
-    * for the account can be found in the account statistics (or use 0 for start).
+          * for the account can be found in the account statistics (or use 0 for start).
-    * @param account_id_or_name The account ID or name whose history should be queried
+          * @param account_id_or_name The account ID or name whose history should be queried
-    * @param stop Sequence number of earliest operation. 0 is default and will
+          * @param stop Sequence number of earliest operation. 0 is default and will
-    * query 'limit' number of operations.
+          * query 'limit' number of operations.
-    * @param limit Maximum number of operations to retrieve (must not exceed 100)
+          * @param limit Maximum number of operations to retrieve (must not exceed 100)
-    * @param start Sequence number of the most recent operation to retrieve.
+          * @param start Sequence number of the most recent operation to retrieve.
-    * 0 is default, which will start querying from the most recent operation.
+          * 0 is default, which will start querying from the most recent operation.
-    * @return A list of operations performed by account, ordered from most recent to oldest.
+          * @return A list of operations performed by account, ordered from most recent to oldest.
-    */
+          */
    vector<operation_history_object> get_relative_account_history(const std::string account_id_or_name,
                                                                  uint32_t stop = 0,
                                                                  unsigned limit = 100,
@@ -156,8 +156,8 @@ private:
 };
 
 /**
- * @brief Block api
+    * @brief Block api
- */
+    */
 class block_api {
 public:
    block_api(graphene::chain::database &db);
@@ -170,8 +170,8 @@ private:
 };
 
 /**
- * @brief The network_broadcast_api class allows broadcasting of transactions.
+    * @brief The network_broadcast_api class allows broadcasting of transactions.
- */
+    */
 class network_broadcast_api : public std::enable_shared_from_this<network_broadcast_api> {
 public:
    network_broadcast_api(application &a);
@@ -186,36 +186,36 @@ public:
    typedef std::function<void(variant /*transaction_confirmation*/)> confirmation_callback;
 
    /**
-    * @brief Broadcast a transaction to the network
+          * @brief Broadcast a transaction to the network
-    * @param trx The transaction to broadcast
+          * @param trx The transaction to broadcast
-    *
+          *
-    * The transaction will be checked for validity in the local database prior to broadcasting. If it fails to
+          * The transaction will be checked for validity in the local database prior to broadcasting. If it fails to
-    * apply locally, an error will be thrown and the transaction will not be broadcast.
+          * apply locally, an error will be thrown and the transaction will not be broadcast.
-    */
+          */
    void broadcast_transaction(const signed_transaction &trx);
 
    /** this version of broadcast transaction registers a callback method that will be called when the transaction is
-    * included into a block.  The callback method includes the transaction id, block number, and transaction number in the
+          * included into a block.  The callback method includes the transaction id, block number, and transaction number in the
-    * block.
+          * block.
-    */
+          */
    void broadcast_transaction_with_callback(confirmation_callback cb, const signed_transaction &trx);
 
    /** this version of broadcast transaction registers a callback method that will be called when the transaction is
-    * included into a block.  The callback method includes the transaction id, block number, and transaction number in the
+          * included into a block.  The callback method includes the transaction id, block number, and transaction number in the
-    * block.
+          * block.
-    */
+          */
    fc::variant broadcast_transaction_synchronous(const signed_transaction &trx);
 
    void broadcast_block(const signed_block &block);
 
    /**
-    * @brief Not reflected, thus not accessible to API clients.
+          * @brief Not reflected, thus not accessible to API clients.
-    *
+          *
-    * This function is registered to receive the applied_block
+          * This function is registered to receive the applied_block
-    * signal from the chain database when a block is received.
+          * signal from the chain database when a block is received.
-    * It then dispatches callbacks to clients who have requested
+          * It then dispatches callbacks to clients who have requested
-    * to be notified when a particular txid is included in a block.
+          * to be notified when a particular txid is included in a block.
-    */
+          */
    void on_applied_block(const signed_block &b);
 
 private:
@@ -225,60 +225,60 @@ private:
 };
 
 /**
- * @brief The network_node_api class allows maintenance of p2p connections.
+    * @brief The network_node_api class allows maintenance of p2p connections.
- */
+    */
 class network_node_api {
 public:
    network_node_api(application &a);
 
    /**
-    * @brief Return general network information, such as p2p port
+          * @brief Return general network information, such as p2p port
-    */
+          */
    fc::variant_object get_info() const;
 
    /**
-    * @brief add_node Connect to a new peer
+          * @brief add_node Connect to a new peer
-    * @param ep The IP/Port of the peer to connect to
+          * @param ep The IP/Port of the peer to connect to
-    */
+          */
    void add_node(const fc::ip::endpoint &ep);
 
    /**
-    * @brief Get status of all current connections to peers
+          * @brief Get status of all current connections to peers
-    */
+          */
    std::vector<net::peer_status> get_connected_peers() const;
 
    /**
-    * @brief Get advanced node parameters, such as desired and max
+          * @brief Get advanced node parameters, such as desired and max
-    *        number of connections
+          *        number of connections
-    */
+          */
    fc::variant_object get_advanced_node_parameters() const;
 
    /**
-    * @brief Set advanced node parameters, such as desired and max
+          * @brief Set advanced node parameters, such as desired and max
-    *        number of connections
+          *        number of connections
-    * @param params a JSON object containing the name/value pairs for the parameters to set
+          * @param params a JSON object containing the name/value pairs for the parameters to set
-    */
+          */
    void set_advanced_node_parameters(const fc::variant_object &params);
 
    /**
-    * @brief Return list of potential peers
+          * @brief Return list of potential peers
-    */
+          */
    std::vector<net::potential_peer_record> get_potential_peers() const;
 
    /**
-    * @brief Return list of pending transactions.
+          * @brief Return list of pending transactions.
-    */
+          */
    map<transaction_id_type, signed_transaction> list_pending_transactions() const;
 
    /**
-    * @brief Subscribes caller for notifications about pending transactions.
+          * @brief Subscribes caller for notifications about pending transactions.
-    * @param callback a functional object which will be called when new transaction is created.
+          * @param callback a functional object which will be called when new transaction is created.
-    */
+          */
    void subscribe_to_pending_transactions(std::function<void(const variant &)> callback);
 
    /**
-    * @brief Unsubscribes caller from notifications about pending transactions.
+          * @brief Unsubscribes caller from notifications about pending transactions.
-    */
+          */
    void unsubscribe_from_pending_transactions();
 
 private:
@@ -290,33 +290,33 @@ private:
 };
 
 /**
- * @brief
+    * @brief
- */
+    */
 class asset_api {
 public:
    asset_api(graphene::app::application &app);
    ~asset_api();
 
    /**
-    * @brief Get asset holders for a specific asset
+          * @brief Get asset holders for a specific asset
-    * @param asset The specific asset id or symbol
+          * @param asset The specific asset id or symbol
-    * @param start The start index
+          * @param start The start index
-    * @param limit Maximum limit must not exceed 100
+          * @param limit Maximum limit must not exceed 100
-    * @return A list of asset holders for the specified asset
+          * @return A list of asset holders for the specified asset
-    */
+          */
    vector<account_asset_balance> get_asset_holders(std::string asset, uint32_t start, uint32_t limit) const;
 
    /**
-    * @brief Get asset holders count for a specific asset
+          * @brief Get asset holders count for a specific asset
-    * @param asset The specific asset id or symbol
+          * @param asset The specific asset id or symbol
-    * @return Holders count for the specified asset
+          * @return Holders count for the specified asset
-    */
+          */
    int get_asset_holders_count(std::string asset) const;
 
    /**
-    * @brief Get all asset holders
+          * @brief Get all asset holders
-    * @return A list of all asset holders
+          * @return A list of all asset holders
-    */
+          */
    vector<asset_holders> get_all_asset_holders() const;
 
    uint32_t api_limit_get_asset_holders = 100;
@@ -337,24 +337,24 @@ extern template class fc::api<graphene::debug_witness::debug_api>;
 
 namespace graphene { namespace app {
 /**
- * @brief The login_api class implements the bottom layer of the RPC API
+    * @brief The login_api class implements the bottom layer of the RPC API
- *
+    *
- * All other APIs must be requested from this API.
+    * All other APIs must be requested from this API.
- */
+    */
 class login_api {
 public:
    login_api(application &a);
    ~login_api();
 
    /**
-    * @brief Authenticate to the RPC server
+          * @brief Authenticate to the RPC server
-    * @param user Username to login with
+          * @param user Username to login with
-    * @param password Password to login with
+          * @param password Password to login with
-    * @return True if logged in successfully; false otherwise
+          * @return True if logged in successfully; false otherwise
-    *
+          *
-    * @note This must be called prior to requesting other APIs. Other APIs may not be accessible until the client
+          * @note This must be called prior to requesting other APIs. Other APIs may not be accessible until the client
-    * has sucessfully authenticated.
+          * has sucessfully authenticated.
-    */
+          */
    bool login(const string &user, const string &password);
    /// @brief Retrieve the network block API
    fc::api<block_api> block() const;

libraries/app/include/graphene/app/database_api.hpp

@@ -82,15 +82,6 @@ using namespace std;
 
 class database_api_impl;
 
-struct signed_block_with_info : public signed_block {
-   signed_block_with_info();
-   signed_block_with_info(const signed_block &block);
-   signed_block_with_info(const signed_block_with_info &block) = default;
-   block_id_type block_id;
-   public_key_type signing_key;
-   vector<transaction_id_type> transaction_ids;
-};
-
 struct order {
    double price;
    double quote;
@@ -198,10 +189,10 @@ public:
    optional<block_header> get_block_header(uint32_t block_num) const;
 
    /**
-    * @brief Retrieve multiple block header by block numbers
+      * @brief Retrieve multiple block header by block numbers
-    * @param block_num vector containing heights of the block whose header should be returned
+      * @param block_num vector containing heights of the block whose header should be returned
-    * @return array of headers of the referenced blocks, or null if no matching block was found
+      * @return array of headers of the referenced blocks, or null if no matching block was found
-    */
+      */
    map<uint32_t, optional<block_header>> get_block_header_batch(const vector<uint32_t> block_nums) const;
 
    /**
@@ -211,13 +202,6 @@ public:
     */
    optional<signed_block> get_block(uint32_t block_num) const;
 
-   /**
-    * @brief Retrieve a full, signed block, with some extra info
-    * @param block_num Height of the block to be returned
-    * @return the referenced block, or null if no matching block was found
-    */
-   optional<signed_block_with_info> get_block2(uint32_t block_num) const;
-
    /**
     * @brief Retrieve a list of signed blocks
     * @param block_num_from start
@@ -279,12 +263,12 @@ public:
    vector<vector<account_id_type>> get_key_references(vector<public_key_type> key) const;
 
    /**
-    * Determine whether a textual representation of a public key
+      * Determine whether a textual representation of a public key
-    * (in Base-58 format) is *currently* linked
+      * (in Base-58 format) is *currently* linked
-    * to any *registered* (i.e. non-stealth) account on the blockchain
+      * to any *registered* (i.e. non-stealth) account on the blockchain
-    * @param public_key Public key
+      * @param public_key Public key
-    * @return Whether a public key is known
+      * @return Whether a public key is known
-    */
+      */
    bool is_public_key_registered(string public_key) const;
 
    //////////////
@@ -691,32 +675,6 @@ public:
     */
    uint64_t get_son_count() const;
 
-   /**
-    * @brief Get list of active sons
-    * @return List of active SONs
-    */
-   flat_map<sidechain_type, vector<son_sidechain_info>> get_active_sons();
-
-   /**
-    * @brief Get list of active sons
-    * @param sidechain Sidechain type [bitcoin|ethereum|hive]
-    * @return List of active SONs
-    */
-   vector<son_sidechain_info> get_active_sons_by_sidechain(sidechain_type sidechain);
-
-   /**
-    * @brief Get SON network status
-    * @return SON network status description for a given sidechain type
-    */
-   map<sidechain_type, map<son_id_type, string>> get_son_network_status();
-
-   /**
-    * @brief Get SON network status
-    * @param sidechain Sidechain type [bitcoin|ethereum|hive]
-    * @return SON network status description for a given sidechain type
-    */
-   map<son_id_type, string> get_son_network_status_by_sidechain(sidechain_type sidechain);
-
    /////////////////////////
    // SON Wallets      //
    /////////////////////////
@@ -1043,25 +1001,14 @@ public:
     * @brief Returns list of all available NTF's
     * @return List of all available NFT's
     */
-   vector<nft_object> nft_get_all_tokens(const nft_id_type lower_id, uint32_t limit) const;
+   vector<nft_object> nft_get_all_tokens() const;
 
    /**
     * @brief Returns NFT's owned by owner
     * @param owner NFT owner
-    * @param lower_id ID of the first NFT to return
-    * @param limit Maximum number of results to return
     * @return List of NFT owned by owner
     */
-   vector<nft_object> nft_get_tokens_by_owner(const account_id_type owner, const nft_id_type lower_id, uint32_t limit) const;
+   vector<nft_object> nft_get_tokens_by_owner(const account_id_type owner) const;
-
-   /**
-    * @brief Returns NFT metadata owned by owner
-    * @param owner NFT owner
-    * @param lower_id ID of the first NFT metadata to return
-    * @param limit Maximum number of results to return
-    * @return List of NFT owned by owner
-    */
-   vector<nft_metadata_object> nft_get_metadata_by_owner(const account_id_type owner, const nft_metadata_id_type lower_id, uint32_t limit) const;
 
    //////////////////
    // MARKET PLACE //
@@ -1091,8 +1038,6 @@ extern template class fc::api<graphene::app::database_api>;
 
 // clang-format off
 
-FC_REFLECT_DERIVED(graphene::app::signed_block_with_info, (graphene::chain::signed_block), (block_id)(signing_key)(transaction_ids));
-
 FC_REFLECT(graphene::app::order, (price)(quote)(base));
 FC_REFLECT(graphene::app::order_book, (base)(quote)(bids)(asks));
 FC_REFLECT(graphene::app::market_ticker, (base)(quote)(latest)(lowest_ask)(highest_bid)(percent_change)(base_volume)(quote_volume));
@@ -1115,7 +1060,6 @@ FC_API(graphene::app::database_api,
    (get_block_header)
    (get_block_header_batch)
    (get_block)
-   (get_block2)
    (get_blocks)
    (get_transaction)
    (get_recent_transaction_by_id)
@@ -1205,10 +1149,6 @@ FC_API(graphene::app::database_api,
    (get_son_by_account)
    (lookup_son_accounts)
    (get_son_count)
-   (get_active_sons)
-   (get_active_sons_by_sidechain)
-   (get_son_network_status)
-   (get_son_network_status_by_sidechain)
 
    // SON wallets
    (get_active_son_wallet)
@@ -1279,7 +1219,6 @@ FC_API(graphene::app::database_api,
    (nft_token_of_owner_by_index)
    (nft_get_all_tokens)
    (nft_get_tokens_by_owner)
-   (nft_get_metadata_by_owner)
 
    // Marketplace
    (list_offers)

libraries/chain/account_evaluator.cpp

@@ -53,54 +53,7 @@ void verify_authority_accounts( const database& db, const authority& a )
    }
 }
 
-// Overwrites the num_son values from the origin to the destination for those sidechains which are found in the origin.
+void verify_account_votes( const database& db, const account_options& options )
-// Keeps the values of num_son for the sidechains which are found in the destination, but not in the origin.
-// Returns false if an error is detected.
-bool merge_num_sons( flat_map<sidechain_type, uint16_t>& destination,
-                     const flat_map<sidechain_type, uint16_t>& origin,
-                     fc::optional<time_point_sec> head_block_time = {})
-{
-   const auto active_sidechains = head_block_time.valid() ? active_sidechain_types(*head_block_time) : all_sidechain_types;
-   bool success = true;
-
-   for (const auto &ns : origin)
-   {
-      destination[ns.first] = ns.second;
-      if (active_sidechains.find(ns.first) == active_sidechains.end())
-      {
-         success = false;
-      }
-   }
-
-   return success;
-}
-
-flat_map<sidechain_type, uint16_t> count_SON_votes_per_sidechain( const flat_set<vote_id_type>& votes )
-{
-   flat_map<sidechain_type, uint16_t> SON_votes_per_sidechain = account_options::ext::empty_num_son();
-
-   for (const auto &vote : votes)
-   {
-      switch (vote.type())
-     {
-      case vote_id_type::son_bitcoin:
-         SON_votes_per_sidechain[sidechain_type::bitcoin]++;
-         break;
-      case vote_id_type::son_hive:
-         SON_votes_per_sidechain[sidechain_type::hive]++;
-         break;
-      case vote_id_type::son_ethereum:
-         SON_votes_per_sidechain[sidechain_type::ethereum]++;
-         break;
-      default:
-         break;
-      }
-   }
-
-   return SON_votes_per_sidechain;
-}
-
-void verify_account_votes( const database& db, const account_options& options, fc::optional<account_object> account = {} )
 {
    // ensure account's votes satisfy requirements
    // NB only the part of vote checking that requires chain state is here,
@@ -115,42 +68,8 @@ void verify_account_votes( const database& db, const account_options& options, f
               "Voted for more witnesses than currently allowed (${c})", ("c", chain_params.maximum_witness_count) );
    FC_ASSERT( options.num_committee <= chain_params.maximum_committee_count,
               "Voted for more committee members than currently allowed (${c})", ("c", chain_params.maximum_committee_count) );
-   FC_ASSERT( chain_params.extensions.value.maximum_son_count.valid() , "Invalid maximum son count" );
+   FC_ASSERT( options.num_son() <= chain_params.maximum_son_count(),
-
+             "Voted for more sons than currently allowed (${c})", ("c", chain_params.maximum_son_count()) );
-   flat_map<sidechain_type, uint16_t> merged_num_sons = account_options::ext::empty_num_son();
-
-   // Merge with existing account if exists
-   if ( account.valid() && account->options.extensions.value.num_son.valid())
-   {
-      merge_num_sons( merged_num_sons, *account->options.extensions.value.num_son, db.head_block_time() );
-   }
-
-   // Apply update operation on top
-   if ( options.extensions.value.num_son.valid() )
-   {
-      merge_num_sons( merged_num_sons, *options.extensions.value.num_son, db.head_block_time() );
-   }
-
-   for(const auto& num_sons : merged_num_sons)
-   {
-      FC_ASSERT( num_sons.second <= *chain_params.extensions.value.maximum_son_count,
-                "Voted for more sons than currently allowed (${c})", ("c", *chain_params.extensions.value.maximum_son_count) );
-   }
-
-   // Count the votes for SONs and confirm that the account did not vote for less SONs than num_son
-   flat_map<sidechain_type, uint16_t> SON_votes_per_sidechain = count_SON_votes_per_sidechain(options.votes);
-
-   for (const auto& number_of_votes : SON_votes_per_sidechain)
-   {
-      // Number of votes of account_options are also checked in account_options::do_evaluate,
-      // but there we are checking the value before merging num_sons, so the values should be checked again
-      const auto sidechain = number_of_votes.first;
-      FC_ASSERT( number_of_votes.second >= merged_num_sons[sidechain],
-                "Voted for less sons than specified in num_son (votes ${v} < num_son ${ns}) for sidechain ${s}",
-                ("v", number_of_votes.second) ("ns", merged_num_sons[sidechain]) ("s", sidechain) );
-   }
-
-   FC_ASSERT( db.find_object(options.voting_account), "Invalid proxy account specified." );
 
    uint32_t max_vote_id = gpo.next_available_vote_id;
    bool has_worker_votes = false;
@@ -263,13 +182,6 @@ object_id_type account_create_evaluator::do_apply( const account_create_operatio
       obj.owner            = o.owner;
       obj.active           = o.active;
       obj.options          = o.options;
-
-      obj.options.extensions.value.num_son = account_options::ext::empty_num_son();
-      if ( o.options.extensions.value.num_son.valid() )
-      {
-         merge_num_sons( *obj.options.extensions.value.num_son, *o.options.extensions.value.num_son );
-      }
-
       obj.statistics = d.create<account_statistics_object>([&obj](account_statistics_object& s){
                            s.owner = obj.id;
                            s.name = obj.name;
@@ -369,7 +281,7 @@ void_result account_update_evaluator::do_evaluate( const account_update_operatio
    acnt = &o.account(d);
 
    if( o.new_options.valid() )
-      verify_account_votes( d, *o.new_options, *acnt );
+      verify_account_votes( d, *o.new_options );
 
    return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
@@ -408,31 +320,7 @@ void_result account_update_evaluator::do_apply( const account_update_operation&
          a.active = *o.active;
          a.top_n_control_flags = 0;
       }
-
+      if( o.new_options ) a.options = *o.new_options;
-      // New num_son structure initialized to 0
-      flat_map<sidechain_type, uint16_t> new_num_son = account_options::ext::empty_num_son();
-
-      // If num_son of existing object is valid, we should merge the existing data
-      if ( a.options.extensions.value.num_son.valid() )
-      {
-         merge_num_sons( new_num_son, *a.options.extensions.value.num_son );
-      }
-
-      // If num_son of the operation are valid, they should merge the existing data
-      if ( o.new_options )
-      {
-         const auto new_options = *o.new_options;
-
-         if ( new_options.extensions.value.num_son.valid() )
-         {
-            merge_num_sons( new_num_son, *new_options.extensions.value.num_son );
-         }
-
-         a.options = *o.new_options;
-      }
-
-      a.options.extensions.value.num_son = new_num_son;
-
       if( o.extensions.value.owner_special_authority.valid() )
       {
          a.owner_special_authority = *(o.extensions.value.owner_special_authority);

libraries/chain/confidential_evaluator.cpp

@@ -33,163 +33,45 @@ namespace graphene { namespace chain {
 
 void_result transfer_to_blind_evaluator::do_evaluate( const transfer_to_blind_operation& o )
 { try {
-  const auto& d = db();
+   return void_result();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME )
-  {
-     const auto& atype = o.amount.asset_id(d);
-     FC_ASSERT( atype.allow_confidential() );
-     FC_ASSERT( !atype.is_transfer_restricted() );
-     FC_ASSERT( !(atype.options.flags & white_list) );
-
-     for( const auto& out : o.outputs )
-     {
-        for( const auto& a : out.owner.account_auths )
-           a.first(d); // verify all accounts exist and are valid
-     }
-  }
-
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
 
-void_result transfer_to_blind_evaluator::do_apply( const transfer_to_blind_operation& o )
+void_result transfer_to_blind_evaluator::do_apply( const transfer_to_blind_operation& o ) 
 { try {
-  if( db().head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
+   return void_result();
-     db().adjust_balance(o.from, -o.amount);
-
-     const auto &add = o.amount.asset_id(db()).dynamic_asset_data_id(db()); // verify fee is a legit asset
-     db().modify(add, [&](asset_dynamic_data_object &obj) {
-        obj.confidential_supply += o.amount.amount;
-        FC_ASSERT(obj.confidential_supply >= 0);
-     });
-     for (const auto &out : o.outputs) {
-        db().create<blinded_balance_object>([&](blinded_balance_object &obj) {
-           obj.asset_id = o.amount.asset_id;
-           obj.owner = out.owner;
-           obj.commitment = out.commitment;
-        });
-     }
-  }
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
 void transfer_to_blind_evaluator::pay_fee()
 {
-  const auto& d = db();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-     if (d.head_block_time() >= HARDFORK_563_TIME)
-        pay_fba_fee(fba_accumulator_id_transfer_to_blind);
-     else
-        generic_evaluator::pay_fee();
-  }
 }
 
 void_result transfer_from_blind_evaluator::do_evaluate( const transfer_from_blind_operation& o )
 { try {
-  const auto& d = db();
+   return void_result();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-     o.fee.asset_id(d); // verify fee is a legit asset
-     const auto &bbi = d.get_index_type<blinded_balance_index>();
-     const auto &cidx = bbi.indices().get<by_commitment>();
-     for (const auto &in : o.inputs) {
-        auto itr = cidx.find(in.commitment);
-        FC_ASSERT(itr != cidx.end());
-        FC_ASSERT(itr->asset_id == o.fee.asset_id);
-        FC_ASSERT(itr->owner == in.owner);
-     }
-  }
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
-void_result transfer_from_blind_evaluator::do_apply( const transfer_from_blind_operation& o )
+void_result transfer_from_blind_evaluator::do_apply( const transfer_from_blind_operation& o ) 
 { try {
-  if( db().head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
+   return void_result();
-     db().adjust_balance(o.fee_payer(), o.fee);
-     db().adjust_balance(o.to, o.amount);
-     const auto &bbi = db().get_index_type<blinded_balance_index>();
-     const auto &cidx = bbi.indices().get<by_commitment>();
-     for (const auto &in : o.inputs) {
-        auto itr = cidx.find(in.commitment);
-        FC_ASSERT(itr != cidx.end());
-        db().remove(*itr);
-     }
-     const auto &add = o.amount.asset_id(db()).dynamic_asset_data_id(db()); // verify fee is a legit asset
-     db().modify(add, [&](asset_dynamic_data_object &obj) {
-        obj.confidential_supply -= o.amount.amount + o.fee.amount;
-        FC_ASSERT(obj.confidential_supply >= 0);
-     });
-  }
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
 void transfer_from_blind_evaluator::pay_fee()
 {
-  const auto& d = db();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-     if (d.head_block_time() >= HARDFORK_563_TIME)
-        pay_fba_fee(fba_accumulator_id_transfer_from_blind);
-     else
-        generic_evaluator::pay_fee();
-  }
 }
 
 void_result blind_transfer_evaluator::do_evaluate( const blind_transfer_operation& o )
 { try {
-  const auto& d = db();
+   return void_result();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-     o.fee.asset_id(d); // verify fee is a legit asset
-     const auto &bbi = d.get_index_type<blinded_balance_index>();
-     const auto &cidx = bbi.indices().get<by_commitment>();
-     for (const auto &out : o.outputs) {
-        for (const auto &a : out.owner.account_auths)
-           a.first(d); // verify all accounts exist and are valid
-     }
-     for (const auto &in : o.inputs) {
-        auto itr = cidx.find(in.commitment);
-        GRAPHENE_ASSERT(itr != cidx.end(), blind_transfer_unknown_commitment, "", ("commitment", in.commitment));
-        FC_ASSERT(itr->asset_id == o.fee.asset_id);
-        FC_ASSERT(itr->owner == in.owner);
-     }
-  }
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
-void_result blind_transfer_evaluator::do_apply( const blind_transfer_operation& o )
+void_result blind_transfer_evaluator::do_apply( const blind_transfer_operation& o ) 
 { try {
-  if( db().head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
+   return void_result();
-     db().adjust_balance(o.fee_payer(), o.fee); // deposit the fee to the temp account
-     const auto &bbi = db().get_index_type<blinded_balance_index>();
-     const auto &cidx = bbi.indices().get<by_commitment>();
-     for (const auto &in : o.inputs) {
-        auto itr = cidx.find(in.commitment);
-        GRAPHENE_ASSERT(itr != cidx.end(), blind_transfer_unknown_commitment, "", ("commitment", in.commitment));
-        db().remove(*itr);
-     }
-     for (const auto &out : o.outputs) {
-        db().create<blinded_balance_object>([&](blinded_balance_object &obj) {
-           obj.asset_id = o.fee.asset_id;
-           obj.owner = out.owner;
-           obj.commitment = out.commitment;
-        });
-     }
-     const auto &add = o.fee.asset_id(db()).dynamic_asset_data_id(db());
-     db().modify(add, [&](asset_dynamic_data_object &obj) {
-        obj.confidential_supply -= o.fee.amount;
-        FC_ASSERT(obj.confidential_supply >= 0);
-     });
-  }
-  return void_result();
 } FC_CAPTURE_AND_RETHROW( (o) ) }
 
 void blind_transfer_evaluator::pay_fee()
 {
-  const auto& d = db();
-  if( d.head_block_time() < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-     if (d.head_block_time() >= HARDFORK_563_TIME)
-        pay_fba_fee(fba_accumulator_id_blind_transfer);
-     else
-        generic_evaluator::pay_fee();
-  }
 }
 
 } } // graphene::chain

libraries/chain/db_block.cpp

@@ -40,10 +40,8 @@
 #include <graphene/chain/exceptions.hpp>
 #include <graphene/chain/evaluator.hpp>
 #include <graphene/chain/witness_schedule_object.hpp>
-#include <graphene/db/object_database.hpp>
 #include <fc/crypto/digest.hpp>
 
-#include <boost/filesystem.hpp>
 
 namespace {
 
@@ -162,13 +160,10 @@ void database::check_transaction_for_duplicated_operations(const signed_transact
       existed_operations_digests.insert( proposed_operations_digests.begin(), proposed_operations_digests.end() );
    });
 
+   for (auto& pending_transaction: _pending_tx)
    {
-      const std::lock_guard<std::mutex> pending_tx_lock{_pending_tx_mutex};
+      auto proposed_operations_digests = gather_proposed_operations_digests(pending_transaction);
-      for (auto &pending_transaction : _pending_tx)
+      existed_operations_digests.insert(proposed_operations_digests.begin(), proposed_operations_digests.end());
-      {
-         auto proposed_operations_digests = gather_proposed_operations_digests(pending_transaction);
-         existed_operations_digests.insert(proposed_operations_digests.begin(), proposed_operations_digests.end());
-      }
    }
 
    auto proposed_operations_digests = gather_proposed_operations_digests(trx);
@@ -190,12 +185,7 @@ bool database::push_block(const signed_block& new_block, uint32_t skip)
    bool result;
    detail::with_skip_flags( *this, skip, [&]()
    {
-      std::vector<processed_transaction> pending_tx = [this] {
+      detail::without_pending_transactions( *this, std::move(_pending_tx),
-         const std::lock_guard<std::mutex> pending_tx_lock{_pending_tx_mutex};
-         return std::move(_pending_tx);
-      }();
-
-      detail::without_pending_transactions( *this, std::move(pending_tx),
       [&]()
       {
          result = _push_block(new_block);
@@ -206,9 +196,6 @@ bool database::push_block(const signed_block& new_block, uint32_t skip)
 
 bool database::_push_block(const signed_block& new_block)
 { try {
-   boost::filesystem::space_info si = boost::filesystem::space(get_data_dir());
-   FC_ASSERT((si.available) > 104857600, "Rejecting block due to low disk space"); // 104857600 bytes = 100 MB
-
    uint32_t skip = get_node_properties().skip_flags;
    const auto now = fc::time_point::now().sec_since_epoch();
 
@@ -395,26 +382,17 @@ processed_transaction database::_push_transaction( const signed_transaction& trx
 {
    // If this is the first transaction pushed after applying a block, start a new undo session.
    // This allows us to quickly rewind to the clean state of the head block, in case a new block arrives.
-   {
+   if( !_pending_tx_session.valid() )
-      const std::lock_guard<std::mutex> pending_tx_session_lock{_pending_tx_session_mutex};
+      _pending_tx_session = _undo_db.start_undo_session();
-      if (!_pending_tx_session.valid()) {
-         const std::lock_guard<std::mutex> undo_db_lock{_undo_db_mutex};
-         _pending_tx_session = _undo_db.start_undo_session();
-      }
-   }
 
    // Create a temporary undo session as a child of _pending_tx_session.
    // The temporary session will be discarded by the destructor if
    // _apply_transaction fails.  If we make it to merge(), we
    // apply the changes.
 
-   const std::lock_guard<std::mutex> undo_db_lock{_undo_db_mutex};
    auto temp_session = _undo_db.start_undo_session();
-   auto processed_trx = _apply_transaction(trx);
+   auto processed_trx = _apply_transaction( trx );
-   {
+   _pending_tx.push_back(processed_trx);
-      const std::lock_guard<std::mutex> pending_tx_lock{_pending_tx_mutex};
-      _pending_tx.push_back(processed_trx);
-   }
 
    // notify_changed_objects();
    // The transaction applied successfully. Merge its changes into the pending block session.
@@ -427,7 +405,6 @@ processed_transaction database::_push_transaction( const signed_transaction& trx
 
 processed_transaction database::validate_transaction( const signed_transaction& trx )
 {
-   const std::lock_guard<std::mutex> undo_db_lock{_undo_db_mutex};
    auto session = _undo_db.start_undo_session();
    return _apply_transaction( trx );
 }
@@ -527,52 +504,47 @@ signed_block database::_generate_block(
    // the value of the "when" variable is known, which means we need to
    // re-apply pending transactions in this method.
    //
-   {
+   _pending_tx_session.reset();
-      const std::lock_guard<std::mutex> pending_tx_session_lock{_pending_tx_session_mutex};
+   _pending_tx_session = _undo_db.start_undo_session();
-      _pending_tx_session.reset();
-      _pending_tx_session = _undo_db.start_undo_session();
-   }
 
    uint64_t postponed_tx_count = 0;
    // pop pending state (reset to head block state)
+   for( const processed_transaction& tx : _pending_tx )
    {
-      const std::lock_guard<std::mutex> pending_tx_lock{_pending_tx_mutex};
+      size_t new_total_size = total_block_size + fc::raw::pack_size( tx );
-      for (const processed_transaction &tx : _pending_tx) {
-         size_t new_total_size = total_block_size + fc::raw::pack_size(tx);
 
-         // postpone transaction if it would make block too big
+      // postpone transaction if it would make block too big
-         if (new_total_size >= maximum_block_size) {
+      if( new_total_size >= maximum_block_size )
-            postponed_tx_count++;
+      {
-            continue;
+         postponed_tx_count++;
-         }
+         continue;
+      }
 
-         try {
+      try
-            auto temp_session = _undo_db.start_undo_session();
+      {
-            processed_transaction ptx = _apply_transaction(tx);
+         auto temp_session = _undo_db.start_undo_session();
-            temp_session.merge();
+         processed_transaction ptx = _apply_transaction( tx );
+         temp_session.merge();
 
-            // We have to recompute pack_size(ptx) because it may be different
+         // We have to recompute pack_size(ptx) because it may be different
-            // than pack_size(tx) (i.e. if one or more results increased
+         // than pack_size(tx) (i.e. if one or more results increased
-            // their size)
+         // their size)
-            total_block_size += fc::raw::pack_size(ptx);
+         total_block_size += fc::raw::pack_size( ptx );
-            pending_block.transactions.push_back(ptx);
+         pending_block.transactions.push_back( ptx );
-         } catch (const fc::exception &e) {
+      }
-            // Do nothing, transaction will not be re-applied
+      catch ( const fc::exception& e )
-            wlog("Transaction was not processed while generating block due to ${e}", ("e", e));
+      {
-            wlog("The transaction was ${t}", ("t", tx));
+         // Do nothing, transaction will not be re-applied
-         }
+         wlog( "Transaction was not processed while generating block due to ${e}", ("e", e) );
+         wlog( "The transaction was ${t}", ("t", tx) );
       }
    }
-
    if( postponed_tx_count > 0 )
    {
       wlog( "Postponed ${n} transactions due to block size limit", ("n", postponed_tx_count) );
    }
 
-   {
+   _pending_tx_session.reset();
-      const std::lock_guard<std::mutex> pending_tx_session_lock{_pending_tx_session_mutex};
-      _pending_tx_session.reset();
-   }
 
    // We have temporarily broken the invariant that
    // _pending_tx_session is the result of applying _pending_tx, as
@@ -620,11 +592,7 @@ signed_block database::_generate_block(
  */
 void database::pop_block()
 { try {
-   {
+   _pending_tx_session.reset();
-      const std::lock_guard<std::mutex> pending_tx_session_lock{_pending_tx_session_mutex};
-      _pending_tx_session.reset();
-   }
-
    auto head_id = head_block_id();
    optional<signed_block> head_block = fetch_block_by_id( head_id );
    GRAPHENE_ASSERT( head_block.valid(), pop_empty_chain, "there are no blocks to pop" );
@@ -638,8 +606,6 @@ void database::pop_block()
 
 void database::clear_pending()
 { try {
-   const std::lock_guard<std::mutex> pending_tx_lock{_pending_tx_mutex};
-   const std::lock_guard<std::mutex> pending_tx_session_lock{_pending_tx_session_mutex};
    assert( (_pending_tx.size() == 0) || _pending_tx_session.valid() );
    _pending_tx.clear();
    _pending_tx_session.reset();
@@ -739,11 +705,8 @@ void database::_apply_block( const signed_block& next_block )
 
    if (global_props.parameters.witness_schedule_algorithm == GRAPHENE_WITNESS_SCHEDULED_ALGORITHM) {
       update_witness_schedule(next_block);
-
+      if(global_props.active_sons.size() > 0) {
-      for(const auto& active_sons : global_props.active_sons) {
+         update_son_schedule(next_block);
-         if(!active_sons.second.empty()) {
-            update_son_schedule(active_sons.first, next_block);
-         }
       }
    }
 
@@ -758,7 +721,7 @@ void database::_apply_block( const signed_block& next_block )
 
    check_ending_lotteries();
    check_ending_nft_lotteries();
-
+   
    create_block_summary(next_block);
    place_delayed_bets(); // must happen after update_global_dynamic_data() updates the time
    clear_expired_transactions();
@@ -776,15 +739,11 @@ void database::_apply_block( const signed_block& next_block )
    // TODO:  figure out if we could collapse this function into
    // update_global_dynamic_data() as perhaps these methods only need
    // to be called for header validation?
-
    update_maintenance_flag( maint_needed );
    if (global_props.parameters.witness_schedule_algorithm == GRAPHENE_WITNESS_SHUFFLED_ALGORITHM) {
       update_witness_schedule();
-
+      if(global_props.active_sons.size() > 0) {
-      for(const auto& active_sidechain_type : active_sidechain_types(dynamic_global_props.time)) {
+         update_son_schedule();
-         if(global_props.active_sons.at(active_sidechain_type).size() > 0) {
-            update_son_schedule(active_sidechain_type);
-         }
       }
    }
 

libraries/chain/db_getter.cpp

@@ -222,32 +222,17 @@ std::set<son_id_type> database::get_sons_to_be_deregistered()
 
    for( auto& son : son_idx )
    {
-      bool need_to_be_deregistered = true;
+      if(son.status == son_status::in_maintenance)
-      for(const auto& status : son.statuses)
       {
-         const auto& sidechain = status.first;
+         auto stats = son.statistics(*this);
-         if(status.second != son_status::in_maintenance)
+         // TODO : We need to add a function that returns if we can deregister SON 
-            need_to_be_deregistered = false;
+         // i.e. with introduction of PW code, we have to make a decision if the SON 
-
+         // is needed for release of funds from the PW
-         if(need_to_be_deregistered)
+         if(head_block_time() - stats.last_down_timestamp >= fc::seconds(get_global_properties().parameters.son_deregister_time()))
          {
-            auto stats = son.statistics(*this);
+            ret.insert(son.id);
-
-            // TODO : We need to add a function that returns if we can deregister SON
-            // i.e. with introduction of PW code, we have to make a decision if the SON
-            // is needed for release of funds from the PW
-            if(stats.last_active_timestamp.contains(sidechain)) {
-               if (head_block_time() - stats.last_active_timestamp.at(sidechain) < fc::seconds(get_global_properties().parameters.son_deregister_time())) {
-                  need_to_be_deregistered = false;
-               }
-            }
          }
       }
-
-      if(need_to_be_deregistered)
-      {
-         ret.insert(son.id);
-      }
    }
    return ret;
 }
@@ -304,50 +289,28 @@ bool database::is_son_dereg_valid( son_id_type son_id )
       return false;
    }
 
-   bool status_son_dereg_valid = true;
+   return (son->status == son_status::in_maintenance &&
-   for (const auto &active_sidechain_type : active_sidechain_types(head_block_time())) {
+                (head_block_time() - son->statistics(*this).last_down_timestamp >= fc::seconds(get_global_properties().parameters.son_deregister_time())));
-      if(son->statuses.at(active_sidechain_type) != son_status::in_maintenance)
-         status_son_dereg_valid = false;
-
-      if(status_son_dereg_valid)
-      {
-         if(son->statistics(*this).last_active_timestamp.contains(active_sidechain_type)) {
-            if (head_block_time() - son->statistics(*this).last_active_timestamp.at(active_sidechain_type) < fc::seconds(get_global_properties().parameters.son_deregister_time())) {
-               status_son_dereg_valid = false;
-            }
-         }
-      }
-   }
-
-   return status_son_dereg_valid;
 }
 
-bool database::is_son_active( sidechain_type type, son_id_type son_id )
+bool database::is_son_active( son_id_type son_id )
 {
    const auto& son_idx = get_index_type<son_index>().indices().get< by_id >();
    auto son = son_idx.find( son_id );
-   if(son == son_idx.end()) {
+   if(son == son_idx.end())
+   {
       return false;
    }
 
    const global_property_object& gpo = get_global_properties();
-   if(!gpo.active_sons.contains(type)) {
-      return false;
-   }
-
-   const auto& gpo_as = gpo.active_sons.at(type);
    vector<son_id_type> active_son_ids;
-   active_son_ids.reserve(gpo_as.size());
+   active_son_ids.reserve(gpo.active_sons.size());
-   std::transform(gpo_as.cbegin(), gpo_as.cend(),
+   std::transform(gpo.active_sons.begin(), gpo.active_sons.end(),
                   std::inserter(active_son_ids, active_son_ids.end()),
-                  [](const son_sidechain_info& swi) {
+                  [](const son_info& swi) {
       return swi.son_id;
    });
 
-   if(active_son_ids.empty()) {
-      return false;
-   }
-
    auto it_son = std::find(active_son_ids.begin(), active_son_ids.end(), son_id);
    return (it_son != active_son_ids.end());
 }
@@ -386,14 +349,23 @@ vector<uint64_t> database::get_random_numbers(uint64_t minimum, uint64_t maximum
 
 bool database::is_asset_creation_allowed(const string &symbol)
 {
+   time_point_sec now = head_block_time();
+   std::unordered_set<std::string> post_son_hf_symbols = {"ETH", "USDT", "BNB", "ADA", "DOGE", "XRP", "USDC", "DOT", "UNI", "BUSD", "BCH", "LTC", "SOL", "LINK", "MATIC", "THETA",
+                                                          "WBTC", "XLM", "ICP", "DAI", "VET", "ETC", "TRX", "FIL", "XMR", "EGR", "EOS", "SHIB", "AAVE", "CRO", "ALGO", "AMP", "BTCB",
+                                                          "BSV", "KLAY", "CAKE", "FTT", "LEO", "XTZ", "TFUEL", "MIOTA", "LUNA", "NEO", "ATOM", "MKR", "FEI", "WBNB", "UST", "AVAX",
+                                                          "STEEM", "HIVE", "HBD", "SBD", "BTS"};
    if (symbol == "BTC")
    {
-      if (head_block_time() < HARDFORK_SON_TIME)
+      if (now < HARDFORK_SON_TIME)
+         return false;
+   }
+
+   if (post_son_hf_symbols.find(symbol) != post_son_hf_symbols.end())
+   {
+      if (now >= HARDFORK_SON_TIME)
          return false;
    }
    return true;
 }
 
-}
+} }
-
-}

libraries/chain/db_init.cpp

@@ -365,7 +365,7 @@ void database::initialize_hardforks()
   _hardfork_times.emplace_back(HARDFORK_SON_FOR_HIVE_TIME);
   _hardfork_times.emplace_back(HARDFORK_SON_TIME);
   _hardfork_times.emplace_back(HARDFORK_SON2_TIME);
-  _hardfork_times.emplace_back(HARDFORK_SON_FOR_ETHEREUM_TIME);
+  _hardfork_times.emplace_back(HARDFORK_SON3_TIME);
   _hardfork_times.emplace_back(HARDFORK_SWEEPS_TIME);
 
   std::sort(_hardfork_times.begin(), _hardfork_times.end());
@@ -374,9 +374,7 @@ void database::initialize_hardforks()
 void database::initialize_indexes()
 {
    reset_indexes();
-
+   _undo_db.set_max_size( GRAPHENE_MIN_UNDO_HISTORY );
-   const std::lock_guard<std::mutex> undo_db_lock{_undo_db_mutex};
-   _undo_db.set_max_size(GRAPHENE_MIN_UNDO_HISTORY);
 
    //Protocol object indexes
    add_index< primary_index<asset_index, 13> >(); // 8192 assets per chunk
@@ -476,9 +474,7 @@ void database::init_genesis(const genesis_state_type& genesis_state)
    FC_ASSERT(genesis_state.initial_active_witnesses <= genesis_state.initial_witness_candidates.size(),
              "initial_active_witnesses is larger than the number of candidate witnesses.");
 
-   const std::lock_guard<std::mutex> undo_db_lock{_undo_db_mutex};
    _undo_db.disable();
-
    struct auth_inhibitor {
       auth_inhibitor(database& db) : db(db), old_flags(db.node_properties().skip_flags)
       { db.node_properties().skip_flags |= skip_authority_check; }
@@ -1104,9 +1100,8 @@ void database::init_genesis(const genesis_state_type& genesis_state)
    FC_ASSERT( _p_witness_schedule_obj->id == witness_schedule_id_type() );
 
       // Initialize witness schedule
-
 #ifndef NDEBUG
-   const son_schedule_object& ssobitcoin =
+   const son_schedule_object& sso =
 #endif
    create<son_schedule_object>([&](son_schedule_object& _sso)
    {
@@ -1115,64 +1110,24 @@ void database::init_genesis(const genesis_state_type& genesis_state)
 
       witness_scheduler_rng rng(_sso.rng_seed.begin(), GRAPHENE_NEAR_SCHEDULE_CTR_IV);
 
-      auto init_bitcoin_sons = get_global_properties().active_sons.at(sidechain_type::bitcoin);
+      auto init_witnesses = get_global_properties().active_witnesses;
 
       _sso.scheduler = son_scheduler();
-      _sso.scheduler._min_token_count = std::max(int(init_bitcoin_sons.size()) / 2, 1);
+      _sso.scheduler._min_token_count = std::max(int(init_witnesses.size()) / 2, 1);
+
 
       _sso.last_scheduling_block = 0;
 
       _sso.recent_slots_filled = fc::uint128::max_value();
    });
-   assert( ssobitcoin.id == son_schedule_id_type(get_son_schedule_id(sidechain_type::bitcoin)) );
+   assert( sso.id == son_schedule_id_type() );
-
-#ifndef NDEBUG
-   const son_schedule_object& ssoethereum =
-#endif
-   create<son_schedule_object>([&](son_schedule_object& _sso)
-   {
-      // for scheduled
-      memset(_sso.rng_seed.begin(), 0, _sso.rng_seed.size());
-
-      witness_scheduler_rng rng(_sso.rng_seed.begin(), GRAPHENE_NEAR_SCHEDULE_CTR_IV);
-
-      auto init_ethereum_sons = get_global_properties().active_sons.at(sidechain_type::ethereum);
-
-      _sso.scheduler = son_scheduler();
-      _sso.scheduler._min_token_count = std::max(int(init_ethereum_sons.size()) / 2, 1);
-
-      _sso.last_scheduling_block = 0;
-
-      _sso.recent_slots_filled = fc::uint128::max_value();
-   });
-   assert( ssoethereum.id == son_schedule_id_type(get_son_schedule_id(sidechain_type::ethereum)) );
-
-#ifndef NDEBUG
-   const son_schedule_object& ssohive =
-#endif
-   create<son_schedule_object>([&](son_schedule_object& _sso)
-   {
-      // for scheduled
-      memset(_sso.rng_seed.begin(), 0, _sso.rng_seed.size());
-
-      witness_scheduler_rng rng(_sso.rng_seed.begin(), GRAPHENE_NEAR_SCHEDULE_CTR_IV);
-
-      auto init_hive_sons = get_global_properties().active_sons.at(sidechain_type::hive);
-
-      _sso.scheduler = son_scheduler();
-      _sso.scheduler._min_token_count = std::max(int(init_hive_sons.size()) / 2, 1);
-
-      _sso.last_scheduling_block = 0;
-
-      _sso.recent_slots_filled = fc::uint128::max_value();
-   });
-   assert( ssohive.id == son_schedule_id_type(get_son_schedule_id(sidechain_type::hive)) );
 
    // Enable fees
    modify(get_global_properties(), [&genesis_state](global_property_object& p) {
       p.parameters.current_fees = genesis_state.initial_parameters.current_fees;
    });
 
+
    // Create FBA counters
    create<fba_accumulator_object>([&]( fba_accumulator_object& acc )
    {

libraries/chain/db_witness_schedule.cpp

@@ -74,32 +74,21 @@ witness_id_type database::get_scheduled_witness( uint32_t slot_num )const
    return wid;
 }
 
-unsigned_int database::get_son_schedule_id( sidechain_type type )const
+son_id_type database::get_scheduled_son( uint32_t slot_num )const
-{
-   static const map<sidechain_type, unsigned_int> schedule_map = {
-      { sidechain_type::bitcoin, 0 },
-      { sidechain_type::ethereum, 1 },
-      { sidechain_type::hive, 2 }
-   };
-
-   return schedule_map.at(type);
-}
-
-son_id_type database::get_scheduled_son( sidechain_type type, uint32_t slot_num )const
 {
    son_id_type sid;
    const global_property_object& gpo = get_global_properties();
    if (gpo.parameters.witness_schedule_algorithm == GRAPHENE_WITNESS_SHUFFLED_ALGORITHM)
    {
        const dynamic_global_property_object& dpo = get_dynamic_global_properties();
-       const son_schedule_object& sso = son_schedule_id_type(get_son_schedule_id(type))(*this);
+       const son_schedule_object& sso = son_schedule_id_type()(*this);
        uint64_t current_aslot = dpo.current_aslot + slot_num;
        return sso.current_shuffled_sons[ current_aslot % sso.current_shuffled_sons.size() ];
    }
    if (gpo.parameters.witness_schedule_algorithm == GRAPHENE_WITNESS_SCHEDULED_ALGORITHM &&
        slot_num != 0 )
    {
-      const son_schedule_object& sso = son_schedule_id_type(get_son_schedule_id(type))(*this);
+       const son_schedule_object& sso = son_schedule_id_type()(*this);
        // ask the near scheduler who goes in the given slot
        bool slot_is_near = sso.scheduler.get_slot(slot_num-1, sid);
        if(! slot_is_near)
@@ -200,39 +189,36 @@ void database::update_witness_schedule()
    }
 }
 
-void database::update_son_schedule(sidechain_type type)
+void database::update_son_schedule()
 {
+   const son_schedule_object& sso = son_schedule_id_type()(*this);
    const global_property_object& gpo = get_global_properties();
 
-   const son_schedule_object& sidechain_sso = get(son_schedule_id_type(get_son_schedule_id(type)));
+   if( head_block_num() % gpo.active_sons.size() == 0 )
-   if( gpo.active_sons.at(type).size() != 0 &&
-         head_block_num() % gpo.active_sons.at(type).size() == 0)
    {
-      modify( sidechain_sso, [&]( son_schedule_object& _sso )
+      modify( sso, [&]( son_schedule_object& _sso )
       {
          _sso.current_shuffled_sons.clear();
-         _sso.current_shuffled_sons.reserve( gpo.active_sons.at(type).size() );
+         _sso.current_shuffled_sons.reserve( gpo.active_sons.size() );
 
-         for ( const auto &w : gpo.active_sons.at(type) ) {
+         for( const son_info& w : gpo.active_sons )
-               _sso.current_shuffled_sons.push_back(w.son_id);
+            _sso.current_shuffled_sons.push_back( w.son_id );
-         }
 
          auto now_hi = uint64_t(head_block_time().sec_since_epoch()) << 32;
-
+         for( uint32_t i = 0; i < _sso.current_shuffled_sons.size(); ++i )
-         for (uint32_t i = 0; i < _sso.current_shuffled_sons.size(); ++i)
          {
             /// High performance random generator
             /// http://xorshift.di.unimi.it/
-            uint64_t k = now_hi + uint64_t(i) * 2685821657736338717ULL;
+            uint64_t k = now_hi + uint64_t(i)*2685821657736338717ULL;
             k ^= (k >> 12);
             k ^= (k << 25);
             k ^= (k >> 27);
             k *= 2685821657736338717ULL;
 
             uint32_t jmax = _sso.current_shuffled_sons.size() - i;
-            uint32_t j = i + k % jmax;
+            uint32_t j = i + k%jmax;
-            std::swap(_sso.current_shuffled_sons[i],
+            std::swap( _sso.current_shuffled_sons[i],
-                      _sso.current_shuffled_sons[j]);
+                       _sso.current_shuffled_sons[j] );
          }
       });
    }
@@ -318,15 +304,13 @@ void database::update_witness_schedule(const signed_block& next_block)
       idump( ( double(total_time/1000000.0)/calls) );
 }
 
-void database::update_son_schedule(sidechain_type type, const signed_block& next_block)
+void database::update_son_schedule(const signed_block& next_block)
 {
    auto start = fc::time_point::now();
-#ifndef NDEBUG
-   const son_schedule_object& sso = get(son_schedule_id_type());
-#endif
    const global_property_object& gpo = get_global_properties();
-   const uint32_t schedule_needs_filled = gpo.active_sons.at(type).size();
+   const son_schedule_object& sso = get(son_schedule_id_type());
-   const uint32_t schedule_slot = get_slot_at_time(next_block.timestamp);
+   uint32_t schedule_needs_filled = gpo.active_sons.size();
+   uint32_t schedule_slot = get_slot_at_time(next_block.timestamp);
 
    // We shouldn't be able to generate _pending_block with timestamp
    // in the past, and incoming blocks from the network with timestamp
@@ -335,49 +319,48 @@ void database::update_son_schedule(sidechain_type type, const signed_block& next
 
    assert( schedule_slot > 0 );
 
+   son_id_type first_son;
+   bool slot_is_near = sso.scheduler.get_slot( schedule_slot-1, first_son );
+
+   son_id_type son;
+
    const dynamic_global_property_object& dpo = get_dynamic_global_properties();
 
    assert( dpo.random.data_size() == witness_scheduler_rng::seed_length );
    assert( witness_scheduler_rng::seed_length == sso.rng_seed.size() );
 
-   const son_schedule_object& sidechain_sso = get(son_schedule_id_type(get_son_schedule_id(type)));
+   modify(sso, [&](son_schedule_object& _sso)
-   son_id_type first_son;
-   bool slot_is_near = sidechain_sso.scheduler.get_slot( schedule_slot-1, first_son );
-   son_id_type son_id;
-
-   modify(sidechain_sso, [&](son_schedule_object& _sso)
    {
-    _sso.slots_since_genesis += schedule_slot;
+      _sso.slots_since_genesis += schedule_slot;
-    witness_scheduler_rng rng(_sso.rng_seed.data, _sso.slots_since_genesis);
+      witness_scheduler_rng rng(sso.rng_seed.data, _sso.slots_since_genesis);
 
-    _sso.scheduler._min_token_count = std::max(int(gpo.active_sons.at(type).size()) / 2, 1);
+      _sso.scheduler._min_token_count = std::max(int(gpo.active_sons.size()) / 2, 1);
 
-    if( slot_is_near )
+      if( slot_is_near )
-    {
+      {
-       uint32_t drain = schedule_slot;
+         uint32_t drain = schedule_slot;
-       while( drain > 0 )
+         while( drain > 0 )
-       {
+         {
-          if( _sso.scheduler.size() == 0 )
+            if( _sso.scheduler.size() == 0 )
-             break;
+               break;
-          _sso.scheduler.consume_schedule();
+            _sso.scheduler.consume_schedule();
-          --drain;
+            --drain;
-       }
+         }
-    }
+      }
-    else
+      else
-    {
+      {
-       _sso.scheduler.reset_schedule( first_son );
+         _sso.scheduler.reset_schedule( first_son );
-    }
+      }
-    while( !_sso.scheduler.get_slot(schedule_needs_filled, son_id) )
+      while( !_sso.scheduler.get_slot(schedule_needs_filled, son) )
-    {
+      {
-       if( _sso.scheduler.produce_schedule(rng) & emit_turn )
+         if( _sso.scheduler.produce_schedule(rng) & emit_turn )
-          memcpy(_sso.rng_seed.begin(), dpo.random.data(), dpo.random.data_size());
+            memcpy(_sso.rng_seed.begin(), dpo.random.data(), dpo.random.data_size());
-    }
+      }
-    _sso.last_scheduling_block = next_block.block_num();
+      _sso.last_scheduling_block = next_block.block_num();
-    _sso.recent_slots_filled = (
+      _sso.recent_slots_filled = (
-                                     (_sso.recent_slots_filled << 1)
+           (_sso.recent_slots_filled << 1)
-                                     + 1) << (schedule_slot - 1);
+           + 1) << (schedule_slot - 1);
    });
-
    auto end = fc::time_point::now();
    static uint64_t total_time = 0;
    static uint64_t calls = 0;

libraries/chain/hardfork.d/HOTFIX_2024.hf

@@ -1,7 +0,0 @@
-#ifndef HARDFORK_HOTFIX_2024_TIME
-#ifdef BUILD_PEERPLAYS_TESTNET
-#define HARDFORK_HOTFIX_2024_TIME (fc::time_point_sec::from_iso_string("2023-12-20T00:00:00"))
-#else
-#define HARDFORK_HOTFIX_2024_TIME (fc::time_point_sec::from_iso_string("2023-12-20T00:00:00"))
-#endif
-#endif

libraries/chain/hardfork.d/SIDECHAIN.hf

@@ -1,7 +0,0 @@
-#ifndef HARDFORK_SIDECHAIN_DELETE_TIME
-#ifdef BUILD_PEERPLAYS_TESTNET
-#define HARDFORK_SIDECHAIN_DELETE_TIME (fc::time_point_sec::from_iso_string("2022-11-16T02:00:00"))
-#else
-#define HARDFORK_SIDECHAIN_DELETE_TIME (fc::time_point_sec::from_iso_string("2022-11-16T02:00:00"))
-#endif
-#endif

libraries/chain/hardfork.d/SON3.hf

@@ -0,0 +1,7 @@
+#ifndef HARDFORK_SON3_TIME
+#ifdef BUILD_PEERPLAYS_TESTNET
+#define HARDFORK_SON3_TIME (fc::time_point_sec::from_iso_string("2022-07-16T00:00:00"))
+#else
+#define HARDFORK_SON3_TIME (fc::time_point_sec::from_iso_string("2022-07-16T00:00:00"))
+#endif
+#endif

libraries/chain/hardfork.d/SON_FOR_ETHEREUM.hf

@@ -1,7 +1,7 @@
 #ifndef HARDFORK_SON_FOR_ETHEREUM_TIME
 #ifdef BUILD_PEERPLAYS_TESTNET
-#define HARDFORK_SON_FOR_ETHEREUM_TIME (fc::time_point_sec::from_iso_string("2023-07-17T12:00:00"))
+#define HARDFORK_SON_FOR_ETHEREUM_TIME (fc::time_point_sec::from_iso_string("2022-07-01T00:00:00"))
 #else
-#define HARDFORK_SON_FOR_ETHEREUM_TIME (fc::time_point_sec::from_iso_string("2023-10-24T12:00:00"))
+#define HARDFORK_SON_FOR_ETHEREUM_TIME (fc::time_point_sec::from_iso_string("2022-07-01T00:00:00"))
 #endif
 #endif

libraries/chain/include/graphene/chain/config.hpp

@@ -158,7 +158,7 @@
 #define GRAPHENE_RECENTLY_MISSED_COUNT_INCREMENT             4
 #define GRAPHENE_RECENTLY_MISSED_COUNT_DECREMENT             3
 
-#define GRAPHENE_CURRENT_DB_VERSION                          "PPY2.5"
+#define GRAPHENE_CURRENT_DB_VERSION                          "PPY2.4"
 
 #define GRAPHENE_IRREVERSIBLE_THRESHOLD                      (70 * GRAPHENE_1_PERCENT)
 

libraries/chain/include/graphene/chain/database.hpp

@@ -245,16 +245,7 @@ namespace graphene { namespace chain {
          witness_id_type get_scheduled_witness(uint32_t slot_num)const;
 
          /**
-          * @brief Get son schedule id for the given sidechain_type.
+          * @brief Get the son scheduled for block production in a slot.
-          *
-          * type sidechain_type we getting schedule.
-          *
-          * returns Id of the schedule object.
-          */
-         unsigned_int get_son_schedule_id(sidechain_type type)const;
-
-         /**
-          * @brief Get the bitcoin or hive son scheduled for block production in a slot.
           *
           * slot_num always corresponds to a time in the future.
           *
@@ -267,7 +258,7 @@ namespace graphene { namespace chain {
           *
           * Passing slot_num == 0 returns GRAPHENE_NULL_WITNESS
           */
-         son_id_type get_scheduled_son(sidechain_type type, uint32_t slot_num)const;
+         son_id_type get_scheduled_son(uint32_t slot_num)const;
 
          /**
           * Get the time at which the given slot occurs.
@@ -292,8 +283,8 @@ namespace graphene { namespace chain {
          vector<witness_id_type> get_near_witness_schedule()const;
          void update_witness_schedule();
          void update_witness_schedule(const signed_block& next_block);
-         void update_son_schedule(sidechain_type type);
+         void update_son_schedule();
-         void update_son_schedule(sidechain_type type, const signed_block& next_block);
+         void update_son_schedule(const signed_block& next_block);
       
          void check_lottery_end_by_participants( asset_id_type asset_id );
          void check_ending_lotteries();
@@ -322,7 +313,7 @@ namespace graphene { namespace chain {
          fc::optional<operation>                create_son_deregister_proposal( son_id_type son_id, account_id_type paying_son );
          signed_transaction                     create_signed_transaction( const fc::ecc::private_key& signing_private_key, const operation& op );
          bool                                   is_son_dereg_valid( son_id_type son_id );
-         bool                                   is_son_active( sidechain_type type, son_id_type son_id );
+         bool                                   is_son_active( son_id_type son_id );
          bool                                   is_asset_creation_allowed(const string& symbol);
 
          time_point_sec   head_block_time()const;
@@ -520,16 +511,12 @@ namespace graphene { namespace chain {
          void notify_changed_objects();
 
       private:
-         std::mutex                             _pending_tx_session_mutex;
          optional<undo_database::session>       _pending_tx_session;
          vector< unique_ptr<op_evaluator> >     _operation_evaluators;
 
          template<class Index>
          vector<std::reference_wrapper<const typename Index::object_type>> sort_votable_objects(size_t count)const;
 
-         template<class Index>
-         vector<std::reference_wrapper<const typename Index::object_type>> sort_votable_objects(sidechain_type sidechain, size_t count)const;
-
          //////////////////// db_block.cpp ////////////////////
 
        public:
@@ -579,22 +566,19 @@ namespace graphene { namespace chain {
          void initialize_budget_record( fc::time_point_sec now, budget_record& rec )const;
          void process_budget();
          void pay_workers( share_type& budget );
-         void pay_sons_before_hf_ethereum();
+         void pay_sons();
-         void pay_sons_after_hf_ethereum();
          void perform_son_tasks();
          void perform_chain_maintenance(const signed_block& next_block, const global_property_object& global_props);
          void update_active_witnesses();
          void update_active_committee_members();
-         void update_son_metrics( const flat_map<sidechain_type, vector<son_sidechain_info> >& curr_active_sons );
+         void update_son_metrics( const vector<son_info>& curr_active_sons );
          void update_active_sons();
          void remove_son_proposal( const proposal_object& proposal );
          void remove_inactive_son_down_proposals( const vector<son_id_type>& son_ids_to_remove );
          void remove_inactive_son_proposals( const vector<son_id_type>& son_ids_to_remove );
-         void update_son_statuses( const flat_map<sidechain_type, vector<son_sidechain_info> >& curr_active_sons,
+         void update_son_statuses( const vector<son_info>& cur_active_sons, const vector<son_info>& new_active_sons );
-                                   const flat_map<sidechain_type, vector<son_sidechain_info> >& new_active_sons );
+         void update_son_wallet( const vector<son_info>& new_active_sons );
-         void update_son_wallet( const flat_map<sidechain_type, vector<son_sidechain_info> >& new_active_sons );
          void update_worker_votes();
-         void hotfix_2024();
 
          public:
             double calculate_vesting_factor(const account_object& stake_account);
@@ -605,7 +589,6 @@ namespace graphene { namespace chain {
          ///@}
          ///@}
 
-         std::mutex                             _pending_tx_mutex;
          vector< processed_transaction >        _pending_tx;
          fork_database                          _fork_db;
 
@@ -633,17 +616,11 @@ namespace graphene { namespace chain {
          uint16_t                          _current_op_in_trx    = 0;
          uint32_t                          _current_virtual_op   = 0;
 
-         vector<uint64_t>                             _vote_tally_buffer;
+         vector<uint64_t>                  _vote_tally_buffer;
-         vector<uint64_t>                             _witness_count_histogram_buffer;
+         vector<uint64_t>                  _witness_count_histogram_buffer;
-         vector<uint64_t>                             _committee_count_histogram_buffer;
+         vector<uint64_t>                  _committee_count_histogram_buffer;
-         flat_map<sidechain_type, vector<uint64_t> >  _son_count_histogram_buffer = []{
+         vector<uint64_t>                  _son_count_histogram_buffer;
-            flat_map<sidechain_type, vector<uint64_t> >  son_count_histogram_buffer;
+         uint64_t                          _total_voting_stake;
-            for(const auto& active_sidechain_type : all_sidechain_types){
-               son_count_histogram_buffer[active_sidechain_type] = vector<uint64_t>{};
-            }
-            return son_count_histogram_buffer;
-         }();
-         uint64_t                                     _total_voting_stake;
 
          flat_map<uint32_t,block_id_type>  _checkpoints;
 

libraries/chain/include/graphene/chain/exceptions.hpp

@@ -182,9 +182,6 @@ namespace graphene { namespace chain {
    GRAPHENE_DECLARE_OP_BASE_EXCEPTIONS( override_transfer );
    GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( not_permitted, override_transfer, 1, "not permitted" )
 
-   GRAPHENE_DECLARE_OP_BASE_EXCEPTIONS( blind_transfer );
-   GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( unknown_commitment, blind_transfer, 1, "Attempting to claim an unknown prior commitment" );
-
    /*
    FC_DECLARE_DERIVED_EXCEPTION( addition_overflow,                 graphene::chain::chain_exception, 30002, "addition overflow" )
    FC_DECLARE_DERIVED_EXCEPTION( subtraction_overflow,              graphene::chain::chain_exception, 30003, "subtraction overflow" )

libraries/chain/include/graphene/chain/global_property_object.hpp

@@ -27,7 +27,7 @@
 #include <graphene/chain/protocol/chain_parameters.hpp>
 #include <graphene/chain/protocol/types.hpp>
 #include <graphene/chain/database.hpp>
-#include <graphene/chain/son_sidechain_info.hpp>
+#include <graphene/chain/son_info.hpp>
 #include <graphene/db/object.hpp>
 
 namespace graphene { namespace chain {
@@ -49,18 +49,10 @@ namespace graphene { namespace chain {
          chain_parameters           parameters;
          optional<chain_parameters> pending_parameters;
 
-         uint32_t                                                 next_available_vote_id = 0;
+         uint32_t                           next_available_vote_id = 0;
-         vector<committee_member_id_type>                         active_committee_members;  // updated once per maintenance interval
+         vector<committee_member_id_type>   active_committee_members; // updated once per maintenance interval
-         flat_set<witness_id_type>                                active_witnesses;          // updated once per maintenance interval
+         flat_set<witness_id_type>          active_witnesses; // updated once per maintenance interval
-         flat_map<sidechain_type, vector<son_sidechain_info> >    active_sons = []()         // updated once per maintenance interval
+         vector<son_info>                   active_sons; // updated once per maintenance interval
-         {
-            flat_map<sidechain_type, vector<son_sidechain_info> > active_sons;
-            for(const auto& active_sidechain_type : all_sidechain_types)
-            {
-               active_sons[active_sidechain_type] = vector<son_sidechain_info>();
-            }
-            return active_sons;
-         }();
          // n.b. witness scheduling is done by witness_schedule object
    };
 

libraries/chain/include/graphene/chain/nft_object.hpp

@@ -130,9 +130,6 @@ namespace graphene { namespace chain {
                std::greater< uint32_t >,
                std::greater< object_id_type >
             >
-         >,
-         ordered_non_unique< tag<by_owner>,
-            member<nft_metadata_object, account_id_type, &nft_metadata_object::owner>
          >
       >
    >;

libraries/chain/include/graphene/chain/protocol/account.hpp

@@ -28,7 +28,6 @@
 #include <graphene/chain/protocol/special_authority.hpp>
 #include <graphene/chain/protocol/types.hpp>
 #include <graphene/chain/protocol/vote.hpp>
-#include <graphene/chain/sidechain_defs.hpp>
 
 namespace graphene { namespace chain {
 
@@ -36,28 +35,13 @@ namespace graphene { namespace chain {
    bool is_cheap_name( const string& n );
 
    /// These are the fields which can be updated by the active authority.
-   struct   account_options
+   struct account_options
    {
       struct ext
       {
-         /// The number of active son members this account votes the blockchain should appoint
+         optional< uint16_t > num_son = 0;
-         /// Must not exceed the actual number of son members voted for in @ref votes
-         optional< flat_map<sidechain_type, uint16_t> > num_son;
-
-         /// Returns and empty num_son map with all sidechains
-         static flat_map<sidechain_type, uint16_t> empty_num_son()
-         {
-            flat_map<sidechain_type, uint16_t> num_son;
-            for(const auto& active_sidechain_type : all_sidechain_types)
-            {
-               num_son[active_sidechain_type] = 0;
-            }
-
-            return num_son;
-         }
       };
 
-
       /// The memo key is the key this account will typically use to encrypt/sign transaction memos and other non-
       /// validated account activities. This field is here to prevent confusion if the active authority has zero or
       /// multiple keys in it.
@@ -73,11 +57,14 @@ namespace graphene { namespace chain {
       /// The number of active committee members this account votes the blockchain should appoint
       /// Must not exceed the actual number of committee members voted for in @ref votes
       uint16_t num_committee = 0;
+      /// The number of active son members this account votes the blockchain should appoint
+      /// Must not exceed the actual number of son members voted for in @ref votes
+      uint16_t num_son() const { return extensions.value.num_son.valid() ? *extensions.value.num_son : 0; }
       /// This is the list of vote IDs this account votes for. The weight of these votes is determined by this
       /// account's balance of core asset.
       flat_set<vote_id_type> votes;
       extension< ext > extensions;
-
+      
       /// Whether this account is voting
       inline bool is_voting() const
       {
@@ -262,7 +249,7 @@ namespace graphene { namespace chain {
     */
    struct account_upgrade_operation : public base_operation
    {
-      struct fee_parameters_type {
+      struct fee_parameters_type { 
          uint64_t membership_annual_fee   =  2000 * GRAPHENE_BLOCKCHAIN_PRECISION;
          uint64_t membership_lifetime_fee = 10000 * GRAPHENE_BLOCKCHAIN_PRECISION; ///< the cost to upgrade to a lifetime member
       };
@@ -307,7 +294,7 @@ namespace graphene { namespace chain {
 
 } } // graphene::chain
 
-FC_REFLECT(graphene::chain::account_options::ext, (num_son))
+FC_REFLECT(graphene::chain::account_options::ext, (num_son) )
 FC_REFLECT(graphene::chain::account_options, (memo_key)(voting_account)(num_witness)(num_committee)(votes)(extensions))
 // FC_REFLECT_TYPENAME( graphene::chain::account_whitelist_operation::account_listing)
 FC_REFLECT_ENUM( graphene::chain::account_whitelist_operation::account_listing,

libraries/chain/include/graphene/chain/protocol/confidential.hpp

@@ -158,7 +158,9 @@ struct transfer_to_blind_operation : public base_operation
    blind_factor_type     blinding_factor;
    vector<blind_output>  outputs;
 
-   account_id_type fee_payer()const { return from; }
+   account_id_type fee_payer()const { return account_id_type{}; }
+
+   //account_id_type fee_payer()const { return from; }
    //void            validate()const;
    //share_type      calculate_fee(const fee_parameters_type& )const;
 };
@@ -179,7 +181,9 @@ struct transfer_from_blind_operation : public base_operation
    blind_factor_type     blinding_factor;
    vector<blind_input>   inputs;
 
-   account_id_type fee_payer()const { return GRAPHENE_TEMP_ACCOUNT; }
+   account_id_type fee_payer()const { return account_id_type{}; }
+
+   //account_id_type fee_payer()const { return GRAPHENE_TEMP_ACCOUNT; }
    //void            validate()const;
    //void            get_required_authorities( vector<authority>& a )const
    //{
@@ -242,8 +246,10 @@ struct blind_transfer_operation : public base_operation
    vector<blind_input>   inputs;
    vector<blind_output>  outputs;
 
+   account_id_type fee_payer()const { return account_id_type{}; }
+
    /** graphene TEMP account */
-   account_id_type fee_payer()const { return GRAPHENE_TEMP_ACCOUNT; }
+   //account_id_type fee_payer()const;
    //void            validate()const;
    //share_type      calculate_fee( const fee_parameters_type& k )const;
    //void            get_required_authorities( vector<authority>& a )const

libraries/chain/include/graphene/chain/protocol/nft_lottery.hpp

@@ -18,7 +18,7 @@ namespace graphene
             // Buyer purchasing lottery tickets
             account_id_type buyer;
             // count of tickets to buy
-            share_type tickets_to_buy;
+            uint64_t tickets_to_buy;
             // amount that can spent
             asset amount;
 
@@ -83,4 +83,4 @@ FC_REFLECT(graphene::chain::nft_lottery_reward_operation::fee_parameters_type, (
 FC_REFLECT(graphene::chain::nft_lottery_end_operation::fee_parameters_type, (fee))
 FC_REFLECT(graphene::chain::nft_lottery_token_purchase_operation, (fee)(lottery_id)(buyer)(tickets_to_buy)(amount)(extensions))
 FC_REFLECT(graphene::chain::nft_lottery_reward_operation, (fee)(lottery_id)(winner)(amount)(win_percentage)(is_benefactor_reward)(winner_ticket_id)(extensions))
-FC_REFLECT(graphene::chain::nft_lottery_end_operation, (fee)(lottery_id)(extensions))
+FC_REFLECT(graphene::chain::nft_lottery_end_operation, (fee)(lottery_id)(extensions))

libraries/chain/include/graphene/chain/protocol/sidechain_transaction.hpp

@@ -71,7 +71,7 @@ FC_REFLECT( graphene::chain::sidechain_transaction_create_operation, (fee)(payer
         (sidechain)
         (object_id)
         (transaction)
-        (signers))
+        (signers) )
 
 FC_REFLECT( graphene::chain::sidechain_transaction_sign_operation::fee_parameters_type, (fee) )
 FC_REFLECT( graphene::chain::sidechain_transaction_sign_operation, (fee)(signer)(payer)

libraries/chain/include/graphene/chain/protocol/son_wallet.hpp

@@ -1,47 +1,40 @@
 #pragma once
 #include <graphene/chain/protocol/base.hpp>
 #include <graphene/chain/son_info.hpp>
-#include <graphene/chain/son_sidechain_info.hpp>
 
 namespace graphene { namespace chain {
 
-   struct son_wallet_recreate_operation : public base_operation
+    struct son_wallet_recreate_operation : public base_operation
-   {
+    {
-     struct fee_parameters_type { uint64_t fee = 0; };
+        struct fee_parameters_type { uint64_t fee = 0; };
-     struct ext
-     {
-        optional<flat_map<sidechain_type, vector<son_sidechain_info> > > sidechain_sons;
-     };
 
-     asset fee;
+        asset fee;
-     account_id_type payer;
+        account_id_type payer;
 
-     vector<son_info> sons;
+        vector<son_info> sons;
-     extension< ext > extensions;
 
-     account_id_type fee_payer()const { return payer; }
+        account_id_type fee_payer()const { return payer; }
-     share_type      calculate_fee(const fee_parameters_type& k)const { return 0; }
+        share_type      calculate_fee(const fee_parameters_type& k)const { return 0; }
-   };
+    };
 
-   struct son_wallet_update_operation : public base_operation
+    struct son_wallet_update_operation : public base_operation
-   {
+    {
-     struct fee_parameters_type { uint64_t fee = 0; };
+        struct fee_parameters_type { uint64_t fee = 0; };
 
-     asset fee;
+        asset fee;
-     account_id_type payer;
+        account_id_type payer;
 
-     son_wallet_id_type son_wallet_id;
+        son_wallet_id_type son_wallet_id;
-     sidechain_type sidechain;
+        sidechain_type sidechain;
-     string address;
+        string address;
 
-     account_id_type fee_payer()const { return payer; }
+        account_id_type fee_payer()const { return payer; }
-     share_type      calculate_fee(const fee_parameters_type& k)const { return 0; }
+        share_type      calculate_fee(const fee_parameters_type& k)const { return 0; }
-   };
+    };
 
 } } // namespace graphene::chain
 
 FC_REFLECT(graphene::chain::son_wallet_recreate_operation::fee_parameters_type, (fee) )
-FC_REFLECT(graphene::chain::son_wallet_recreate_operation::ext, (sidechain_sons))
+FC_REFLECT(graphene::chain::son_wallet_recreate_operation, (fee)(payer)(sons) )
-FC_REFLECT(graphene::chain::son_wallet_recreate_operation, (fee)(payer)(sons)(extensions) )
 FC_REFLECT(graphene::chain::son_wallet_update_operation::fee_parameters_type, (fee) )
 FC_REFLECT(graphene::chain::son_wallet_update_operation, (fee)(payer)(son_wallet_id)(sidechain)(address) )

libraries/chain/include/graphene/chain/protocol/types.hpp

@@ -395,13 +395,6 @@ namespace graphene { namespace chain {
        bool is_valid_muse( const std::string& base58str );
    };
 
-   class pubkey_comparator {
-   public:
-      inline bool operator()(const public_key_type& a, const public_key_type& b) const {
-         return a.key_data < b.key_data;
-      }
-   };
-
    struct extended_public_key_type
    {
       struct binary_key

libraries/chain/include/graphene/chain/protocol/vote.hpp

@@ -59,9 +59,7 @@ struct vote_id_type
       committee,
       witness,
       worker,
-      son_bitcoin,
+      son,
-      son_hive,
-      son_ethereum,
       VOTE_TYPE_COUNT
    };
 
@@ -146,7 +144,7 @@ void from_variant( const fc::variant& var, graphene::chain::vote_id_type& vo, ui
 
 FC_REFLECT_TYPENAME( fc::flat_set<graphene::chain::vote_id_type> )
 
-FC_REFLECT_ENUM( graphene::chain::vote_id_type::vote_type, (witness)(committee)(worker)(son_bitcoin)(son_hive)(son_ethereum)(VOTE_TYPE_COUNT) )
+FC_REFLECT_ENUM( graphene::chain::vote_id_type::vote_type, (witness)(committee)(worker)(son)(VOTE_TYPE_COUNT) )
 FC_REFLECT( graphene::chain::vote_id_type, (content) )
 
 GRAPHENE_EXTERNAL_SERIALIZATION( extern, graphene::chain::vote_id_type )

libraries/chain/include/graphene/chain/sidechain_address_object.hpp

@@ -31,20 +31,11 @@ namespace graphene { namespace chain {
          time_point_sec expires;
 
          sidechain_address_object() :
-            sidechain(sidechain_type::bitcoin), //! FIXME - bitcoin ???
+            sidechain(sidechain_type::bitcoin),
             deposit_public_key(""),
             deposit_address(""),
             withdraw_public_key(""),
             withdraw_address("") {}
-
-         inline string get_deposit_address() const {
-            if(sidechain_type::ethereum != sidechain)
-               return deposit_address;
-
-            auto deposit_address_lower = deposit_address;
-            std::transform(deposit_address_lower.begin(), deposit_address_lower.end(), deposit_address_lower.begin(), ::tolower);
-            return deposit_address_lower;
-         }
    };
 
    struct by_account;
@@ -85,7 +76,7 @@ namespace graphene { namespace chain {
          ordered_non_unique< tag<by_sidechain_and_deposit_address_and_expires>,
             composite_key<sidechain_address_object,
                member<sidechain_address_object, sidechain_type, &sidechain_address_object::sidechain>,
-               const_mem_fun<sidechain_address_object, string, &sidechain_address_object::get_deposit_address>,
+               member<sidechain_address_object, string, &sidechain_address_object::deposit_address>,
                member<sidechain_address_object, time_point_sec, &sidechain_address_object::expires>
             >
          >

libraries/chain/include/graphene/chain/sidechain_defs.hpp

@@ -1,11 +1,6 @@
 #pragma once
 
-#include <set>
-
-#include <graphene/chain/hardfork.hpp>
-
 #include <fc/reflect/reflect.hpp>
-#include <fc/time.hpp>
 
 namespace graphene { namespace chain {
 
@@ -18,28 +13,12 @@ enum class sidechain_type {
    hive
 };
 
-static const std::set<sidechain_type> all_sidechain_types = {sidechain_type::bitcoin, sidechain_type::ethereum, sidechain_type::hive};
+} }
-
-inline std::set<sidechain_type> active_sidechain_types(const fc::time_point_sec block_time) {
-   std::set<sidechain_type> active_sidechain_types{};
-
-   if (block_time >= HARDFORK_SON_TIME)
-      active_sidechain_types.insert(sidechain_type::bitcoin);
-   if (block_time >= HARDFORK_SON_FOR_HIVE_TIME)
-      active_sidechain_types.insert(sidechain_type::hive);
-   if (block_time >= HARDFORK_SON_FOR_ETHEREUM_TIME)
-      active_sidechain_types.insert(sidechain_type::ethereum);
-
-   return active_sidechain_types;
-}
-
-} // namespace chain
-} // namespace graphene
 
 FC_REFLECT_ENUM(graphene::chain::sidechain_type,
-   (unknown)
+        (unknown)
-   (bitcoin)
+        (bitcoin)
-   (ethereum)
+        (ethereum)
-   (eos)
+        (eos)
-   (hive)
+        (hive)
-   (peerplays) )
+        (peerplays) )

libraries/chain/include/graphene/chain/sidechain_transaction_object.hpp

@@ -2,7 +2,7 @@
 #include <boost/multi_index/composite_key.hpp>
 #include <graphene/chain/protocol/types.hpp>
 #include <graphene/chain/sidechain_defs.hpp>
-#include <graphene/chain/son_sidechain_info.hpp>
+#include <graphene/chain/son_info.hpp>
 
 namespace graphene { namespace chain {
    using namespace graphene::db;
@@ -30,7 +30,7 @@ namespace graphene { namespace chain {
          sidechain_type sidechain = sidechain_type::unknown;
          object_id_type object_id;
          std::string transaction;
-         std::vector<son_sidechain_info> signers;
+         std::vector<son_info> signers;
          std::vector<std::pair<son_id_type, std::string>> signatures;
          std::string sidechain_transaction;
 

libraries/chain/include/graphene/chain/son_info.hpp

@@ -3,11 +3,12 @@
 #include <graphene/chain/sidechain_defs.hpp>
 
 namespace graphene { namespace chain {
+   using namespace graphene::db;
 
    /**
-          * @class son_info
+    * @class son_info
-          * @brief tracks information about a SON info required to re/create primary wallet
+    * @brief tracks information about a SON info required to re/create primary wallet
-          * @ingroup object
+    * @ingroup object
     */
    struct son_info {
       son_id_type son_id;
@@ -25,11 +26,11 @@ namespace graphene { namespace chain {
          if (son_sets_equal) {
             bool sidechain_public_keys_equal = true;
             for (size_t i = 0; i < sidechain_public_keys.size(); i++) {
-               const auto lhs_scpk = sidechain_public_keys.nth(i);
+                const auto lhs_scpk = sidechain_public_keys.nth(i);
-               const auto rhs_scpk = rhs.sidechain_public_keys.nth(i);
+                const auto rhs_scpk = rhs.sidechain_public_keys.nth(i);
-               sidechain_public_keys_equal = sidechain_public_keys_equal &&
+                sidechain_public_keys_equal = sidechain_public_keys_equal &&
-                                             (lhs_scpk->first == rhs_scpk->first) &&
+                        (lhs_scpk->first == rhs_scpk->first) &&
-                                             (lhs_scpk->second == rhs_scpk->second);
+                        (lhs_scpk->second == rhs_scpk->second);
             }
             son_sets_equal = son_sets_equal && sidechain_public_keys_equal;
          }
@@ -39,4 +40,8 @@ namespace graphene { namespace chain {
 
 } }
 
-FC_REFLECT( graphene::chain::son_info, (son_id) (weight) (signing_key) (sidechain_public_keys) )
+FC_REFLECT( graphene::chain::son_info,
+      (son_id)
+      (weight)
+      (signing_key)
+      (sidechain_public_keys) )

libraries/chain/include/graphene/chain/son_object.hpp

@@ -35,15 +35,15 @@ namespace graphene { namespace chain {
          // Transactions signed since the last son payouts
          flat_map<sidechain_type, uint64_t> txs_signed;
          // Total Voted Active time i.e. duration selected as part of voted active SONs
-         flat_map<sidechain_type, uint64_t> total_voted_time;
+         uint64_t total_voted_time = 0;
          // Total Downtime barring the current down time in seconds, used for stats to present to user
-         flat_map<sidechain_type, uint64_t> total_downtime;
+         uint64_t total_downtime = 0;
          // Current Interval Downtime since last maintenance
-         flat_map<sidechain_type, uint64_t> current_interval_downtime;
+         uint64_t current_interval_downtime = 0;
          // Down timestamp, if son status is in_maintenance use this
-         flat_map<sidechain_type, fc::time_point_sec> last_down_timestamp;
+         fc::time_point_sec last_down_timestamp;
          // Last Active heartbeat timestamp
-         flat_map<sidechain_type, fc::time_point_sec> last_active_timestamp;
+         fc::time_point_sec last_active_timestamp;
          // Deregistered Timestamp
          fc::time_point_sec deregistered_timestamp;
          // Total sidechain transactions reported by SON network while SON was active
@@ -64,48 +64,23 @@ namespace graphene { namespace chain {
          static const uint8_t type_id  = son_object_type;
 
          account_id_type son_account;
-         flat_map<sidechain_type, vote_id_type> sidechain_vote_ids;
+         vote_id_type vote_id;
-         flat_map<sidechain_type, uint64_t> total_votes = []()
+         uint64_t total_votes = 0;
-         {
-            flat_map<sidechain_type, uint64_t> total_votes;
-            for(const auto& active_sidechain_type : all_sidechain_types)
-            {
-               total_votes[active_sidechain_type] = 0;
-            }
-            return total_votes;
-         }();
          string url;
          vesting_balance_id_type deposit;
          public_key_type signing_key;
          vesting_balance_id_type pay_vb;
          son_statistics_id_type statistics;
-         flat_map<sidechain_type, son_status> statuses = []()
+         son_status status = son_status::inactive;
-         {
-            flat_map<sidechain_type, son_status> statuses;
-            for(const auto& active_sidechain_type : all_sidechain_types)
-            {
-               statuses[active_sidechain_type] = son_status::inactive;
-            }
-            return statuses;
-         }();
          flat_map<sidechain_type, string> sidechain_public_keys;
 
          void pay_son_fee(share_type pay, database& db);
-         bool has_valid_config(time_point_sec head_block_time, sidechain_type sidechain) const;
+         bool has_valid_config()const;
-
+         bool has_valid_config(time_point_sec head_block_time)const;
-         inline optional<vote_id_type> get_sidechain_vote_id(sidechain_type sidechain) const { return sidechain_vote_ids.contains(sidechain) ? sidechain_vote_ids.at(sidechain) : optional<vote_id_type>{}; }
-         inline optional<vote_id_type> get_bitcoin_vote_id() const { return get_sidechain_vote_id(sidechain_type::bitcoin); }
-         inline optional<vote_id_type> get_hive_vote_id() const { return get_sidechain_vote_id(sidechain_type::hive); }
-         inline optional<vote_id_type> get_ethereum_vote_id() const { return get_sidechain_vote_id(sidechain_type::ethereum); }
-
-      private:
-         bool has_valid_config(sidechain_type sidechain) const;
    };
 
    struct by_account;
-   struct by_vote_id_bitcoin;
+   struct by_vote_id;
-   struct by_vote_id_hive;
-   struct by_vote_id_ethereum;
    using son_multi_index_type = multi_index_container<
       son_object,
       indexed_by<
@@ -115,14 +90,8 @@ namespace graphene { namespace chain {
          ordered_unique< tag<by_account>,
             member<son_object, account_id_type, &son_object::son_account>
          >,
-         ordered_non_unique< tag<by_vote_id_bitcoin>,
+         ordered_unique< tag<by_vote_id>,
-            const_mem_fun<son_object, optional<vote_id_type>, &son_object::get_bitcoin_vote_id>
+            member<son_object, vote_id_type, &son_object::vote_id>
-         >,
-         ordered_non_unique< tag<by_vote_id_hive>,
-            const_mem_fun<son_object, optional<vote_id_type>, &son_object::get_hive_vote_id>
-         >,
-         ordered_non_unique< tag<by_vote_id_ethereum>,
-            const_mem_fun<son_object, optional<vote_id_type>, &son_object::get_ethereum_vote_id>
          >
       >
    >;
@@ -148,14 +117,14 @@ FC_REFLECT_ENUM(graphene::chain::son_status, (inactive)(active)(request_maintena
 
 FC_REFLECT_DERIVED( graphene::chain::son_object, (graphene::db::object),
                     (son_account)
-                    (sidechain_vote_ids)
+                    (vote_id)
                     (total_votes)
                     (url)
                     (deposit)
                     (signing_key)
                     (pay_vb)
                     (statistics)
-                    (statuses)
+                    (status)
                     (sidechain_public_keys)
                   )
 

libraries/chain/include/graphene/chain/son_sidechain_info.hpp

@@ -1,31 +0,0 @@
-#pragma once
-#include <graphene/chain/protocol/types.hpp>
-#include <graphene/chain/sidechain_defs.hpp>
-
-namespace graphene { namespace chain {
-
-   /**
-    * @class son_sidechain_info
-    * @brief tracks information about a SON info required to re/create primary wallet
-    * @ingroup object
-    */
-   struct son_sidechain_info {
-      son_id_type son_id;
-      weight_type weight = 0;
-      public_key_type signing_key;
-      string public_key;
-
-      bool operator==(const son_sidechain_info& rhs) const {
-         bool son_sets_equal =
-               (son_id == rhs.son_id) &&
-               (weight == rhs.weight) &&
-               (signing_key == rhs.signing_key) &&
-               (public_key == rhs.public_key);
-
-         return son_sets_equal;
-      }
-   };
-
-} }
-
-FC_REFLECT( graphene::chain::son_sidechain_info, (son_id) (weight) (signing_key) (public_key) )

libraries/chain/include/graphene/chain/son_wallet_object.hpp

@@ -1,6 +1,6 @@
 #pragma once
 #include <graphene/chain/protocol/types.hpp>
-#include <graphene/chain/son_sidechain_info.hpp>
+#include <graphene/chain/son_info.hpp>
 #include <graphene/chain/sidechain_defs.hpp>
 
 namespace graphene { namespace chain {
@@ -21,7 +21,7 @@ namespace graphene { namespace chain {
          time_point_sec expires;
 
          flat_map<sidechain_type, string> addresses;
-         flat_map<sidechain_type, vector<son_sidechain_info> > sons;
+         vector<son_info> sons;
    };
 
    struct by_valid_from;

libraries/chain/include/graphene/chain/voters_info.hpp

@@ -19,11 +19,11 @@ namespace graphene { namespace chain {
        * @ingroup object
     */
    struct voters_info {
-      optional<voters_info_object>                             voters_for_committee_member;
+      optional<voters_info_object>           voters_for_committee_member;
-      optional<voters_info_object>                             voters_for_witness;
+      optional<voters_info_object>           voters_for_witness;
-      optional<vector<voters_info_object> >                    voters_for_workers;
+      optional<vector<voters_info_object> >  voters_for_workers;
-      optional<vector<voters_info_object> >                    voters_against_workers;
+      optional<vector<voters_info_object> >  voters_against_workers;
-      optional<flat_map<sidechain_type, voters_info_object> >  voters_for_son;
+      optional<voters_info_object>           voters_for_son;
    };
 
 } } // graphene::chain
@@ -37,4 +37,4 @@ FC_REFLECT( graphene::chain::voters_info,
    (voters_for_witness)
    (voters_for_workers)
    (voters_against_workers)
-   (voters_for_son))
+   (voters_for_son) )

libraries/chain/include/graphene/chain/votes_info.hpp

@@ -19,11 +19,11 @@ namespace graphene { namespace chain {
        * @ingroup object
     */
    struct votes_info {
-      optional< vector< votes_info_object > >                              votes_for_committee_members;
+      optional< vector< votes_info_object > > votes_for_committee_members;
-      optional< vector< votes_info_object > >                              votes_for_witnesses;
+      optional< vector< votes_info_object > > votes_for_witnesses;
-      optional< vector< votes_info_object > >                              votes_for_workers;
+      optional< vector< votes_info_object > > votes_for_workers;
-      optional< vector< votes_info_object > >                              votes_against_workers;
+      optional< vector< votes_info_object > > votes_against_workers;
-      optional< flat_map<sidechain_type, vector< votes_info_object > > >   votes_for_sons;
+      optional< vector< votes_info_object > > votes_for_sons;
    };
 
 } } // graphene::chain
@@ -37,4 +37,4 @@ FC_REFLECT( graphene::chain::votes_info,
    (votes_for_witnesses)
    (votes_for_workers)
    (votes_against_workers)
-   (votes_for_sons))
+   (votes_for_sons) )

libraries/chain/include/graphene/chain/witness_schedule_object.hpp

@@ -96,7 +96,7 @@ class son_schedule_object : public graphene::db::abstract_object<son_schedule_ob
       static const uint8_t space_id = implementation_ids;
       static const uint8_t type_id = impl_son_schedule_object_type;
 
-      vector<son_id_type > current_shuffled_sons;
+      vector< son_id_type > current_shuffled_sons;
 
       son_scheduler scheduler;
       uint32_t last_scheduling_block;

libraries/chain/include/graphene/chain/witness_scheduler.hpp

@@ -162,12 +162,8 @@ class generic_witness_scheduler
          _schedule.pop_front();
 
          auto it = _lame_duck.find( result );
-         if( it != _lame_duck.end() ) {
+         if( it != _lame_duck.end() )
-            set< WitnessID > removal_set;
+            _lame_duck.erase( it );
-            removal_set.insert(*it);
-            remove_all( removal_set );
-            _lame_duck.erase(it);
-         }
          if( debug ) check_invariant();
          return result;
       }
@@ -393,7 +389,7 @@ class generic_witness_scheduler
       // scheduled
       std::deque < WitnessID > _schedule;
 
-      // in _schedule, but must be removed
+      // in _schedule, but not to be replaced
       set< WitnessID > _lame_duck;
 };
 

libraries/chain/nft_lottery_evaluator.cpp

@@ -30,7 +30,7 @@ namespace graphene
 
                 auto lottery_options = lottery_md_obj.lottery_data->lottery_options;
                 FC_ASSERT(lottery_options.ticket_price.asset_id == op.amount.asset_id);
-                FC_ASSERT(op.tickets_to_buy * lottery_options.ticket_price.amount.value == op.amount.amount.value);
+                FC_ASSERT((double)op.amount.amount.value / lottery_options.ticket_price.amount.value == (double)op.tickets_to_buy);
                 return void_result();
             }
             FC_CAPTURE_AND_RETHROW((op))
@@ -142,4 +142,4 @@ namespace graphene
             FC_CAPTURE_AND_RETHROW((op))
         }
     } // namespace chain
-} // namespace graphene
+} // namespace graphene

libraries/chain/protocol/account.cpp

@@ -174,37 +174,22 @@ void account_options::validate() const
 {
    auto needed_witnesses = num_witness;
    auto needed_committee = num_committee;
+   auto needed_sons = num_son();
 
    for( vote_id_type id : votes )
       if( id.type() == vote_id_type::witness && needed_witnesses )
          --needed_witnesses;
       else if ( id.type() == vote_id_type::committee && needed_committee )
          --needed_committee;
+      else if ( id.type() == vote_id_type::son && needed_sons )
+         --needed_sons;
 
    FC_ASSERT( needed_witnesses == 0,
               "May not specify fewer witnesses than the number voted for.");
    FC_ASSERT( needed_committee == 0,
               "May not specify fewer committee members than the number voted for.");
-
+   FC_ASSERT( needed_sons == 0,
-   if ( extensions.value.num_son.valid() )
+              "May not specify fewer SONs than the number voted for.");
-   {
-      flat_map<sidechain_type, uint16_t> needed_sons = *extensions.value.num_son;
-
-      for( vote_id_type id : votes )
-         if ( id.type() == vote_id_type::son_bitcoin && needed_sons[sidechain_type::bitcoin] )
-               --needed_sons[sidechain_type::bitcoin];
-         else if ( id.type() == vote_id_type::son_hive && needed_sons[sidechain_type::hive] )
-               --needed_sons[sidechain_type::hive];
-         else if ( id.type() == vote_id_type::son_ethereum && needed_sons[sidechain_type::ethereum] )
-               --needed_sons[sidechain_type::ethereum];
-
-      FC_ASSERT( needed_sons[sidechain_type::bitcoin] == 0,
-                "May not specify fewer Bitcoin SONs than the number voted for.");
-      FC_ASSERT( needed_sons[sidechain_type::hive] == 0,
-                "May not specify fewer Hive SONs than the number voted for.");
-      FC_ASSERT( needed_sons[sidechain_type::ethereum] == 0,
-                "May not specify fewer Ethereum SONs than the number voted for.");
-   }
 }
 
 void affiliate_reward_distribution::validate() const

libraries/chain/sidechain_address_evaluator.cpp

@@ -22,14 +22,11 @@ object_id_type add_sidechain_address_evaluator::do_apply(const sidechain_address
     const auto &sidechain_addresses_idx = db().get_index_type<sidechain_address_index>().indices().get<by_account_and_sidechain_and_expires>();
     const auto &addr_itr = sidechain_addresses_idx.find(std::make_tuple(op.sidechain_address_account, op.sidechain, time_point_sec::maximum()));
 
-    if (addr_itr != sidechain_addresses_idx.end()) {
+    if (addr_itr != sidechain_addresses_idx.end())
-       if (db().head_block_time() >= HARDFORK_SIDECHAIN_DELETE_TIME) {
+    {
-          db().remove(*addr_itr);
+        db().modify(*addr_itr, [&](sidechain_address_object &sao) {
-       } else {
+            sao.expires = db().head_block_time();
-          db().modify(*addr_itr, [&](sidechain_address_object &sao) {
+        });
-             sao.expires = db().head_block_time();
-          });
-       }
     }
 
     const auto& new_sidechain_address_object = db().create<sidechain_address_object>( [&]( sidechain_address_object& obj ){
@@ -50,7 +47,7 @@ void_result update_sidechain_address_evaluator::do_evaluate(const sidechain_addr
 { try {
     const auto& sidx = db().get_index_type<son_index>().indices().get<by_account>();
     const auto& son_obj = sidx.find(op.payer);
-    FC_ASSERT( son_obj != sidx.end() && db().is_son_active(op.sidechain, son_obj->id), "Non active SON trying to update deposit address object" );
+    FC_ASSERT( son_obj != sidx.end() && db().is_son_active(son_obj->id), "Non active SON trying to update deposit address object" );
     const auto& sdpke_idx = db().get_index_type<sidechain_address_index>().indices().get<by_sidechain_and_deposit_public_key_and_expires>();
     FC_ASSERT( op.deposit_address.valid() && op.deposit_public_key.valid() && op.deposit_address_data.valid(), "Update operation by SON is not valid");
     FC_ASSERT( (*op.deposit_address).length() > 0 && (*op.deposit_public_key).length() > 0 && (*op.deposit_address_data).length() > 0, "SON should create a valid deposit address with valid deposit public key");
@@ -108,14 +105,10 @@ void_result delete_sidechain_address_evaluator::do_apply(const sidechain_address
 { try {
     const auto& idx = db().get_index_type<sidechain_address_index>().indices().get<by_id>();
     auto sidechain_address = idx.find(op.sidechain_address_id);
-    if (sidechain_address != idx.end()) {
+    if(sidechain_address != idx.end()) {
-       if (db().head_block_time() >= HARDFORK_SIDECHAIN_DELETE_TIME) {
+        db().modify(*sidechain_address, [&](sidechain_address_object &sao) {
-          db().remove(*sidechain_address);
+            sao.expires = db().head_block_time();
-       } else {
+        });
-          db().modify(*sidechain_address, [&](sidechain_address_object &sao) {
-             sao.expires = db().head_block_time();
-          });
-       }
     }
     return void_result();
 } FC_CAPTURE_AND_RETHROW( (op) ) }

libraries/chain/sidechain_transaction_evaluator.cpp

@@ -11,7 +11,7 @@ namespace graphene { namespace chain {
 void_result sidechain_transaction_create_evaluator::do_evaluate(const sidechain_transaction_create_operation &op)
 { try {
    FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
-   FC_ASSERT(op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer.");
+   FC_ASSERT( op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer." );
 
    FC_ASSERT((op.object_id.is<son_wallet_id_type>() || op.object_id.is<son_wallet_deposit_id_type>() || op.object_id.is<son_wallet_withdraw_id_type>()), "Invalid object id");
 
@@ -28,26 +28,15 @@ void_result sidechain_transaction_create_evaluator::do_evaluate(const sidechain_
 object_id_type sidechain_transaction_create_evaluator::do_apply(const sidechain_transaction_create_operation &op)
 { try {
    const auto &new_sidechain_transaction_object = db().create<sidechain_transaction_object>([&](sidechain_transaction_object &sto) {
-
       sto.timestamp = db().head_block_time();
       sto.sidechain = op.sidechain;
       sto.object_id = op.object_id;
       sto.transaction = op.transaction;
-      std::vector<son_sidechain_info> signers;
+      sto.signers = op.signers;
-      for(const auto& signer : op.signers){
+      std::transform(op.signers.begin(), op.signers.end(), std::inserter(sto.signatures, sto.signatures.end()), [](const son_info &si) {
-         son_sidechain_info ssi;
-         ssi.son_id = signer.son_id;
-         ssi.weight = signer.weight;
-         ssi.signing_key = signer.signing_key;
-         ssi.public_key = signer.sidechain_public_keys.at(op.sidechain);
-         signers.emplace_back(std::move(ssi));
-      }
-      sto.signers = std::move(signers);
-
-      std::transform(sto.signers.begin(), sto.signers.end(), std::inserter(sto.signatures, sto.signatures.end()), [](const son_sidechain_info &si) {
          return std::make_pair(si.son_id, std::string());
       });
-      for (const auto &si : sto.signers) {
+      for (const auto &si : op.signers) {
          sto.total_weight = sto.total_weight + si.weight;
       }
       sto.sidechain_transaction = "";

libraries/chain/son_evaluator.cpp

@@ -39,28 +39,13 @@ void_result create_son_evaluator::do_evaluate(const son_create_operation& op)
 object_id_type create_son_evaluator::do_apply(const son_create_operation& op)
 { try {
     vote_id_type vote_id;
-    flat_map<sidechain_type, vote_id_type> vote_ids;
+    db().modify(db().get_global_properties(), [&vote_id](global_property_object& p) {
+        vote_id = get_next_vote_id(p, vote_id_type::son);
+    });
 
-    const auto now = db().head_block_time();
+    const auto& new_son_object = db().create<son_object>( [&]( son_object& obj ){
-    if( now < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-      db().modify(db().get_global_properties(), [&vote_id](global_property_object &p) {
-         vote_id = get_next_vote_id(p, vote_id_type::son_bitcoin);
-      });
-    }
-    else {
-      db().modify(db().get_global_properties(), [&vote_ids](global_property_object &p) {
-         vote_ids[sidechain_type::bitcoin] = get_next_vote_id(p, vote_id_type::son_bitcoin);
-         vote_ids[sidechain_type::hive] = get_next_vote_id(p, vote_id_type::son_hive);
-         vote_ids[sidechain_type::ethereum] = get_next_vote_id(p, vote_id_type::son_ethereum);
-      });
-    }
-
-    const auto& new_son_object = db().create<son_object>( [&]( son_object& obj ) {
         obj.son_account = op.owner_account;
-        if( now < HARDFORK_SON_FOR_ETHEREUM_TIME )
+        obj.vote_id = vote_id;
-           obj.sidechain_vote_ids[sidechain_type::bitcoin] = vote_id;
-        else
-           obj.sidechain_vote_ids = vote_ids;
         obj.url = op.url;
         obj.deposit = op.deposit;
         obj.signing_key = op.signing_key;
@@ -109,8 +94,7 @@ object_id_type update_son_evaluator::do_apply(const son_update_operation& op)
            if(op.new_signing_key.valid()) so.signing_key = *op.new_signing_key;
            if(op.new_sidechain_public_keys.valid()) so.sidechain_public_keys = *op.new_sidechain_public_keys;
            if(op.new_pay_vb.valid()) so.pay_vb = *op.new_pay_vb;
-           for(auto& status : so.statuses)
+           if(so.status == son_status::deregistered) so.status = son_status::inactive;
-            if(status.second == son_status::deregistered) status.second = son_status::inactive;
        });
    }
    return op.son_id;
@@ -143,8 +127,7 @@ void_result deregister_son_evaluator::do_apply(const son_deregister_operation& o
        });
 
        db().modify(*son, [&op](son_object &so) {
-          for(auto& status : so.statuses)
+          so.status = son_status::deregistered;
-            status.second = son_status::deregistered;
        });
 
        auto stats_obj = ss_idx.find(son->statistics);
@@ -161,28 +144,18 @@ void_result son_heartbeat_evaluator::do_evaluate(const son_heartbeat_operation&
 { try {
     FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK"); // can be removed after HF date pass
     const auto& idx = db().get_index_type<son_index>().indices().get<by_id>();
-    const auto itr = idx.find(op.son_id);
+    auto itr = idx.find(op.son_id);
     FC_ASSERT( itr != idx.end() );
     FC_ASSERT(itr->son_account == op.owner_account);
     auto stats = itr->statistics( db() );
     // Inactive SONs need not send heartbeats
-    bool status_need_to_send_heartbeats = false;
+    FC_ASSERT((itr->status == son_status::active) || (itr->status == son_status::in_maintenance) || (itr->status == son_status::request_maintenance), "Inactive SONs need not send heartbeats");
-    for(const auto& status : itr->statuses)
-    {
-       if( (status.second == son_status::active) || (status.second == son_status::in_maintenance) || (status.second == son_status::request_maintenance) )
-          status_need_to_send_heartbeats = true;
-    }
-    FC_ASSERT(status_need_to_send_heartbeats, "Inactive SONs need not send heartbeats");
     // Account for network delays
     fc::time_point_sec min_ts = db().head_block_time() - fc::seconds(5 * db().block_interval());
     // Account for server ntp sync difference
     fc::time_point_sec max_ts = db().head_block_time() + fc::seconds(5 * db().block_interval());
-    for(const auto& active_sidechain_type : active_sidechain_types(db().head_block_time())) {
+    FC_ASSERT(op.ts > stats.last_active_timestamp, "Heartbeat sent without waiting minimum time");
-      if(stats.last_active_timestamp.contains(active_sidechain_type))
+    FC_ASSERT(op.ts > stats.last_down_timestamp, "Heartbeat sent is invalid can't be <= last down timestamp");
-         FC_ASSERT(op.ts > stats.last_active_timestamp.at(active_sidechain_type), "Heartbeat sent for sidechain = ${sidechain} without waiting minimum time", ("sidechain", active_sidechain_type));
-      if(stats.last_down_timestamp.contains(active_sidechain_type))
-         FC_ASSERT(op.ts > stats.last_down_timestamp.at(active_sidechain_type), "Heartbeat sent for sidechain = ${sidechain} is invalid can't be <= last down timestamp", ("sidechain", active_sidechain_type));
-    }
     FC_ASSERT(op.ts >= min_ts, "Heartbeat ts is behind the min threshold");
     FC_ASSERT(op.ts <= max_ts, "Heartbeat ts is above the max threshold");
     return void_result();
@@ -191,48 +164,44 @@ void_result son_heartbeat_evaluator::do_evaluate(const son_heartbeat_operation&
 object_id_type son_heartbeat_evaluator::do_apply(const son_heartbeat_operation& op)
 { try {
     const auto& idx = db().get_index_type<son_index>().indices().get<by_id>();
-    const auto itr = idx.find(op.son_id);
+    auto itr = idx.find(op.son_id);
     if(itr != idx.end())
     {
         const global_property_object& gpo = db().get_global_properties();
+        vector<son_id_type> active_son_ids;
+        active_son_ids.reserve(gpo.active_sons.size());
+        std::transform(gpo.active_sons.begin(), gpo.active_sons.end(),
+                        std::inserter(active_son_ids, active_son_ids.end()),
+                        [](const son_info& swi) {
+            return swi.son_id;
+        });
 
-        for(const auto& active_sidechain_sons : gpo.active_sons) {
+        auto it_son = std::find(active_son_ids.begin(), active_son_ids.end(), op.son_id);
-           const auto& sidechain = active_sidechain_sons.first;
+        bool is_son_active = true;
-           const auto& active_sons = active_sidechain_sons.second;
 
-           vector<son_id_type> active_son_ids;
+        if(it_son == active_son_ids.end()) {
-           active_son_ids.reserve(active_sons.size());
+            is_son_active = false;
-           std::transform(active_sons.cbegin(), active_sons.cend(),
+        }
-                          std::inserter(active_son_ids, active_son_ids.end()),
-                          [](const son_sidechain_info &swi) {
-                             return swi.son_id;
-                          });
 
-           const auto it_son = std::find(active_son_ids.begin(), active_son_ids.end(), op.son_id);
+        if(itr->status == son_status::in_maintenance) {
-           bool is_son_active = true;
+            db().modify( itr->statistics( db() ), [&]( son_statistics_object& sso )
+            {
+                sso.current_interval_downtime += op.ts.sec_since_epoch() - sso.last_down_timestamp.sec_since_epoch();
+                sso.last_active_timestamp = op.ts;
+            } );
 
-           if (it_son == active_son_ids.end()) {
+            db().modify(*itr, [&is_son_active](son_object &so) {
-              is_son_active = false;
+                if(is_son_active) {
-           }
+                    so.status = son_status::active;
-
+                } else {
-           if (itr->statuses.at(sidechain) == son_status::in_maintenance) {
+                    so.status = son_status::inactive;
-              db().modify(itr->statistics(db()), [&](son_statistics_object &sso) {
+                }
-                 sso.current_interval_downtime[sidechain] += op.ts.sec_since_epoch() - (sso.last_down_timestamp.contains(sidechain) ? sso.last_down_timestamp.at(sidechain).sec_since_epoch() : op.ts.sec_since_epoch());
+            });
-                 sso.last_active_timestamp[sidechain] = op.ts;
+        } else if ((itr->status == son_status::active) || (itr->status == son_status::request_maintenance)) {
-              });
+            db().modify( itr->statistics( db() ), [&]( son_statistics_object& sso )
-
+            {
-              db().modify(*itr, [&is_son_active, &sidechain](son_object &so) {
+                sso.last_active_timestamp = op.ts;
-                 if (is_son_active) {
+            } );
-                    so.statuses[sidechain] = son_status::active;
-                 } else {
-                    so.statuses[sidechain] = son_status::inactive;
-                 }
-              });
-           } else if ((itr->statuses.at(sidechain) == son_status::active) || (itr->statuses.at(sidechain) == son_status::request_maintenance)) {
-              db().modify(itr->statistics(db()), [&](son_statistics_object &sso) {
-                 sso.last_active_timestamp[sidechain] = op.ts;
-              });
-           }
         }
     }
     return op.son_id;
@@ -244,41 +213,29 @@ void_result son_report_down_evaluator::do_evaluate(const son_report_down_operati
     FC_ASSERT(op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer.");
     const auto& idx = db().get_index_type<son_index>().indices().get<by_id>();
     FC_ASSERT( idx.find(op.son_id) != idx.end() );
-    const auto itr = idx.find(op.son_id);
+    auto itr = idx.find(op.son_id);
-    const auto stats = itr->statistics( db() );
+    auto stats = itr->statistics( db() );
-    bool status_need_to_report_down = false;
+    FC_ASSERT(itr->status == son_status::active || itr->status == son_status::request_maintenance, "Inactive/Deregistered/in_maintenance SONs cannot be reported on as down");
-    for(const auto& status : itr->statuses)
+    FC_ASSERT(op.down_ts >= stats.last_active_timestamp, "down_ts should be greater than last_active_timestamp");
-    {
-       if( (status.second == son_status::active) || (status.second == son_status::request_maintenance) )
-          status_need_to_report_down = true;
-    }
-    FC_ASSERT(status_need_to_report_down, "Inactive/Deregistered/in_maintenance SONs cannot be reported on as down");
-    for(const auto& active_sidechain_type : active_sidechain_types(db().head_block_time())) {
-      if(stats.last_active_timestamp.contains(active_sidechain_type))
-         FC_ASSERT(op.down_ts >= stats.last_active_timestamp.at(active_sidechain_type), "sidechain = ${sidechain} down_ts should be greater than last_active_timestamp", ("sidechain", active_sidechain_type));
-    }
     return void_result();
 } FC_CAPTURE_AND_RETHROW( (op) ) }
 
 object_id_type son_report_down_evaluator::do_apply(const son_report_down_operation& op)
 { try {
     const auto& idx = db().get_index_type<son_index>().indices().get<by_id>();
-    const auto itr = idx.find(op.son_id);
+    auto itr = idx.find(op.son_id);
     if(itr != idx.end())
     {
-       for( const auto& status : itr->statuses ) {
+        if ((itr->status == son_status::active) || (itr->status == son_status::request_maintenance)) {
-          const auto& sidechain = status.first;
+            db().modify( itr->statistics( db() ), [&]( son_statistics_object& sso )
+            {
+                sso.last_down_timestamp = op.down_ts;
+            });
 
-          if ((status.second == son_status::active) || (status.second == son_status::request_maintenance)) {
+            db().modify(*itr, [&op](son_object &so) {
-             db().modify(*itr, [&sidechain](son_object &so) {
+                so.status = son_status::in_maintenance;
-                so.statuses[sidechain] = son_status::in_maintenance;
+            });
-             });
+        }
-
-             db().modify(itr->statistics(db()), [&](son_statistics_object &sso) {
-                sso.last_down_timestamp[sidechain] = op.down_ts;
-             });
-          }
-       }
     }
     return op.son_id;
 } FC_CAPTURE_AND_RETHROW( (op) ) }
@@ -292,19 +249,9 @@ void_result son_maintenance_evaluator::do_evaluate(const son_maintenance_operati
     FC_ASSERT( itr != idx.end() );
     // Inactive SONs can't go to maintenance, toggle between active and request_maintenance states
     if(op.request_type == son_maintenance_request_type::request_maintenance) {
-       bool status_active = false;
+        FC_ASSERT(itr->status == son_status::active, "Inactive SONs can't request for maintenance");
-       for(const auto& status : itr->statuses) {
+    } else if(op.request_type == son_maintenance_request_type::cancel_request_maintenance) {
-          if( (status.second == son_status::active) )
+        FC_ASSERT(itr->status == son_status::request_maintenance, "Only maintenance requested SONs can cancel the request");
-             status_active = true;
-       }
-       FC_ASSERT(status_active, "Inactive SONs can't request for maintenance");
-    } else if(op.request_type == son_maintenance_request_type::cancel_request_maintenance) { 
-          bool status_request_maintenance = false;
-          for(const auto& status : itr->statuses) {
-             if( (status.second == son_status::request_maintenance) )
-                status_request_maintenance = true;
-          }
-          FC_ASSERT(status_request_maintenance, "Only maintenance requested SONs can cancel the request");
     } else {
         FC_ASSERT(false, "Invalid maintenance operation");
     }
@@ -317,33 +264,15 @@ object_id_type son_maintenance_evaluator::do_apply(const son_maintenance_operati
     auto itr = idx.find(op.son_id);
     if(itr != idx.end())
     {
-       bool status_active = false;
+        if(itr->status == son_status::active && op.request_type == son_maintenance_request_type::request_maintenance) {
-       for(const auto& status : itr->statuses) {
+            db().modify(*itr, [](son_object &so) {
-          if( (status.second == son_status::active) )
+                so.status = son_status::request_maintenance;
-             status_active = true;
+            });
-       }
+        } else if(itr->status == son_status::request_maintenance && op.request_type == son_maintenance_request_type::cancel_request_maintenance) {
-       if(status_active && op.request_type == son_maintenance_request_type::request_maintenance) {
+            db().modify(*itr, [](son_object &so) {
-          db().modify(*itr, [](son_object &so) {
+                so.status = son_status::active;
-             for(auto& status : so.statuses) {
+            });
-                status.second = son_status::request_maintenance;
+        }
-             }
-          });
-       }
-       else
-       {
-          bool status_request_maintenance = false;
-          for(const auto& status : itr->statuses) {
-             if( (status.second == son_status::request_maintenance) )
-                status_request_maintenance = true;
-          }
-          if(status_request_maintenance && op.request_type == son_maintenance_request_type::cancel_request_maintenance) {
-             db().modify(*itr, [](son_object &so) {
-               for(auto& status : so.statuses) {
-                  status.second = son_status::active;
-               }
-             });
-          }
-       }
     }
     return op.son_id;
 } FC_CAPTURE_AND_RETHROW( (op) ) }

libraries/chain/son_object.cpp

@@ -6,22 +6,20 @@ namespace graphene { namespace chain {
       db.adjust_balance(son_account, pay);
    }
 
-   bool son_object::has_valid_config(sidechain_type sidechain) const {
+   bool son_object::has_valid_config()const {
-      return (sidechain_public_keys.find( sidechain ) != sidechain_public_keys.end()) &&
+      return ((std::string(signing_key).length() > 0) &&
-         (sidechain_public_keys.at(sidechain).length() > 0);
+             (sidechain_public_keys.size() > 0) &&
+             (sidechain_public_keys.find( sidechain_type::bitcoin ) != sidechain_public_keys.end()) &&
+             (sidechain_public_keys.at(sidechain_type::bitcoin).length() > 0));
    }
 
-   bool son_object::has_valid_config(time_point_sec head_block_time, sidechain_type sidechain) const {
+   bool son_object::has_valid_config(time_point_sec head_block_time)const {
-      bool retval = (std::string(signing_key).length() > 0) && (sidechain_public_keys.size() > 0);
+      bool retval = has_valid_config();
 
-      if (head_block_time < HARDFORK_SON_FOR_HIVE_TIME) {
+      if (head_block_time >= HARDFORK_SON_FOR_HIVE_TIME) {
-         retval = retval && has_valid_config(sidechain_type::bitcoin);
+          retval = retval &&
-      }
+                   (sidechain_public_keys.find( sidechain_type::hive ) != sidechain_public_keys.end()) &&
-      if (head_block_time >= HARDFORK_SON_FOR_HIVE_TIME && head_block_time < HARDFORK_SON_FOR_ETHEREUM_TIME) {
+                   (sidechain_public_keys.at(sidechain_type::hive).length() > 0);
-         retval = retval && has_valid_config(sidechain_type::bitcoin) && has_valid_config(sidechain_type::hive);
-      }
-      else if (head_block_time >= HARDFORK_SON_FOR_ETHEREUM_TIME) {
-         retval = retval && has_valid_config(sidechain);
       }
 
       return retval;

libraries/chain/son_wallet_deposit_evaluator.cpp

@@ -23,9 +23,9 @@ void_result create_son_wallet_deposit_evaluator::do_evaluate(const son_wallet_de
    const auto &swdo_idx = db().get_index_type<son_wallet_deposit_index>().indices().get<by_sidechain_uid>();
    const auto swdo = swdo_idx.find(op.sidechain_uid);
    if (swdo == swdo_idx.end()) {
-      const auto &gpo = db().get_global_properties();
+      auto &gpo = db().get_global_properties();
       bool expected = false;
-      for (auto &si : gpo.active_sons.at(op.sidechain)) {
+      for (auto &si : gpo.active_sons) {
          if (op.son_id == si.son_id) {
             expected = true;
             break;
@@ -78,8 +78,8 @@ object_id_type create_son_wallet_deposit_evaluator::do_apply(const son_wallet_de
          swdo.peerplays_to = op.peerplays_to;
          swdo.peerplays_asset = op.peerplays_asset;
 
-         const auto &gpo = db().get_global_properties();
+         auto &gpo = db().get_global_properties();
-         for (auto &si : gpo.active_sons.at(op.sidechain)) {
+         for (auto &si : gpo.active_sons) {
             swdo.expected_reports.insert(std::make_pair(si.son_id, si.weight));
 
             auto stats_itr = db().get_index_type<son_stats_index>().indices().get<by_owner>().find(si.son_id);
@@ -142,11 +142,11 @@ void_result process_son_wallet_deposit_evaluator::do_evaluate(const son_wallet_d
 { try{
    FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
    FC_ASSERT( op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer." );
+   FC_ASSERT(db().get_global_properties().active_sons.size() >= db().get_chain_properties().immutable_parameters.min_son_count, "Min required voted SONs not present");
 
    const auto& idx = db().get_index_type<son_wallet_deposit_index>().indices().get<by_id>();
    const auto& itr = idx.find(op.son_wallet_deposit_id);
    FC_ASSERT(itr != idx.end(), "Son wallet deposit not found");
-   FC_ASSERT(db().get_global_properties().active_sons.at(itr->sidechain).size() >= db().get_chain_properties().immutable_parameters.min_son_count, "Min required voted SONs not present");
    FC_ASSERT(!itr->processed, "Son wallet deposit is already processed");
    return void_result();
 } FC_CAPTURE_AND_RETHROW( (op) ) }

libraries/chain/son_wallet_evaluator.cpp

@@ -7,9 +7,8 @@ namespace graphene { namespace chain {
 
 void_result recreate_son_wallet_evaluator::do_evaluate(const son_wallet_recreate_operation& op)
 { try{
-   const auto now = db().head_block_time();
+   FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
-   FC_ASSERT(now >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
+   FC_ASSERT( op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer." );
-   FC_ASSERT(op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer.");
 
    const auto& idx = db().get_index_type<son_wallet_index>().indices().get<by_id>();
    auto itr = idx.rbegin();
@@ -17,36 +16,12 @@ void_result recreate_son_wallet_evaluator::do_evaluate(const son_wallet_recreate
    {
       // Compare current wallet SONs and to-be lists of active sons
       auto cur_wallet_sons = (*itr).sons;
-      flat_map<sidechain_type, vector<son_sidechain_info> > new_wallet_sons;
+      auto new_wallet_sons = op.sons;
-      if( now < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
-         for(const auto& son : op.sons){
-            for(const auto& active_sidechain_type : active_sidechain_types(db().head_block_time())){
-               son_sidechain_info ssi;
-               ssi.son_id = son.son_id;
-               ssi.weight = son.weight;
-               ssi.signing_key = son.signing_key;
-               ssi.public_key = son.sidechain_public_keys.at(active_sidechain_type);
-               new_wallet_sons[active_sidechain_type].emplace_back(std::move(ssi));
-            }
-         }
-      }
-      else{
-         FC_ASSERT(op.extensions.value.sidechain_sons.valid(), "Sons is not valid");
-         new_wallet_sons = *op.extensions.value.sidechain_sons;
-      }
 
       bool son_sets_equal = (cur_wallet_sons.size() == new_wallet_sons.size());
       if (son_sets_equal) {
-         for( const auto& cur_wallet_sidechain_sons : cur_wallet_sons ) {
+         for( size_t i = 0; i < cur_wallet_sons.size(); i++ ) {
-            const auto& sidechain = cur_wallet_sidechain_sons.first;
+            son_sets_equal = son_sets_equal && cur_wallet_sons.at(i) == new_wallet_sons.at(i);
-            const auto& _cur_wallet_sidechain_sons = cur_wallet_sidechain_sons.second;
-
-            son_sets_equal = son_sets_equal && (_cur_wallet_sidechain_sons.size() == new_wallet_sons.at(sidechain).size());
-            if (son_sets_equal) {
-               for (size_t i = 0; i < cur_wallet_sons.size(); i++) {
-                  son_sets_equal = son_sets_equal && _cur_wallet_sidechain_sons.at(i) == new_wallet_sons.at(sidechain).at(i);
-               }
-            }
          }
       }
 
@@ -68,26 +43,9 @@ object_id_type recreate_son_wallet_evaluator::do_apply(const son_wallet_recreate
    }
 
    const auto& new_son_wallet_object = db().create<son_wallet_object>( [&]( son_wallet_object& obj ){
-      const auto now = db().head_block_time();
+      obj.valid_from = db().head_block_time();
-      obj.valid_from = now;
       obj.expires = time_point_sec::maximum();
-      if( now < HARDFORK_SON_FOR_ETHEREUM_TIME ) {
+      obj.sons = op.sons;
-         flat_map<sidechain_type, vector<son_sidechain_info> > sons;
-         for(const auto& son : op.sons){
-            for(const auto& active_sidechain_type : active_sidechain_types(db().head_block_time())){
-               son_sidechain_info ssi;
-               ssi.son_id = son.son_id;
-               ssi.weight = son.weight;
-               ssi.signing_key = son.signing_key;
-               ssi.public_key = son.sidechain_public_keys.at(active_sidechain_type);
-               sons[active_sidechain_type].emplace_back(std::move(ssi));
-            }
-         }
-         obj.sons = std::move(sons);
-      }
-      else{
-         obj.sons = *op.extensions.value.sidechain_sons;
-      }
    });
    return new_son_wallet_object.id;
 } FC_CAPTURE_AND_RETHROW( (op) ) }
@@ -97,19 +55,8 @@ void_result update_son_wallet_evaluator::do_evaluate(const son_wallet_update_ope
    FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
    FC_ASSERT( op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer." );
 
-   const son_wallet_id_type son_wallet_id = [&]{
-      if(db().head_block_time() >= HARDFORK_SON_FOR_ETHEREUM_TIME)
-      {
-         const auto ast = active_sidechain_types(db().head_block_time());
-         const auto id = (op.son_wallet_id.instance.value - std::distance(ast.begin(), ast.find(op.sidechain))) / ast.size();
-         return son_wallet_id_type{ id };
-      }
-
-      return op.son_wallet_id;
-   }();
-
    const auto& idx = db().get_index_type<son_wallet_index>().indices().get<by_id>();
-   FC_ASSERT( idx.find(son_wallet_id) != idx.end() );
+   FC_ASSERT( idx.find(op.son_wallet_id) != idx.end() );
    //auto itr = idx.find(op.son_wallet_id);
    //FC_ASSERT( itr->addresses.find(op.sidechain) == itr->addresses.end() ||
    //        itr->addresses.at(op.sidechain).empty(), "Sidechain wallet address already set");
@@ -118,19 +65,8 @@ void_result update_son_wallet_evaluator::do_evaluate(const son_wallet_update_ope
 
 object_id_type update_son_wallet_evaluator::do_apply(const son_wallet_update_operation& op)
 { try {
-   const son_wallet_id_type son_wallet_id = [&]{
-      if(db().head_block_time() >= HARDFORK_SON_FOR_ETHEREUM_TIME)
-      {
-         const auto ast = active_sidechain_types(db().head_block_time());
-         const auto id = (op.son_wallet_id.instance.value - std::distance(ast.begin(), ast.find(op.sidechain))) / ast.size();
-         return son_wallet_id_type{ id };
-      }
-
-      return op.son_wallet_id;
-   }();
-
    const auto& idx = db().get_index_type<son_wallet_index>().indices().get<by_id>();
-   auto itr = idx.find(son_wallet_id);
+   auto itr = idx.find(op.son_wallet_id);
    if (itr != idx.end())
    {
       if (itr->addresses.find(op.sidechain) == itr->addresses.end()) {

libraries/chain/son_wallet_withdraw_evaluator.cpp

@@ -10,13 +10,12 @@ namespace graphene { namespace chain {
 
 void_result create_son_wallet_withdraw_evaluator::do_evaluate(const son_wallet_withdraw_create_operation& op)
 { try {
-   const auto now = db().head_block_time();
+   FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
-   FC_ASSERT(now >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
+
    const auto &son_idx = db().get_index_type<son_index>().indices().get<by_id>();
    const auto so = son_idx.find(op.son_id);
    FC_ASSERT(so != son_idx.end(), "SON not found");
    FC_ASSERT(so->son_account == op.payer, "Payer is not SON account owner");
-   FC_ASSERT(!(op.sidechain == sidechain_type::peerplays && now >= HARDFORK_SON_FOR_ETHEREUM_TIME), "Peerplays sidechain type is not allowed");
 
    const auto &ss_idx = db().get_index_type<son_stats_index>().indices().get<by_owner>();
    FC_ASSERT(ss_idx.find(op.son_id) != ss_idx.end(), "Statistic object for a given SON ID does not exists");
@@ -24,23 +23,15 @@ void_result create_son_wallet_withdraw_evaluator::do_evaluate(const son_wallet_w
    const auto &swwo_idx = db().get_index_type<son_wallet_withdraw_index>().indices().get<by_peerplays_uid>();
    const auto swwo = swwo_idx.find(op.peerplays_uid);
    if (swwo == swwo_idx.end()) {
-      const sidechain_type sidechain = [&op]{
+      auto &gpo = db().get_global_properties();
-         if(op.sidechain == sidechain_type::peerplays){
-            return op.withdraw_sidechain;
-         }
-         else
-            return op.sidechain;
-      }();
-
-      const auto &gpo = db().get_global_properties();
       bool expected = false;
-      for (auto &si : gpo.active_sons.at(sidechain)) {
+      for (auto &si : gpo.active_sons) {
          if (op.son_id == si.son_id) {
             expected = true;
             break;
          }
       }
-      FC_ASSERT(expected, "Only active SON can create withdraw");
+      FC_ASSERT(expected, "Only active SON can create deposit");
    } else {
       bool exactly_the_same = true;
       exactly_the_same = exactly_the_same && (swwo->sidechain == op.sidechain);
@@ -85,16 +76,8 @@ object_id_type create_son_wallet_withdraw_evaluator::do_apply(const son_wallet_w
          swwo.withdraw_currency = op.withdraw_currency;
          swwo.withdraw_amount = op.withdraw_amount;
 
-         const sidechain_type sidechain = [&op]{
+         auto &gpo = db().get_global_properties();
-            if(op.sidechain == sidechain_type::peerplays){
+         for (auto &si : gpo.active_sons) {
-               return op.withdraw_sidechain;
-            }
-            else
-               return op.sidechain;
-         }();
-
-         const auto &gpo = db().get_global_properties();
-         for (auto &si : gpo.active_sons.at(sidechain)) {
             swwo.expected_reports.insert(std::make_pair(si.son_id, si.weight));
 
             auto stats_itr = db().get_index_type<son_stats_index>().indices().get<by_owner>().find(si.son_id);
@@ -155,17 +138,13 @@ object_id_type create_son_wallet_withdraw_evaluator::do_apply(const son_wallet_w
 
 void_result process_son_wallet_withdraw_evaluator::do_evaluate(const son_wallet_withdraw_process_operation& op)
 { try{
-   const auto now = db().head_block_time();
+   FC_ASSERT(db().head_block_time() >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
-   FC_ASSERT(now >= HARDFORK_SON_TIME, "Not allowed until SON HARDFORK");
    FC_ASSERT( op.payer == db().get_global_properties().parameters.son_account(), "SON paying account must be set as payer." );
+   FC_ASSERT(db().get_global_properties().active_sons.size() >= db().get_chain_properties().immutable_parameters.min_son_count, "Min required voted SONs not present");
 
    const auto& idx = db().get_index_type<son_wallet_withdraw_index>().indices().get<by_id>();
    const auto& itr = idx.find(op.son_wallet_withdraw_id);
    FC_ASSERT(itr != idx.end(), "Son wallet withdraw not found");
-   FC_ASSERT(!(itr->sidechain == sidechain_type::peerplays && now >= HARDFORK_SON_FOR_ETHEREUM_TIME), "Peerplays sidechain type is not allowed");
-   if(itr->sidechain != sidechain_type::peerplays) {
-      FC_ASSERT(db().get_global_properties().active_sons.at(itr->sidechain).size() >= db().get_chain_properties().immutable_parameters.min_son_count, "Min required voted SONs not present");
-   }
    FC_ASSERT(!itr->processed, "Son wallet withdraw is already processed");
    return void_result();
 } FC_CAPTURE_AND_RETHROW( (op) ) }

libraries/db/include/graphene/db/object_database.hpp

@@ -29,7 +29,6 @@
 #include <fc/log/logger.hpp>
 
 #include <map>
-#include <mutex>
 
 namespace graphene { namespace db {
 
@@ -145,7 +144,6 @@ namespace graphene { namespace db {
          fc::path get_data_dir()const { return _data_dir; }
 
          /** public for testing purposes only... should be private in practice. */
-         mutable std::mutex                     _undo_db_mutex;
          undo_database                          _undo_db;
      protected:
          template<typename IndexType>

libraries/net/core_messages.cpp

@@ -47,3 +47,4 @@ namespace graphene { namespace net {
   const core_message_type_enum get_current_connections_reply_message::type   = core_message_type_enum::get_current_connections_reply_message_type;
 
 } } // graphene::net
+

libraries/net/include/graphene/net/config.hpp

@@ -23,8 +23,6 @@
  */
 #pragma once
 
-#include <stddef.h>
-
 #define GRAPHENE_NET_PROTOCOL_VERSION                        106
 
 /**
@@ -112,6 +110,3 @@
 #define GRAPHENE_NET_MAX_NESTED_OBJECTS                      (250)
 
 #define MAXIMUM_PEERDB_SIZE 1000
-
-constexpr size_t MAX_BLOCKS_TO_HANDLE_AT_ONCE = 200;
-constexpr size_t MAX_SYNC_BLOCKS_TO_PREFETCH = 10 * MAX_BLOCKS_TO_HANDLE_AT_ONCE;

libraries/net/include/graphene/net/node.hpp

@@ -61,7 +61,7 @@ namespace graphene { namespace net {
    class node_delegate
    {
       public:
-         virtual ~node_delegate() = default;
+         virtual ~node_delegate(){}
 
          /**
           *  If delegate has the item, the network has no need to fetch it.
@@ -71,9 +71,7 @@ namespace graphene { namespace net {
          /**
           *  @brief Called when a new block comes in from the network
           *
-          *  @param blk_msg the message which contains the block
           *  @param sync_mode true if the message was fetched through the sync process, false during normal operation
-          *  @param contained_transaction_msg_ids container for the transactions to write back into
           *  @returns true if this message caused the blockchain to switch forks, false if it did not
           *
           *  @throws exception if error validating the item, otherwise the item is
@@ -197,7 +195,7 @@ namespace graphene { namespace net {
    {
       public:
         node(const std::string& user_agent);
-        virtual ~node();
+        ~node();
 
         void close();
 
@@ -215,34 +213,11 @@ namespace graphene { namespace net {
          */
         void      add_node( const fc::ip::endpoint& ep );
 
-        /*****
-         * @brief add a list of nodes to seed the p2p network
-         * @param seeds a vector of url strings
-         */
-        void add_seed_nodes( std::vector<std::string> seeds );
-
-        /****
-         * @brief add a node to seed the p2p network
-         * @param in the url as a string
-         */
-        void add_seed_node( const std::string& in);
-
         /**
          *  Attempt to connect to the specified endpoint immediately.
          */
         virtual void connect_to_endpoint( const fc::ip::endpoint& ep );
 
-        /**
-         * @brief Helper to convert a string to a collection of endpoints
-         *
-         * This converts a string (i.e. "bitshares.eu:665535" to a collection of endpoints.
-         * NOTE: Throws an exception if not in correct format or was unable to resolve URL.
-         *
-         * @param in the incoming string
-         * @returns a vector of endpoints
-         */
-        static std::vector<fc::ip::endpoint> resolve_string_to_ip_endpoints( const std::string& in );
-
         /**
          *  Specifies the network interface and port upon which incoming
          *  connections should be accepted.

libraries/net/include/graphene/net/peer_connection.hpp

@@ -62,7 +62,6 @@ namespace graphene { namespace net
     class peer_connection_delegate
     {
     public:
-      virtual ~peer_connection_delegate() = default;
       virtual void on_message(peer_connection* originating_peer,
                               const message& received_message) = 0;
       virtual void on_connection_closed(peer_connection* originating_peer) = 0;
@@ -126,7 +125,7 @@ namespace graphene { namespace net
          * it is sitting on the queue
          */
         virtual size_t get_size_in_queue() = 0;
-        virtual ~queued_message() = default;
+        virtual ~queued_message() {}
       };
 
       /* when you queue up a 'real_queued_message', a full copy of the message is

libraries/net/include/graphene/net/peer_database.hpp

@@ -97,7 +97,7 @@ namespace graphene { namespace net {
   {
   public:
     peer_database();
-    virtual ~peer_database();
+    ~peer_database();
 
     void open(const fc::path& databaseFilename);
     void close();

libraries/net/peer_database.cpp

@@ -50,8 +50,7 @@ namespace graphene { namespace net {
                                            indexed_by<ordered_non_unique<tag<last_seen_time_index>, 
                                                                          member<potential_peer_record, 
                                                                                 fc::time_point_sec, 
-                                                                                &potential_peer_record::last_seen_time>,
+                                                                                &potential_peer_record::last_seen_time> >,
-                                                                         std::greater<fc::time_point_sec> >,
                                                       hashed_unique<tag<endpoint_index>, 
                                                                     member<potential_peer_record, 
                                                                            fc::ip::endpoint, 

libraries/plugins/account_history/account_history_plugin.cpp

@@ -85,7 +85,6 @@ void account_history_plugin_impl::update_account_histories( const signed_block&
       vector<optional< operation_history_object > >& hist = db.get_applied_operations();
       bool is_first = true;
       auto skip_oho_id = [&is_first,&db,this]() {
-         const std::lock_guard<std::mutex> undo_db_lock{db._undo_db_mutex};
          if( is_first && db._undo_db.enabled() ) // this ensures that the current id is rolled back on undo
          {
             db.remove( db.create<operation_history_object>( []( operation_history_object& obj) {} ) );

libraries/plugins/debug_witness/CMakeLists.txt

@@ -16,4 +16,3 @@ install( TARGETS
    LIBRARY DESTINATION lib
    ARCHIVE DESTINATION lib
 )
-INSTALL( FILES ${HEADERS} DESTINATION "include/graphene/debug_witness" )

libraries/plugins/debug_witness/debug_api.cpp

@@ -34,9 +34,7 @@ class debug_api_impl
 };
 
 debug_api_impl::debug_api_impl( graphene::app::application& _app ) : app( _app )
-{
+{}
-   // Nothing else to do
-}
 
 
 void debug_api_impl::debug_push_blocks( const std::string& src_filename, uint32_t count )

libraries/plugins/debug_witness/debug_witness.cpp

@@ -38,10 +38,7 @@ using std::vector;
 
 namespace bpo = boost::program_options;
 
-debug_witness_plugin::~debug_witness_plugin()
+debug_witness_plugin::~debug_witness_plugin() {}
-{
-   cleanup();
-}
 
 void debug_witness_plugin::plugin_set_program_options(
    boost::program_options::options_description& command_line_options,
@@ -65,7 +62,7 @@ void debug_witness_plugin::plugin_initialize(const boost::program_options::varia
    ilog("debug_witness plugin:  plugin_initialize() begin");
    _options = &options;
 
-   if( options.count("debug-private-key") > 0 )
+   if( options.count("debug-private-key") )
    {
       const std::vector<std::string> key_id_to_wif_pair_strings = options["debug-private-key"].as<std::vector<std::string>>();
       for (const std::string& key_id_to_wif_pair_string : key_id_to_wif_pair_strings)
@@ -103,6 +100,7 @@ void debug_witness_plugin::plugin_startup()
    _changed_objects_conn = db.changed_objects.connect([this](const std::vector<graphene::db::object_id_type>& ids, const fc::flat_set<graphene::chain::account_id_type>& impacted_accounts){ on_changed_objects(ids, impacted_accounts); });
    _removed_objects_conn = db.removed_objects.connect([this](const std::vector<graphene::db::object_id_type>& ids, const std::vector<const graphene::db::object*>& objs, const fc::flat_set<graphene::chain::account_id_type>& impacted_accounts){ on_removed_objects(ids, objs, impacted_accounts); });
 
+   return;
 }
 
 void debug_witness_plugin::on_changed_objects( const std::vector<graphene::db::object_id_type>& ids, const fc::flat_set<graphene::chain::account_id_type>& impacted_accounts )
@@ -157,15 +155,11 @@ void debug_witness_plugin::flush_json_object_stream()
 }
 
 void debug_witness_plugin::plugin_shutdown()
-{
-   cleanup();
-}
-
-void debug_witness_plugin::cleanup()
 {
    if( _json_object_stream )
    {
       _json_object_stream->close();
       _json_object_stream.reset();
    }
+   return;
 }

libraries/plugins/debug_witness/include/graphene/debug_witness/debug_witness.hpp

@@ -34,25 +34,23 @@ namespace graphene { namespace debug_witness_plugin {
 
 class debug_witness_plugin : public graphene::app::plugin {
 public:
-   using graphene::app::plugin::plugin;
+   ~debug_witness_plugin();
-   ~debug_witness_plugin() override;
 
    std::string plugin_name()const override;
 
-   void plugin_set_program_options(
+   virtual void plugin_set_program_options(
       boost::program_options::options_description &command_line_options,
       boost::program_options::options_description &config_file_options
       ) override;
 
-   void plugin_initialize( const boost::program_options::variables_map& options ) override;
+   virtual void plugin_initialize( const boost::program_options::variables_map& options ) override;
-   void plugin_startup() override;
+   virtual void plugin_startup() override;
-   void plugin_shutdown() override;
+   virtual void plugin_shutdown() override;
 
    void set_json_object_stream( const std::string& filename );
    void flush_json_object_stream();
 
 private:
-   void cleanup();
 
    void on_changed_objects( const std::vector<graphene::db::object_id_type>& ids, const fc::flat_set<graphene::chain::account_id_type>& impacted_accounts );
    void on_removed_objects( const std::vector<graphene::db::object_id_type>& ids, const std::vector<const graphene::db::object*> objs, const fc::flat_set<graphene::chain::account_id_type>& impacted_accounts );
@@ -60,7 +58,7 @@ private:
 
    boost::program_options::variables_map _options;
 
-   std::map<chain::public_key_type, fc::ecc::private_key, chain::pubkey_comparator> _private_keys;
+   std::map<chain::public_key_type, fc::ecc::private_key> _private_keys;
 
    std::shared_ptr< std::ofstream > _json_object_stream;
    boost::signals2::scoped_connection _applied_block_conn;

libraries/plugins/delayed_node/delayed_node_plugin.cpp

@@ -63,24 +63,8 @@ void delayed_node_plugin::plugin_set_program_options(bpo::options_description& c
 
 void delayed_node_plugin::connect()
 {
-   fc::http::websocket_connection_ptr con;
+   my->client_connection = std::make_shared<fc::rpc::websocket_api_connection>(my->client.connect(my->remote_endpoint), GRAPHENE_MAX_NESTED_OBJECTS);
-   try
-   {
-      con = my->client.connect(my->remote_endpoint);
-   }
-   catch( const fc::exception& e )
-   {
-      wlog("Error while connecting: ${e}", ("e", e.to_detail_string()));
-      connection_failed();
-      return;
-   }
-   my->client_connection = std::make_shared<fc::rpc::websocket_api_connection>(
-           con, GRAPHENE_NET_MAX_NESTED_OBJECTS );
    my->database_api = my->client_connection->get_remote_api<graphene::app::database_api>(0);
-   my->database_api->set_block_applied_callback([this]( const fc::variant& block_id )
-   {
-      fc::from_variant( block_id, my->last_received_remote_head, GRAPHENE_MAX_NESTED_OBJECTS );
-   } );
    my->client_connection_closed = my->client_connection->closed.connect([this] {
       connection_failed();
    });
@@ -89,9 +73,7 @@ void delayed_node_plugin::connect()
 void delayed_node_plugin::plugin_initialize(const boost::program_options::variables_map& options)
 {
    FC_ASSERT(options.count("trusted-node") > 0);
-   ilog("delayed_node_plugin:  plugin_initialize() begin");
    my->remote_endpoint = "ws://" + options.at("trusted-node").as<std::string>();
-   ilog("delayed_node_plugin:  plugin_initialize() end");
 }
 
 void delayed_node_plugin::sync_with_trusted_node()
@@ -118,11 +100,8 @@ void delayed_node_plugin::sync_with_trusted_node()
       while( remote_dpo.last_irreversible_block_num > db.head_block_num() )
       {
          fc::optional<graphene::chain::signed_block> block = my->database_api->get_block( db.head_block_num()+1 );
-         // TODO: during sync, decouple requesting blocks from preprocessing + applying them
          FC_ASSERT(block, "Trusted node claims it has blocks it doesn't actually have.");
          ilog("Pushing block #${n}", ("n", block->block_num()));
-         // timur: failed to merge from bitshares, API n/a in peerplays
-         // db.precompute_parallel( *block, graphene::chain::database::skip_nothing ).wait();
          db.push_block(*block);
          synced_blocks++;
       }
@@ -157,12 +136,24 @@ void delayed_node_plugin::plugin_startup()
       mainloop();
    });
 
-   connect();
+   try
+   {
+      connect();
+      my->database_api->set_block_applied_callback([this]( const fc::variant& block_id )
+      {
+         fc::from_variant( block_id, my->last_received_remote_head, GRAPHENE_MAX_NESTED_OBJECTS );
+      } );
+      return;
+   }
+   catch (const fc::exception& e)
+   {
+      elog("Error during connection: ${e}", ("e", e.to_detail_string()));
+   }
+   fc::async([this]{connection_failed();});
 }
 
 void delayed_node_plugin::connection_failed()
 {
-   my->last_received_remote_head = my->last_processed_remote_head;
    elog("Connection to trusted node failed; retrying in 5 seconds...");
    fc::schedule([this]{connect();}, fc::time_point::now() + fc::seconds(5));
 }

libraries/plugins/elasticsearch/elasticsearch_plugin.cpp

@@ -127,7 +127,6 @@ bool elasticsearch_plugin_impl::update_account_histories( const signed_block& b
    const vector<optional< operation_history_object > >& hist = db.get_applied_operations();
    bool is_first = true;
    auto skip_oho_id = [&is_first,&db,this]() {
-      const std::lock_guard<std::mutex> undo_db_lock{db._undo_db_mutex};
       if( is_first && db._undo_db.enabled() ) // this ensures that the current id is rolled back on undo
       {
          db.remove( db.create<operation_history_object>( []( operation_history_object& obj) {} ) );

libraries/plugins/peerplays_sidechain/CMakeLists.txt

@@ -3,7 +3,7 @@ file(GLOB_RECURSE HEADERS "include/graphene/peerplays_sidechain/*.hpp")
 add_library( peerplays_sidechain
              peerplays_sidechain_plugin.cpp
              sidechain_api.cpp
-             sidechain_net_handler_factory.cpp
+             sidechain_net_manager.cpp
              sidechain_net_handler.cpp
              sidechain_net_handler_bitcoin.cpp
              sidechain_net_handler_ethereum.cpp
@@ -16,8 +16,6 @@ add_library( peerplays_sidechain
              bitcoin/segwit_addr.cpp
              bitcoin/utils.cpp
              bitcoin/sign_bitcoin_transaction.cpp
-             bitcoin/libbitcoin_client.cpp
-             bitcoin/estimate_fee_external.cpp
              common/rpc_client.cpp
              common/utils.cpp
              ethereum/encoders.cpp
@@ -44,7 +42,7 @@ endif()
 unset(ENABLE_PEERPLAYS_ASSET_DEPOSITS)
 unset(ENABLE_PEERPLAYS_ASSET_DEPOSITS CACHE)
 
-target_link_libraries( peerplays_sidechain PRIVATE curl graphene_plugin sha3 zmq bitcoin-system bitcoin-protocol bitcoin-client bitcoin-explorer )
+target_link_libraries( peerplays_sidechain PRIVATE graphene_plugin sha3 zmq )
 target_include_directories( peerplays_sidechain
                             PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/include" )
 

libraries/plugins/peerplays_sidechain/bitcoin/bitcoin_address.cpp

@@ -242,12 +242,12 @@ bytes btc_multisig_segwit_address::get_address_bytes(const bytes &script_hash) {
 }
 
 btc_weighted_multisig_address::btc_weighted_multisig_address(const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data,
-                                                             network ntype, payment_type type) {
+                                                             network ntype) {
    network_type = ntype;
-   this->type = type;
    create_redeem_script(keys_data);
    create_witness_script();
    create_segwit_address();
+   type = payment_type::P2WSH;
 }
 
 void btc_weighted_multisig_address::create_redeem_script(const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data) {
@@ -278,43 +278,26 @@ void btc_weighted_multisig_address::create_witness_script() {
    script_builder builder;
    builder << op::_0;
    builder << fc::sha256::hash(redeem_script_.data(), redeem_script_.size());
+
    witness_script_ = builder;
 }
 
 void btc_weighted_multisig_address::create_segwit_address() {
    std::string hrp;
-   address_types byte_version;
    switch (network_type) {
    case (network::mainnet):
       hrp = "bc";
-      byte_version = address_types::MAINNET_SCRIPT;
       break;
    case (network::testnet):
       hrp = "tb";
-      byte_version = address_types::TESTNET_SCRIPT;
       break;
    case (network::regtest):
       hrp = "bcrt";
-      byte_version = address_types::TESTNET_SCRIPT;
       break;
    }
-
+   fc::sha256 sh = fc::sha256::hash(&redeem_script_[0], redeem_script_.size());
-   if (type == payment_type::P2WSH) {
+   std::vector<uint8_t> hash_data(sh.data(), sh.data() + sh.data_size());
-      fc::sha256 sh = fc::sha256::hash(&redeem_script_[0], redeem_script_.size());
+   address = segwit_addr::encode(hrp, 0, hash_data);
-      std::vector<uint8_t> hash_data(sh.data(), sh.data() + sh.data_size());
-      address = segwit_addr::encode(hrp, 0, hash_data);
-   } else if (type == payment_type::P2SH_WSH) {
-      fc::sha256 hash256 = fc::sha256::hash(&witness_script_[0], witness_script_.size());
-      fc::ripemd160 hash160 = fc::ripemd160::hash(hash256.data(), hash256.data_size());
-      raw_address = bytes(hash160.data(), hash160.data() + hash160.data_size());
-      bytes address_bytes(1, byte_version); // 1 byte version
-      address_bytes.insert(address_bytes.end(), raw_address.begin(), raw_address.end());
-      fc::sha256 hash256_1 = fc::sha256::hash(fc::sha256::hash(address_bytes.data(), address_bytes.size()));
-      address_bytes.insert(address_bytes.end(), hash256_1.data(), hash256_1.data() + 4); // 4 byte checksum
-      address = fc::to_base58(address_bytes);
-   } else {
-      wlog("Unsupported payment type of address");
-   }
 }
 
 btc_one_or_m_of_n_multisig_address::btc_one_or_m_of_n_multisig_address(const fc::ecc::public_key &user_key_data,
@@ -370,12 +353,12 @@ void btc_one_or_m_of_n_multisig_address::create_segwit_address() {
 
 btc_one_or_weighted_multisig_address::btc_one_or_weighted_multisig_address(const fc::ecc::public_key &user_key_data,
                                                                            const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data,
-                                                                           bitcoin_address::network ntype, payment_type type) {
+                                                                           bitcoin_address::network ntype) {
    network_type = ntype;
-   this->type = type;
    create_redeem_script(user_key_data, keys_data);
    create_witness_script();
    create_segwit_address();
+   type = payment_type::P2WSH;
 }
 
 void btc_one_or_weighted_multisig_address::create_redeem_script(const fc::ecc::public_key &user_key_data, const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data) {
@@ -415,39 +398,20 @@ void btc_one_or_weighted_multisig_address::create_witness_script() {
 
 void btc_one_or_weighted_multisig_address::create_segwit_address() {
    std::string hrp;
-   address_types byte_version;
    switch (network_type) {
    case (network::mainnet):
-      byte_version = address_types::MAINNET_SCRIPT;
       hrp = "bc";
       break;
    case (network::testnet):
-      byte_version = address_types::TESTNET_SCRIPT;
       hrp = "tb";
       break;
    case (network::regtest):
-      byte_version = address_types::TESTNET_SCRIPT;
       hrp = "bcrt";
       break;
    }
-
+   fc::sha256 sh = fc::sha256::hash(&redeem_script_[0], redeem_script_.size());
-   if (type == payment_type::P2WSH) {
+   std::vector<uint8_t> hash_data(sh.data(), sh.data() + sh.data_size());
-      fc::sha256 sh = fc::sha256::hash(&redeem_script_[0], redeem_script_.size());
+   address = segwit_addr::encode(hrp, 0, hash_data);
-      std::vector<uint8_t> hash_data(sh.data(), sh.data() + sh.data_size());
-      address = segwit_addr::encode(hrp, 0, hash_data);
-   } else if (type == payment_type::P2SH_WSH) {
-      fc::sha256 hash256 = fc::sha256::hash(&witness_script_[0], witness_script_.size());
-      fc::ripemd160 hash160 = fc::ripemd160::hash(hash256.data(), hash256.data_size());
-      raw_address = bytes(hash160.data(), hash160.data() + hash160.data_size());
-
-      bytes address_bytes(1, byte_version); // 1 byte version test net
-      address_bytes.insert(address_bytes.end(), raw_address.begin(), raw_address.end());
-      fc::sha256 hash256_1 = fc::sha256::hash(fc::sha256::hash(address_bytes.data(), address_bytes.size()));
-      address_bytes.insert(address_bytes.end(), hash256_1.data(), hash256_1.data() + 4); // 4 byte checksum
-      address = fc::to_base58(address_bytes);
-   } else {
-      elog("Unsupported payment type of address");
-   }
 }
 
 btc_timelocked_one_or_weighted_multisig_address::btc_timelocked_one_or_weighted_multisig_address(const fc::ecc::public_key &user_key_data, uint32_t latency, const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data, bitcoin_address::network ntype) :

libraries/plugins/peerplays_sidechain/bitcoin/bitcoin_transaction.cpp

@@ -152,7 +152,7 @@ void bitcoin_transaction_builder::add_in(payment_type type, tx_in txin, const by
       txin.scriptSig = script_code;
       break;
    default: {
-      if (txin.prevout.hash == fc::sha256("0000000000000000000000000000000000000000000000000000000000000000")) { // coinbase
+      if (txin.prevout.hash == fc::sha256("0000000000000000000000000000000000000000000000000000000000000000")) { //coinbase
          FC_ASSERT(script_code != bytes());
          txin.scriptSig = script_code;
       }

libraries/plugins/peerplays_sidechain/bitcoin/estimate_fee_external.cpp

@@ -1,157 +0,0 @@
-
-#include <graphene/peerplays_sidechain/bitcoin/estimate_fee_external.hpp>
-
-#include <boost/property_tree/json_parser.hpp>
-#include <boost/property_tree/ptree.hpp>
-
-#include <fc/log/logger.hpp>
-
-#include <iostream>
-
-namespace graphene {
-namespace peerplays_sidechain {
-
-static size_t writeFunction(void *ptr, size_t size, size_t nmemb, std::string *data) {
-   data->append((char *)ptr, size * nmemb);
-   return size * nmemb;
-}
-
-estimate_fee_external::estimate_fee_external() {
-   curl = curl_easy_init();
-}
-
-estimate_fee_external::~estimate_fee_external() {
-   curl_easy_cleanup(curl);
-}
-
-std::vector<std::pair<std::string, uint64_t>> estimate_fee_external::get_fee_external(uint16_t target_block) {
-
-   std::vector<std::pair<std::string, uint64_t>> estimate_fee_external_collection;
-   this->target_block = target_block;
-
-   for (auto &url_fee_parser : url_get_fee_parsers) {
-      response = get_response(url_fee_parser.first);
-      uint64_t fee = url_fee_parser.second();
-      std::string url_str = url_fee_parser.first;
-      if (fee != 0) {
-         estimate_fee_external_collection.emplace_back(std::make_pair(url_fee_parser.first, fee));
-      }
-   }
-
-   return estimate_fee_external_collection;
-}
-
-std::string estimate_fee_external::get_response(std::string url) {
-
-   std::string response;
-   if (curl) {
-      curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
-      curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 1L);
-      curl_easy_setopt(curl, CURLOPT_USERPWD, "user:pass");
-      curl_easy_setopt(curl, CURLOPT_USERAGENT, "curl/7.42.0");
-      curl_easy_setopt(curl, CURLOPT_MAXREDIRS, 50L);
-      curl_easy_setopt(curl, CURLOPT_TCP_KEEPALIVE, 1L);
-      curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writeFunction);
-      curl_easy_setopt(curl, CURLOPT_WRITEDATA, &response);
-      curl_easy_perform(curl);
-   }
-   return response;
-}
-
-uint64_t estimate_fee_external::parse_and_get_fee_1() {
-   //"https://www.bitgo.com/api/v2/btc/tx/fee"
-
-   uint64_t founded_fee = 0;
-
-   if (response.empty()) {
-      return founded_fee;
-   }
-
-   std::stringstream response_ss(response);
-   boost::property_tree::ptree response_pt;
-   boost::property_tree::read_json(response_ss, response_pt);
-
-   for (const auto &tx_child : response_pt.get_child("feeByBlockTarget")) {
-      const auto &block_num = tx_child.first.data();
-      const auto &fee = tx_child.second.data();
-
-      founded_fee = std::stoi(fee);
-
-      if (std::stoi(block_num) >= target_block) {
-         return founded_fee;
-      }
-   }
-
-   return founded_fee;
-}
-
-uint64_t estimate_fee_external::parse_and_get_fee_2() {
-   // https://bitcoiner.live/api/fees/estimates/latest
-   uint64_t founded_fee = 0;
-
-   if (response.empty()) {
-      return founded_fee;
-   }
-
-   std::stringstream response_ss(response);
-   boost::property_tree::ptree response_pt;
-   boost::property_tree::read_json(response_ss, response_pt);
-
-   for (const auto &tx_child : response_pt.get_child("estimates")) {
-      const auto &time_str = tx_child.first.data();
-
-      auto time = std::stoi(time_str);
-      auto block_num = time / 30;
-
-      if (tx_child.second.count("sat_per_vbyte")) {
-         auto founded_fee_str = tx_child.second.get_child("sat_per_vbyte").data();
-         founded_fee = std::stoi(founded_fee_str) * 1000;
-      }
-
-      if (block_num >= target_block) {
-         return founded_fee;
-      }
-   }
-
-   return founded_fee;
-}
-
-uint64_t estimate_fee_external::parse_and_get_fee_3() {
-   // https://api.blockchain.info/mempool/fees
-
-   if (response.empty()) {
-      return 0;
-   }
-
-   std::stringstream response_ss(response);
-   boost::property_tree::ptree response_pt;
-   boost::property_tree::read_json(response_ss, response_pt);
-
-   if (response_pt.get_child("limits").count("min") && response_pt.get_child("limits").count("max")) {
-      auto limits_min_str = response_pt.get_child("limits.min").data();
-      auto limits_max_str = response_pt.get_child("limits.max").data();
-
-      auto limits_min = std::stoi(limits_min_str);
-      auto limits_max = std::stoi(limits_max_str);
-
-      auto priority_max = (limits_max - (limits_min - 1)) / 2;
-
-      if (response_pt.count("regular") && response_pt.count("priority")) {
-         auto regular_str = response_pt.get_child("regular").data();
-         auto priority_str = response_pt.get_child("priority").data();
-
-         auto regular = std::stoi(regular_str);
-         auto priority = std::stoi(priority_str);
-
-         if (target_block >= priority_max) {
-            return regular * 1000;
-         } else {
-            return priority * 1000;
-         }
-      }
-   }
-
-   return 0;
-}
-
-}} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/bitcoin/libbitcoin_client.cpp

@@ -1,227 +0,0 @@
-
-#include <graphene/peerplays_sidechain/bitcoin/libbitcoin_client.hpp>
-
-#include <system_error>
-
-#include <bitcoin/explorer/config/transaction.hpp>
-#include <bitcoin/system/config/hash256.hpp>
-
-#include <boost/xpressive/xpressive.hpp>
-
-#include <fc/crypto/hex.hpp>
-#include <fc/log/logger.hpp>
-
-namespace graphene { namespace peerplays_sidechain {
-
-libbitcoin_client::libbitcoin_client(std::string url) :
-      obelisk_client(LIBBITCOIN_SERVER_TIMEOUT, LIBBITCOIN_SERVER_RETRIES) {
-
-   std::string reg_expr = "^((?P<Protocol>https|http|tcp):\\/\\/)?(?P<Host>[a-zA-Z0-9\\-\\.]+)(:(?P<Port>\\d{1,5}))?(?P<Target>\\/.+)?";
-   boost::xpressive::sregex sr = boost::xpressive::sregex::compile(reg_expr);
-
-   boost::xpressive::smatch sm;
-
-   if (boost::xpressive::regex_search(url, sm, sr)) {
-      protocol = sm["Protocol"];
-      if (protocol.empty()) {
-         protocol = "tcp";
-      }
-
-      host = sm["Host"];
-      if (host.empty()) {
-         host + "localhost";
-      }
-
-      port = sm["Port"];
-      if (port.empty()) {
-         port = "9091";
-      }
-   }
-
-   uint16_t port_num = std::stoi(port);
-   std::string final_url = protocol + "://" + host;
-
-   libbitcoin::config::endpoint address(final_url, port_num);
-
-   libbitcoin::client::connection_type connection;
-   connection.retries = LIBBITCOIN_SERVER_RETRIES;
-   connection.server = address;
-
-   if (!obelisk_client.connect(connection)) {
-      elog("Can't connect libbitcoin for url: ${url}", ("url", final_url));
-   }
-
-   is_connected = true;
-}
-
-std::string libbitcoin_client::send_transaction(std::string tx) {
-
-   std::string res;
-
-   auto error_handler = [&](const std::error_code &ec) {
-      elog("error on sending bitcoin transaction ${error_code}", ("error_code", ec.message()));
-   };
-
-   auto result_handler = [&](libbitcoin::code result_code) {
-      ilog("result code on sending transaction ${result_code}", ("result_code", result_code.message()));
-      res = std::to_string(result_code.value());
-   };
-
-   libbitcoin::explorer::config::transaction transaction(tx);
-
-   libbitcoin::chain::transaction trx;
-
-   // This validates the tx, submits it to local tx pool, and notifies peers.
-   obelisk_client.transaction_pool_broadcast(error_handler, result_handler, transaction);
-   obelisk_client.wait();
-
-   return res;
-}
-
-libbitcoin::chain::output::list libbitcoin_client::get_transaction(std::string tx_id, std::string &tx_hash, uint32_t &confirmitions) {
-
-   libbitcoin::chain::output::list outs;
-
-   auto error_handler = [&](const std::error_code &ec) {
-      elog("error on fetch_trx_by_hash: ${hash} ${error_code}", ("hash", tx_id)("error_code", ec.message()));
-   };
-
-   auto transaction_handler = [&](const libbitcoin::chain::transaction &tx_handler) {
-      tx_hash = libbitcoin::config::hash256(tx_handler.hash(false)).to_string();
-      // TODO try to find this value (confirmitions)
-      confirmitions = 1;
-      outs = tx_handler.outputs();
-   };
-
-   libbitcoin::hash_digest hash = libbitcoin::config::hash256(tx_id);
-
-   // obelisk_client.blockchain_fetch_transaction (error_handler, transaction_handler,hash);
-   obelisk_client.blockchain_fetch_transaction2(error_handler, transaction_handler, hash);
-
-   obelisk_client.wait();
-
-   return outs;
-}
-
-std::vector<list_unspent_replay> libbitcoin_client::listunspent(std::string address, double amount) {
-   std::vector<list_unspent_replay> result;
-
-   auto error_handler = [&](const std::error_code &ec) {
-      elog("error on list_unspent ${error_code}", ("error_code", ec.message()));
-   };
-
-   auto replay_handler = [&](const libbitcoin::chain::points_value &points) {
-      for (auto &point : points.points) {
-         list_unspent_replay output;
-         output.hash = libbitcoin::config::hash256(point.hash()).to_string();
-         output.value = point.value();
-         output.index = point.index();
-         result.emplace_back(output);
-      }
-   };
-
-   libbitcoin::wallet::payment_address payment_address(address);
-   uint64_t satoshi = 100000000 * amount;
-
-   obelisk_client.blockchain_fetch_unspent_outputs(error_handler,
-                                                   replay_handler, payment_address, satoshi, libbitcoin::wallet::select_outputs::algorithm::individual);
-
-   obelisk_client.wait();
-
-   return result;
-}
-
-bool libbitcoin_client::get_is_test_net() {
-
-   bool result = false;
-
-   auto error_handler = [&](const std::error_code &ec) {
-      elog("error on fetching genesis block ${error_code}", ("error_code", ec.message()));
-   };
-
-   auto block_header_handler = [&](const libbitcoin::chain::header &block_header) {
-      std::string hash_str = libbitcoin::config::hash256(block_header.hash()).to_string();
-      if (hash_str == GENESIS_TESTNET_HASH || hash_str == GENESIS_REGTEST_HASH) {
-         result = true;
-      }
-   };
-
-   obelisk_client.blockchain_fetch_block_header(error_handler, block_header_handler, 0);
-
-   obelisk_client.wait();
-   return result;
-}
-
-uint64_t libbitcoin_client::get_fee_from_trx(libbitcoin::chain::transaction trx) {
-   bool general_fee_est_error = false;
-
-   if (trx.is_coinbase()) {
-      return 0;
-   }
-
-   const auto total_output_value = trx.total_output_value();
-   // get the inputs and from inputs previous outputs
-   std::map<libbitcoin::hash_digest, std::vector<uint32_t>> prev_out_trxs;
-   for (auto &ins : trx.inputs()) {
-      const auto &prev_out = ins.previous_output();
-      prev_out_trxs[prev_out.hash()].emplace_back(prev_out.index());
-   }
-
-   // fetch the trx to get total input value
-   uint64_t total_input_value = 0;
-   auto transaction_handler = [&](const libbitcoin::chain::transaction &tx_handler) {
-      std::vector<uint32_t> indexes = prev_out_trxs[tx_handler.hash()];
-
-      for (auto &index : indexes) {
-         total_input_value += tx_handler.outputs()[index].value();
-      }
-   };
-
-   auto error_handler = [&](const std::error_code &ec) {
-      elog("error on fetching trx ${error_code}", ("error_code", ec.message()));
-      general_fee_est_error = true;
-   };
-
-   for (const auto &iter : prev_out_trxs) {
-      if (general_fee_est_error) {
-         break;
-      }
-
-      obelisk_client.blockchain_fetch_transaction2(error_handler, transaction_handler, iter.first);
-      obelisk_client.wait();
-   }
-
-   if (total_input_value >= total_output_value) {
-      return total_input_value - total_output_value;
-   } else {
-      // something is really wrong if this happens,so we are going to mark as an error
-      elog("On fee estimation something is wrong in total inputs and total outputs for trx hash: ${hash}",
-           ("hash", libbitcoin::config::hash256(trx.hash()).to_string()));
-      return 0;
-   }
-}
-
-uint64_t libbitcoin_client::get_average_fee_from_trxs(std::vector<libbitcoin::chain::transaction> trx_list) {
-   std::vector<uint64_t> fee_per_trxs;
-
-   for (auto &trx : trx_list) {
-
-      uint64_t fee = get_fee_from_trx(trx);
-      if (fee > 0) {
-         fee_per_trxs.emplace_back(fee);
-      }
-   }
-
-   uint64_t average_estimated_fee = 0;
-
-   if (fee_per_trxs.size()) {
-      for (const auto &fee : fee_per_trxs) {
-         average_estimated_fee += fee;
-      }
-
-      average_estimated_fee /= fee_per_trxs.size();
-   }
-
-   return average_estimated_fee;
-}
-}} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/common/rpc_client.cpp

@@ -18,40 +18,10 @@
 
 namespace graphene { namespace peerplays_sidechain {
 
-struct rpc_reply {
+rpc_client::rpc_client(std::string _url, std::string _user, std::string _password, bool _debug_rpc_calls) :
-   uint16_t status;
+      url(_url),
-   std::string body;
+      user(_user),
-};
+      password(_password),
-
-class rpc_connection {
-public:
-   rpc_connection(const rpc_credentials &_credentials, bool _debug_rpc_calls);
-
-   std::string send_post_request(std::string method, std::string params, bool show_log);
-   std::string get_url() const;
-
-protected:
-   rpc_credentials credentials;
-   bool debug_rpc_calls;
-
-   std::string protocol;
-   std::string host;
-   std::string port;
-   std::string target;
-   std::string authorization;
-
-   uint32_t request_id;
-
-private:
-   rpc_reply send_post_request(std::string body, bool show_log);
-
-   boost::beast::net::io_context ioc;
-   boost::beast::net::ip::tcp::resolver resolver;
-   boost::asio::ip::basic_resolver_results<boost::asio::ip::tcp> results;
-};
-
-rpc_connection::rpc_connection(const rpc_credentials &_credentials, bool _debug_rpc_calls) :
-      credentials(_credentials),
       debug_rpc_calls(_debug_rpc_calls),
       request_id(0),
       resolver(ioc) {
@@ -61,7 +31,7 @@ rpc_connection::rpc_connection(const rpc_credentials &_credentials, bool _debug_
 
    boost::xpressive::smatch sm;
 
-   if (boost::xpressive::regex_search(credentials.url, sm, sr)) {
+   if (boost::xpressive::regex_search(url, sm, sr)) {
       protocol = sm["Protocol"];
       if (protocol.empty()) {
          protocol = "http";
@@ -82,84 +52,60 @@ rpc_connection::rpc_connection(const rpc_credentials &_credentials, bool _debug_
          target = "/";
       }
 
-      authorization = "Basic " + base64_encode(credentials.user + ":" + credentials.password);
+      authorization = "Basic " + base64_encode(user + ":" + password);
 
       results = resolver.resolve(host, port);
 
    } else {
-      elog("Invalid URL: ${url}", ("url", credentials.url));
+      elog("Invalid URL: ${url}", ("url", url));
    }
 }
 
-std::string rpc_connection::get_url() const {
-   return credentials.url;
-}
-
 std::string rpc_client::retrieve_array_value_from_reply(std::string reply_str, std::string array_path, uint32_t idx) {
-   if (reply_str.empty()) {
+   std::stringstream ss(reply_str);
-      wlog("RPC call ${function}, empty reply string", ("function", __FUNCTION__));
+   boost::property_tree::ptree json;
+   boost::property_tree::read_json(ss, json);
+   if (json.find("result") == json.not_found()) {
       return "";
    }
 
-   try {
+   auto json_result = json.get_child_optional("result");
-      std::stringstream ss(reply_str);
+   if (json_result) {
-      boost::property_tree::ptree json;
+      boost::property_tree::ptree array_ptree = json_result.get();
-      boost::property_tree::read_json(ss, json);
+      if (!array_path.empty()) {
-      if (json.find("result") == json.not_found()) {
+         array_ptree = json_result.get().get_child(array_path);
-         return "";
       }
-
+      uint32_t array_el_idx = -1;
-      auto json_result = json.get_child_optional("result");
+      for (const auto &array_el : array_ptree) {
-      if (json_result) {
+         array_el_idx = array_el_idx + 1;
-         boost::property_tree::ptree array_ptree = json_result.get();
+         if (array_el_idx == idx) {
-         if (!array_path.empty()) {
+            std::stringstream ss_res;
-            array_ptree = json_result.get().get_child(array_path);
+            boost::property_tree::json_parser::write_json(ss_res, array_el.second);
-         }
+            return ss_res.str();
-         uint32_t array_el_idx = -1;
-         for (const auto &array_el : array_ptree) {
-            array_el_idx = array_el_idx + 1;
-            if (array_el_idx == idx) {
-               std::stringstream ss_res;
-               boost::property_tree::json_parser::write_json(ss_res, array_el.second);
-               return ss_res.str();
-            }
          }
       }
-   } catch (const boost::property_tree::json_parser::json_parser_error &e) {
-      wlog("RPC call ${function} failed: ${e}", ("function", __FUNCTION__)("e", e.what()));
    }
 
    return "";
 }
 
 std::string rpc_client::retrieve_value_from_reply(std::string reply_str, std::string value_path) {
-   if (reply_str.empty()) {
+   std::stringstream ss(reply_str);
-      wlog("RPC call ${function}, empty reply string", ("function", __FUNCTION__));
+   boost::property_tree::ptree json;
+   boost::property_tree::read_json(ss, json);
+   if (json.find("result") == json.not_found()) {
       return "";
    }
 
-   try {
+   auto json_result = json.get_child_optional("result");
-      std::stringstream ss(reply_str);
+   if (json_result) {
-      boost::property_tree::ptree json;
+      return json_result.get().get<std::string>(value_path);
-      boost::property_tree::read_json(ss, json);
-      if (json.find("result") == json.not_found()) {
-         return "";
-      }
-
-      auto json_result = json.get_child_optional("result");
-      if (json_result) {
-         return json_result.get().get<std::string>(value_path);
-      }
-
-      return json.get<std::string>("result");
-   } catch (const boost::property_tree::json_parser::json_parser_error &e) {
-      wlog("RPC call ${function} failed: ${e}", ("function", __FUNCTION__)("e", e.what()));
    }
 
-   return "";
+   return json.get<std::string>("result");
 }
 
-std::string rpc_connection::send_post_request(std::string method, std::string params, bool show_log) {
+std::string rpc_client::send_post_request(std::string method, std::string params, bool show_log) {
    std::stringstream body;
 
    request_id = request_id + 1;
@@ -172,33 +118,29 @@ std::string rpc_connection::send_post_request(std::string method, std::string pa
 
    body << " }";
 
-   try {
+   const auto reply = send_post_request(body.str(), show_log);
-      const auto reply = send_post_request(body.str(), show_log);
 
-      if (reply.body.empty()) {
+   if (reply.body.empty()) {
-         wlog("RPC call ${function} failed", ("function", __FUNCTION__));
+      wlog("RPC call ${function} failed", ("function", __FUNCTION__));
-         return "";
+      return "";
-      }
+   }
 
-      std::stringstream ss(std::string(reply.body.begin(), reply.body.end()));
+   std::stringstream ss(std::string(reply.body.begin(), reply.body.end()));
-      boost::property_tree::ptree json;
+   boost::property_tree::ptree json;
-      boost::property_tree::read_json(ss, json);
+   boost::property_tree::read_json(ss, json);
 
-      if (json.count("error") && !json.get_child("error").empty()) {
+   if (json.count("error") && !json.get_child("error").empty()) {
-         wlog("RPC call ${function} with body ${body} failed with reply '${msg}'", ("function", __FUNCTION__)("body", body.str())("msg", ss.str()));
+      wlog("RPC call ${function} with body ${body} failed with reply '${msg}'", ("function", __FUNCTION__)("body", body.str())("msg", ss.str()));
-      }
+   }
 
-      if (reply.status == 200) {
+   if (reply.status == 200) {
-         return ss.str();
+      return ss.str();
-      }
-   } catch (const boost::system::system_error &e) {
-      elog("RPC call ${function} failed: ${e}", ("function", __FUNCTION__)("e", e.what()));
    }
 
    return "";
 }
 
-rpc_reply rpc_connection::send_post_request(std::string body, bool show_log) {
+rpc_reply rpc_client::send_post_request(std::string body, bool show_log) {
 
    // These object is used as a context for ssl connection
    boost::asio::ssl::context ctx(boost::asio::ssl::context::tlsv12_client);
@@ -273,7 +215,7 @@ rpc_reply rpc_connection::send_post_request(std::string body, bool show_log) {
    reply.body = rbody;
 
    if (show_log) {
-      ilog("### Request URL:    ${url}", ("url", credentials.url));
+      ilog("### Request URL:    ${url}", ("url", url));
       ilog("### Request:        ${body}", ("body", body));
       ilog("### Response:       ${rbody}", ("rbody", rbody));
    }
@@ -281,113 +223,4 @@ rpc_reply rpc_connection::send_post_request(std::string body, bool show_log) {
    return reply;
 }
 
-rpc_client::rpc_client(sidechain_type _sidechain, const std::vector<rpc_credentials> &_credentials, bool _debug_rpc_calls, bool _simulate_connection_reselection) :
-      sidechain(_sidechain),
-      debug_rpc_calls(_debug_rpc_calls),
-      simulate_connection_reselection(_simulate_connection_reselection) {
-   FC_ASSERT(_credentials.size());
-   for (size_t i = 0; i < _credentials.size(); i++)
-      connections.push_back(new rpc_connection(_credentials[i], _debug_rpc_calls));
-   n_active_conn = 0;
-   if (connections.size() > 1)
-      schedule_connection_selection();
-}
-
-void rpc_client::schedule_connection_selection() {
-   fc::time_point now = fc::time_point::now();
-   static const int64_t time_to_next_conn_selection = 10 * 1000 * 1000; // 10 sec
-   fc::time_point next_wakeup = now + fc::microseconds(time_to_next_conn_selection);
-   connection_selection_task = fc::schedule([this] {
-      select_connection();
-   },
-                                            next_wakeup, "SON RPC connection selection");
-}
-
-void rpc_client::select_connection() {
-   FC_ASSERT(connections.size() > 1);
-
-   const std::lock_guard<std::mutex> lock(conn_mutex);
-
-   static const int t_limit = 5 * 1000 * 1000, // 5 sec
-         quality_diff_threshold = 10 * 1000;   // 10 ms
-
-   int best_n = -1;
-   int best_quality = -1;
-
-   std::vector<uint64_t> head_block_numbers;
-   head_block_numbers.resize(connections.size());
-
-   std::vector<int> qualities;
-   qualities.resize(connections.size());
-
-   for (size_t n = 0; n < connections.size(); n++) {
-      rpc_connection &conn = *connections[n];
-      int quality = 0;
-      head_block_numbers[n] = std::numeric_limits<uint64_t>::max();
-
-      // ping n'th node
-      if (debug_rpc_calls)
-         ilog("### Ping ${sidechain} node #${n}, ${url}", ("sidechain", fc::reflector<sidechain_type>::to_string(sidechain))("n", n)("url", conn.get_url()));
-      fc::time_point t_sent = fc::time_point::now();
-      uint64_t head_block_number = ping(conn);
-      fc::time_point t_received = fc::time_point::now();
-      int t = (t_received - t_sent).count();
-
-      // evaluate n'th node reply quality and switch to it if it's better
-      if (head_block_number != std::numeric_limits<uint64_t>::max()) {
-         if (simulate_connection_reselection)
-            t += rand() % 10;
-         FC_ASSERT(t != -1);
-         head_block_numbers[n] = head_block_number;
-         if (t < t_limit)
-            quality = t_limit - t; // the less time, the higher quality
-
-         // look for the best quality
-         if (quality > best_quality) {
-            best_n = n;
-            best_quality = quality;
-         }
-      }
-      qualities[n] = quality;
-   }
-
-   FC_ASSERT(best_n != -1 && best_quality != -1);
-   if (best_n != n_active_conn) { // if the best client is not the current one, ...
-      uint64_t active_head_block_number = head_block_numbers[n_active_conn];
-      if ((active_head_block_number == std::numeric_limits<uint64_t>::max()      // ...and the current one has no known head block...
-           || head_block_numbers[best_n] >= active_head_block_number)            // ...or the best client's head is more recent than the current, ...
-          && best_quality > qualities[n_active_conn] + quality_diff_threshold) { // ...and the new client's quality exceeds current more than by threshold
-         n_active_conn = best_n;                                                 // ...then select new one
-         if (debug_rpc_calls)
-            ilog("### Reselected ${sidechain} node to #${n}, ${url}", ("sidechain", fc::reflector<sidechain_type>::to_string(sidechain))("n", n_active_conn)("url", connections[n_active_conn]->get_url()));
-      }
-   }
-
-   schedule_connection_selection();
-}
-
-rpc_connection &rpc_client::get_active_connection() const {
-   return *connections[n_active_conn];
-}
-
-std::string rpc_client::send_post_request(std::string method, std::string params, bool show_log) {
-   const std::lock_guard<std::mutex> lock(conn_mutex);
-   return send_post_request(get_active_connection(), method, params, show_log);
-}
-
-std::string rpc_client::send_post_request(rpc_connection &conn, std::string method, std::string params, bool show_log) {
-   return conn.send_post_request(method, params, show_log);
-}
-
-rpc_client::~rpc_client() {
-   try {
-      if (connection_selection_task.valid())
-         connection_selection_task.cancel_and_wait(__FUNCTION__);
-   } catch (fc::canceled_exception &) {
-      // Expected exception. Move along.
-   } catch (fc::exception &e) {
-      edump((e.to_detail_string()));
-   }
-}
-
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/common/utils.cpp

@@ -1,8 +1,8 @@
 #include <graphene/peerplays_sidechain/common/utils.hpp>
 
-#include <boost/algorithm/string.hpp>
 #include <boost/archive/iterators/base64_from_binary.hpp>
 #include <boost/archive/iterators/binary_from_base64.hpp>
+//#include <boost/archive/iterators/ostream_iterator.hpp>
 #include <boost/archive/iterators/transform_width.hpp>
 
 namespace graphene { namespace peerplays_sidechain {
@@ -48,17 +48,4 @@ std::string object_id_to_string(graphene::chain::object_id_type id) {
    return object_id;
 }
 
-graphene::chain::object_id_type string_to_object_id(const std::string &id) {
-   std::vector<std::string> strs;
-   boost::split(strs, id, boost::is_any_of("."));
-   if (strs.size() != 3) {
-      elog("Wrong object_id format: ${id}", ("id", id));
-      return graphene::chain::object_id_type{};
-   }
-
-   auto s = boost::lexical_cast<int>(strs.at(0));
-   auto t = boost::lexical_cast<int>(strs.at(1));
-   return graphene::chain::object_id_type{(uint8_t)s, (uint8_t)t, boost::lexical_cast<uint64_t>(strs.at(2))};
-}
-
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/ethereum/decoders.cpp

@@ -5,51 +5,8 @@
 
 namespace graphene { namespace peerplays_sidechain { namespace ethereum {
 
-//! base_decoder
-boost::multiprecision::uint256_t base_decoder::decode_uint256(const std::string &value) {
-   boost::multiprecision::uint256_t result = 0;
-
-   boost::multiprecision::uint256_t power(1);
-   uint8_t digit;
-   int pos = value.size() - 1;
-   while (pos >= 0) {
-      digit = 0;
-      if ('0' <= value[pos] && value[pos] <= '9') {
-         digit = value[pos] - '0';
-      } else if ('a' <= value[pos] && value[pos] <= 'z') {
-         digit = value[pos] - 'a' + 10;
-      }
-      result += digit * power;
-      pos--;
-      power *= 16;
-   }
-
-   return result;
-}
-
-std::string base_decoder::decode_address(const std::string &value) {
-   return value.substr(24, 40);
-}
-
-//! deposit_erc20_decoder
-const std::string deposit_erc20_decoder::function_signature = "97feb926"; //! depositERC20(address,uint256)
-fc::optional<deposit_erc20_transaction> deposit_erc20_decoder::decode(const std::string &input) {
-   const auto input_without_0x = remove_0x(input);
-   if (function_signature != input_without_0x.substr(0, 8)) {
-      return fc::optional<deposit_erc20_transaction>{};
-   }
-   if (input_without_0x.size() != 136) {
-      return fc::optional<deposit_erc20_transaction>{};
-   }
-
-   deposit_erc20_transaction erc_20;
-   erc_20.token = add_0x(base_decoder::decode_address(input_without_0x.substr(8, 64)));
-   erc_20.amount = base_decoder::decode_uint256(input_without_0x.substr(72, 64));
-
-   return erc_20;
-}
-
 //! rlp_decoder
+
 namespace {
 const signed char p_util_hexdigit[256] =
       {-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,

libraries/plugins/peerplays_sidechain/ethereum/encoders.cpp

@@ -2,6 +2,7 @@
 
 #include <boost/algorithm/hex.hpp>
 #include <boost/format.hpp>
+#include <stdlib.h>
 
 #include <graphene/peerplays_sidechain/ethereum/utils.hpp>
 
@@ -18,17 +19,13 @@ std::string base_encoder::encode_address(const std::string &value) {
 
 std::string base_encoder::encode_string(const std::string &value) {
    std::string data = (boost::format("%x") % boost::io::group(std::setw(64), std::setfill('0'), value.size())).str();
-   data += boost::algorithm::hex(value);
+   data += boost::algorithm::hex(value) + std::string((64 - value.size() * 2 % 64), '0');
-   if (value.size() % 32 != 0) {
-      data += std::string((64 - value.size() * 2 % 64), '0');
-   }
    return data;
 }
 
 //! update_owners_encoder
-const std::string update_owners_encoder::function_signature = "23ab6adf"; //! updateOwners((address,uint256)[],string)
+std::string update_owners_encoder::encode(const std::vector<std::pair<std::string, uint16_t>> &owners_weights, const std::string &object_id) const {
-std::string update_owners_encoder::encode(const std::vector<std::pair<std::string, uint16_t>> &owners_weights, const std::string &object_id) {
+   std::string data = "0x" + function_signature;
-   std::string data = add_0x(function_signature);
    data += base_encoder::encode_uint256(64);
    data += base_encoder::encode_uint256((owners_weights.size() * 2 + 3) * 32);
    data += base_encoder::encode_uint256(owners_weights.size());
@@ -42,9 +39,8 @@ std::string update_owners_encoder::encode(const std::vector<std::pair<std::strin
 }
 
 //! withdrawal_encoder
-const std::string withdrawal_encoder::function_signature = "e088747b"; //! withdraw(address,uint256,string)
+std::string withdrawal_encoder::encode(const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id) const {
-std::string withdrawal_encoder::encode(const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id) {
+   std::string data = "0x" + function_signature;
-   std::string data = add_0x(function_signature);
    data += base_encoder::encode_address(to);
    data += base_encoder::encode_uint256(amount);
    data += base_encoder::encode_uint256(32 * 3);
@@ -53,70 +49,6 @@ std::string withdrawal_encoder::encode(const std::string &to, boost::multiprecis
    return data;
 }
 
-//! withdrawal_erc20_encoder
-const std::string withdrawal_erc20_encoder::function_signature = "483c0467"; //! withdrawERC20(address,address,uint256,string)
-std::string withdrawal_erc20_encoder::encode(const std::string &token, const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id) {
-   std::string data = add_0x(function_signature);
-   data += base_encoder::encode_address(token);
-   data += base_encoder::encode_address(to);
-   data += base_encoder::encode_uint256(amount);
-   data += base_encoder::encode_uint256(32 * 4);
-   data += base_encoder::encode_string(object_id);
-
-   return data;
-}
-
-//! signature_encoder
-const std::string update_owners_function_signature = "9d608673";    //! updateOwners((bytes,(uint8,bytes32,bytes32))[])
-const std::string withdrawal_function_signature = "daac6c81";       //! withdraw((bytes,(uint8,bytes32,bytes32))[])
-const std::string withdrawal_erc20_function_signature = "d2bf2866"; //! withdrawERC20((bytes,(uint8,bytes32,bytes32))[])
-signature_encoder::signature_encoder(const std::string &function_hash) :
-      function_signature{function_hash} {
-}
-
-std::string signature_encoder::get_function_signature_from_transaction(const std::string &transaction) {
-   const std::string tr = remove_0x(transaction);
-   if (tr.substr(0, 8) == update_owners_encoder::function_signature)
-      return update_owners_function_signature;
-
-   if (tr.substr(0, 8) == withdrawal_encoder::function_signature)
-      return withdrawal_function_signature;
-
-   if (tr.substr(0, 8) == withdrawal_erc20_encoder::function_signature)
-      return withdrawal_erc20_function_signature;
-
-   return "";
-}
-
-std::string signature_encoder::encode(const std::vector<encoded_sign_transaction> &transactions) const {
-   std::string data = add_0x(function_signature);
-   data += base_encoder::encode_uint256(32);
-   data += base_encoder::encode_uint256(transactions.size());
-   size_t offset = (transactions.size()) * 32;
-   for (const auto &transaction : transactions) {
-      data += base_encoder::encode_uint256(offset);
-      const auto transaction_data = remove_0x(transaction.data);
-      offset += 5 * 32 + transaction_data.size() / 2;
-      if (transaction_data.size() / 2 % 32 != 0) {
-         offset += 32 - transaction_data.size() / 2 % 32;
-      }
-   }
-   for (const auto &transaction : transactions) {
-      data += base_encoder::encode_uint256(4 * 32);
-      data += base_encoder::encode_address(transaction.sign.v);
-      data += base_encoder::encode_address(transaction.sign.r);
-      data += base_encoder::encode_address(transaction.sign.s);
-      const auto transaction_data = remove_0x(transaction.data);
-      data += base_encoder::encode_uint256(transaction_data.size() / 2);
-      data += transaction_data;
-      if (transaction_data.size() % 64 != 0) {
-         data += std::string((64 - transaction_data.size() % 64), '0');
-      }
-   }
-
-   return data;
-}
-
 //! rlp_encoder
 std::string rlp_encoder::encode(const std::string &s) {
    return encode_rlp(hex2bytes(s));
@@ -137,9 +69,8 @@ std::string rlp_encoder::encode_length(int len, int offset) {
 
 std::string rlp_encoder::hex2bytes(const std::string &s) {
    std::string dest;
-   const auto s_final = s.size() % 2 == 0 ? s : "0" + s;
+   dest.resize(s.size() / 2);
-   dest.resize(s_final.size() / 2);
+   hex2bin(s.c_str(), &dest[0]);
-   hex2bin(s_final.c_str(), &dest[0]);
    return dest;
 }
 

libraries/plugins/peerplays_sidechain/ethereum/transaction.cpp

@@ -22,43 +22,7 @@ const secp256k1_context *eth_context() {
    return ctx;
 }
 
-bytes keccak_hash(const std::string &data) {
+//! transaction
-   bytes hash;
-   hash.resize(32);
-   const auto transaction_string = boost::algorithm::unhex(remove_0x(data));
-   keccak_256((const unsigned char *)transaction_string.data(), transaction_string.size(), (unsigned char *)hash.data());
-
-   return hash;
-}
-
-signature sign_hash(const bytes &hash, const std::string &chain_id, const std::string &private_key) {
-   const bytes priv_key = parse_hex(private_key);
-
-   int recid = 0;
-   secp256k1_ecdsa_recoverable_signature sig;
-   FC_ASSERT(secp256k1_ecdsa_sign_recoverable(eth_context(), &sig, (const unsigned char *)hash.data(), (const unsigned char *)priv_key.data(), NULL, NULL));
-   fc::ecc::compact_signature result;
-   FC_ASSERT(secp256k1_ecdsa_recoverable_signature_serialize_compact(eth_context(), (unsigned char *)result.begin() + 1, &recid, &sig));
-
-   unsigned int v = recid + from_hex<unsigned int>(chain_id) * 2 + 35;
-
-   bytes r;
-   for (int i = 1; i < 33; i++)
-      r.emplace_back((char)result.at(i));
-
-   bytes s;
-   for (int i = 33; i < 65; i++)
-      s.emplace_back((char)result.at(i));
-
-   signature eth_sig;
-   eth_sig.v = to_hex(v);
-   eth_sig.r = fc::to_hex((char *)&r[0], r.size());
-   eth_sig.s = fc::to_hex((char *)&s[0], s.size());
-
-   return eth_sig;
-}
-
-//! base_transaction
 
 base_transaction::base_transaction(const std::string &raw_tx) {
 }
@@ -106,7 +70,12 @@ raw_transaction::raw_transaction(const std::string &raw_tx) :
 }
 
 bytes raw_transaction::hash() const {
-   return keccak_hash(serialize());
+   bytes hash;
+   hash.resize(32);
+   const auto transaction_string = boost::algorithm::unhex(remove_0x(serialize()));
+   keccak_256((const unsigned char *)transaction_string.data(), transaction_string.size(), (unsigned char *)hash.data());
+
+   return hash;
 }
 
 signed_transaction raw_transaction::sign(const std::string &private_key) const {
@@ -119,10 +88,27 @@ signed_transaction raw_transaction::sign(const std::string &private_key) const {
    tr.value = value;
    tr.data = data;
 
-   const auto sig = sign_hash(hash(), chain_id, private_key);
+   const bytes priv_key = parse_hex(private_key);
-   tr.v = sig.v;
+
-   tr.r = sig.r;
+   int recid = 0;
-   tr.s = sig.s;
+   secp256k1_ecdsa_recoverable_signature sig;
+   FC_ASSERT(secp256k1_ecdsa_sign_recoverable(eth_context(), &sig, (const unsigned char *)hash().data(), (const unsigned char *)priv_key.data(), NULL, NULL));
+   fc::ecc::compact_signature result;
+   FC_ASSERT(secp256k1_ecdsa_recoverable_signature_serialize_compact(eth_context(), (unsigned char *)result.begin() + 1, &recid, &sig));
+
+   bytes r;
+   for (int i = 1; i < 33; i++)
+      r.emplace_back((char)result.at(i));
+
+   bytes v = bytes{char(recid + from_hex<int>(chain_id) * 2 + 35)};
+
+   bytes s;
+   for (int i = 33; i < 65; i++)
+      s.emplace_back((char)result.at(i));
+
+   tr.r = fc::to_hex((char *)&r[0], r.size());
+   tr.v = fc::to_hex((char *)&v[0], v.size());
+   tr.s = fc::to_hex((char *)&s[0], s.size());
 
    return tr;
 }
@@ -171,8 +157,8 @@ signed_transaction::signed_transaction(const std::string &raw_tx) :
 std::string signed_transaction::recover(const std::string &chain_id) const {
    fc::ecc::compact_signature input64;
    fc::from_hex(r, (char *)&input64.at(1), 32);
-   const int recid = from_hex<unsigned int>(v) - from_hex<unsigned int>(chain_id) * 2 - 35;
+   fc::from_hex(v, (char *)&input64.at(0), 1);
-   fc::from_hex(std::to_string(recid), (char *)&input64.at(0), 1);
+   int recid = input64.at(0) - from_hex<int>(chain_id) * 2 - 35;
    fc::from_hex(s, (char *)&input64.at(33), 32);
 
    secp256k1_ecdsa_recoverable_signature sig;
@@ -210,8 +196,8 @@ std::string signed_transaction::serialize() const {
                                   rlp_encoder::encode(remove_0x(value)) +
                                   rlp_encoder::encode(remove_0x(data)) +
                                   rlp_encoder::encode(remove_0x(v)) +
-                                  rlp_encoder::encode(remove_leading_00(remove_0x(r))) +
+                                  rlp_encoder::encode(remove_0x(r)) +
-                                  rlp_encoder::encode(remove_leading_00(remove_0x(s)));
+                                  rlp_encoder::encode(remove_0x(s));
 
    return add_0x(bytes2hex(rlp_encoder::encode_length(serialized.size(), 192) + serialized));
 }
@@ -234,9 +220,9 @@ void signed_transaction::deserialize(const std::string &raw_tx) {
    boost::algorithm::to_lower(data);
    v = add_0x(rlp_array.at(6));
    boost::algorithm::to_lower(v);
-   r = add_0x(add_leading_00(rlp_array.at(7)));
+   r = add_0x(rlp_array.at(7));
    boost::algorithm::to_lower(r);
-   s = add_0x(add_leading_00(rlp_array.at(8)));
+   s = add_0x(rlp_array.at(8));
    boost::algorithm::to_lower(s);
 }
 

libraries/plugins/peerplays_sidechain/ethereum/types.cpp

@@ -1,36 +1,5 @@
 #include <graphene/peerplays_sidechain/ethereum/types.hpp>
 
-#include <boost/property_tree/json_parser.hpp>
-#include <boost/property_tree/ptree.hpp>
-
 namespace graphene { namespace peerplays_sidechain { namespace ethereum {
 
-signature::signature(const std::string &sign) {
-   deserialize(sign);
-}
-
-std::string signature::serialize() const {
-   boost::property_tree::ptree pt;
-   pt.put("v", v);
-   pt.put("r", r);
-   pt.put("s", s);
-
-   std::stringstream ss;
-   boost::property_tree::json_parser::write_json(ss, pt);
-   return ss.str();
-}
-
-void signature::deserialize(const std::string &raw_tx) {
-   std::stringstream ss_tx(raw_tx);
-   boost::property_tree::ptree tx_json;
-   boost::property_tree::read_json(ss_tx, tx_json);
-
-   if (tx_json.count("v"))
-      v = tx_json.get<std::string>("v");
-   if (tx_json.count("r"))
-      r = tx_json.get<std::string>("r");
-   if (tx_json.count("s"))
-      s = tx_json.get<std::string>("s");
-}
-
 }}} // namespace graphene::peerplays_sidechain::ethereum

libraries/plugins/peerplays_sidechain/ethereum/utils.cpp

@@ -49,24 +49,4 @@ std::string remove_0x(const std::string &s) {
    return s;
 }
 
-std::string add_leading_00(const std::string &s) {
-   std::string result = s;
-
-   while (result.size() < 64) {
-      result = "00" + result;
-   }
-
-   return result;
-}
-
-std::string remove_leading_00(const std::string &s) {
-   std::string result = s;
-
-   while (result.size() > 1 && result.substr(0, 2) == "00") {
-      result = result.substr(2);
-   }
-
-   return result;
-}
-
 }}} // namespace graphene::peerplays_sidechain::ethereum

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/bitcoin/bitcoin_address.hpp

@@ -8,14 +8,6 @@ using namespace graphene::chain;
 namespace graphene { namespace peerplays_sidechain { namespace bitcoin {
 
 const bytes op_num = {0x51, 0x52, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5a, 0x5b, 0x5c, 0x5d, 0x5e, 0x5f}; // OP_1 - OP_15
-enum address_types { MAINNET_SCRIPT = 5,
-                     TESTNET_SCRIPT = 196 };
-
-enum script_op {
-   OP_0 = 0x00,
-   OP_PUSH = 0x20,
-   OP_SIZE_34 = 0x22
-};
 
 class bitcoin_address {
 
@@ -104,6 +96,9 @@ private:
    void create_address();
 
 public:
+   enum address_types { MAINNET_SCRIPT = 5,
+                        TESTNET_SCRIPT = 196 };
+
    enum { OP_0 = 0x00,
           OP_EQUAL = 0x87,
           OP_HASH160 = 0xa9,
@@ -150,7 +145,7 @@ public:
    btc_weighted_multisig_address() = default;
 
    btc_weighted_multisig_address(const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data,
-                                 network network_type = network::regtest, payment_type type = payment_type::P2SH_WSH);
+                                 network network_type = network::regtest);
 
    bytes get_redeem_script() const {
       return redeem_script_;
@@ -195,7 +190,7 @@ class btc_one_or_weighted_multisig_address : public bitcoin_address {
 public:
    btc_one_or_weighted_multisig_address() = default;
    btc_one_or_weighted_multisig_address(const fc::ecc::public_key &user_key_data, const std::vector<std::pair<fc::ecc::public_key, uint16_t>> &keys_data,
-                                        network network_type = network::regtest, payment_type type = payment_type::P2SH_WSH);
+                                        network network_type = network::regtest);
    bytes get_redeem_script() const {
       return redeem_script_;
    }

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/bitcoin/estimate_fee_external.hpp

@@ -1,39 +0,0 @@
-#pragma once
-
-#include <curl/curl.h>
-
-#include <cstdint>
-#include <functional>
-#include <map>
-#include <string>
-#include <vector>
-
-typedef std::function<uint64_t()> get_fee_func_type;
-
-namespace graphene { namespace peerplays_sidechain {
-
-class estimate_fee_external {
-public:
-   estimate_fee_external();
-   ~estimate_fee_external();
-   std::vector<std::pair<std::string, uint64_t>> get_fee_external(uint16_t target_block);
-
-private:
-   std::string get_response(std::string url);
-   // Here add your custom parser for external url. Take care of incremental name
-   // and populate the list of url_parsers bellow paired with the function
-   uint64_t parse_and_get_fee_1();
-   uint64_t parse_and_get_fee_2();
-   uint64_t parse_and_get_fee_3();
-
-   const std::map<std::string, get_fee_func_type> url_get_fee_parsers{
-         {"https://www.bitgo.com/api/v2/btc/tx/fee", std::bind(&estimate_fee_external::parse_and_get_fee_1, this)},
-         {"https://bitcoiner.live/api/fees/estimates/latest", std::bind(&estimate_fee_external::parse_and_get_fee_2, this)},
-         {"https://api.blockchain.info/mempool/fees", std::bind(&estimate_fee_external::parse_and_get_fee_3, this)}};
-
-   std::string response;
-   uint16_t target_block;
-   CURL *curl{nullptr};
-};
-
-}} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/bitcoin/libbitcoin_client.hpp

@@ -1,53 +0,0 @@
-#pragma once
-
-#include <bitcoin/client/obelisk_client.hpp>
-#include <bitcoin/client/socket_stream.hpp>
-#include <bitcoin/system/chain/block.hpp>
-
-#include <boost/signals2.hpp>
-#include <mutex>
-
-#define LIBBITCOIN_SERVER_TIMEOUT (10)
-#define LIBBITCOIN_SERVER_RETRIES (100)
-#define DEAFULT_LIBBITCOIN_TRX_FEE (20000)
-#define MAX_TRXS_IN_MEMORY_POOL (30000)
-#define MIN_TRXS_IN_BUCKET (100)
-
-#define GENESIS_MAINNET_HASH "000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f"
-#define GENESIS_TESTNET_HASH "000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943"
-#define GENESIS_REGTEST_HASH "0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206"
-
-namespace graphene { namespace peerplays_sidechain {
-
-typedef std::function<void(const libbitcoin::chain::block &)>
-      block_update_handler;
-
-struct list_unspent_replay {
-   std::string hash;
-   uint64_t value;
-   uint32_t index;
-};
-
-class libbitcoin_client {
-public:
-   libbitcoin_client(std::string url);
-   std::string send_transaction(const std::string tx);
-   libbitcoin::chain::output::list get_transaction(std::string tx_id, std::string &tx_hash, uint32_t &confirmitions);
-   std::vector<list_unspent_replay> listunspent(std::string address, double amount);
-   uint64_t get_average_fee_from_trxs(std::vector<libbitcoin::chain::transaction> trx_list);
-   uint64_t get_fee_from_trx(libbitcoin::chain::transaction trx);
-   bool get_is_test_net();
-
-private:
-   libbitcoin::client::obelisk_client obelisk_client;
-   libbitcoin::protocol::zmq::identifier id;
-
-   std::string protocol;
-   std::string host;
-   std::string port;
-   std::string url;
-
-   bool is_connected = false;
-};
-
-}} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/bitcoin/utils.hpp

@@ -1,5 +1,4 @@
 #pragma once
-
 #include <fc/crypto/elliptic.hpp>
 #include <fc/crypto/hex.hpp>
 #include <graphene/peerplays_sidechain/bitcoin/types.hpp>

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/common/rpc_client.hpp

@@ -3,52 +3,44 @@
 #include <cstdint>
 #include <string>
 
-#include <fc/thread/future.hpp>
-#include <fc/thread/thread.hpp>
-
 #include <boost/asio/ip/tcp.hpp>
 #include <boost/beast/core.hpp>
 
-#include <graphene/peerplays_sidechain/defs.hpp>
-
 namespace graphene { namespace peerplays_sidechain {
 
-class rpc_connection;
+struct rpc_reply {
-
+   uint16_t status;
-struct rpc_credentials {
+   std::string body;
-   std::string url;
-   std::string user;
-   std::string password;
 };
 
 class rpc_client {
 public:
-   const sidechain_type sidechain;
+   rpc_client(std::string _url, std::string _user, std::string _password, bool _debug_rpc_calls);
-
-   rpc_client(sidechain_type _sidechain, const std::vector<rpc_credentials> &_credentials, bool _debug_rpc_calls, bool _simulate_connection_reselection);
-   ~rpc_client();
 
 protected:
-   bool debug_rpc_calls;
+   std::string retrieve_array_value_from_reply(std::string reply_str, std::string array_path, uint32_t idx);
-   bool simulate_connection_reselection;
+   std::string retrieve_value_from_reply(std::string reply_str, std::string value_path);
    std::string send_post_request(std::string method, std::string params, bool show_log);
 
-   static std::string send_post_request(rpc_connection &conn, std::string method, std::string params, bool show_log);
+   std::string url;
+   std::string user;
+   std::string password;
+   bool debug_rpc_calls;
 
-   static std::string retrieve_array_value_from_reply(std::string reply_str, std::string array_path, uint32_t idx);
+   std::string protocol;
-   static std::string retrieve_value_from_reply(std::string reply_str, std::string value_path);
+   std::string host;
+   std::string port;
+   std::string target;
+   std::string authorization;
+
+   uint32_t request_id;
 
 private:
-   std::vector<rpc_connection *> connections;
+   rpc_reply send_post_request(std::string body, bool show_log);
-   int n_active_conn;
-   fc::future<void> connection_selection_task;
-   std::mutex conn_mutex;
 
-   rpc_connection &get_active_connection() const;
+   boost::beast::net::io_context ioc;
-
+   boost::beast::net::ip::tcp::resolver resolver;
-   void select_connection();
+   boost::asio::ip::basic_resolver_results<boost::asio::ip::tcp> results;
-   void schedule_connection_selection();
-   virtual uint64_t ping(rpc_connection &conn) const = 0;
 };
 
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/common/utils.hpp

@@ -8,6 +8,5 @@ std::string base64_encode(const std::string &s);
 std::string base64_decode(const std::string &s);
 
 std::string object_id_to_string(graphene::chain::object_id_type id);
-graphene::chain::object_id_type string_to_object_id(const std::string &id);
 
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/defs.hpp

@@ -57,16 +57,10 @@ struct info_for_vin {
    bool resend = false;
 };
 
-enum class sidechain_event_type {
-   deposit,
-   withdrawal
-};
-
 struct sidechain_event_data {
    fc::time_point_sec timestamp;
    uint32_t block_num;
    sidechain_type sidechain;
-   sidechain_event_type type;
    std::string sidechain_uid;
    std::string sidechain_transaction_id;
    std::string sidechain_from;

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/ethereum/decoders.hpp

@@ -1,31 +1,10 @@
 #pragma once
 
-#include <boost/multiprecision/cpp_int.hpp>
 #include <string>
 #include <vector>
 
-#include <fc/optional.hpp>
-
 namespace graphene { namespace peerplays_sidechain { namespace ethereum {
 
-class base_decoder {
-public:
-   static boost::multiprecision::uint256_t decode_uint256(const std::string &value);
-   static std::string decode_address(const std::string &value);
-};
-
-struct deposit_erc20_transaction {
-   std::string token;
-   boost::multiprecision::uint256_t amount;
-};
-
-class deposit_erc20_decoder {
-public:
-   static const std::string function_signature;
-
-   static fc::optional<deposit_erc20_transaction> decode(const std::string &input);
-};
-
 class rlp_decoder {
 private:
    enum RLP_constants {

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/ethereum/encoders.hpp

@@ -4,15 +4,8 @@
 #include <string>
 #include <vector>
 
-#include <graphene/peerplays_sidechain/ethereum/types.hpp>
-
 namespace graphene { namespace peerplays_sidechain { namespace ethereum {
 
-struct encoded_sign_transaction {
-   std::string data;
-   signature sign;
-};
-
 class base_encoder {
 public:
    static std::string encode_uint256(boost::multiprecision::uint256_t value);
@@ -22,34 +15,16 @@ public:
 
 class update_owners_encoder {
 public:
-   static const std::string function_signature;
+   const std::string function_signature = "23ab6adf"; //! updateOwners((address,uint256)[],string)
 
-   static std::string encode(const std::vector<std::pair<std::string, uint16_t>> &owners_weights, const std::string &object_id);
+   std::string encode(const std::vector<std::pair<std::string, uint16_t>> &owners_weights, const std::string &object_id) const;
 };
 
 class withdrawal_encoder {
 public:
-   static const std::string function_signature;
+   const std::string function_signature = "e088747b"; //! withdraw(address,uint256,string)
 
-   static std::string encode(const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id);
+   std::string encode(const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id) const;
-};
-
-class withdrawal_erc20_encoder {
-public:
-   static const std::string function_signature;
-
-   static std::string encode(const std::string &token, const std::string &to, boost::multiprecision::uint256_t amount, const std::string &object_id);
-};
-
-class signature_encoder {
-public:
-   const std::string function_signature;
-
-   signature_encoder(const std::string &function_hash);
-
-   static std::string get_function_signature_from_transaction(const std::string &transaction);
-
-   std::string encode(const std::vector<encoded_sign_transaction> &transactions) const;
 };
 
 class rlp_encoder {
@@ -64,4 +39,35 @@ private:
    static void hex2bin(const char *src, char *target);
 };
 
+/*class ethereum_function_call_encoder {
+public:
+   enum operation_t {
+      OPERATION_CALL,
+      OPERATION_DELEGATE_CALL
+   };
+
+   static constexpr const char *const default_prev_addr = "0000000000000000000000000000000000000001";
+
+   std::string encode_function_signature(const std::string &function_signature);
+   std::string encode_address(const std::string &addr);
+   std::string encode_uint256(const std::string &value);
+   std::string encode_uint8(uint8_t value);
+   std::string encode_bytes(const std::string &values);
+};
+
+class safe_transaction_encoder {
+public:
+   static constexpr const char *const default_safe_tx_gas = "0";
+   static constexpr const char *const default_data_gas = "0";
+   static constexpr const char *const default_gas_price = "0";
+   static constexpr const char *const default_gas_token = "0000000000000000000000000000000000000000";
+   static constexpr const char *const default_refund_receiver = "0000000000000000000000000000000000000000";
+
+   std::string create_safe_address(const std::vector<std::string> &owner_addresses, uint32_t threshold);
+   std::string build_transaction(const std::string &safe_account_addr, const std::string &value, const std::string &data, uint8_t operation, const std::string &safeTxGas, const std::string &dataGas, const std::string &gasPrice, const std::string &gasToken, const std::string &refundReceiver);
+
+private:
+   ethereum_function_call_encoder m_ethereum_function_call_encoder;
+};*/
+
 }}} // namespace graphene::peerplays_sidechain::ethereum

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/ethereum/transaction.hpp

@@ -8,9 +8,6 @@
 
 namespace graphene { namespace peerplays_sidechain { namespace ethereum {
 
-bytes keccak_hash(const std::string &data);
-signature sign_hash(const bytes &hash, const std::string &chain_id, const std::string &private_key);
-
 class base_transaction {
 public:
    base_transaction() = default;
@@ -78,3 +75,89 @@ public:
 };
 
 }}} // namespace graphene::peerplays_sidechain::ethereum
+
+// Example 1
+//{
+//  "blockHash": "0x64a6706ecaf5a97b7f3e047abb20ff223ce82c6994d80e68fdb1fdfb38d0209c",
+//  "blockNumber": "0xe5827c",
+//  "from": "0x8614c67e085f2334010f2a28e806c6f1cc176d12",
+//  "gas": "0x38822",
+//  "gasPrice": "0xce42cba69",
+//  "maxFeePerGas": "0xddb4d8d16",
+//  "maxPriorityFeePerGas": "0x3b9aca00",
+//  "hash": "0xeac92ea09fa8eb3ca2fb0d156cceb38ae69d4345869d41e8e49d5ecbcbb622dc",
+//  "input": "0x5ae401dc0000000000000000000000000000000000000000000000000000000062bb57cf00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000e4472b43f300000000000000000000000000000000000000000000000002514d9d7d7d8000000000000000000000000000000000000000000007dced93dd41fd3e1f9e80c200000000000000000000000000000000000000000000000000000000000000800000000000000000000000008614c67e085f2334010f2a28e806c6f1cc176d120000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000059c12ed5aaf25adbc6e15f9cc9bab2dde03121500000000000000000000000000000000000000000000000000000000",
+//  "nonce": "0x32",
+//  "to": "0x68b3465833fb72a70ecdf485e0e4c7bd8665fc45",
+//  "transactionIndex": "0xb6",
+//  "value": "0x2514d9d7d7d8000",
+//  "type": "0x2",
+//  "accessList": [],
+//  "chainId": "0x1",
+//  "v": "0x1",
+//  "r": "0x2f8d6a9c737ed98792bafc903b8f1aa54adc731bd3cf9a8b25246a1c9095a28c",
+//  "s": "0x782c40e64b47a221a07612c822c08763f626e53c4b00b73f4c5ba86304c43f14"
+//}
+//
+//"0xf9021332850ce42cba69830388229468b3465833fb72a70ecdf485e0e4c7bd8665fc458802514d9d7d7d8000b901a45ae401dc0000000000000000000000000000000000000000000000000000000062bb57cf00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000e4472b43f300000000000000000000000000000000000000000000000002514d9d7d7d8000000000000000000000000000000000000000000007dced93dd41fd3e1f9e80c200000000000000000000000000000000000000000000000000000000000000800000000000000000000000008614c67e085f2334010f2a28e806c6f1cc176d120000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000059c12ed5aaf25adbc6e15f9cc9bab2dde0312150000000000000000000000000000000000000000000000000000000001a02f8d6a9c737ed98792bafc903b8f1aa54adc731bd3cf9a8b25246a1c9095a28ca0782c40e64b47a221a07612c822c08763f626e53c4b00b73f4c5ba86304c43f14"
+//
+//{
+//  "nonce": 50,
+//  "gasPrice": {
+//    "_hex": "0x0ce42cba69"
+//  },
+//  "gasLimit": {
+//    "_hex": "0x038822"
+//  },
+//  "to": "0x68b3465833fb72a70ecdf485e0e4c7bd8665fc45",
+//  "value": {
+//    "_hex": "0x02514d9d7d7d8000"
+//  },
+//  "data": "0x5ae401dc0000000000000000000000000000000000000000000000000000000062bb57cf00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000e4472b43f300000000000000000000000000000000000000000000000002514d9d7d7d8000000000000000000000000000000000000000000007dced93dd41fd3e1f9e80c200000000000000000000000000000000000000000000000000000000000000800000000000000000000000008614c67e085f2334010f2a28e806c6f1cc176d120000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000059c12ed5aaf25adbc6e15f9cc9bab2dde03121500000000000000000000000000000000000000000000000000000000",
+//  "v": 1,
+//  "r": "0x2f8d6a9c737ed98792bafc903b8f1aa54adc731bd3cf9a8b25246a1c9095a28c",
+//  "s": "0x782c40e64b47a221a07612c822c08763f626e53c4b00b73f4c5ba86304c43f14"
+//}
+
+// Example 2
+//{
+//  "blockHash": "0xe2ae3afd86dc7343c7fb753441447a0a51bb19499325ad6e278256f0cd1b5894",
+//  "blockNumber": "0xe58271",
+//  "from": "0xb895ade6d337fbb8cb97f2ea7da43106c7f5cc26",
+//  "gas": "0x5208",
+//  "gasPrice": "0xe6f3b322e",
+//  "maxFeePerGas": "0x1322455fd3",
+//  "maxPriorityFeePerGas": "0x53724e00",
+//  "hash": "0xed29b56e52ad2d452e25b8ec70c37f59d935cd6d0f8fe8e83b256f3ffdfd3fce",
+//  "input": "0x",
+//  "nonce": "0x37",
+//  "to": "0x176386b6ffc469ac049f9ec1f6cc0efd1d09b373",
+//  "transactionIndex": "0x8a",
+//  "value": "0x4563918244f40000",
+//  "type": "0x2",
+//  "accessList": [],
+//  "chainId": "0x1",
+//  "v": "0x0",
+//  "r": "0xdcc588257770e08660cb809e71b293f556cd5f5323e832d96ee896ff8830ca4c",
+//  "s": "0x28c7ce6a539d9318688687097a2db29e15c32ba8c085275fdd3dddf047d4bd1a"
+//}
+//
+//"0xf86c37850e6f3b322e82520894176386b6ffc469ac049f9ec1f6cc0efd1d09b373884563918244f400008000a0dcc588257770e08660cb809e71b293f556cd5f5323e832d96ee896ff8830ca4ca028c7ce6a539d9318688687097a2db29e15c32ba8c085275fdd3dddf047d4bd1a"
+//
+//{
+//  "nonce": 55,
+//  "gasPrice": {
+//    "_hex": "0x0e6f3b322e"
+//  },
+//  "gasLimit": {
+//    "_hex": "0x5208"
+//  },
+//  "to": "0x176386b6ffc469ac049f9ec1f6cc0efd1d09b373",
+//  "value": {
+//    "_hex": "0x4563918244f40000"
+//  },
+//  "data": "0x",
+//  "v": 0,
+//  "r": "0xdcc588257770e08660cb809e71b293f556cd5f5323e832d96ee896ff8830ca4c",
+//  "s": "0x28c7ce6a539d9318688687097a2db29e15c32ba8c085275fdd3dddf047d4bd1a"
+//}

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/ethereum/types.hpp

@@ -9,17 +9,4 @@ typedef uint64_t network_id_type;
 
 using bytes = std::vector<char>;
 
-class signature {
-public:
-   std::string v;
-   std::string r;
-   std::string s;
-
-   signature() = default;
-   signature(const std::string &sign);
-
-   std::string serialize() const;
-   void deserialize(const std::string &sign);
-};
-
 }}} // namespace graphene::peerplays_sidechain::ethereum

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/ethereum/utils.hpp

@@ -14,19 +14,13 @@ std::string add_0x(const std::string &s);
 
 std::string remove_0x(const std::string &s);
 
-std::string add_leading_00(const std::string &s);
-
-std::string remove_leading_00(const std::string &s);
-
 template <typename T>
-std::string to_hex(const T &val, bool add_front_zero = true) {
+std::string to_hex(const T &val) {
    std::stringstream stream;
    stream << std::hex << val;
    std::string result(stream.str());
-   if (add_front_zero) {
+   if (result.size() % 2)
-      if (result.size() % 2)
+      result = "0" + result;
-         result = "0" + result;
-   }
    return result;
 }
 

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/hive/types.hpp

@@ -22,15 +22,15 @@ typedef fc::ecc::private_key private_key_type;
 typedef fc::sha256 chain_id_type;
 typedef std::string account_name_type;
 typedef fc::ripemd160 block_id_type;
-// typedef fc::ripemd160 checksum_type;
+//typedef fc::ripemd160 checksum_type;
 typedef fc::ripemd160 transaction_id_type;
 typedef fc::sha256 digest_type;
 typedef fc::ecc::compact_signature signature_type;
 typedef fc::safe<int64_t> share_type;
-// typedef safe<uint64_t> ushare_type;
+//typedef safe<uint64_t> ushare_type;
-// typedef uint16_t weight_type;
+//typedef uint16_t weight_type;
-// typedef uint32_t contribution_id_type;
+//typedef uint32_t contribution_id_type;
-// typedef fixed_string<32> custom_id_type;
+//typedef fixed_string<32> custom_id_type;
 
 struct public_key_type {
 

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/peerplays_sidechain_plugin.hpp

@@ -13,18 +13,16 @@ class peerplays_sidechain_plugin_impl;
 }
 
 struct son_proposal_type {
-   son_proposal_type(int op, sidechain_type sid, son_id_type son, object_id_type object) :
+   son_proposal_type(int op, son_id_type son, object_id_type object) :
          op_type(op),
-         sidechain(sid),
          son_id(son),
          object_id(object) {
    }
    int op_type;
-   sidechain_type sidechain;
    son_id_type son_id;
    object_id_type object_id;
    bool operator<(const son_proposal_type &other) const {
-      return std::tie(op_type, sidechain, son_id, object_id) < std::tie(other.op_type, other.sidechain, other.son_id, other.object_id);
+      return std::tie(op_type, son_id, object_id) < std::tie(other.op_type, other.son_id, other.object_id);
    }
 };
 
@@ -44,17 +42,16 @@ public:
    std::unique_ptr<detail::peerplays_sidechain_plugin_impl> my;
 
    std::set<chain::son_id_type> &get_sons();
-   const son_id_type get_current_son_id(sidechain_type sidechain);
+   const son_id_type get_current_son_id();
-   const son_object get_current_son_object(sidechain_type sidechain);
+   const son_object get_current_son_object();
    const son_object get_son_object(son_id_type son_id);
-   bool is_active_son(sidechain_type sidechain, son_id_type son_id);
+   bool is_active_son(son_id_type son_id);
    bool is_son_deregistered(son_id_type son_id);
    fc::ecc::private_key get_private_key(son_id_type son_id);
    fc::ecc::private_key get_private_key(chain::public_key_type public_key);
-   void log_son_proposal_retry(sidechain_type sidechain, int op_type, object_id_type object_id);
+   void log_son_proposal_retry(int op_type, object_id_type object_id);
-   bool can_son_participate(sidechain_type sidechain, int op_type, object_id_type object_id);
+   bool can_son_participate(int op_type, object_id_type object_id);
    std::map<sidechain_type, std::vector<std::string>> get_son_listener_log();
-   optional<asset> estimate_withdrawal_transaction_fee(sidechain_type sidechain);
 };
 
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_api.hpp

@@ -26,10 +26,9 @@ public:
    std::shared_ptr<detail::sidechain_api_impl> my;
 
    std::map<sidechain_type, std::vector<std::string>> get_son_listener_log();
-   optional<asset> estimate_withdrawal_transaction_fee(sidechain_type sidechain);
 };
 
 }} // namespace graphene::peerplays_sidechain
 
 FC_API(graphene::peerplays_sidechain::sidechain_api,
-       (get_son_listener_log)(estimate_withdrawal_transaction_fee))
+       (get_son_listener_log))

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler.hpp

@@ -16,17 +16,14 @@
 namespace graphene { namespace peerplays_sidechain {
 
 class sidechain_net_handler {
-protected:
-   sidechain_net_handler(sidechain_type _sidechain, peerplays_sidechain_plugin &_plugin, const boost::program_options::variables_map &options);
-
 public:
+   sidechain_net_handler(peerplays_sidechain_plugin &_plugin, const boost::program_options::variables_map &options);
    virtual ~sidechain_net_handler();
 
-   sidechain_type get_sidechain() const;
+   sidechain_type get_sidechain();
-   std::vector<std::string> get_sidechain_deposit_addresses() const;
+   std::vector<std::string> get_sidechain_deposit_addresses();
-   std::vector<std::string> get_sidechain_withdraw_addresses() const;
+   std::vector<std::string> get_sidechain_withdraw_addresses();
-   std::vector<sidechain_transaction_object> get_sidechain_transaction_objects(sidechain_transaction_status status) const;
+   std::string get_private_key(std::string public_key);
-   std::string get_private_key(std::string public_key) const;
 
    bool proposal_exists(int32_t operation_tag, const object_id_type &object_id, boost::optional<chain::operation &> proposal_op = boost::none);
    bool signer_expected(const sidechain_transaction_object &sto, son_id_type signer);
@@ -53,15 +50,13 @@ public:
 
    void add_to_son_listener_log(std::string trx_id);
    std::vector<std::string> get_son_listener_log();
-   virtual optional<asset> estimate_withdrawal_transaction_fee() const = 0;
 
 protected:
-   const sidechain_type sidechain;
    peerplays_sidechain_plugin &plugin;
    graphene::chain::database &database;
+   sidechain_type sidechain;
 
    bool debug_rpc_calls;
-   bool use_bitcoind_client;
 
    std::map<std::string, std::string> private_keys;
 

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler_bitcoin.hpp

@@ -1,20 +1,18 @@
 #pragma once
 
+#include <graphene/peerplays_sidechain/common/rpc_client.hpp>
 #include <graphene/peerplays_sidechain/sidechain_net_handler.hpp>
 
-#include <mutex>
 #include <string>
 #include <thread>
 #include <zmq_addon.hpp>
 
 #include <boost/signals2.hpp>
 
-#include <fc/network/http/connection.hpp>
+#include <mutex>
 
+#include <fc/network/http/connection.hpp>
 #include <graphene/peerplays_sidechain/bitcoin/bitcoin_address.hpp>
-#include <graphene/peerplays_sidechain/bitcoin/estimate_fee_external.hpp>
-#include <graphene/peerplays_sidechain/bitcoin/libbitcoin_client.hpp>
-#include <graphene/peerplays_sidechain/common/rpc_client.hpp>
 
 namespace graphene { namespace peerplays_sidechain {
 
@@ -25,27 +23,7 @@ public:
    uint64_t amount_;
 };
 
-class btc_txin {
+class bitcoin_rpc_client : public rpc_client {
-public:
-   std::vector<std::string> tx_address;
-   uint64_t tx_amount;
-   uint64_t tx_vout;
-};
-
-class btc_tx {
-public:
-   std::string tx_txid;
-   uint32_t tx_confirmations;
-   std::vector<btc_txin> tx_in_list;
-};
-
-class block_data {
-public:
-   std::string block_hash;
-   libbitcoin::chain::block block;
-};
-
-class bitcoin_client_base {
 public:
    enum class multi_type {
       script,
@@ -63,47 +41,14 @@ public:
       std::string label;
    };
 
-   virtual uint64_t estimatesmartfee(uint16_t conf_target = 1) = 0;
-   virtual std::vector<info_for_vin> getblock(const block_data &block, int32_t verbosity = 2) = 0;
-   virtual btc_tx getrawtransaction(const std::string &txid, const bool verbose = false) = 0;
-   virtual void getnetworkinfo() = 0;
-   virtual std::string getblockchaininfo() = 0;
-   virtual std::vector<btc_txout> listunspent_by_address_and_amount(const std::string &address, double transfer_amount, const uint32_t minconf = 1, const uint32_t maxconf = 9999999) = 0;
-   virtual std::string sendrawtransaction(const std::string &tx_hex) = 0;
-   virtual void importmulti(const std::vector<multi_params> &address_or_script_array, const bool rescan = true) {
-      ;
-   };
-   virtual std::string loadwallet(const std::string &filename) {
-      return "";
-   };
-   virtual std::string walletlock() {
-      return "";
-   };
-   virtual bool walletpassphrase(const std::string &passphrase, uint32_t timeout = 60) {
-      return false;
-   };
-
-   void import_trx_to_memory_pool(const libbitcoin::chain::transaction &trx) {
-      std::unique_lock<std::mutex> lck(libbitcoin_event_mutex);
-      if (trx_memory_pool.size() < MAX_TRXS_IN_MEMORY_POOL) {
-         trx_memory_pool.emplace_back(trx);
-      }
-   }
-
-protected:
-   std::vector<libbitcoin::chain::transaction> trx_memory_pool;
-   std::mutex libbitcoin_event_mutex;
-};
-
-class bitcoin_rpc_client : public bitcoin_client_base, public rpc_client {
 public:
-public:
+   bitcoin_rpc_client(std::string _url, std::string _user, std::string _password, bool _debug_rpc_calls);
-   bitcoin_rpc_client(const std::vector<rpc_credentials> &_credentials, bool _debug_rpc_calls, bool _simulate_connection_reselection);
 
-   uint64_t estimatesmartfee(uint16_t conf_target = 1);
+   std::string createwallet(const std::string &wallet_name);
-   std::vector<info_for_vin> getblock(const block_data &block, int32_t verbosity = 2);
+   uint64_t estimatesmartfee(uint16_t conf_target = 128);
-   btc_tx getrawtransaction(const std::string &txid, const bool verbose = false);
+   std::string getblock(const std::string &block_hash, int32_t verbosity = 2);
-   void getnetworkinfo();
+   std::string getrawtransaction(const std::string &txid, const bool verbose = false);
+   std::string getnetworkinfo();
    std::string getblockchaininfo();
    void importmulti(const std::vector<multi_params> &address_or_script_array, const bool rescan = true);
    std::vector<btc_txout> listunspent(const uint32_t minconf = 1, const uint32_t maxconf = 9999999);
@@ -113,88 +58,37 @@ public:
    std::string walletlock();
    bool walletpassphrase(const std::string &passphrase, uint32_t timeout = 60);
 
-   virtual uint64_t ping(rpc_connection &conn) const override;
-
 private:
    std::string ip;
+   uint32_t rpc_port;
    std::string user;
    std::string password;
    std::string wallet_name;
    std::string wallet_password;
-   uint32_t bitcoin_major_version;
-};
-
-class bitcoin_libbitcoin_client : public bitcoin_client_base, public libbitcoin_client {
-public:
-   bitcoin_libbitcoin_client(std::string url);
-   uint64_t estimatesmartfee(uint16_t conf_target = 1);
-   std::vector<info_for_vin> getblock(const block_data &block, int32_t verbosity = 2);
-   btc_tx getrawtransaction(const std::string &txid, const bool verbose = false);
-   void getnetworkinfo();
-   std::string getblockchaininfo();
-   std::vector<btc_txout> listunspent_by_address_and_amount(const std::string &address, double transfer_amount, const uint32_t minconf = 1, const uint32_t maxconf = 9999999);
-   std::string sendrawtransaction(const std::string &tx_hex);
-
-private:
-   bool is_test_net = false;
-   std::unique_ptr<estimate_fee_external> estimate_fee_ext;
-   uint64_t current_internal_fee = DEAFULT_LIBBITCOIN_TRX_FEE;
 };
 
 // =============================================================================
 
-class zmq_listener_base {
+class zmq_listener {
 public:
-   virtual ~zmq_listener_base(){};
+   zmq_listener(std::string _ip, uint32_t _zmq);
-   zmq_listener_base(std::string _ip, uint32_t _block_zmq_port, uint32_t _trx_zmq_port = 0) {
-      ip = _ip;
-      block_zmq_port = _block_zmq_port;
-      trx_zmq_port = _trx_zmq_port;
-      stopped = false;
-   };
-   virtual void start() = 0;
-   boost::signals2::signal<void(const block_data &)> block_event_received;
-   boost::signals2::signal<void(const libbitcoin::chain::transaction &)> trx_event_received;
-
-protected:
-   std::string ip;
-   uint32_t block_zmq_port;
-   uint32_t trx_zmq_port;
-   std::atomic_bool stopped;
-   std::thread block_thr;
-   std::thread trx_thr;
-};
-
-class zmq_listener : public zmq_listener_base {
-public:
-   zmq_listener(std::string _ip, uint32_t _block_zmq_port, uint32_t _trx_zmq_port = 0);
    virtual ~zmq_listener();
+
    void start();
+   boost::signals2::signal<void(const std::string &)> event_received;
 
 private:
    void handle_zmq();
    std::vector<zmq::message_t> receive_multipart();
 
+   std::string ip;
+   uint32_t zmq_port;
+
    zmq::context_t ctx;
    zmq::socket_t socket;
-};
 
-class zmq_listener_libbitcoin : public zmq_listener_base {
+   std::atomic_bool stopped;
-public:
+   std::thread thr;
-   zmq_listener_libbitcoin(std::string _ip, uint32_t _block_zmq_port = 9093, uint32_t _trx_zmq_port = 9094);
-   virtual ~zmq_listener_libbitcoin();
-   void start();
-
-private:
-   void handle_block();
-   void handle_trx();
-
-   libbitcoin::protocol::zmq::context block_context;
-   libbitcoin::protocol::zmq::socket block_socket;
-   libbitcoin::protocol::zmq::poller block_poller;
-   libbitcoin::protocol::zmq::context trx_context;
-   libbitcoin::protocol::zmq::socket trx_socket;
-   libbitcoin::protocol::zmq::poller trx_poller;
 };
 
 // =============================================================================
@@ -212,19 +106,18 @@ public:
    std::string process_sidechain_transaction(const sidechain_transaction_object &sto);
    std::string send_sidechain_transaction(const sidechain_transaction_object &sto);
    bool settle_sidechain_transaction(const sidechain_transaction_object &sto, asset &settle_amount);
-   virtual optional<asset> estimate_withdrawal_transaction_fee() const override;
 
 private:
-   std::vector<rpc_credentials> _rpc_credentials;
+   std::string ip;
-   std::string libbitcoin_server_ip;
+   uint32_t zmq_port;
-   uint32_t libbitcoin_block_zmq_port;
+   uint32_t rpc_port;
-   uint32_t libbitcoin_trx_zmq_port;
+   std::string rpc_user;
-   uint32_t bitcoin_node_zmq_port;
+   std::string rpc_password;
    std::string wallet_name;
    std::string wallet_password;
 
-   std::unique_ptr<bitcoin_client_base> bitcoin_client;
+   std::unique_ptr<bitcoin_rpc_client> bitcoin_client;
-   std::unique_ptr<zmq_listener_base> listener;
+   std::unique_ptr<zmq_listener> listener;
 
    fc::future<void> on_changed_objects_task;
 
@@ -234,7 +127,7 @@ private:
    std::mutex event_handler_mutex;
    typedef std::lock_guard<decltype(event_handler_mutex)> scoped_lock;
 
-   std::string create_primary_wallet_address(const std::vector<son_sidechain_info> &son_pubkeys);
+   std::string create_primary_wallet_address(const std::vector<son_info> &son_pubkeys);
 
    std::string create_primary_wallet_transaction(const son_wallet_object &prev_swo, std::string new_sw_address);
    std::string create_deposit_transaction(const son_wallet_deposit_object &swdo);
@@ -244,9 +137,9 @@ private:
    std::string sign_transaction(const sidechain_transaction_object &sto);
    std::string send_transaction(const sidechain_transaction_object &sto);
 
-   void block_handle_event(const block_data &event_data);
+   void handle_event(const std::string &event_data);
-   void trx_handle_event(const libbitcoin::chain::transaction &event_data);
    std::string get_redeemscript_for_userdeposit(const std::string &user_address);
+   std::vector<info_for_vin> extract_info_from_block(const std::string &_block);
    void on_changed_objects(const vector<object_id_type> &ids, const flat_set<account_id_type> &accounts);
    void on_changed_objects_cb(const vector<object_id_type> &ids, const flat_set<account_id_type> &accounts);
 };

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler_ethereum.hpp

@@ -4,7 +4,6 @@
 
 #include <string>
 
-#include <boost/bimap.hpp>
 #include <boost/signals2.hpp>
 
 #include <graphene/peerplays_sidechain/common/rpc_client.hpp>
@@ -14,30 +13,24 @@ namespace graphene { namespace peerplays_sidechain {
 
 class ethereum_rpc_client : public rpc_client {
 public:
-   ethereum_rpc_client(const std::vector<rpc_credentials> &credentials, bool debug_rpc_calls, bool simulate_connection_reselection);
+   ethereum_rpc_client(const std::string &url, const std::string &user_name, const std::string &password, bool debug_rpc_calls);
 
-   std::string eth_blockNumber();
+   std::string admin_node_info();
    std::string eth_get_block_by_number(std::string block_number, bool full_block);
    std::string eth_get_logs(std::string wallet_contract_address);
-   std::string eth_chainId();
    std::string net_version();
    std::string eth_get_transaction_count(const std::string &params);
    std::string eth_gas_price();
-   std::string eth_estimateGas(const std::string &params);
 
    std::string get_chain_id();
    std::string get_network_id();
    std::string get_nonce(const std::string &address);
    std::string get_gas_price();
    std::string get_gas_limit();
-   std::string get_estimate_gas(const std::string &params);
 
    std::string eth_send_transaction(const std::string &params);
    std::string eth_send_raw_transaction(const std::string &params);
    std::string eth_get_transaction_receipt(const std::string &params);
-   std::string eth_get_transaction_by_hash(const std::string &params);
-
-   virtual uint64_t ping(rpc_connection &conn) const override;
 };
 
 class sidechain_net_handler_ethereum : public sidechain_net_handler {
@@ -53,20 +46,19 @@ public:
    std::string process_sidechain_transaction(const sidechain_transaction_object &sto);
    std::string send_sidechain_transaction(const sidechain_transaction_object &sto);
    bool settle_sidechain_transaction(const sidechain_transaction_object &sto, asset &settle_amount);
-   virtual optional<asset> estimate_withdrawal_transaction_fee() const override;
 
 private:
-   std::vector<rpc_credentials> _rpc_credentials;
+   std::string rpc_url;
+   std::string rpc_user;
+   std::string rpc_password;
    std::string wallet_contract_address;
-   using bimap_type = boost::bimap<std::string, std::string>;
-   bimap_type erc20_addresses;
 
    ethereum_rpc_client *rpc_client;
 
    ethereum::chain_id_type chain_id;
    ethereum::network_id_type network_id;
 
-   std::string create_primary_wallet_transaction(const std::vector<son_sidechain_info> &son_pubkeys, const std::string &object_id);
+   std::string create_primary_wallet_transaction(const std::vector<son_info> &son_pubkeys, const std::string &object_id);
    std::string create_deposit_transaction(const son_wallet_deposit_object &swdo);
    std::string create_withdrawal_transaction(const son_wallet_withdraw_object &swwo);
 
@@ -77,7 +69,7 @@ private:
    boost::signals2::signal<void(const std::string &)> event_received;
    void schedule_ethereum_listener();
    void ethereum_listener_loop();
-   void handle_event(const std::string &block_number);
+   void handle_event(const std::string &event_data);
 };
 
 }} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler_factory.hpp

@@ -1,23 +0,0 @@
-#pragma once
-
-#include <graphene/chain/sidechain_defs.hpp>
-#include <graphene/peerplays_sidechain/peerplays_sidechain_plugin.hpp>
-#include <graphene/peerplays_sidechain/sidechain_net_handler.hpp>
-
-#include <vector>
-
-#include <boost/program_options.hpp>
-
-namespace graphene { namespace peerplays_sidechain {
-
-class sidechain_net_handler_factory {
-public:
-   sidechain_net_handler_factory(peerplays_sidechain_plugin &_plugin);
-
-   std::unique_ptr<sidechain_net_handler> create_handler(sidechain_type sidechain, const boost::program_options::variables_map &options) const;
-
-private:
-   peerplays_sidechain_plugin &plugin;
-};
-
-}} // namespace graphene::peerplays_sidechain

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler_hive.hpp

@@ -13,7 +13,7 @@ namespace graphene { namespace peerplays_sidechain {
 
 class hive_rpc_client : public rpc_client {
 public:
-   hive_rpc_client(const std::vector<rpc_credentials> &credentials, bool debug_rpc_calls, bool simulate_connection_reselection);
+   hive_rpc_client(const std::string &url, const std::string &user_name, const std::string &password, bool debug_rpc_calls);
 
    std::string account_history_api_get_transaction(std::string transaction_id);
    std::string block_api_get_block(uint32_t block_number);
@@ -30,8 +30,6 @@ public:
    std::string get_head_block_time();
    std::string get_is_test_net();
    std::string get_last_irreversible_block_num();
-
-   virtual uint64_t ping(rpc_connection &conn) const override;
 };
 
 class sidechain_net_handler_hive : public sidechain_net_handler {
@@ -47,11 +45,11 @@ public:
    std::string process_sidechain_transaction(const sidechain_transaction_object &sto);
    std::string send_sidechain_transaction(const sidechain_transaction_object &sto);
    bool settle_sidechain_transaction(const sidechain_transaction_object &sto, asset &settle_amount);
-   virtual optional<asset> estimate_withdrawal_transaction_fee() const override;
 
 private:
-   std::vector<rpc_credentials> _rpc_credentials;
+   std::string rpc_url;
-
+   std::string rpc_user;
+   std::string rpc_password;
    std::string wallet_account_name;
 
    hive_rpc_client *rpc_client;

libraries/plugins/peerplays_sidechain/include/graphene/peerplays_sidechain/sidechain_net_handler_peerplays.hpp

@@ -19,7 +19,6 @@ public:
    std::string process_sidechain_transaction(const sidechain_transaction_object &sto);
    std::string send_sidechain_transaction(const sidechain_transaction_object &sto);
    bool settle_sidechain_transaction(const sidechain_transaction_object &sto, asset &settle_amount);
-   virtual optional<asset> estimate_withdrawal_transaction_fee() const override;
 
 private:
 };