Do not decrease Peerplays balance if withdraw tx is failed in sidechain #100

New issue

Closed

opened 2021-05-13 11:29:32 +00:00 by gladcow · 8 comments

gladcow commented

2021-05-13 11:29:32 +00:00

(Migrated from gitlab.com)

Now Peerplays account balance is decreased afterwithdraw HIVE transaction inspite of the failure to broadcast the transaction in Hive network and move the balance to the Hive account
Current error message:
1605710ms th_a rpc_client.cpp:88 send_post_request ] ### Response: {"jsonrpc":"2.0","error":{"code":-32000,"message":"missing required active authority:Missing Active Authority son-account","data":{"code":3010000,"name":"tx_missing_active_auth","message":"missing required active authority","stack":[{"context":{"level":"error","file":"transaction_util.hpp","line":86,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"Missing Active Authority ${id}","data":{"id":"son-account","auth":{"weight_threshold":11,"account_auths":[["sonaccount01",1],["sonaccount02",1],["sonaccount03",1],["sonaccount04",1],["sonaccount05",1],["sonaccount06",1],["sonaccount07",1],["sonaccount08",1],["sonaccount09",1],["sonaccount10",1],["sonaccount11",1],["sonaccount12",1],["sonaccount13",1],["sonaccount14",1],["sonaccount15",1]],"key_auths":[]},"owner":{"weight_threshold":1,"account_auths":[],"key_auths":[["TST8kLKo9seYaJvuQSdwFd2YAi29VRdCVeLgd3E8A7PUFaKosYRGL",1]]}}},{"context":{"level":"warn","file":"transaction_util.hpp","line":103,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"auth_containers":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"sigs":["TST52QZ71ZHGyx5XZkmjm9JGwvsk8HXaK59q1TkiwyvqdavDrET8Z","TST5EzV5Angy3uDCX7xwKNCfJqeva94k5AQj5ax6tNx1su52sU7JF","TST5zUt9ek3BaygipHDWFgPoCXnYQbsFNQUhc6S72ifazyqy3fRQ4","TST6cfN7qqFGxgKR7xyCv4522XL3sh88D86XnuV3hQXHdDKuPRwPe","TST6mf9qCd9iLdTbhNGXRWrmgw8kHKfRhtCHdHfd8pTW4vHicvhfQ","TST6tVhZ1T84P7BNhLwZoBgKiHAwR91Ufr1UcVdu5YD6ygTQPKzFF","TST78V6gkr4awmbpkhzG6dgjmuLomt6bPpu2WzK4yFHVruXWa9uwP","TST7HZfbBs7VyvfxjeAA1zyeXAfTKj98cZkWDXSm5vQhniXSgTVa8","TST7Z9qyg3jzXc3SBZphqrGnme6UQ7XGf4Vib4GRRS8NTm5afkyRE","TST8GMQufkL4f8N6rK29h93yHVhXioxHsV1LjxYVpXRqRZBS5qEo5","TST8QHapvbso88AF3ocYiSdrAaZBtJmPtTtB8drQJhQatqSnNvsW3"]}},{"context":{"level":"warn","file":"transaction.cpp","line":232,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"*this":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}},{"context":{"level":"warn","file":"database.cpp","line":4317,"method":"_apply_transaction","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"trx":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}},{"context":{"level":"warn","file":"database.cpp","line":1224,"method":"push_transaction","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"trx":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}}]}},"id":4621}

Now Peerplays account balance is decreased afterwithdraw HIVE transaction inspite of the failure to broadcast the transaction in Hive network and move the balance to the Hive account Current error message: `1605710ms th_a rpc_client.cpp:88 send_post_request ] ### Response: {"jsonrpc":"2.0","error":{"code":-32000,"message":"missing required active authority:Missing Active Authority son-account","data":{"code":3010000,"name":"tx_missing_active_auth","message":"missing required active authority","stack":[{"context":{"level":"error","file":"transaction_util.hpp","line":86,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"Missing Active Authority ${id}","data":{"id":"son-account","auth":{"weight_threshold":11,"account_auths":[["sonaccount01",1],["sonaccount02",1],["sonaccount03",1],["sonaccount04",1],["sonaccount05",1],["sonaccount06",1],["sonaccount07",1],["sonaccount08",1],["sonaccount09",1],["sonaccount10",1],["sonaccount11",1],["sonaccount12",1],["sonaccount13",1],["sonaccount14",1],["sonaccount15",1]],"key_auths":[]},"owner":{"weight_threshold":1,"account_auths":[],"key_auths":[["TST8kLKo9seYaJvuQSdwFd2YAi29VRdCVeLgd3E8A7PUFaKosYRGL",1]]}}},{"context":{"level":"warn","file":"transaction_util.hpp","line":103,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"auth_containers":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"sigs":["TST52QZ71ZHGyx5XZkmjm9JGwvsk8HXaK59q1TkiwyvqdavDrET8Z","TST5EzV5Angy3uDCX7xwKNCfJqeva94k5AQj5ax6tNx1su52sU7JF","TST5zUt9ek3BaygipHDWFgPoCXnYQbsFNQUhc6S72ifazyqy3fRQ4","TST6cfN7qqFGxgKR7xyCv4522XL3sh88D86XnuV3hQXHdDKuPRwPe","TST6mf9qCd9iLdTbhNGXRWrmgw8kHKfRhtCHdHfd8pTW4vHicvhfQ","TST6tVhZ1T84P7BNhLwZoBgKiHAwR91Ufr1UcVdu5YD6ygTQPKzFF","TST78V6gkr4awmbpkhzG6dgjmuLomt6bPpu2WzK4yFHVruXWa9uwP","TST7HZfbBs7VyvfxjeAA1zyeXAfTKj98cZkWDXSm5vQhniXSgTVa8","TST7Z9qyg3jzXc3SBZphqrGnme6UQ7XGf4Vib4GRRS8NTm5afkyRE","TST8GMQufkL4f8N6rK29h93yHVhXioxHsV1LjxYVpXRqRZBS5qEo5","TST8QHapvbso88AF3ocYiSdrAaZBtJmPtTtB8drQJhQatqSnNvsW3"]}},{"context":{"level":"warn","file":"transaction.cpp","line":232,"method":"verify_authority","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"*this":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}},{"context":{"level":"warn","file":"database.cpp","line":4317,"method":"_apply_transaction","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"trx":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}},{"context":{"level":"warn","file":"database.cpp","line":1224,"method":"push_transaction","hostname":"","timestamp":"2021-05-12T13:26:45"},"format":"","data":{"trx":{"ref_block_num":1885,"ref_block_prefix":4115378905,"expiration":"2021-05-12T13:28:09","operations":[{"type":"transfer_operation","value":{"from":"son-account","to":"account05","amount":{"amount":"50000","precision":3,"nai":"@@000000013"},"memo":""}}],"extensions":[],"signatures":["20105cdc3bea4d4c4a3def67d67ed4262f9f2b0eac6cf723bbd5cac032c82f124e0794570aa2cde0bb2868c088f94380442b65ef018e7ebff8aaf4a3448343c59b","20417edf54e96b39eafd749ea8bb23a850bfed842c3e74a9ddb5c5a264fd17ec3c1ea46a00851c7c1e9c8275c1b8c3c6190bf98a08f8aa2a2fda85bcf969dc1cd0","203d1d258a53e21c6e45e1f72642179d0684ee32b5a620a4c3445f8899020f10af1616222fd1d34ab4553b8a7f7b7927e3eff115bde3439fbd31ff3a3fc3bd58cf","1f5c61a162aac83a867eb594b1309e91952557c289ad80419c8d8c561a73b898b96dd3d548026c336c23ef07721b907fd3f67850c2594658f27ee33895d1f8ef24","206bbeab4fdbb22852f1b5ef203cff7367364f631cccdd7e64746dec38913b1af11ee86e97271352fd76cae94c4871faf0f5f82ff8174f6ed5a9630c0a53987435","2028c2dc026a1eee8929affda8586b8a3f92f682b21664017ed114c98a842e54f50fb0d181a88cf357348665d324418be2ca809c54785395f703ee1571a24dcf63","1f2885b1bdf75ebb417216f3cd9ec3c495413a31897253136ab54b47046148323c4ee0f123ed863cd1961a0488da9783772821c4dd24b99b2547c10e8cdc86f17c","1f2fc5669ea24939241dfc09f7a131f7f63df1513abc6a75773875d9a25806a00f1173afbe56932743e84cf1efe5ff1c3e5ce752b127cce29665c8cdc171c0a0c2","1f777573318bfee24d4af4931ec7a9114e60366788e463b153f0c7e5383c8199623bb2679ee76a7f240403df7b5d25b1835bc9886e7b23208322fda768380cffcf","204f9d1323e9db5dccad6042edc400e5dbb606b2ce533e9dc7c16e8e8bc2f4152015ec5013cdaf714f9b3f2d82501e66298792554d81f5d14070dd081bbd3c56b2","204a4f734e63c459311ed75b88a545870decde05a595398fa3782779c94da023d339dcdd013e83e1ccab9d133d35c6a0af85a2a4fe1f52a4678079e77354933ae1"]}}}]}},"id":4621}`

gladcow commented

2021-05-13 11:29:32 +00:00

(Migrated from gitlab.com)

added to epic &80

serkixenos commented

2021-05-16 22:37:01 +00:00

(Migrated from gitlab.com)

This is not a bug, its more like incomplete feature at this moment. Transaction settling is part of proposal approvals. Proposal approvals will verify whether the transaction is actually processed, and check all transaction properties, to make sure that transaction fully matches the one that should be executed.

Look at the Bitcoin SON code for reference on transaction settling.

serkixenos commented

2021-05-16 23:28:04 +00:00

(Migrated from gitlab.com)

Regarding "Missing Active Authority son-account" - this means that signatures are not correct. We need to double check them first.

Expected nai is 21, but here its 13.

Regarding "Missing Active Authority son-account" - this means that signatures are not correct. We need to double check them first. Expected nai is 21, but here its 13.

serkixenos commented

2021-05-17 14:08:36 +00:00

(Migrated from gitlab.com)

assigned to @bobinson and unassigned @gladcow

serkixenos commented

2021-05-17 14:15:34 +00:00

(Migrated from gitlab.com)

changed time estimate to 16h

serkixenos commented

2021-06-29 22:11:43 +00:00

(Migrated from gitlab.com)

assigned to @prandnum

serkixenos commented

2021-06-29 22:12:31 +00:00

(Migrated from gitlab.com)

@prandnum Do you agree to close this one as an obsolete?

prandnum commented

2021-06-30 20:34:42 +00:00

(Migrated from gitlab.com)

Tried some negative scenarios, hive chain and cli wallets were brought down and the withdrawal was attempted and HIVE accounts got properly credited once the communication was re-established.

prandnum (Migrated from gitlab.com) closed this issue

2021-06-30 20:34:43 +00:00