Port mandatory fc and network changes for websocket, api connection, state, thread and future changes #15

New issue

Closed

opened 2020-07-09 14:15:21 +00:00 by pblockc · 7 comments

pblockc commented

2020-07-09 14:15:21 +00:00

(Migrated from gitlab.com)

Origin: https://gitlab.com/PBSA/PeerplaysIO/tools-libs/peerplays-fc/-/merge_requests/17#note_376021642

The gap between bitshares-fc and peerplays-fc is huge and require considerable effort for porting and testing. IMHO, first port all mandatory changes that needs to address current issues.

Based on my analysis, the below PR's needs to be ported to fix issues in websocket, api connection, state, thread and future.

Note: The effort would be between 80-100hrs as there might be chances to get some other relevant changes forcefully to fix compilation/dependency problems.

Origin: https://gitlab.com/PBSA/PeerplaysIO/tools-libs/peerplays-fc/-/merge_requests/17#note_376021642 The gap between bitshares-fc and peerplays-fc is huge and require considerable effort for porting and testing. IMHO, first port all mandatory changes that needs to address current issues. Based on my analysis, the below PR's needs to be ported to fix issues in websocket, api connection, state, thread and future. **Note: The effort would be between 80-100hrs as there might be chances to get some other relevant changes forcefully to fix compilation/dependency problems.** - https://github.com/bitshares/bitshares-core/commit/6f8a393bd94490790e0fce947eebfb2acfe90f2e - https://github.com/bitshares/bitshares-core/pull/1854 - https://github.com/bitshares/bitshares-core/commit/2389c81893074de8ff7d82ade0b8ee68f9a9889e - https://github.com/bitshares/bitshares-core/pull/1782 - - https://github.com/bitshares/bitshares-fc/pull/11 (big list of changes but recommnded) - https://github.com/bitshares/bitshares-fc/pull/29 (add complete websocket test) - https://github.com/bitshares/bitshares-fc/pull/62 - https://github.com/bitshares/bitshares-fc/pull/126 - https://github.com/bitshares/bitshares-fc/pull/110 - https://github.com/bitshares/bitshares-fc/pull/106 - https://github.com/bitshares/bitshares-fc/pull/108 - https://github.com/bitshares/bitshares-fc/pull/107 - https://github.com/bitshares/bitshares-fc/pull/119(big list of changes) - https://github.com/bitshares/bitshares-fc/pull/136 - https://github.com/bitshares/bitshares-fc/pull/142 - https://github.com/bitshares/bitshares-fc/pull/134 - https://github.com/bitshares/bitshares-fc/pull/201 - https://github.com/bitshares/bitshares-fc/pull/205 - - https://github.com/bitshares/bitshares-fc/commit/06f88979a09364ff9e88c1de681786c79ed1ca8b#diff-4252eaec0048dfb15e2f84a88c2d92be(Resolve crash in API node) - https://github.com/bitshares/bitshares-fc/pull/119

pblockc commented

2020-07-09 14:15:56 +00:00

(Migrated from gitlab.com)

changed the description

bobinson commented

2020-07-10 12:46:03 +00:00

(Migrated from gitlab.com)

changed time estimate to 2w

bobinson commented

2020-07-15 18:47:00 +00:00

(Migrated from gitlab.com)

@pblockc - This proposal is approved. Please fill the following form and share with support AT pbsa.info

Peerplay.io_Propsal_Template.pdf

@pblockc - This proposal is approved. Please fill the following form and share with support AT pbsa.info [Peerplay.io_Propsal_Template.pdf](/uploads/9e7001dfaa576928e8c9d4e21271796b/Peerplay.io_Propsal_Template.pdf)

pblockc commented

2020-07-15 20:02:03 +00:00

(Migrated from gitlab.com)

Thank you @bobinson, I will share the form with the support team.

pblockc commented

2020-08-06 13:06:54 +00:00

(Migrated from gitlab.com)

mentioned in merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!18

pblockc commented

2020-08-11 19:14:55 +00:00

(Migrated from gitlab.com)

All the required changes has been brought in. Since there are too many dependencies, websocket related stuff has been addressed.

New branch for blockchain updates: ws-updates

fc PR: https://gitlab.com/PBSA/PeerplaysIO/tools-libs/peerplays-fc/-/merge_requests/18

All the required changes has been brought in. Since there are too many dependencies, websocket related stuff has been addressed. New branch for blockchain updates: ws-updates fc PR: https://gitlab.com/PBSA/PeerplaysIO/tools-libs/peerplays-fc/-/merge_requests/18

pblockc commented

2020-08-14 19:19:59 +00:00

(Migrated from gitlab.com)

mentioned in merge request !1

pblockc (Migrated from gitlab.com) closed this issue

2020-09-04 13:10:04 +00:00