Peerplays_Blockchain/peerplays_migrated

Fork 0

[SON for Hive] - Deposit from any Hive account to any Peerplays account #152

New issue

Closed

opened 2021-07-26 10:54:09 +00:00 by serkixenos · 13 comments

serkixenos commented

2021-07-26 10:54:09 +00:00

(Migrated from gitlab.com)

Deposit process should be improved, to allow depositing funds from any Hive account to any Peerplays account.

We can do this by adding information about actual receiver to the memo field.

Deposit process should be improved, to allow depositing funds from any Hive account to any Peerplays account. We can do this by adding information about actual receiver to the memo field.

serkixenos commented

2021-07-26 10:54:09 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

serkixenos commented

2021-07-26 11:35:44 +00:00

(Migrated from gitlab.com)

changed time estimate to 24h

serkixenos commented

2021-07-27 21:45:55 +00:00

(Migrated from gitlab.com)

To test, add memo to the transfer command in Hive cli_wallet, in the following format "son-payment-to: ACCOUNT_NAME".
In SON foir Hive test environment, command would be:

transfer account01 son-account "100.000 TESTS" "son-payment-to: account02" true

This will assign payment from account01 to account02, and SONs will transfer the funds to account02.

To test, add memo to the transfer command in Hive cli_wallet, in the following format "son-payment-to: ACCOUNT_NAME". In SON foir Hive test environment, command would be: ``` transfer account01 son-account "100.000 TESTS" "son-payment-to: account02" true ``` This will assign payment from account01 to account02, and SONs will transfer the funds to account02.

serkixenos commented

2021-07-29 12:32:37 +00:00

(Migrated from gitlab.com)

changed time estimate to 16h

prandnum commented

2021-08-02 16:59:37 +00:00

(Migrated from gitlab.com)

able to transfer from HIVE account02 to account07 in peerplays account.

transfer account01 son-account "123.000 TESTS" "son-payment-to: account07" true
transfer account01 son-account "321.000 TBD" "son-payment-to: account07" true

@serkixenos @bobinson - Doesn't more characters in the memo field attract more fees? if no then no issues else we can just restrict to username ie in this case, from 25 character to 9 son-payment-to: account07 ---> account07

able to transfer from HIVE account02 to account07 in peerplays account. transfer account01 son-account "123.000 TESTS" "son-payment-to: account07" true transfer account01 son-account "321.000 TBD" "son-payment-to: account07" true @serkixenos @bobinson - Doesn't more characters in the memo field attract more fees? if no then no issues else we can just restrict to username ie in this case, from 25 character to 9 son-payment-to: account07 ---> account07

serkixenos commented

2021-08-02 17:07:22 +00:00

(Migrated from gitlab.com)

Regarding fees, yes, it does.

This way we explicitly state that we want our memo message to be interpreted as an instruction to redirect the payment to a specific account. The idea behind it is to prevent interpreting ANY memo message as an account name.

Regarding fees, yes, it does. This way we explicitly state that we want our memo message to be interpreted as an instruction to redirect the payment to a specific account. The idea behind it is to prevent interpreting ANY memo message as an account name.

prandnum commented

2021-08-02 17:27:25 +00:00

(Migrated from gitlab.com)

thanks. @bobinson please provide your view.

bobinson commented

2021-08-03 06:55:13 +00:00

(Migrated from gitlab.com)

I am confused about the account names.

account02.hive (in Hive), account07.ppy (in peerplays)
account01.hive wants to transfer 123 TESTS to account02.hive

Assuming the above are the accounts involved, the following can be the command to transfer funds. This method is known to Steem, Hive, Peerplays, Bitshares and EOS users.

transfer account01.hive son-account "123.000 TESTS" "account07.ppy" true transfer account01.hive son-account "321.000 TBD" "account07.ppy" true

@prandnum - it will be good to use self-explained address names.

For example, transfer from Steem / Hive to Binance : https://steemit.com/cryptocurrency/@fernwehninja/a-quick-guide-on-how-to-transfer-or-deposit-steem-to-binance

@serkixenos - lets not add additional text and we will live with only the account name. ie, we should not be using "son-payment-to:" ... The idea of this providing more for us to identity the deposit it good but its not used by the Bitshares/EOS/Steem/Hive community right now and will create confusion.

I am confused about the account names. - account02.hive (in Hive), account07.ppy (in peerplays) - account01.hive wants to transfer 123 TESTS to account02.hive Assuming the above are the accounts involved, the following can be the command to transfer funds. This method is known to Steem, Hive, Peerplays, Bitshares and EOS users. ``` transfer account01.hive son-account "123.000 TESTS" "account07.ppy" true transfer account01.hive son-account "321.000 TBD" "account07.ppy" true ``` @prandnum - it will be good to use self-explained address names. For example, transfer from Steem / Hive to Binance : https://steemit.com/cryptocurrency/@fernwehninja/a-quick-guide-on-how-to-transfer-or-deposit-steem-to-binance @serkixenos - lets not add additional text and we will live with only the account name. ie, we should not be using "`son-payment-to:`" ... The idea of this providing more for us to identity the deposit it good but its not used by the Bitshares/EOS/Steem/Hive community right now and will create confusion.

prandnum commented

2021-08-04 12:02:57 +00:00

(Migrated from gitlab.com)

moving back to the pending state for implementing Bobinsons comment.

serkixenos commented

2021-08-05 12:38:03 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and unassigned @serkixenos

prandnum commented

2021-08-06 11:28:07 +00:00

(Migrated from gitlab.com)

works as per requirement.