[SON for Hive] : end user documentation voting for SON #156

Closed
opened 2021-07-29 06:22:41 +00:00 by bobinson · 21 comments
bobinson commented 2021-07-29 06:22:41 +00:00 (Migrated from gitlab.com)
  • End user documentation based on #154 to use #155 must be provided.
  • This can be based on the cli_wallet method
- End user documentation based on #154 to use #155 must be provided. - This can be based on the `cli_wallet` method
bobinson commented 2021-07-29 06:22:41 +00:00 (Migrated from gitlab.com)

assigned to @Hiltos1

assigned to @Hiltos1
Hiltos1 commented 2021-08-16 14:07:21 +00:00 (Migrated from gitlab.com)

changed time estimate to 8h

changed time estimate to 8h
Hiltos1 commented 2021-08-30 13:12:33 +00:00 (Migrated from gitlab.com)

assigned to @bobinson

assigned to @bobinson
Hiltos1 commented 2021-08-30 13:12:43 +00:00 (Migrated from gitlab.com)

@bobinson,
A function does not yet exist for voting on SONs per sidechain. I can document voting for SONs as it currently exists, but I'll have to revisit this when it changes in the next hard-fork.

Should we:

  • wait for the hard-fork to document voting for SONs per sidechain?
  • OR
  • document the existing voting and update the doc after the hard-fork?

Thanks,
Sean

@bobinson, A function does not yet exist for voting on SONs **per sidechain**. I can document voting for SONs as it currently exists, but I'll have to revisit this when it changes in the next hard-fork. Should we: - wait for the hard-fork to document voting for SONs per sidechain? - OR - document the existing voting and update the doc after the hard-fork? Thanks, Sean
bobinson commented 2021-08-31 11:19:19 +00:00 (Migrated from gitlab.com)

@Hiltos1 - lets keep this on hold until we have the feature completed.

@Hiltos1 - lets keep this on hold until we have the feature completed.
Hiltos1 commented 2021-08-31 20:06:26 +00:00 (Migrated from gitlab.com)

Removing from the milestone until the feature is ready to document.

Removing from the milestone until the feature is ready to document.
hbelakon commented 2021-10-13 03:40:11 +00:00 (Migrated from gitlab.com)

added to epic &113

added to epic &113
bobinson commented 2023-07-24 09:11:58 +00:00 (Migrated from gitlab.com)

assigned to @Bharathi-Chandrasekaran and unassigned @bobinson

assigned to @Bharathi-Chandrasekaran and unassigned @bobinson
bobinson commented 2023-07-24 09:12:00 +00:00 (Migrated from gitlab.com)

Please check whether this is still relevant.

Please check whether this is still relevant.
Bharathi-Chandrasekaran commented 2023-09-13 12:31:34 +00:00 (Migrated from gitlab.com)

The SON voting features are available and hence moving from Hold to accepted state.

The SON voting features are available and hence moving from Hold to accepted state.
Bharathi-Chandrasekaran commented 2023-09-20 14:09:08 +00:00 (Migrated from gitlab.com)

Hi @vampik and @serkixenos,

Could you please review and provide your feedback/updates/changes for the updated CLI commands SON voting document?

https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/183/the-basics/using-the-cli-wallet/cli-commands-for-sons/updated-cli-commands-for-son-voting

Hi @vampik and @serkixenos, Could you please review and provide your feedback/updates/changes for the updated CLI commands SON voting document? https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/183/the-basics/using-the-cli-wallet/cli-commands-for-sons/updated-cli-commands-for-son-voting
vampik commented 2023-09-21 04:24:30 +00:00 (Migrated from gitlab.com)

I don't have access to this document.

I don't have access to this document.
Bharathi-Chandrasekaran commented 2023-09-21 12:06:36 +00:00 (Migrated from gitlab.com)

Hi @Hiltos1 ,

Could you please provide access for reviewing?

Hi @Hiltos1 , Could you please provide access for reviewing?
serkixenos commented 2023-09-21 12:16:14 +00:00 (Migrated from gitlab.com)

Description of update_son_votes parameter desired_number_of_sons is not correct. Using this command, user is able to vote for/suggest number of active SONs for a sidechain. The parameter desired_number_of_sons is used for voting for/suggesting the number of active SONs.

Also, it would be nice to have more example commands with short explanations:

Account named account01 votes for account named sonaccount01 to become an active SON for bitcoin sidechain

vote_for_son account01 sonaccount01 bitcoin true true

Account named account01 revokes its vote for account named sonaccount01 to become an active SON for bitcoin sidechain

vote_for_son account01 sonaccount01 bitcoin false true

Account named account02 votes for account named sonaccount03 to become an active SON for ethereum sidechain

vote_for_son account02 sonaccount03 ethereum true true

Account named account02 revokes its vote for account named sonaccount03 to become an active SON for ethereum sidechain

vote_for_son account02 sonaccount03 ethereum false true

Account named account05 votes for accounts named sonaccount01, sonaccount02, sonaccount03, sonaccount04, sonaccount05, revokes its votes for accounts named sonaccount06, sonaccount07, to become an active SONs, and votes for the total number of 5 active SONs, for hive network

update_son_votes account05 [sonaccount01, sonaccount02, sonaccount03, sonaccount04, sonaccount05] [sonaccount06, sonaccount07] hive 5 true
Description of update_son_votes parameter desired_number_of_sons is not correct. Using this command, user is able to vote for/suggest number of active SONs for a sidechain. The parameter desired_number_of_sons is used for voting for/suggesting the number of active SONs. Also, it would be nice to have more example commands with short explanations: Account named account01 votes for account named sonaccount01 to become an active SON for bitcoin sidechain ``` vote_for_son account01 sonaccount01 bitcoin true true ``` Account named account01 revokes its vote for account named sonaccount01 to become an active SON for bitcoin sidechain ``` vote_for_son account01 sonaccount01 bitcoin false true ``` Account named account02 votes for account named sonaccount03 to become an active SON for ethereum sidechain ``` vote_for_son account02 sonaccount03 ethereum true true ``` Account named account02 revokes its vote for account named sonaccount03 to become an active SON for ethereum sidechain ``` vote_for_son account02 sonaccount03 ethereum false true ``` Account named account05 votes for accounts named sonaccount01, sonaccount02, sonaccount03, sonaccount04, sonaccount05, revokes its votes for accounts named sonaccount06, sonaccount07, to become an active SONs, and votes for the total number of 5 active SONs, for hive network ``` update_son_votes account05 [sonaccount01, sonaccount02, sonaccount03, sonaccount04, sonaccount05] [sonaccount06, sonaccount07] hive 5 true ```
Bharathi-Chandrasekaran commented 2023-09-22 12:20:53 +00:00 (Migrated from gitlab.com)

Hi @serkixenos ,
Thanks for the review. I will update the changes and upload for review.

Hi @serkixenos , Thanks for the review. I will update the changes and upload for review.
Bharathi-Chandrasekaran commented 2023-09-26 13:23:20 +00:00 (Migrated from gitlab.com)
Hi @serkixenos, I have updated the document. Please review and provide your feedback. https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/183/the-basics/using-the-cli-wallet/cli-commands-for-sons/updated-cli-commands-for-son-voting
serkixenos commented 2023-09-26 17:25:47 +00:00 (Migrated from gitlab.com)

LGTM

LGTM
Bharathi-Chandrasekaran commented 2023-09-26 17:27:54 +00:00 (Migrated from gitlab.com)

Thanks for the review @serkixenos.

Thanks for the review @serkixenos.
vampik commented 2023-09-26 18:16:41 +00:00 (Migrated from gitlab.com)

Everything looks fine for me.

Everything looks fine for me.
Bharathi-Chandrasekaran commented 2023-09-26 18:59:31 +00:00 (Migrated from gitlab.com)

Thanks for your review @vampik.

Thanks for your review @vampik.
Bharathi-Chandrasekaran commented 2023-09-26 19:09:40 +00:00 (Migrated from gitlab.com)

The document is merged, please find the link to the document below:
https://infra.peerplays.com/the-basics/using-the-cli-wallet/cli-commands-for-sons/updated-cli-commands-for-son-voting

Hence closing the issue.

The document is merged, please find the link to the document below: https://infra.peerplays.com/the-basics/using-the-cli-wallet/cli-commands-for-sons/updated-cli-commands-for-son-voting Hence closing the issue.
Bharathi-Chandrasekaran (Migrated from gitlab.com) closed this issue 2023-09-26 19:09:41 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#156
No description provided.