bitcoin deposit address not generated for peerplays account

prandnum commented

2021-08-11 19:53:03 +00:00

(Migrated from gitlab.com)

After running the SON HIVE QA setup, I don't see the bitcoin deposit address generated for accounts, in this example account01. It is the same for all the 16 accounts(account01-account16)

unlocked >>> get_sidechain_addresses_by_account account01
get_sidechain_addresses_by_account account01
[{
    "id": "1.38.0",
    "sidechain_address_account": "1.2.52",
    "sidechain": "bitcoin",
    "deposit_public_key": "0368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cd",
    "deposit_address": "",
    "deposit_address_data": "", 
    "withdraw_public_key": "02743d4f24f88095de7921b8a8486cb46f009b7c034daa931821fb688c9c1e42a2",
    "withdraw_address": "2MtTPtraZawsvNGc8eCdx98hXbi4gaYy8L6",
    "valid_from": "2021-08-07T12:56:30",
    "expires": "2106-02-07T06:28:15"
  },{
    "id": "1.38.16",
    "sidechain_address_account": "1.2.52",
    "sidechain": "hive",
    "deposit_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s",
    "deposit_address": "account01",
    "deposit_address_data": "",
    "withdraw_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s",
    "withdraw_address": "account01",
    "valid_from": "2021-08-07T12:56:30",
    "expires": "2106-02-07T06:28:15"
  },{
    "id": "1.38.32",
    "sidechain_address_account": "1.2.52",
    "sidechain": "peerplays",
    "deposit_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "deposit_address": "account01",
    "deposit_address_data": "",
    "withdraw_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "withdraw_address": "account01",
    "valid_from": "2021-08-07T12:56:30",
    "expires": "2106-02-07T06:28:15"
  }
]
unlocked >>>

After running the SON HIVE QA setup, I don't see the bitcoin deposit address generated for accounts, in this example account01. It is the same for all the 16 accounts(account01-account16) ``` unlocked >>> get_sidechain_addresses_by_account account01 get_sidechain_addresses_by_account account01 [{ "id": "1.38.0", "sidechain_address_account": "1.2.52", "sidechain": "bitcoin", "deposit_public_key": "0368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cd", "deposit_address": "", "deposit_address_data": "", "withdraw_public_key": "02743d4f24f88095de7921b8a8486cb46f009b7c034daa931821fb688c9c1e42a2", "withdraw_address": "2MtTPtraZawsvNGc8eCdx98hXbi4gaYy8L6", "valid_from": "2021-08-07T12:56:30", "expires": "2106-02-07T06:28:15" },{ "id": "1.38.16", "sidechain_address_account": "1.2.52", "sidechain": "hive", "deposit_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s", "deposit_address": "account01", "deposit_address_data": "", "withdraw_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s", "withdraw_address": "account01", "valid_from": "2021-08-07T12:56:30", "expires": "2106-02-07T06:28:15" },{ "id": "1.38.32", "sidechain_address_account": "1.2.52", "sidechain": "peerplays", "deposit_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "deposit_address": "account01", "deposit_address_data": "", "withdraw_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "withdraw_address": "account01", "valid_from": "2021-08-07T12:56:30", "expires": "2106-02-07T06:28:15" } ] unlocked >>> ```

prandnum commented

2021-08-11 19:53:03 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

prandnum commented

2021-08-11 19:53:27 +00:00

(Migrated from gitlab.com)

@bobinson @serkixenos

CC: @hbelakon

@bobinson @serkixenos CC: @hbelakon

serkixenos commented

2021-08-12 01:46:58 +00:00

(Migrated from gitlab.com)

SON for Hive QA Environment is built specifically for Hive. Bitcoin software is not installed in this image, and Bitcoin sidechain handler is disabled.

serkixenos (Migrated from gitlab.com) closed this issue

2021-08-12 01:46:58 +00:00

bobinson commented

2021-08-13 09:07:29 +00:00

(Migrated from gitlab.com)

@prandnum - the similar bug / issue seems to be there on the MAINNET too. You can try to investigate various scenarios on a network with Bitcoin Sidechain enabled. We need to explore more scenarios with incorrect config files. We also need to assume sceanrios where in all the nodes are run by the same person and they having knowledge of all the keys!

prandnum (Migrated from gitlab.com) reopened this issue

2021-08-13 18:56:26 +00:00

prandnum commented

2021-08-13 19:03:49 +00:00

(Migrated from gitlab.com)

@serkixenos Bitcoin sidechain is also required to validate https://gitlab.com/PBSA/peerplays/-/issues/145 Right now I can see only hive tx signing count. I have set up the bitcoin node in regtest mode inside the docker for SON HIVE environment by running the commands mentioned in your init script for bitcoin. Can you let me know how Peerplays bitcoin handler can be enabled so that I can verify whether the modified setup is usable for the test?

@bobinson I don't have any negative scenarios yet, but then will try to come up with some. but a person running all more than one SON was totally unexpected :)

@serkixenos Bitcoin sidechain is also required to validate https://gitlab.com/PBSA/peerplays/-/issues/145 Right now I can see only hive tx signing count. I have set up the bitcoin node in regtest mode inside the docker for SON HIVE environment by running the commands mentioned in your init script for bitcoin. Can you let me know how Peerplays bitcoin handler can be enabled so that I can verify whether the modified setup is usable for the test? @bobinson I don't have any negative scenarios yet, but then will try to come up with some. but a person running all more than one SON was totally unexpected :)

serkixenos commented

2021-08-14 02:06:09 +00:00

(Migrated from gitlab.com)

SON for Hive QA Environment is built specifically for Hive. It is not a place to test Bitcoin stuff. Gladiator was set up as a full test environment, but we do not have it now...

BTC sidechain handler can be enabled by setting parameter bitcoin-sidechain-enabled to 1, and you might get deposit addresses created by just enabling btc handler.

For 145, there are more changes to apply - accounts do not have registered BTC sidechain addresses, BTC wallets are not created, initialized with development keys and funded, and you need to separate users from sons, to prevent them taking funds from each other (because of keeping all private keys in single wallet).

SON for Hive QA Environment is built specifically for Hive. It is not a place to test Bitcoin stuff. Gladiator was set up as a full test environment, but we do not have it now... BTC sidechain handler can be enabled by setting parameter bitcoin-sidechain-enabled to 1, and you might get deposit addresses created by just enabling btc handler. For 145, there are more changes to apply - accounts do not have registered BTC sidechain addresses, BTC wallets are not created, initialized with development keys and funded, and you need to separate users from sons, to prevent them taking funds from each other (because of keeping all private keys in single wallet).

bobinson commented

2021-08-14 09:59:51 +00:00

(Migrated from gitlab.com)

@serkixenos @prandnum - folks, we eventually need to test both Bitcoin and Hive together on the same network. Same setup. Can we extend this setup, ie the one created for Hive to have all the necessary bells and whistles for testing both ?

Also, lets make sure that we are running everything in the same physicial server if possible (if not in the same VM) & all the blockchain nodes are dockers. Essentially we don't want to get into the death trap of Proxmox > KVM > QEMU.

@serkixenos @prandnum - folks, we eventually need to test both Bitcoin and Hive together on the same network. Same setup. Can we extend this setup, ie the one created for Hive to have all the necessary bells and whistles for testing both ? Also, lets make sure that we are running everything in the same physicial server if possible (if not in the same VM) & all the blockchain nodes are dockers. Essentially we don't want to get into the death trap of Proxmox > KVM > QEMU.

prandnum commented

2021-08-17 12:04:59 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and unassigned @serkixenos

hbelakon commented

2021-08-26 12:29:39 +00:00

(Migrated from gitlab.com)

@serkixenos please estimate! I will put 16h/Weight 2 for now...

hbelakon commented

2021-08-26 12:29:53 +00:00

(Migrated from gitlab.com)

changed time estimate to 16h

prandnum commented

2021-08-26 15:25:55 +00:00

(Migrated from gitlab.com)

in the new combined Bitcoin, Peerplays, Hive Docker environment, the deposit address is properly generated.

get_sidechain_addresses_by_account account01
[{
    "id": "1.38.0",
    "sidechain_address_account": "1.2.52",
    "sidechain": "bitcoin",
    "deposit_public_key": "0368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cd",
    "deposit_address": "bcrt1qz2cykw980zns8uxpt7dsn4ku7ce24cq3z8mna0tttzhw2qcr4y0qxmgej2",
    "deposit_address_data": "{ \"redeemScript\": \"210368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cdac635167007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac635193687c2102ef0d79bfdb99ab0be674b1d5d06c24debd74bffdc28d466633d6668cc281cccfac635193687c210317941e4219548682fb8d8e172f0a8ce4d83ce21272435c85d598558c8e060b7fac635193687c210266065b27f7e3d3ad45b471b1cd4e02de73fc4737dc2679915a45e293c5adcf84ac635193687c21023821cc3da7be9e8cdceb8f146e9ddd78a9519875ecc5b42fe645af690544bccfac635193687c210229ff2b2106b76c27c393e82d71c20eec32bcf1f0cf1a9aca8a237269a67ff3e5ac635193687c21024d113381cc09deb8a6da62e0470644d1a06de82be2725b5052668c8845a4a8daac635193687c2103df2462a5a2f681a3896f61964a65566ff77448be9a55a6da18506fd9c6c051c1ac635193687c2102bafba3096f546cc5831ce1e49ba7142478a659f2d689bbc70ed37235255172a8ac635193687c210287bcbd4f5d357f89a86979b386402445d7e9a5dccfd16146d1d2ab0dc2c32ae8ac635193687c2102053859d76aa375d6f343a60e3678e906c008015e32fe4712b1fd2b26473bdd73ac635193685ba268\", \"witnessScript\": \"002012b04b38a778a703f0c15f9b09d6dcf632aae01111f73ebd6b58aee50303a91e\" }",
    "withdraw_public_key": "02743d4f24f88095de7921b8a8486cb46f009b7c034daa931821fb688c9c1e42a2",
    "withdraw_address": "2MtTPtraZawsvNGc8eCdx98hXbi4gaYy8L6",
    "valid_from": "2021-08-25T16:54:42",
    "expires": "2106-02-07T06:28:15"
  },{
    "id": "1.38.16",
    "sidechain_address_account": "1.2.52",
    "sidechain": "hive",
    "deposit_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s",
    "deposit_address": "account01",
    "deposit_address_data": "",
    "withdraw_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s",
    "withdraw_address": "account01",
    "valid_from": "2021-08-25T16:54:42",
    "expires": "2106-02-07T06:28:15"
  },{
    "id": "1.38.32",
    "sidechain_address_account": "1.2.52",
    "sidechain": "peerplays",
    "deposit_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "deposit_address": "account01",
    "deposit_address_data": "",
    "withdraw_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "withdraw_address": "account01",
    "valid_from": "2021-08-25T16:54:42",
    "expires": "2106-02-07T06:28:15"
  }
]
unlocked >>>

in the new combined Bitcoin, Peerplays, Hive Docker environment, the deposit address is properly generated. ``` get_sidechain_addresses_by_account account01 [{ "id": "1.38.0", "sidechain_address_account": "1.2.52", "sidechain": "bitcoin", "deposit_public_key": "0368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cd", "deposit_address": "bcrt1qz2cykw980zns8uxpt7dsn4ku7ce24cq3z8mna0tttzhw2qcr4y0qxmgej2", "deposit_address_data": "{ \"redeemScript\": \"210368dc31b2b547c74f52abfc67c7fc768c68115d8ab96430d9bb4996fa660121cdac635167007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac635193687c2102ef0d79bfdb99ab0be674b1d5d06c24debd74bffdc28d466633d6668cc281cccfac635193687c210317941e4219548682fb8d8e172f0a8ce4d83ce21272435c85d598558c8e060b7fac635193687c210266065b27f7e3d3ad45b471b1cd4e02de73fc4737dc2679915a45e293c5adcf84ac635193687c21023821cc3da7be9e8cdceb8f146e9ddd78a9519875ecc5b42fe645af690544bccfac635193687c210229ff2b2106b76c27c393e82d71c20eec32bcf1f0cf1a9aca8a237269a67ff3e5ac635193687c21024d113381cc09deb8a6da62e0470644d1a06de82be2725b5052668c8845a4a8daac635193687c2103df2462a5a2f681a3896f61964a65566ff77448be9a55a6da18506fd9c6c051c1ac635193687c2102bafba3096f546cc5831ce1e49ba7142478a659f2d689bbc70ed37235255172a8ac635193687c210287bcbd4f5d357f89a86979b386402445d7e9a5dccfd16146d1d2ab0dc2c32ae8ac635193687c2102053859d76aa375d6f343a60e3678e906c008015e32fe4712b1fd2b26473bdd73ac635193685ba268\", \"witnessScript\": \"002012b04b38a778a703f0c15f9b09d6dcf632aae01111f73ebd6b58aee50303a91e\" }", "withdraw_public_key": "02743d4f24f88095de7921b8a8486cb46f009b7c034daa931821fb688c9c1e42a2", "withdraw_address": "2MtTPtraZawsvNGc8eCdx98hXbi4gaYy8L6", "valid_from": "2021-08-25T16:54:42", "expires": "2106-02-07T06:28:15" },{ "id": "1.38.16", "sidechain_address_account": "1.2.52", "sidechain": "hive", "deposit_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s", "deposit_address": "account01", "deposit_address_data": "", "withdraw_public_key": "TST5quk5Brh16v9RhdK6uCFxy4j3T9Dsz7krCUPwuAgvTzghQBG7s", "withdraw_address": "account01", "valid_from": "2021-08-25T16:54:42", "expires": "2106-02-07T06:28:15" },{ "id": "1.38.32", "sidechain_address_account": "1.2.52", "sidechain": "peerplays", "deposit_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "deposit_address": "account01", "deposit_address_data": "", "withdraw_public_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "withdraw_address": "account01", "valid_from": "2021-08-25T16:54:42", "expires": "2106-02-07T06:28:15" } ] unlocked >>> ```

prandnum (Migrated from gitlab.com) closed this issue

2021-08-26 15:25:56 +00:00

bobinson commented

2021-08-27 09:21:55 +00:00

(Migrated from gitlab.com)

@prandnum - however note that this is a "perfect" environemnt where we have made sure everything is correct. Manipulating the configuration files, trying with duplicate keys for Bitcoin SONs etc are recommended as future scenarios.

bitcoin deposit address not generated for peerplays account #167