[Feature] extending the MEMO feature in Peerplays #178

New issue

Closed

opened 2021-09-09 12:08:58 +00:00 by bobinson · 10 comments

bobinson commented

2021-09-09 12:08:58 +00:00

(Migrated from gitlab.com)

Right now, ie by default Peerplays blockchain is allowing memos to be send only as encrypted messages.

We need an option to send plain text memos as well.

Feature description:

A message with the character # at beginning should result in encrypted messages
A message without the # should be a plain text message (visible publicly on the chain.)

This is required for simplifying the Hive SONs process.

Right now, ie by default Peerplays blockchain is allowing memos to be send only as encrypted messages. We need an option to send plain text memos as well. Feature description: - A message with the character `#` at beginning should result in encrypted messages - A message _without_ the `#` should be a plain text message (visible publicly on the chain.) This is required for simplifying the Hive SONs process.

bobinson commented

2021-09-09 12:08:58 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

serkixenos commented

2021-09-22 14:02:51 +00:00

(Migrated from gitlab.com)

https://gitlab.com/PBSA/peerplays/-/merge_requests/13/diffs?commit_id=765bebdef3cb5063ca9f59cb85ad9fbcc032c675

serkixenos commented

2021-09-22 14:03:33 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and unassigned @serkixenos

prandnum commented

2021-09-22 18:34:47 +00:00

(Migrated from gitlab.com)

@serkixenos will rebuild using peerplays-utils/peerplays-qa-environment code pull the required changes?

serkixenos commented

2021-09-23 14:56:36 +00:00

(Migrated from gitlab.com)

For Peerplays yes, it will. For Hive, you should rebuild its image from scratch, to pickup the latest init-network script.

prandnum commented

2021-09-24 18:51:15 +00:00

(Migrated from gitlab.com)

unlocked >>> transfer peerplaysuser01 son-account 153 HBD "hiveuser01" true
transfer peerplaysuser01 son-account 153 HBD "hiveuser01" true
{
  "ref_block_num": 2141,
  "ref_block_prefix": 790315650,
  "expiration": "2021-09-24T18:16:21",
  "operations": [[
      0,{
        "fee": {
          "amount": 2087890,
          "asset_id": "1.3.0"
        },
        "from": "1.2.68",
        "to": "1.2.19",
        "amount": {
          "amount": 153000,
          "asset_id": "1.3.2"
        },
        "memo": {
          "from": "TEST8GQp4p28G9bNzMwoDy28z3ga6aJJDFAG2oHibZekHiHJAfV4bn",
          "to": "TEST1111111111111111111111111111111114T1Anm",
          "nonce": 0,
          "message": "0000000068697665757365723031"
        },
        "extensions": []
      }
    ]
  ],
  "extensions": [],
  "signatures": [
    "201e09e5894a866ec011719024eb1f42b719f1ef4eec5188cdd07629791f7396bd32bbb4967c6314188f279b9e7df66668ea59c4a98ec7473f062bbbdea8c87a2b"
  ]
}
unlocked >>> transfer peerplaysuser01 son-account 284 HIVE "hiveuser01" true
transfer peerplaysuser01 son-account 284 HIVE "hiveuser01" true
{
  "ref_block_num": 2141,
  "ref_block_prefix": 790315650,
  "expiration": "2021-09-24T18:16:21",
  "operations": [[
      0,{
        "fee": {
          "amount": 2087890,
          "asset_id": "1.3.0"
        },
        "from": "1.2.68",
        "to": "1.2.19",
        "amount": {
          "amount": 284000,
          "asset_id": "1.3.3"
        },
        "memo": {
          "from": "TEST8GQp4p28G9bNzMwoDy28z3ga6aJJDFAG2oHibZekHiHJAfV4bn",
          "to": "TEST1111111111111111111111111111111114T1Anm",
          "nonce": 0,
          "message": "0000000068697665757365723031"
        },
        "extensions": []
      }
    ]
  ],
  "extensions": [],
  "signatures": [
    "207f85e8da916a82f0237617ade8c95ffd52e02f82ef4bef71b8f7c35e3e2f546a37df6e650cb586487a44a989873a50299efddfd77e0da42d32b80995703cfe5e"
  ]
}

unlocked >>> list_account_balances son-account
list_account_balances son-account
49098999.93344 TEST
153 HBD
284 HIVE

unlocked >>> list_account_balances son-account
list_account_balances son-account
49098999.93344 TEST
153 HBD
284 HIVE

unlocked >>> list_account_balances son-account
list_account_balances son-account
49098959.91344 TEST
0 HBD
0 HIVE

unlocked >>> list_account_balances peerplaysuser01
list_account_balances peerplaysuser01
1938.24220 TEST
0 HBD
0 HIVE

unlocked >>>

unlocked >>> get_account_history peerplaysuser01 100
get_account_history peerplaysuser01 100
2021-09-24T18:15:54 Transfer 284 HIVE from peerplaysuser01 to son-account -- Memo: hiveuser01   (Fee: 20.87890 TEST)
2021-09-24T18:15:54 Transfer 153 HBD from peerplaysuser01 to son-account -- Memo: hiveuser01   (Fee: 20.87890 TEST)
2021-09-24T18:08:54 asset_issue_operation son-account fee: 20.01000 TEST
2021-09-24T18:08:51 asset_issue_operation son-account fee: 20.01000 TEST
2021-09-24T17:14:06 asset_reserve_operation peerplaysuser01 fee: 20 TEST
2021-09-24T17:13:51 Transfer 1000 TEST from nathan to peerplaysuser01   (Fee: 20 TEST)
2021-09-24T17:12:45 Transfer 1000 TEST from nathan to peerplaysuser01   (Fee: 20 TEST)
2021-09-24T17:12:45 Transfer 949994000 TEST from nathan to peerplaysuser01   (Fee: 20 TEST)
2021-09-24T17:12:33 Create Account 'peerplaysuser01'   (Fee: 5.15039 TEST)

unlocked >>>

``` unlocked >>> transfer peerplaysuser01 son-account 153 HBD "hiveuser01" true transfer peerplaysuser01 son-account 153 HBD "hiveuser01" true { "ref_block_num": 2141, "ref_block_prefix": 790315650, "expiration": "2021-09-24T18:16:21", "operations": [[ 0,{ "fee": { "amount": 2087890, "asset_id": "1.3.0" }, "from": "1.2.68", "to": "1.2.19", "amount": { "amount": 153000, "asset_id": "1.3.2" }, "memo": { "from": "TEST8GQp4p28G9bNzMwoDy28z3ga6aJJDFAG2oHibZekHiHJAfV4bn", "to": "TEST1111111111111111111111111111111114T1Anm", "nonce": 0, "message": "0000000068697665757365723031" }, "extensions": [] } ] ], "extensions": [], "signatures": [ "201e09e5894a866ec011719024eb1f42b719f1ef4eec5188cdd07629791f7396bd32bbb4967c6314188f279b9e7df66668ea59c4a98ec7473f062bbbdea8c87a2b" ] } unlocked >>> transfer peerplaysuser01 son-account 284 HIVE "hiveuser01" true transfer peerplaysuser01 son-account 284 HIVE "hiveuser01" true { "ref_block_num": 2141, "ref_block_prefix": 790315650, "expiration": "2021-09-24T18:16:21", "operations": [[ 0,{ "fee": { "amount": 2087890, "asset_id": "1.3.0" }, "from": "1.2.68", "to": "1.2.19", "amount": { "amount": 284000, "asset_id": "1.3.3" }, "memo": { "from": "TEST8GQp4p28G9bNzMwoDy28z3ga6aJJDFAG2oHibZekHiHJAfV4bn", "to": "TEST1111111111111111111111111111111114T1Anm", "nonce": 0, "message": "0000000068697665757365723031" }, "extensions": [] } ] ], "extensions": [], "signatures": [ "207f85e8da916a82f0237617ade8c95ffd52e02f82ef4bef71b8f7c35e3e2f546a37df6e650cb586487a44a989873a50299efddfd77e0da42d32b80995703cfe5e" ] } unlocked >>> list_account_balances son-account list_account_balances son-account 49098999.93344 TEST 153 HBD 284 HIVE unlocked >>> list_account_balances son-account list_account_balances son-account 49098999.93344 TEST 153 HBD 284 HIVE unlocked >>> list_account_balances son-account list_account_balances son-account 49098959.91344 TEST 0 HBD 0 HIVE unlocked >>> list_account_balances peerplaysuser01 list_account_balances peerplaysuser01 1938.24220 TEST 0 HBD 0 HIVE unlocked >>> unlocked >>> get_account_history peerplaysuser01 100 get_account_history peerplaysuser01 100 2021-09-24T18:15:54 Transfer 284 HIVE from peerplaysuser01 to son-account -- Memo: hiveuser01 (Fee: 20.87890 TEST) 2021-09-24T18:15:54 Transfer 153 HBD from peerplaysuser01 to son-account -- Memo: hiveuser01 (Fee: 20.87890 TEST) 2021-09-24T18:08:54 asset_issue_operation son-account fee: 20.01000 TEST 2021-09-24T18:08:51 asset_issue_operation son-account fee: 20.01000 TEST 2021-09-24T17:14:06 asset_reserve_operation peerplaysuser01 fee: 20 TEST 2021-09-24T17:13:51 Transfer 1000 TEST from nathan to peerplaysuser01 (Fee: 20 TEST) 2021-09-24T17:12:45 Transfer 1000 TEST from nathan to peerplaysuser01 (Fee: 20 TEST) 2021-09-24T17:12:45 Transfer 949994000 TEST from nathan to peerplaysuser01 (Fee: 20 TEST) 2021-09-24T17:12:33 Create Account 'peerplaysuser01' (Fee: 5.15039 TEST) unlocked >>> ```

prandnum (Migrated from gitlab.com) closed this issue

2021-09-24 18:51:16 +00:00

hbelakon commented

2021-10-13 03:00:32 +00:00

(Migrated from gitlab.com)

added to epic &372

yviter commented

2021-10-18 11:45:11 +00:00

(Migrated from gitlab.com)

mentioned in commit 39263ba774

mentioned in commit 39263ba7745b074d389ba83191f7c56dd56bcbac

serkixenos commented