Peerplays Production release is missing two cli commands #194

New issue

Closed

opened 2021-10-15 15:13:31 +00:00 by Hiltos1 · 7 comments

Hiltos1 commented

2021-10-15 15:13:31 +00:00

(Migrated from gitlab.com)

Description

The Peerplays CLI wallet does not allow the update_account_auth_key or update_account_keys commands in production. These commands are working in the testnet releases.

Preconditions

Production (mainnet) version is installed.

Affected Versions

The production releases with tags 1.5.13 going back to 1.0.0 are affected.

Scenario

Run the cli_wallet connected to mainnet.
Try the gethelp update_account_auth_key and/or gethelp update_account_keys commands. (These will error with command not found)
Try the help command. (The list of commands does not include the update_account_auth_key or update_account_keys commands)

Current Bugged Behavior

In any production (mainnet) release, the update_account_auth_key and update_account_keys commands don't exist.

Expected Correct Behavior

In mainnet, the update_account_auth_key and update_account_keys commands should exist and function as intended.

Possible Fixes

The code for these functions already exists in the testnet code. See test-1.5.5 wallet.hpp lines 759 & 778. I'm sure there is more code that will be needed in other files too, like wallet.cpp.

## Description The Peerplays CLI wallet does not allow the `update_account_auth_key` or `update_account_keys` commands in production. These commands are working in the testnet releases. ## Preconditions - Production (mainnet) version is installed. ## Affected Versions The production releases with tags `1.5.13` going back to `1.0.0` are affected. ## Scenario 1. Run the cli_wallet connected to mainnet. 2. Try the `gethelp update_account_auth_key` and/or `gethelp update_account_keys` commands. (These will error with command not found) 3. Try the `help` command. (The list of commands does not include the `update_account_auth_key` or `update_account_keys` commands) ## Current Bugged Behavior In any production (mainnet) release, the `update_account_auth_key` and `update_account_keys` commands don't exist. ## Expected Correct Behavior In mainnet, the `update_account_auth_key` and `update_account_keys` commands should exist and function as intended. ## Possible Fixes The code for these functions already exists in the testnet code. See `test-1.5.5` wallet.hpp lines 759 & 778. I'm sure there is more code that will be needed in other files too, like wallet.cpp.

Hiltos1 commented

2021-10-15 15:13:31 +00:00

(Migrated from gitlab.com)

assigned to @sierra19XX

serkixenos commented

2021-10-15 15:39:06 +00:00

(Migrated from gitlab.com)

Related commit, merged into develop, but not master
3f4fc67e40

Related commit, merged into develop, but not master https://gitlab.com/PBSA/peerplays/-/commit/3f4fc67e40f0f1399b8e0422039a2d7752a11ebd

serkixenos commented

2021-12-01 03:00:15 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos and unassigned @sierra19XX

bobinson commented

2021-12-01 07:53:22 +00:00

(Migrated from gitlab.com)

The commands are available in teh current develop

serkixenos commented

2021-12-06 15:16:25 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and unassigned @serkixenos

serkixenos commented

2021-12-06 15:18:53 +00:00

(Migrated from gitlab.com)

@prandnum Verify that two commands are present in the cli wallet, from develop branch

prandnum commented

2021-12-06 20:38:23 +00:00

(Migrated from gitlab.com)

Works fine. Closing the bug.

root@119ac54dae2f:~/peerplays-network# ./cli_wallet --version
Version: test-1.5.4-48-g732cae96
Git Revision: 732cae963d97756c3abd4e4b6ffe332c2bc8a82c
Built: Dec  5 2021 at 20:22:52
SSL: OpenSSL 1.1.1f  31 Mar 2020
Boost: 1.67
root@119ac54dae2f:~/peerplays-network# ./cli_wallet
Logging RPC to file: logs/rpc/rpc.log
2207364ms th_a       main.cpp:197                  main                 ] wdata.ws_user:  wdata.ws_password:
locked >>> unlock password
unlock password
null
unlocked >>> gethelp update_account_auth_key
gethelp update_account_auth_key

This method updates the key of an authority for an exisiting account.
Warning: You can create impossible authorities using this method. The
method will fail if you create an impossible owner authority, but will
allow impossible active and posting authorities.

unlocked >>> gethelp update_account_keys
gethelp update_account_keys

Updates account public keys

Returns
    the signed transaction updating account public keys

unlocked >>>

Works fine. Closing the bug. ``` root@119ac54dae2f:~/peerplays-network# ./cli_wallet --version Version: test-1.5.4-48-g732cae96 Git Revision: 732cae963d97756c3abd4e4b6ffe332c2bc8a82c Built: Dec 5 2021 at 20:22:52 SSL: OpenSSL 1.1.1f 31 Mar 2020 Boost: 1.67 root@119ac54dae2f:~/peerplays-network# ./cli_wallet Logging RPC to file: logs/rpc/rpc.log 2207364ms th_a main.cpp:197 main ] wdata.ws_user: wdata.ws_password: locked >>> unlock password unlock password null unlocked >>> gethelp update_account_auth_key gethelp update_account_auth_key This method updates the key of an authority for an exisiting account. Warning: You can create impossible authorities using this method. The method will fail if you create an impossible owner authority, but will allow impossible active and posting authorities. unlocked >>> gethelp update_account_keys gethelp update_account_keys Updates account public keys Returns the signed transaction updating account public keys unlocked >>> ```

prandnum (Migrated from gitlab.com) closed this issue

2021-12-06 20:38:24 +00:00