Empty JSON parsing failure 2 #225

New issue

Closed

opened 2021-12-10 13:23:45 +00:00 by yviter · 7 comments

yviter commented

2021-12-10 13:23:45 +00:00

(Migrated from gitlab.com)

No description provided.

yviter commented

2021-12-10 13:23:58 +00:00

(Migrated from gitlab.com)

assigned to @yviter

yviter commented

2021-12-10 17:13:38 +00:00

(Migrated from gitlab.com)

Bug "Empty JSON parsing failure" was fixed previously. The reason was found out and problem was fixed at central points. However brief analysis show potential problems in following files:
libraries/plugins/peerplays_sidechain/bitcoin/utils.cpp
libraries/plugins/peerplays_sidechain/sidechain_net_handler_bitcoin.cpp
libraries/plugins/peerplays_sidechain/sidechain_net_handler_hive.cpp

Bug "Empty JSON parsing failure" was fixed previously. The reason was found out and problem was fixed at central points. However brief analysis show potential problems in following files: libraries/plugins/peerplays_sidechain/bitcoin/utils.cpp libraries/plugins/peerplays_sidechain/sidechain_net_handler_bitcoin.cpp libraries/plugins/peerplays_sidechain/sidechain_net_handler_hive.cpp

yviter commented

2021-12-13 13:02:35 +00:00

(Migrated from gitlab.com)

at RPC client all potential situations was fixed in prev. ticket
for HIVE: no any potential problem found: all checks already present is source code
for Bitcoin: many potential places; all places was bookmarked to discuss and suggest error handling method (files: sidechain_net_handler_bitcoin.cpp and bitcoin/utils.cpp)

0) at RPC client all potential situations was fixed in prev. ticket 1) for HIVE: no any potential problem found: all checks already present is source code 2) for Bitcoin: many potential places; all places was bookmarked to discuss and suggest error handling method (files: sidechain_net_handler_bitcoin.cpp and bitcoin/utils.cpp)

yviter commented

2021-12-13 17:06:04 +00:00

(Migrated from gitlab.com)

Commited for review

hbelakon commented

2021-12-14 03:00:27 +00:00

(Migrated from gitlab.com)

@yviter please estimate, I will put 16h/Weight 2

hbelakon commented

2021-12-14 03:08:35 +00:00

(Migrated from gitlab.com)

@yviter Which epic is that? I will out SON- Javascript Library for now

serkixenos commented

2022-01-20 14:02:54 +00:00

(Migrated from gitlab.com)

Code reviewed (branch bug/empty-json-parsing-failure-2). Regarding bitcoin cases, although strings are not checked at the moment of loading into property tree, there are other mechanisms that will ensure that strings are not empty. Eg, address creation, or transaction creation will silently fail, and the sidechain transaction objects will not be created at all.

Closing this ticket as too general. If specific problem is found, caused by specific empty string, we will create a new ticket for it.

serkixenos (Migrated from gitlab.com) closed this issue

2022-01-20 14:02:55 +00:00