Peerplays_Blockchain/peerplays_migrated

Fork 0

cli_test warns on select_top_fifteen_sons, cli_list_active_sons, maintenence_test #229

New issue

Closed

opened 2021-12-14 13:01:51 +00:00 by pavel.baykov · 14 comments

pavel.baykov commented

2021-12-14 13:01:51 +00:00

(Migrated from gitlab.com)

select_top_fifteen_sons
cli_list_active_sons
maintenence_test

have triggered assertions

SON cli wallet tests for list_active_sons end
Cleanup cli_wallet::boost_fixture_test_case
2703323ms th_a undo_database.cpp:294 pop_commit ] error popping commit 10 assert_exception: Assert Exception
ok: Could not modify object, most likely an index constraint was violated
{}
th_a generic_index.hpp:88 modify
2703323ms th_a db_management.cpp:272 close ] Database close unexpected exception: {"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"generic_index.hpp","line":88,"method":"modify","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"ok: Could not modify object, most likely an index constraint was violated","data":{}},{"context":{"level":"warn","file":"object_database.cpp","line":119,"method":"pop_undo","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"","data":{}},{"context":{"level":"warn","file":"db_block.cpp","line":594,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"","data":{}}]}
2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055300656
2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055298592
2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055299968
2703862ms p2p thread.cpp:246 exec ] thread canceled: 9 canceled_exception: Canceled

select_top_fifteen_sons cli_list_active_sons maintenence_test have triggered assertions SON cli wallet tests for list_active_sons end Cleanup cli_wallet::boost_fixture_test_case 2703323ms th_a undo_database.cpp:294 pop_commit ] error popping commit 10 assert_exception: Assert Exception ok: Could not modify object, most likely an index constraint was violated {} th_a generic_index.hpp:88 modify 2703323ms th_a db_management.cpp:272 close ] Database close unexpected exception: {"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"generic_index.hpp","line":88,"method":"modify","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"ok: Could not modify object, most likely an index constraint was violated","data":{}},{"context":{"level":"warn","file":"object_database.cpp","line":119,"method":"pop_undo","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"","data":{}},{"context":{"level":"warn","file":"db_block.cpp","line":594,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2021-12-14T12:45:03"},"format":"","data":{}}]} 2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055300656 2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055298592 2703850ms th_a database_api.cpp:359 ~database_api_impl ] freeing database api 93825055299968 2703862ms p2p thread.cpp:246 exec ] thread canceled: 9 canceled_exception: Canceled

pavel.baykov commented

2021-12-14 13:01:51 +00:00

(Migrated from gitlab.com)

assigned to @pavel.baykov

pavel.baykov commented

2021-12-14 13:05:19 +00:00

(Migrated from gitlab.com)

the problem with list_active_sons from:

db_management.cpp , 272 get_dynamic_global_properties().last_irreversible_block_num does not match head_block_num()

potentially not consistent state of DB

the problem with list_active_sons from: db_management.cpp , 272 get_dynamic_global_properties().last_irreversible_block_num does not match head_block_num() potentially not consistent state of DB

hbelakon commented

2021-12-24 04:13:57 +00:00

(Migrated from gitlab.com)

@pavel.baykov Please do assign proper labels (Type and status) - see what I have added . Thanks

hbelakon commented

2021-12-24 04:14:32 +00:00

(Migrated from gitlab.com)

@pavel.baykov Please estimate! I will pit 8h/Weight 1 for now

hbelakon commented

2021-12-24 04:14:40 +00:00

(Migrated from gitlab.com)

changed time estimate to 8h

serkixenos commented

2022-01-20 14:04:38 +00:00

(Migrated from gitlab.com)

This is expected. LIB never matches head block.

serkixenos commented

2022-01-20 14:40:13 +00:00

(Migrated from gitlab.com)

Nothing to review for now, putting it on hold until more info provided.

pavel.baykov commented

2022-02-07 13:38:29 +00:00

(Migrated from gitlab.com)

this ticket could be solved with a change:
libraries/app/application.cpp

my->_chain_db->close(false); //<-- Disable Database rewind

with this change tests are passing with no Assertions and Warning

this ticket could be solved with a change: libraries/app/application.cpp my->_chain_db->close(false); //<-- Disable Database rewind with this change tests are passing with no Assertions and Warning

pavel.baykov commented

2022-02-07 13:41:06 +00:00

(Migrated from gitlab.com)

If Rewind is enabled:
i tried in the pop_block()
disable undo_db by removing pop_undo() from pop_block()

in this combination we have assertion from fork_db

2089820ms th_a db_management.cpp:272 close ] Database close unexpected exception: {"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"fork_database.cpp","line":42,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2022-02-07T13:34:49"},"format":"prev: poping block would leave head block null","data":{}},{"context":{"level":"warn","file":"db_block.cpp","line":600,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2022-02-07T13:34:49"},"format":"","data":{}}]}

If Rewind is enabled: i tried in the pop_block() disable undo_db by removing pop_undo() from pop_block() in this combination we have assertion from fork_db 2089820ms th_a db_management.cpp:272 close ] Database close unexpected exception: {"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"fork_database.cpp","line":42,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2022-02-07T13:34:49"},"format":"prev: poping block would leave head block null","data":{}},{"context":{"level":"warn","file":"db_block.cpp","line":600,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2022-02-07T13:34:49"},"format":"","data":{}}]}

pavel.baykov commented

2022-02-07 13:44:02 +00:00

(Migrated from gitlab.com)

if disable close DB at all by removing
my->_chain_db->close();
in the libraries/app/application.cpp
we still have memory issues that sanitizer can identify, so Database Rewind functionality itself have a problem and memory issues is a separate problem

if disable close DB at all by removing my->_chain_db->close(); in the libraries/app/application.cpp we still have memory issues that sanitizer can identify, so Database Rewind functionality itself have a problem and memory issues is a separate problem

serkixenos commented

2022-02-07 18:59:58 +00:00

(Migrated from gitlab.com)

@pavel.baykov is this related branch?
https://gitlab.com/PBSA/peerplays/-/tree/sanitezers

CI/CD pipeline fails:
https://gitlab.com/PBSA/peerplays/-/pipelines/463874224

@pavel.baykov is this related branch? https://gitlab.com/PBSA/peerplays/-/tree/sanitezers CI/CD pipeline fails: https://gitlab.com/PBSA/peerplays/-/pipelines/463874224

pavel.baykov commented

2022-02-07 19:08:11 +00:00

(Migrated from gitlab.com)

fix for the unit tests in the
https://gitlab.com/PBSA/peerplays/-/tree/bug/issue229

the branch above is for sanitizers, it builds only test target and i used it with boost 1.78

fix for the unit tests in the https://gitlab.com/PBSA/peerplays/-/tree/bug/issue229 the branch above is for sanitizers, it builds only test target and i used it with boost 1.78

serkixenos commented

2022-02-07 19:15:32 +00:00

(Migrated from gitlab.com)

We need branch with your change, we need it to be executed without errors in CI/CD, and we need MR for it.

Please, create a branch with a fix and appropriate merge request.

We need branch with your change, we need it to be executed without errors in CI/CD, and we need MR for it. Please, create a branch with a fix and appropriate merge request.

serkixenos commented

2022-02-23 00:42:56 +00:00

(Migrated from gitlab.com)

SON cli tests are wrapped in try catch block, that hides errors in these tests. We will handle this in a another ticket: https://gitlab.com/PBSA/peerplays/-/issues/279

serkixenos (Migrated from gitlab.com) closed this issue

2022-02-23 00:42:57 +00:00