Peerplays_Blockchain/peerplays_migrated

Fork 0

Invalid list_active_sons output #261

New issue

Closed

opened 2022-01-20 17:07:32 +00:00 by sivayavvari · 11 comments

sivayavvari commented

2022-01-20 17:07:32 +00:00

(Migrated from gitlab.com)

The command below gives wrong output (on irona chain)

list_active_sons 
[[
    "sonaccount04",
    "1.33.3"
  ],[
    "sonaccount05",
    "1.33.4"
  ],[
    "sonaccount06",
    "1.33.5"
  ],[
    "sonaccount08",
    "1.33.7"
  ],[
    "sonaccount09",
    "1.33.8"
  ],[
    "sonaccount10",
    "1.33.0"
  ],[
    "sonaccount11",
    "1.33.0"
  ]
]

Attaching theget_global_properties and info commands output.

info.txt

get_global_properties.txt

The command below gives wrong output (on irona chain) ```unlocked >>> list_active_sons list_active_sons [[ "sonaccount04", "1.33.3" ],[ "sonaccount05", "1.33.4" ],[ "sonaccount06", "1.33.5" ],[ "sonaccount08", "1.33.7" ],[ "sonaccount09", "1.33.8" ],[ "sonaccount10", "1.33.0" ],[ "sonaccount11", "1.33.0" ] ] ``` Attaching the`get_global_properties` and `info` commands output. [info.txt](/uploads/7e387717232a54202851c8b7753260ec/info.txt) [get_global_properties.txt](/uploads/029d68a8a163881ebfec1694e4bc4f6e/get_global_properties.txt)

sivayavvari commented

2022-01-20 17:08:00 +00:00

(Migrated from gitlab.com)

changed the description

sivayavvari commented

2022-01-20 17:08:37 +00:00

(Migrated from gitlab.com)

changed the description

sivayavvari commented

2022-01-20 17:52:55 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

serkixenos commented

2022-01-20 19:24:18 +00:00

(Migrated from gitlab.com)

The root cause for this bug is that cli wallet command inserts null ID in case of deregistered son.

https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/wallet/wallet.cpp#L2221

The root cause for this bug is that cli wallet command inserts null ID in case of deregistered son. https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/wallet/wallet.cpp#L2221

hbelakon commented

2022-01-21 04:33:41 +00:00

(Migrated from gitlab.com)

@serkixenos please estimate- I will put 1d/weight 1

hbelakon commented

2022-01-21 04:33:52 +00:00

(Migrated from gitlab.com)

changed time estimate to 8h

serkixenos commented

2022-01-21 16:18:10 +00:00

(Migrated from gitlab.com)

0bcb0487a7

https://gitlab.com/PBSA/peerplays/-/commit/0bcb0487a797935d40c6cec13d6320a5e9491d87

serkixenos commented

2022-01-21 16:19:37 +00:00

(Migrated from gitlab.com)

@prandnum

Compare command output with outputs of info and get_global_properties.
Check the output when SONs are in different states, like inactive, active, in maintenance, deregistered...

@prandnum Compare command output with outputs of info and get_global_properties. Check the output when SONs are in different states, like inactive, active, in maintenance, deregistered...

serkixenos commented

2022-01-21 16:19:52 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and unassigned @serkixenos

prandnum commented

2022-01-26 18:22:52 +00:00

(Migrated from gitlab.com)

verified the fix. details attached.

0-Initial-state.txt
1-in_maintenance-sonaccount04.txt
2-deregistered-sonaccount04.txt
3-sonaccount04-replaced.txt

verified the fix. details attached. [0-Initial-state.txt](/uploads/03790f2b620451a240f522e8fae5d702/0-Initial-state.txt) [1-in_maintenance-sonaccount04.txt](/uploads/5c1b10d36b2d0d8be3436feb73e1507e/1-in_maintenance-sonaccount04.txt) [2-deregistered-sonaccount04.txt](/uploads/9f9ab2ad5cd9485e41fcd5c1589cafa5/2-deregistered-sonaccount04.txt) [3-sonaccount04-replaced.txt](/uploads/c2ebcc232bdd5a9dcb6a1745dec1f26a/3-sonaccount04-replaced.txt)

prandnum (Migrated from gitlab.com) closed this issue

2022-01-26 18:22:52 +00:00

hbelakon commented

2022-01-28 04:23:17 +00:00

(Migrated from gitlab.com)

WHICH EPIC IS THAT??????