Find MIT compatible replacement for readline #27

New issue

Closed

opened 2020-08-25 14:10:42 +00:00 by bobinson · 10 comments

bobinson commented

2020-08-25 14:10:42 +00:00

(Migrated from gitlab.com)

Bitshares discussion : https://github.com/bitshares/bitshares-core/issues/673

propose an MIT compatible replacement

We are interested in putting this under peerplays.io community initiative and community members interested can fill the attached PDF form and share with PBSA.Peerplay.io_Ticket_Propsal_Template.pdf

Bitshares discussion : https://github.com/bitshares/bitshares-core/issues/673 - propose an MIT compatible replacement We are interested in putting this under peerplays.io community initiative and community members interested can fill the attached PDF form and share with PBSA.[Peerplay.io_Ticket_Propsal_Template.pdf](/uploads/6cdc41d370e67ec91772da4ae94c2664/Peerplay.io_Ticket_Propsal_Template.pdf)

pblockc commented

2020-08-25 14:26:56 +00:00

(Migrated from gitlab.com)

We should move to an alternative with a less restrictive license, like https://github.com/troglobit/editline

Estimate is around 40 Hrs including a script to test all cli commands.

Peerplays has licensing issues with "Readline" library. Readline is GPL. We're using libreadline, so due to the transitive nature of GPL Peerplays required to license peerplays-network as GPL. It's not suggestible to do that right now, so we're in violation of the readline license. We should move to an alternative with a less restrictive license, like https://github.com/troglobit/editline Estimate is around 40 Hrs including a script to test all cli commands.

bobinson commented

2020-08-26 10:55:33 +00:00

(Migrated from gitlab.com)

The https://github.com/troglobit/editline/blob/master/LICENSE is compatible with MIT ?

pblockc commented

2020-08-26 14:26:15 +00:00

(Migrated from gitlab.com)

The troglobit/editline license is very liberal and can be used with credits. Please verify once.

gizord commented

2020-09-21 09:08:45 +00:00

(Migrated from gitlab.com)

PRs from bitshares that might help you:

Let me know if you need assistance with those.

PRs from bitshares that might help you: * https://github.com/bitshares/bitshares-core/pull/685 * https://github.com/bitshares/bitshares-fc/pull/14 Let me know if you need assistance with those.

bobinson commented

2020-09-21 10:55:41 +00:00

(Migrated from gitlab.com)

assigned to @pblockc

pblockc commented

2020-10-16 15:32:36 +00:00

(Migrated from gitlab.com)

mentioned in merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!20

pblockc commented

2020-10-16 15:35:45 +00:00

(Migrated from gitlab.com)

mentioned in merge request !4