Enable multiple SON support by default #273

New issue

Closed

opened 2022-02-08 14:34:24 +00:00 by serkixenos · 4 comments

serkixenos commented

2022-02-08 14:34:24 +00:00

(Migrated from gitlab.com)

This is achieved by removing cmake parameter ENABLE_MULTIPLE_SONS.

serkixenos commented

2022-02-08 14:34:24 +00:00

(Migrated from gitlab.com)

assigned to @hirunda

hirunda commented

2022-02-09 17:40:35 +00:00

(Migrated from gitlab.com)

assigned to @prandnum

hirunda commented

2022-02-09 17:56:59 +00:00

(Migrated from gitlab.com)

Test steps:
1)
Try to configure with following command

cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_MULTIPLE_SONS=1 -DBUILD_PEERPLAYS_TESTNET=1 .

You should get warning message as following:

CMake Warning:
  Manually-specified variables were not used by the project:

    ENABLE_MULTIPLE_SONS

Configure with the following should be without any warning:

cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_PEERPLAYS_TESTNET=1 .

Build the software from related MR
Run the software with the following config file:
https://gitlab.com/PBSA/tools-libs/peerplays-utils/-/blob/master/peerplays-qa-environment/peerplays/config.ini

software should run without any failure ...

Previously, without related MR , the following error message would pop-up:
"Invalid configuration, multiple SON IDs provided"

Related MR https://gitlab.com/PBSA/peerplays/-/merge_requests/64 Test steps: 1) Try to configure with following command ``` cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_MULTIPLE_SONS=1 -DBUILD_PEERPLAYS_TESTNET=1 . ``` You should get warning message as following: ``` CMake Warning: Manually-specified variables were not used by the project: ENABLE_MULTIPLE_SONS ``` 2) Configure with the following should be without any warning: ``` cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_PEERPLAYS_TESTNET=1 . ``` 3) Build the software from related MR 4) Run the software with the following config file: https://gitlab.com/PBSA/tools-libs/peerplays-utils/-/blob/master/peerplays-qa-environment/peerplays/config.ini software should run without any failure ... Previously, without related MR , the following error message would pop-up: "Invalid configuration, multiple SON IDs provided"

prandnum (Migrated from gitlab.com) closed this issue

2022-02-15 12:08:41 +00:00

prandnum commented

2022-02-15 12:09:07 +00:00

(Migrated from gitlab.com)

Ran the witness node and found no errors.