Refactor GPO and DGPO, move dynamic data from GPO to DGPO #275

New issue

Closed

opened 2022-02-11 15:02:51 +00:00 by serkixenos · 6 comments

serkixenos commented

2022-02-11 15:02:51 +00:00

(Migrated from gitlab.com)

Some of the values in GPO (global property object) are dynamic, they change during time, and these should be removed from GPO to DGPO (dynamic global property object)

At least these four should be moved to DGPO

    "extensions": {
      ...
      "gpos_period": 15552000,
      "gpos_subperiod": 2592000,
      "gpos_period_start": 1644184800,
      "gpos_vesting_lockin_period": 2592000,
      ...
    }

Some of the values in GPO (global property object) are dynamic, they change during time, and these should be removed from GPO to DGPO (dynamic global property object) At least these four should be moved to DGPO ``` "extensions": { ... "gpos_period": 15552000, "gpos_subperiod": 2592000, "gpos_period_start": 1644184800, "gpos_vesting_lockin_period": 2592000, ... } ``` Related to https://gitlab.com/PBSA/peerplays/-/issues/149

serkixenos commented

2022-02-11 15:03:15 +00:00

(Migrated from gitlab.com)

marked this issue as related to #149

serkixenos commented

2022-02-11 15:08:03 +00:00

(Migrated from gitlab.com)

Important read on why this matters:
https://gitlab.com/PBSA/peerplays/-/issues/127

GPOS values (and some others too) are rewritten on chain parameter change proposal execution.

Important read on why this matters: https://gitlab.com/PBSA/peerplays/-/issues/127 GPOS values (and some others too) are rewritten on chain parameter change proposal execution.

serkixenos commented

2022-02-15 14:53:23 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

hbelakon commented

2022-02-17 04:40:54 +00:00

(Migrated from gitlab.com)

changed epic to &489

serkixenos commented

2022-03-01 04:32:22 +00:00

(Migrated from gitlab.com)

Actually, the only value that needs to be transferred to DGPO is

    "extensions": {
      ...
      "gpos_period_start": 1644184800,
      ...
    }

Actually, the only value that needs to be transferred to DGPO is ``` "extensions": { ... "gpos_period_start": 1644184800, ... } ```

serkixenos commented

2022-03-10 21:41:53 +00:00

(Migrated from gitlab.com)

Wont do. gpos_period_start change is prevented with:

https://gitlab.com/PBSA/peerplays/-/issues/149
https://gitlab.com/PBSA/peerplays/-/merge_requests/79

Closing.

Wont do. `gpos_period_start` change is prevented with: https://gitlab.com/PBSA/peerplays/-/issues/149 https://gitlab.com/PBSA/peerplays/-/merge_requests/79 Closing.

serkixenos (Migrated from gitlab.com) closed this issue

2022-03-10 21:41:54 +00:00