Peerplays_Blockchain/peerplays_migrated

[SON-HIVE Voting] Introduce new vote_id for Hive SONs #303

New issue

Closed

opened 2022-03-03 18:33:59 +00:00 by serkixenos · 8 comments

serkixenos commented

2022-03-03 18:33:59 +00:00

(Migrated from gitlab.com)

The goal is to separate voting for Bitcoin and Hive SONs, so that they can act independently of each others.

Current:

   enum vote_type
   {
      committee,
      witness,
      worker,
      son,
      VOTE_TYPE_COUNT
   };

Wanted:

   enum vote_type
   {
      committee,
      witness,
      worker,
      son_bitcoin,
      son_hive,
      VOTE_TYPE_COUNT
   };

All code affected by this change should be refactored, in a way that enables that Bitcoin SON and Hive SON are considered separate entities.

The goal is to separate voting for Bitcoin and Hive SONs, so that they can act independently of each others. Current: ``` enum vote_type { committee, witness, worker, son, VOTE_TYPE_COUNT }; ``` Wanted: ``` enum vote_type { committee, witness, worker, son_bitcoin, son_hive, VOTE_TYPE_COUNT }; ``` All code affected by this change should be refactored, in a way that enables that Bitcoin SON and Hive SON are considered separate entities.

hbelakon commented

2022-03-08 04:11:03 +00:00

(Migrated from gitlab.com)

changed title from Introduce new vote_id for Hive SONs to {+[SON-HIVE Voting] +}Introduce new vote_id for Hive SONs

changed title from **Introduce new vote_id for Hive SONs** to **{+[SON-HIVE Voting] +}Introduce new vote_id for Hive SONs**

hbelakon commented

2022-03-08 04:11:15 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

assigned to @serkixenos

hbelakon commented

2022-03-08 04:11:53 +00:00

(Migrated from gitlab.com)

@serkixenos please estimate

@serkixenos please estimate

serkixenos commented

2022-03-09 03:02:06 +00:00

(Migrated from gitlab.com)

Base your work on feature/son-for-hive-voting branch

https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

Base your work on feature/son-for-hive-voting branch https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

serkixenos commented

2022-03-22 02:13:57 +00:00

(Migrated from gitlab.com)

d39f3f309a/libraries/chain/include/graphene/chain/protocol/vote.hpp (L62)

https://gitlab.com/PBSA/peerplays/-/blob/d39f3f309a8dfb2799fca986d9ac05e40ea09f66/libraries/chain/include/graphene/chain/protocol/vote.hpp#L62

serkixenos (Migrated from gitlab.com) closed this issue

2022-03-22 02:14:09 +00:00

serkixenos commented

2022-03-28 14:12:15 +00:00

(Migrated from gitlab.com)

mentioned in issue #155

mentioned in issue #155

hbelakon commented

2022-04-08 14:51:30 +00:00

(Migrated from gitlab.com)

changed epic to &295

changed epic to &295

hbelakon commented

2022-05-04 18:25:31 +00:00

(Migrated from gitlab.com)

changed epic to &532

changed epic to &532

Sign in to join this conversation.

No labels

priority::Critical

priority::Medium

QA-TestCases::Done

QA-TestCases::InProgress

severity:: Critical

severity:: High

severity:: Medium

state:: Accepted

state:: Blocked

state:: in progress

state:: in review

state:: on hold

state:: Pending

state:: Pushed to Prod

state:: Revision Needed

state::out-of-scope

type :: Discussion

type :: Duplicate

type:: interaction-design

type:: New Feature

type::documentation

type::maintenance

type::recurring-tasks

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#303

No description provided.