[SON-HIVE Voting] Refactor cli wallet command vote_for_son, to enable voting for SON per sidechain #304

New issue

Closed

opened 2022-03-03 18:40:09 +00:00 by serkixenos · 9 comments

serkixenos commented

2022-03-03 18:40:09 +00:00

(Migrated from gitlab.com)

Current:

   signed_transaction vote_for_son(string voting_account,
                                        string son,
                                        bool approve,
                                        bool broadcast /* = false */)

Wanted:

   signed_transaction vote_for_son(string voting_account,
                                        string son,
                                        sidechain_type sidechain,
                                        bool approve,
                                        bool broadcast /* = false */)

The goal is to separate voting for Bitcoin and Hive SONs, so that they can act independently of each others. All code affected by this change should be refactored, in a way that enables that Bitcoin SON and Hive SON are considered separate entities. Current: ``` signed_transaction vote_for_son(string voting_account, string son, bool approve, bool broadcast /* = false */) ``` Wanted: ``` signed_transaction vote_for_son(string voting_account, string son, sidechain_type sidechain, bool approve, bool broadcast /* = false */) ```

hbelakon commented

2022-03-08 04:09:08 +00:00

(Migrated from gitlab.com)

changed title from Refactor cli wallet command vote_for_son, to enable voting for SON per sidechain to {+[SON-HIVE Voting] +}Refactor cli wallet command vote_for_son, to enable voting for SON per sidechain

changed title from **Refactor cli wallet command vote_for_son, to enable voting for SON per sidechain** to **{+[SON-HIVE Voting] +}Refactor cli wallet command vote_for_son, to enable voting for SON per sidechain**

hbelakon commented

2022-03-08 04:09:14 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

hbelakon commented

2022-03-08 04:09:57 +00:00

(Migrated from gitlab.com)

@serkixenos please estimate

serkixenos commented

2022-03-09 03:02:11 +00:00

(Migrated from gitlab.com)

Base your work on feature/son-for-hive-voting branch

https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

Base your work on feature/son-for-hive-voting branch https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

serkixenos commented

2022-03-28 14:12:15 +00:00

(Migrated from gitlab.com)

mentioned in issue #155

pavel.baykov commented

2022-04-06 12:33:12 +00:00

(Migrated from gitlab.com)

assigned to @pavel.baykov

pavel.baykov commented

2022-04-07 11:15:05 +00:00

(Migrated from gitlab.com)

checked voting/unvoting in feature/son-for-hive-voting branch with BTC and HIVE, with 2 voting account and 2 SON account
transfer nathan account01 20000.000 TEST "" true
create_vesting_balance account01 100 TEST gpos true
vote_for_son account01 sonaccount01 1 true true
wait 10 min
checked votes using
get_son sonaccount01
vote_for_son account01 sonaccount01 5 true true
checked votes using
get_son sonaccount01

automated it in endtoendtests

checked voting/unvoting in feature/son-for-hive-voting branch with BTC and HIVE, with 2 voting account and 2 SON account transfer nathan account01 20000.000 TEST "" true create_vesting_balance account01 100 TEST gpos true vote_for_son account01 sonaccount01 1 true true wait 10 min checked votes using get_son sonaccount01 vote_for_son account01 sonaccount01 5 true true checked votes using get_son sonaccount01 automated it in endtoendtests

pavel.baykov (Migrated from gitlab.com) closed this issue

2022-04-08 04:27:07 +00:00

hbelakon commented

2022-04-08 13:52:50 +00:00

(Migrated from gitlab.com)

changed epic to &295

hbelakon commented

2022-05-04 18:35:23 +00:00

(Migrated from gitlab.com)

changed epic to &532