Peerplays_Blockchain/peerplays_migrated

[SON-HIVE Voting] Refactor maintenance block processing to create multiple lists of active SONs, one per sidechain #308

New issue

Closed

opened 2022-03-03 19:05:30 +00:00 by serkixenos · 23 comments

serkixenos commented

2022-03-03 19:05:30 +00:00

(Migrated from gitlab.com)

The goal is to separate voting for Bitcoin and Hive SONs, so that they can act independently of each others.
All code affected by this change should be refactored, in a way that enables that Bitcoin SON and Hive SON are considered separate entities.

Maintenance block processing should create list of active sons per sidechain, considering "per sidechain" votes, so only vote_id_bitcoin for a list of active sons for Bitcoin, and only vote_id_hive for a list of active SONs for Hive.

The goal is to separate voting for Bitcoin and Hive SONs, so that they can act independently of each others. All code affected by this change should be refactored, in a way that enables that Bitcoin SON and Hive SON are considered separate entities. Maintenance block processing should create list of active sons per sidechain, considering "per sidechain" votes, so only vote_id_bitcoin for a list of active sons for Bitcoin, and only vote_id_hive for a list of active SONs for Hive.

serkixenos commented

2022-03-03 19:41:10 +00:00

(Migrated from gitlab.com)

Function of interest:

void database::update_active_sons()

Refactor config checking functions:

   bool son_object::has_valid_config()
   bool son_object::has_valid_config(time_point_sec head_block_time)

If SON was voted as a Bitcoin SON only, has valid config should check ONLY bitcoin configuration. Same goes for Hive.

Function of interest: ``` void database::update_active_sons() ``` Refactor config checking functions: ``` bool son_object::has_valid_config() bool son_object::has_valid_config(time_point_sec head_block_time) ``` If SON was voted as a Bitcoin SON only, has valid config should check ONLY bitcoin configuration. Same goes for Hive.

hbelakon commented

2022-03-08 03:55:34 +00:00

(Migrated from gitlab.com)

changed title from Refactor maintenance block processing to create multiple lists of active SONs, one per sidechain to {+[SON-HIVE Voting] +}Refactor maintenance block processing to create multiple lists of active SONs, one per sidechain

changed title from **Refactor maintenance block processing to create multiple lists of active SONs, one per sidechain** to **{+[SON-HIVE Voting] +}Refactor maintenance block processing to create multiple lists of active SONs, one per sidechain**

hbelakon commented

2022-03-08 03:56:09 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

assigned to @serkixenos

hbelakon commented

2022-03-08 03:56:31 +00:00

(Migrated from gitlab.com)

@serkixenos please estimate

@serkixenos please estimate

serkixenos commented

2022-03-09 03:02:26 +00:00

(Migrated from gitlab.com)

Base your work on feature/son-for-hive-voting branch

https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

Base your work on feature/son-for-hive-voting branch https://gitlab.com/PBSA/peerplays/-/tree/feature/son-for-hive-voting

vampik commented

2022-03-10 14:18:18 +00:00

(Migrated from gitlab.com)

assigned to @vampik

assigned to @vampik

vampik commented

2022-03-28 06:10:49 +00:00

(Migrated from gitlab.com)

mentioned in commit cbca83a90e

mentioned in commit cbca83a90e3c8e6c45ab7ee2b8c73d18a28c9ee2

serkixenos commented

2022-03-28 14:12:16 +00:00

(Migrated from gitlab.com)

mentioned in issue #155

mentioned in issue #155

vampik commented

2022-03-29 05:48:03 +00:00

(Migrated from gitlab.com)

mentioned in commit 32d67b2c30

mentioned in commit 32d67b2c30f0814eec9798180d5bdccdc8279efe

vampik commented

2022-03-31 09:13:32 +00:00

(Migrated from gitlab.com)

mentioned in commit 467522f7d8

mentioned in commit 467522f7d87814fee2012adf2eddd81316a13ea6

vampik commented

2022-04-01 10:05:20 +00:00

(Migrated from gitlab.com)

mentioned in commit f6c9b1b7a6

mentioned in commit f6c9b1b7a6675414ebe6e0c19f24040a54aa7f54

vampik commented

2022-04-04 05:36:59 +00:00

(Migrated from gitlab.com)

mentioned in commit e217fb94f3

mentioned in commit e217fb94f3055b8061ae73c9170ad00ef58f416c

vampik commented

2022-04-05 05:05:16 +00:00

(Migrated from gitlab.com)

mentioned in commit 0d74fcf675

mentioned in commit 0d74fcf675fd0d85f0c7343fc363ae608b7bf277

vampik commented

2022-04-05 05:05:16 +00:00

(Migrated from gitlab.com)

mentioned in commit 550727757f

mentioned in commit 550727757f763af014fc6ea08f2c20cc8a5f6881

vampik commented

2022-04-05 12:24:08 +00:00

(Migrated from gitlab.com)

mentioned in commit 446d89764c

mentioned in commit 446d89764cf6ca6fce74737c453c8c48d2b5e7a4

vampik commented

2022-04-05 12:24:08 +00:00

(Migrated from gitlab.com)

mentioned in commit 7a41307712

mentioned in commit 7a4130771291f9283e5697c84ce6490d00a9d22d

vampik commented

2022-04-05 12:35:29 +00:00

(Migrated from gitlab.com)

mentioned in merge request !92

mentioned in merge request !92

vampik commented

2022-04-06 05:35:00 +00:00

(Migrated from gitlab.com)

There are several "Fixme" comments in the code, that we should resolve in the future.

There are several "Fixme" comments in the code, that we should resolve in the future.

serkixenos commented

2022-04-07 19:06:07 +00:00

(Migrated from gitlab.com)

mentioned in commit eb5ef77aee

mentioned in commit eb5ef77aee0ba189168ad757cfa31bfea7b7ad2b

serkixenos commented

2022-04-07 19:06:07 +00:00

(Migrated from gitlab.com)

mentioned in commit 355b9aae84

mentioned in commit 355b9aae84464a1b592d3b3ce87296e3ef0ca69c

serkixenos commented

2022-04-07 19:07:24 +00:00

(Migrated from gitlab.com)

Merged into son-for-hive-voting, full testing will be done when completed.

Merged into son-for-hive-voting, full testing will be done when completed.

serkixenos (Migrated from gitlab.com) closed this issue

2022-04-07 19:07:27 +00:00

hbelakon commented

2022-04-08 14:41:36 +00:00

(Migrated from gitlab.com)

changed epic to &295

changed epic to &295

hbelakon commented

2022-05-04 18:47:00 +00:00

(Migrated from gitlab.com)

changed epic to &530

changed epic to &530

Sign in to join this conversation.

No labels

priority::Critical

priority::Medium

QA-TestCases::Done

QA-TestCases::InProgress

severity:: Critical

severity:: High

severity:: Medium

state:: Accepted

state:: Blocked

state:: in progress

state:: in review

state:: on hold

state:: Pending

state:: Pushed to Prod

state:: Revision Needed

state::out-of-scope

type :: Discussion

type :: Duplicate

type:: interaction-design

type:: New Feature

type::documentation

type::maintenance

type::recurring-tasks

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#308

No description provided.