Remove hardcoded chain parameters #315

New issue

Closed

opened 2022-03-09 17:28:33 +00:00 by serkixenos · 4 comments

serkixenos commented

2022-03-09 17:28:33 +00:00

(Migrated from gitlab.com)

https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/chain/db_maint.cpp#L2035

libraries/chain/db_maint.cpp contains hardcoded chain params in function void update_son_params(database& db).

The implementation does not control that these parameters are applied only once, immediately after HARDFORK_SON2_TIME, but it will continue to apply them on each maintenance block, which will prevent changes initiated through chain parameter change, or asset update proposal to apply.

Additionally, changing BTC asset properties is redundant, since the asset is already created with appropriate flags.

Remove changing BTC asset properties
Make sure that son count is changes only once, immediately after HARDFORK_SON2_TIME
Test both Mainnet and Testnet implementations

https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/chain/db_maint.cpp#L2035 libraries/chain/db_maint.cpp contains hardcoded chain params in function void update_son_params(database& db). The implementation does not control that these parameters are applied only once, immediately after HARDFORK_SON2_TIME, but it will continue to apply them on each maintenance block, which will prevent changes initiated through chain parameter change, or asset update proposal to apply. Additionally, changing BTC asset properties is redundant, since the asset is already created with appropriate flags. 1. Remove changing BTC asset properties 2. Make sure that son count is changes only once, immediately after HARDFORK_SON2_TIME 3. Test both Mainnet and Testnet implementations

serkixenos commented

2022-03-10 14:15:36 +00:00

(Migrated from gitlab.com)

changed title from Remove hardcoded chain parametrs to Remove hardcoded chain paramet{+e+}rs

changed title from **Remove hardcoded chain parametrs** to **Remove hardcoded chain paramet{+e+}rs**

hirunda commented

2022-03-17 12:38:34 +00:00

(Migrated from gitlab.com)

assigned to @hirunda

hirunda commented

2022-03-17 23:35:59 +00:00

(Migrated from gitlab.com)