deprecated variables used in fc library #34

New issue

Closed

opened 2020-11-16 10:47:16 +00:00 by prandnum · 16 comments

prandnum commented

2020-11-16 10:47:16 +00:00

(Migrated from gitlab.com)

Details: Job #845699070

Branch: develop

Issue:

Following messages are recorded in the build logs \

[ 16%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/openssl.cpp.o
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp: In constructor '˜fc::openssl_scope::openssl_scope()':
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp:33:33: warning: 'void OPENSSL_config(const char)' is deprecated [-Wdeprecated-declarations]*
OPENSSL_config(nullptr);
^
In file included from /usr/include/openssl/ec.h:14:0,
from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/include/fc/crypto/openssl.hpp:2,
from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp:1:
/usr/include/openssl/conf.h:91:1: note: declared here
DEPRECATEDIN_1_1_0(void OPENSSL_config(const char *config_name))
^
[ 16%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/crc.cpp.o\

[ 21%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/network/http/http_connection.cpp.o
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp: In function 'void fc::rand_bytes(char*, int)':
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:11:14: warning: unused variable 'init' [-Wunused-variable]
static int init = init_openssl();
^~~~
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp: In function 'void fc::rand_pseudo_bytes(char*, int)':
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:22:60: warning: 'int RAND_pseudo_bytes(unsigned char, int)' is deprecated [-Wdeprecated-declarations]
int result = RAND_pseudo_bytes((unsigned char)buf, count);
^
In file included from /usr/include/openssl/e_os2.h:13:0,
from /usr/include/openssl/ossl_typ.h:19,
from /usr/include/openssl/rand.h:14,
from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:1:
/usr/include/openssl/rand.h:44:1: note: declared here
DEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int num))
^
/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:20:14: warning: unused variable 'init' [-Wunused-variable]
static int init = init_openssl();
^~~~\

### Details: Job #845699070 ### Branch: develop ### Issue: Following messages are recorded in the build logs \ *** [ 16%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/openssl.cpp.o \ /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp: In constructor '˜fc::openssl_scope::openssl_scope()':\ ****/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp:33:33: warning: 'void OPENSSL_config(const char*)' is deprecated [-Wdeprecated-declarations]****\ OPENSSL_config(nullptr);\ ^ In file included from /usr/include/openssl/ec.h:14:0,\ from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/include/fc/crypto/openssl.hpp:2,\ from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/openssl.cpp:1:\ /usr/include/openssl/conf.h:91:1: note: declared here\ DEPRECATEDIN_1_1_0(void OPENSSL_config(const char *config_name))\ ^ [ 16%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/crc.cpp.o\ *** [ 21%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/network/http/http_connection.cpp.o\ /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp: In function 'void fc::rand_bytes(char*, int)':\ /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:11:14: warning: unused variable 'init' [-Wunused-variable]\ static int init = init_openssl();\ ^~~~ /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp: In function 'void fc::rand_pseudo_bytes(char*, int)':\ ****/home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:22:60: warning: 'int RAND_pseudo_bytes(unsigned char*, int)' is deprecated [-Wdeprecated-declarations]****\ int result = RAND_pseudo_bytes((unsigned char*)buf, count);\ ^\ In file included from /usr/include/openssl/e_os2.h:13:0,\ from /usr/include/openssl/ossl_typ.h:19,\ from /usr/include/openssl/rand.h:14,\ from /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:1:\ /usr/include/openssl/rand.h:44:1: note: declared here\ DEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int num))\ ^\ /home/gitlab-runner/builds/qk1zxGTz/0/PBSA/peerplays/libraries/fc/src/crypto/rand.cpp:20:14: warning: unused variable 'init' [-Wunused-variable]\ static int init = init_openssl();\ ^~~~\ ***

prandnum commented

2020-11-16 10:48:03 +00:00

(Migrated from gitlab.com)

@bobinson please take a look.

bobinson commented

2020-11-16 14:09:04 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

serkixenos commented

2021-01-31 08:36:38 +00:00

(Migrated from gitlab.com)

Many FC build warnings are removed here
5a5154b260

Many FC build warnings are removed here https://gitlab.com/PBSA/peerplays/-/commit/5a5154b260c05c821d5e84a306d89b0123bc8d34

bobinson commented

2021-02-15 05:50:32 +00:00

(Migrated from gitlab.com)

@serkixenos - whats the status with this one ?

serkixenos commented

2021-02-17 12:07:47 +00:00

(Migrated from gitlab.com)

Many FC build warnings are removed here 5a5154b260

These changes are present in both develop and beatrice, but not master.

Due to recent changes in OpenSSL library, regarding config function, it would be best to wait for ticket #44 to complete, and then remove any leftovers in this section.

Many FC build warnings are removed here https://gitlab.com/PBSA/peerplays/-/commit/5a5154b260c05c821d5e84a306d89b0123bc8d34 These changes are present in both develop and beatrice, but not master. Due to recent changes in OpenSSL library, regarding config function, it would be best to wait for ticket #44 to complete, and then remove any leftovers in this section.

serkixenos commented

2021-05-19 12:44:14 +00:00

(Migrated from gitlab.com)

mentioned in issue #111