memo of HIVE and HBD withdraw process is encrypted #369

New issue

Closed

opened 2022-05-16 12:12:54 +00:00 by bobinson · 4 comments

bobinson commented

2022-05-16 12:12:54 +00:00

(Migrated from gitlab.com)

When a SON Hive withdraw is done a transfer is initiated from end user account (ie a Peerplays account) to son-account on the blockchain. Ideally the associated memos must in plain text so that anyone can verify the transactions. While encryption is optional this must not be the default behavior. If there are no side effects its better to keep the default behavior as plain text memo.

Environment : mainnet 1.5.16

new >>> get_account_history son-account 100
get_account_history son-account 100
2022-05-13T16:19:36 asset_reserve_operation son-account fee: 0.01000 PPY
2022-05-13T16:19:36 sidechain_transaction_settle_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:19:33 proposal_create_operation muskelkater-son fee: 0.01051 PPY   result: 1.10.27950
2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:36 proposal_create_operation muskelkater-son fee: 0.01160 PPY   result: 1.10.27949
2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:36 proposal_create_operation brewster-son fee: 0.01160 PPY   result: 1.10.27948
2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:36 proposal_create_operation hiltos-son fee: 0.01160 PPY   result: 1.10.27947
2022-05-13T16:18:33 proposal_create_operation original-son fee: 0.01160 PPY   result: 1.10.27946
2022-05-13T16:18:33 proposal_create_operation will-cook fee: 0.01160 PPY   result: 1.10.27945
2022-05-13T16:18:33 proposal_create_operation yonder-son fee: 0.01160 PPY   result: 1.10.27944
2022-05-13T16:18:33 proposal_create_operation huszar-son fee: 0.01160 PPY   result: 1.10.27943
2022-05-13T16:18:33 sidechain_transaction_create_operation son-account fee: 0 PPY   result: 1.39.9
2022-05-13T16:18:33 son_wallet_withdraw_process_operation son-account fee: 0 PPY   result: 1.37.6
2022-05-13T16:18:30 proposal_create_operation will-cook fee: 0.01961 PPY   result: 1.10.27942
2022-05-13T16:18:27 Transfer 0.103 HIVE from may11 to son-account -- Unlock wallet to see memo.   (Fee: 0.01085 PPY)

other relevant transactions

2022-05-13T16:17:21 Transfer 0.100 HBD from may11 to son-account -- Unlock wallet to see memo.   (Fee: 0.01085 PPY)
2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Unlock wallet to see memo.   (Fee: 0.01090 PPY)

When a SON Hive withdraw is done a transfer is initiated from end user account (ie a Peerplays account) to `son-account` on the blockchain. Ideally the associated memos must in plain text so that anyone can verify the transactions. While encryption is optional this must not be the default behavior. If there are no side effects its better to keep the default behavior as plain text memo. Environment : mainnet 1.5.16 ``` new >>> get_account_history son-account 100 get_account_history son-account 100 2022-05-13T16:19:36 asset_reserve_operation son-account fee: 0.01000 PPY 2022-05-13T16:19:36 sidechain_transaction_settle_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:19:33 proposal_create_operation muskelkater-son fee: 0.01051 PPY result: 1.10.27950 2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:36 proposal_create_operation muskelkater-son fee: 0.01160 PPY result: 1.10.27949 2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:36 proposal_create_operation brewster-son fee: 0.01160 PPY result: 1.10.27948 2022-05-13T16:18:36 sidechain_transaction_sign_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:36 proposal_create_operation hiltos-son fee: 0.01160 PPY result: 1.10.27947 2022-05-13T16:18:33 proposal_create_operation original-son fee: 0.01160 PPY result: 1.10.27946 2022-05-13T16:18:33 proposal_create_operation will-cook fee: 0.01160 PPY result: 1.10.27945 2022-05-13T16:18:33 proposal_create_operation yonder-son fee: 0.01160 PPY result: 1.10.27944 2022-05-13T16:18:33 proposal_create_operation huszar-son fee: 0.01160 PPY result: 1.10.27943 2022-05-13T16:18:33 sidechain_transaction_create_operation son-account fee: 0 PPY result: 1.39.9 2022-05-13T16:18:33 son_wallet_withdraw_process_operation son-account fee: 0 PPY result: 1.37.6 2022-05-13T16:18:30 proposal_create_operation will-cook fee: 0.01961 PPY result: 1.10.27942 2022-05-13T16:18:27 Transfer 0.103 HIVE from may11 to son-account -- Unlock wallet to see memo. (Fee: 0.01085 PPY) ``` other relevant transactions ``` 2022-05-13T16:17:21 Transfer 0.100 HBD from may11 to son-account -- Unlock wallet to see memo. (Fee: 0.01085 PPY) 2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Unlock wallet to see memo. (Fee: 0.01090 PPY) ```

bobinson commented

2022-05-17 12:41:58 +00:00

(Migrated from gitlab.com)

changed the description

bobinson commented

2022-05-17 13:40:43 +00:00

(Migrated from gitlab.com)

additional tests:

Working as expected 1:

Version: test-1.5.4-150-g690a3ff0
Git Revision: 690a3ff0e7dc86b15ee61638df40c8e65335866e
Built: Apr 28 2022 at 07:18:20
SSL: OpenSSL 1.1.1  11 Sep 2018
Boost: 1.67

new >>>

2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Memo: theycallmedan (Fee: 0.01090 PPY)

Working as expected 2:

2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Memo: theycallmedan   (Fee: 0.01090 PPY)

Version: test-1.5.4-155-g23cdcec3
Git Revision: 23cdcec381fa2866c6b24684da99971671bb9165
Built: May 13 2022 at 08:39:08
SSL: OpenSSL 1.1.1  11 Sep 2018
Boost: 1.67
``

additional tests: ## Working as expected 1: ``` Version: test-1.5.4-150-g690a3ff0 Git Revision: 690a3ff0e7dc86b15ee61638df40c8e65335866e Built: Apr 28 2022 at 07:18:20 SSL: OpenSSL 1.1.1 11 Sep 2018 Boost: 1.67 ``` `new >>>` `2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Memo: theycallmedan (Fee: 0.01090 PPY)` --- ## Working as expected 2: ``` 2022-05-11T14:48:39 Transfer 0.010 HIVE from may11 to son-account -- Memo: theycallmedan (Fee: 0.01090 PPY) ``` ``` Version: test-1.5.4-155-g23cdcec3 Git Revision: 23cdcec381fa2866c6b24684da99971671bb9165 Built: May 13 2022 at 08:39:08 SSL: OpenSSL 1.1.1 11 Sep 2018 Boost: 1.67 ``

bobinson commented

2022-05-17 13:40:51 +00:00

(Migrated from gitlab.com)

assigned to @bobinson

hbelakon commented

2022-05-19 23:53:47 +00:00

(Migrated from gitlab.com)

added to epic &80

bobinson (Migrated from gitlab.com) closed this issue

2023-07-24 09:13:52 +00:00