Unit tests for new cli_wallet commands #436

New issue

Closed

opened 2022-09-14 19:29:20 +00:00 by serkixenos · 9 comments

serkixenos commented

2022-09-14 19:29:20 +00:00

(Migrated from gitlab.com)

Implement unit tests for new cli?wallet commands:

   get_active_sons
   get_active_sons_by_sidechain
   get_son_network_status
   get_son_network_status_by_sidechain

Also, remove list_active_sons command and tests, as they are not needed anymore.

Reference tests here https://gitlab.com/PBSA/peerplays/-/tree/master/tests/cli

Implement unit tests for new cli?wallet commands: ``` get_active_sons get_active_sons_by_sidechain get_son_network_status get_son_network_status_by_sidechain ``` Also, remove list_active_sons command and tests, as they are not needed anymore. Reference tests here https://gitlab.com/PBSA/peerplays/-/tree/master/tests/cli

serkixenos commented

2022-09-14 19:29:20 +00:00

(Migrated from gitlab.com)

assigned to @mkhan17

serkixenos commented

2022-10-03 17:01:19 +00:00

(Migrated from gitlab.com)

https://gitlab.com/PBSA/peerplays/-/merge_requests/159

mkhan17 commented

2022-10-04 09:52:52 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and @wsalloum

prandnum commented

2022-10-05 11:08:26 +00:00

(Migrated from gitlab.com)

Build and cli_tests run log cli_tests.log

kiran@warpspeed:~/PBSA/05102022/peerplays$ git log -3
commit 0856e898bb2d0fbe60f9261332049088881bc01f (HEAD -> develop, origin/develop)
Merge: 1b1df250 4db9f3a1
Author: serkixenos <serki.xenos@gmail.com>
Date:   Mon Oct 3 17:34:01 2022 +0000

    Merge branch 'update-cli-wallet-docs' into 'develop'
    
    Update cli wallet docs
    
    See merge request PBSA/peerplays!162

commit 4db9f3a15bfb25ac823a73b50d23dd2e381d87e0
Author: serkixenos <serki.xenos@gmail.com>
Date:   Mon Oct 3 17:34:01 2022 +0000

    Update cli wallet docs

commit 1b1df25023187333707d27fa14331447df3fe9cf
Merge: f9314a4c e6474f5f
Author: serkixenos <serki.xenos@gmail.com>
Date:   Mon Oct 3 17:31:59 2022 +0000

    Merge branch 'bug/fix-api-doc-generation-for-map' into 'develop'
    
    Fix API docs generation for map<> and flat_map<>
    
    See merge request PBSA/peerplays!161
kiran@warpspeed:~/PBSA/05102022/peerplays$

kiran@warpspeed:~/PBSA/436$ grep get_active_sons cli_tests.log 
kiran@warpspeed:~/PBSA/436$ grep get_active_sons_by_sidechain cli_tests.log 
kiran@warpspeed:~/PBSA/436$ grep get_son_network_status cli_tests.log 
kiran@warpspeed:~/PBSA/436$ grep get_son_network_status_by_sidechain cli_tests.log 
kiran@warpspeed:~/PBSA/436$

@mkhan17 I dont see the above commands being run, please review the logs.

Build and cli_tests run log [cli_tests.log](/uploads/61922d4177c456826ecc34fd05d7ad14/cli_tests.log) ``` kiran@warpspeed:~/PBSA/05102022/peerplays$ git log -3 commit 0856e898bb2d0fbe60f9261332049088881bc01f (HEAD -> develop, origin/develop) Merge: 1b1df250 4db9f3a1 Author: serkixenos <serki.xenos@gmail.com> Date: Mon Oct 3 17:34:01 2022 +0000 Merge branch 'update-cli-wallet-docs' into 'develop' Update cli wallet docs See merge request PBSA/peerplays!162 commit 4db9f3a15bfb25ac823a73b50d23dd2e381d87e0 Author: serkixenos <serki.xenos@gmail.com> Date: Mon Oct 3 17:34:01 2022 +0000 Update cli wallet docs commit 1b1df25023187333707d27fa14331447df3fe9cf Merge: f9314a4c e6474f5f Author: serkixenos <serki.xenos@gmail.com> Date: Mon Oct 3 17:31:59 2022 +0000 Merge branch 'bug/fix-api-doc-generation-for-map' into 'develop' Fix API docs generation for map<> and flat_map<> See merge request PBSA/peerplays!161 kiran@warpspeed:~/PBSA/05102022/peerplays$ ``` ``` kiran@warpspeed:~/PBSA/436$ grep get_active_sons cli_tests.log kiran@warpspeed:~/PBSA/436$ grep get_active_sons_by_sidechain cli_tests.log kiran@warpspeed:~/PBSA/436$ grep get_son_network_status cli_tests.log kiran@warpspeed:~/PBSA/436$ grep get_son_network_status_by_sidechain cli_tests.log kiran@warpspeed:~/PBSA/436$ ``` @mkhan17 I dont see the above commands being run, please review the logs.

prandnum commented

2022-10-06 17:03:09 +00:00

(Migrated from gitlab.com)

@mkhan17 please review the logs
CC: @serkixenos

@mkhan17 please review the logs CC: @serkixenos

mkhan17 commented

2022-10-06 17:37:36 +00:00

(Migrated from gitlab.com)

unassigned @prandnum, @mkhan17, and @wsalloum

mkhan17 commented

2022-10-06 17:37:42 +00:00

(Migrated from gitlab.com)