Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

The output of gethelp function in cli_wallet for some functions is not well formatted #450

New issue
Closed
opened 2022-09-20 14:36:09 +00:00 by wsalloum · 20 comments
wsalloum commented 2022-09-20 14:36:09 +00:00 (Migrated from gitlab.com)
Copy link

The output for the gethelp in cli_wallet should be formatted as the following :

new >>> gethelp list_accounts
gethelp list_accounts

Lists all accounts registered in the blockchain. This returns a list of all account names and their account ids, sorted by account name.

Use the 'lowerbound' and limit parameters to page through the list. To
retrieve all accounts, start by setting 'lowerbound' to the empty string
'""', and then each iteration, pass the last account name returned as the
'lowerbound' for the next 'list_accounts()' call.

Command:
    list_accounts lowerbound limit

Parameters:
    lowerbound (string): the name of the first account to return. If the
        named account does not exist, the list will start at the account
        that comes after 'lowerbound'
    limit (integer): the maximum number of accounts to return (max: 1000)

Returns:
    a list of accounts mapping account names to account ids

But it is not well formatted for the following list:

create_account_role
create_bid
create_custom_permission
create_worker
create_account_with_brain_key
create_lottery
create_asset
create_custom_account_authority
create_offer
update_asset_feed_producers
update_account_role
update_custom_account_authority
update_custom_permission
transfer
list_buy_offers
list_event_groups
list_offer_history
list_betting_market_groups
list_committee_members
list_events_in_group
list_offers
list_sports
list_betting_markets
list_core_accounts
list_sell_offers
get_events_containing_sub_string
get_global_betting_statistics
get_key_label
get_account_lotteries
get_account_roles_by_owner
get_limit_orders
get_active_custom_account_authorities_by_operation
get_lotteries
get_lottery_balance
get_total_matched_bet_amount_for_betting_market_group
get_market_history
get_matched_bets_for_bettor
get_tournaments
get_all_matched_bets_for_bettor
get_tournaments_by_state
get_all_unmatched_bets_for_bettor
get_offer_history_by_bidder
get_offer_history_by_issuer
get_offer_history_by_item
get_unmatched_bets_for_bettor
get_offers_by_issuer
get_offers_by_item
get_block
get_order_book
get_blocks
get_private_key
get_call_orders
get_custom_account_authorities
get_public_key
get_custom_account_authorities_by_permission_id
get_custom_account_authorities_by_permission_name
get_settle_orders
get_custom_permission_by_name
get_custom_permissions
set_key_label
set_fees_on_builder_transaction
set_password
settle_asset
sign_builder_transaction

For example :

unlocked >>> gethelp get_tournaments_by_state 
gethelp get_tournaments_by_state 

No help defined for method get_tournaments_by_state

unlocked >>> gethelp get_transaction_id       
gethelp get_transaction_id 

Convert a JSON transaction to its transactin ID.

Command:
    get_transaction_id trx
The output for the gethelp in cli_wallet should be formatted as the following : ``` new >>> gethelp list_accounts gethelp list_accounts Lists all accounts registered in the blockchain. This returns a list of all account names and their account ids, sorted by account name. Use the 'lowerbound' and limit parameters to page through the list. To retrieve all accounts, start by setting 'lowerbound' to the empty string '""', and then each iteration, pass the last account name returned as the 'lowerbound' for the next 'list_accounts()' call. Command: list_accounts lowerbound limit Parameters: lowerbound (string): the name of the first account to return. If the named account does not exist, the list will start at the account that comes after 'lowerbound' limit (integer): the maximum number of accounts to return (max: 1000) Returns: a list of accounts mapping account names to account ids ``` But it is not well formatted for the following list: ``` create_account_role create_bid create_custom_permission create_worker create_account_with_brain_key create_lottery create_asset create_custom_account_authority create_offer update_asset_feed_producers update_account_role update_custom_account_authority update_custom_permission transfer list_buy_offers list_event_groups list_offer_history list_betting_market_groups list_committee_members list_events_in_group list_offers list_sports list_betting_markets list_core_accounts list_sell_offers get_events_containing_sub_string get_global_betting_statistics get_key_label get_account_lotteries get_account_roles_by_owner get_limit_orders get_active_custom_account_authorities_by_operation get_lotteries get_lottery_balance get_total_matched_bet_amount_for_betting_market_group get_market_history get_matched_bets_for_bettor get_tournaments get_all_matched_bets_for_bettor get_tournaments_by_state get_all_unmatched_bets_for_bettor get_offer_history_by_bidder get_offer_history_by_issuer get_offer_history_by_item get_unmatched_bets_for_bettor get_offers_by_issuer get_offers_by_item get_block get_order_book get_blocks get_private_key get_call_orders get_custom_account_authorities get_public_key get_custom_account_authorities_by_permission_id get_custom_account_authorities_by_permission_name get_settle_orders get_custom_permission_by_name get_custom_permissions set_key_label set_fees_on_builder_transaction set_password settle_asset sign_builder_transaction ``` For example : ``` unlocked >>> gethelp get_tournaments_by_state gethelp get_tournaments_by_state No help defined for method get_tournaments_by_state unlocked >>> gethelp get_transaction_id gethelp get_transaction_id Convert a JSON transaction to its transactin ID. Command: get_transaction_id trx ```
serkixenos commented 2022-09-22 12:29:38 +00:00 (Migrated from gitlab.com)
Copy link

@wsalloum Can you review the docs for these functions here:
https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/wallet/include/graphene/wallet/wallet.hpp

Lets check if these functions are documented at all. If not, we do not expect any output from them, but we can consider documenting them. If yes, we can take a closer look into formatting issues.

Split this list into actually documented and not documented at all.

@wsalloum Can you review the docs for these functions here: https://gitlab.com/PBSA/peerplays/-/blob/develop/libraries/wallet/include/graphene/wallet/wallet.hpp Lets check if these functions are documented at all. If not, we do not expect any output from them, but we can consider documenting them. If yes, we can take a closer look into formatting issues. Split this list into actually documented and not documented at all.
timur.5 commented 2022-09-22 12:37:16 +00:00 (Migrated from gitlab.com)
Copy link

Possibly, we should leave no functions without comments
and fail the build if we face undocumented ones in wallet.hpp?

We can mark hidden functions explicitly by something like '@hidden'.
After '@hidden' there can be other comments -
programmers could need them internally.

Possibly, we should leave no functions without comments and fail the build if we face undocumented ones in wallet.hpp? We can mark hidden functions explicitly by something like '\@hidden'. After '\@hidden' there can be other comments - programmers could need them internally.
wsalloum commented 2022-09-26 08:05:06 +00:00 (Migrated from gitlab.com)
Copy link

Not documented:

add_operation_to_builder_transaction
begin_builder_transaction
buy_ticket
cancel_bet
cancel_offer
create_account_role
create_bid
create_custom_account_authority
create_custom_permission
create_lottery
create_offer
dbg_generate_blocks
dbg_make_mia
dbg_make_uia
dbg_push_blocks
dbg_stream_json_objects
dbg_update_object
delete_account_role
delete_custom_account_authority
delete_custom_permission
flood_network
get_account_lotteries
get_account_roles_by_owner
get_active_custom_account_authorities_by_operation
get_all_matched_bets_for_bettor
get_all_unmatched_bets_for_bettor
get_block
get_blocks
get_call_orders
get_custom_account_authorities
get_custom_account_authorities_by_permission_id
get_custom_account_authorities_by_permission_name
get_custom_permission_by_name
get_custom_permissions
get_events_containing_sub_string
get_global_betting_statistics
get_key_label
get_limit_orders
get_lotteries
get_lottery_balance
get_market_history
get_matched_bets_for_bettor
get_offer_history_by_bidder
get_offer_history_by_issuer
get_offer_history_by_item
get_offers_by_issuer
get_offers_by_item
get_order_book
get_public_key
get_settle_orders
get_son_listener_log
get_total_matched_bet_amount_for_betting_market_group
get_tournaments
get_tournaments_by_state
get_unmatched_bets_for_bettor
import_account_keys
import_accounts
list_betting_market_groups
list_betting_markets
list_buy_offers
list_core_accounts
list_event_groups
list_events_in_group
list_offer_history
list_offers
list_sell_offers
list_sports
network_add_nodes
network_get_connected_peers
nft_lottery_buy_ticket
preview_builder_transaction
propose_builder_transaction
propose_builder_transaction2
propose_create_betting_market
propose_create_betting_market_group
propose_create_betting_market_rules
propose_create_event
propose_create_event_group
propose_create_sport
propose_delete_event_group
propose_delete_sport
propose_resolve_betting_market_group
propose_update_betting_market
propose_update_betting_market_group
propose_update_betting_market_rules
propose_update_event
propose_update_event_group
propose_update_sport
remove_builder_transaction
replace_operation_in_builder_transaction
set_fees_on_builder_transaction
set_key_label
sign_builder_transaction
update_account_role
update_custom_account_authority
update_custom_permission

Not formatted:

create_asset
get_private_key
get_transaction_id
import_balance
set_password
transfer
transfer2
update_son
Not documented: ``` add_operation_to_builder_transaction begin_builder_transaction buy_ticket cancel_bet cancel_offer create_account_role create_bid create_custom_account_authority create_custom_permission create_lottery create_offer dbg_generate_blocks dbg_make_mia dbg_make_uia dbg_push_blocks dbg_stream_json_objects dbg_update_object delete_account_role delete_custom_account_authority delete_custom_permission flood_network get_account_lotteries get_account_roles_by_owner get_active_custom_account_authorities_by_operation get_all_matched_bets_for_bettor get_all_unmatched_bets_for_bettor get_block get_blocks get_call_orders get_custom_account_authorities get_custom_account_authorities_by_permission_id get_custom_account_authorities_by_permission_name get_custom_permission_by_name get_custom_permissions get_events_containing_sub_string get_global_betting_statistics get_key_label get_limit_orders get_lotteries get_lottery_balance get_market_history get_matched_bets_for_bettor get_offer_history_by_bidder get_offer_history_by_issuer get_offer_history_by_item get_offers_by_issuer get_offers_by_item get_order_book get_public_key get_settle_orders get_son_listener_log get_total_matched_bet_amount_for_betting_market_group get_tournaments get_tournaments_by_state get_unmatched_bets_for_bettor import_account_keys import_accounts list_betting_market_groups list_betting_markets list_buy_offers list_core_accounts list_event_groups list_events_in_group list_offer_history list_offers list_sell_offers list_sports network_add_nodes network_get_connected_peers nft_lottery_buy_ticket preview_builder_transaction propose_builder_transaction propose_builder_transaction2 propose_create_betting_market propose_create_betting_market_group propose_create_betting_market_rules propose_create_event propose_create_event_group propose_create_sport propose_delete_event_group propose_delete_sport propose_resolve_betting_market_group propose_update_betting_market propose_update_betting_market_group propose_update_betting_market_rules propose_update_event propose_update_event_group propose_update_sport remove_builder_transaction replace_operation_in_builder_transaction set_fees_on_builder_transaction set_key_label sign_builder_transaction update_account_role update_custom_account_authority update_custom_permission ``` Not formatted: ``` create_asset get_private_key get_transaction_id import_balance set_password transfer transfer2 update_son ```
serkixenos commented 2022-09-29 20:10:07 +00:00 (Migrated from gitlab.com)
Copy link

Comments:

create_asset - special case, the gethelp output format differs from usual, but its correct
get_private_key - docs updated, param descriptions added
get_transaction_id - docs updated, param descriptions added
import_balance - docs updated, param descriptions added
set_password - docs updated, param descriptions added
transfer - special case, the gethelp format output differs from usual, but its correct
transfer2 - docs updated, param descriptions added
update_son - gethelp output is as expected

Special gethelp cases:

https://gitlab.com/PBSA/peerplays/-/blob/update-cli-wallet-docs/libraries/wallet/wallet.cpp#L5752

create_account_with_brain_key
create_asset
import_key
register_account
transfer

Additionally documented commands:

add_operation_to_builder_transaction
begin_builder_transaction
preview_builder_transaction
propose_builder_transaction
propose_builder_transaction2
remove_builder_transaction
replace_operation_in_builder_transaction
set_fees_on_builder_transaction
sign_builder_transaction

References:

https://gitlab.com/PBSA/peerplays/-/commits/update-cli-wallet-docs

c0fd97ae52

Comments: ``` create_asset - special case, the gethelp output format differs from usual, but its correct get_private_key - docs updated, param descriptions added get_transaction_id - docs updated, param descriptions added import_balance - docs updated, param descriptions added set_password - docs updated, param descriptions added transfer - special case, the gethelp format output differs from usual, but its correct transfer2 - docs updated, param descriptions added update_son - gethelp output is as expected ``` Special gethelp cases: https://gitlab.com/PBSA/peerplays/-/blob/update-cli-wallet-docs/libraries/wallet/wallet.cpp#L5752 ``` create_account_with_brain_key create_asset import_key register_account transfer ``` Additionally documented commands: ``` add_operation_to_builder_transaction begin_builder_transaction preview_builder_transaction propose_builder_transaction propose_builder_transaction2 remove_builder_transaction replace_operation_in_builder_transaction set_fees_on_builder_transaction sign_builder_transaction ``` References: https://gitlab.com/PBSA/peerplays/-/commits/update-cli-wallet-docs https://gitlab.com/PBSA/peerplays/-/commit/c0fd97ae521b47f883fb09321c6b85f20f8e7d5a
serkixenos commented 2022-09-29 20:12:24 +00:00 (Migrated from gitlab.com)
Copy link

Updated list of undocumented functions

buy_ticket
cancel_bet
cancel_offer
create_account_role
create_bid
create_custom_account_authority
create_custom_permission
create_lottery
create_offer
dbg_generate_blocks
dbg_make_mia
dbg_make_uia
dbg_push_blocks
dbg_stream_json_objects
dbg_update_object
delete_account_role
delete_custom_account_authority
delete_custom_permission
flood_network
get_account_lotteries
get_account_roles_by_owner
get_active_custom_account_authorities_by_operation
get_all_matched_bets_for_bettor
get_all_unmatched_bets_for_bettor
get_block
get_blocks
get_call_orders
get_custom_account_authorities
get_custom_account_authorities_by_permission_id
get_custom_account_authorities_by_permission_name
get_custom_permission_by_name
get_custom_permissions
get_events_containing_sub_string
get_global_betting_statistics
get_key_label
get_limit_orders
get_lotteries
get_lottery_balance
get_market_history
get_matched_bets_for_bettor
get_offer_history_by_bidder
get_offer_history_by_issuer
get_offer_history_by_item
get_offers_by_issuer
get_offers_by_item
get_order_book
get_public_key
get_settle_orders
get_son_listener_log
get_total_matched_bet_amount_for_betting_market_group
get_tournaments
get_tournaments_by_state
get_unmatched_bets_for_bettor
import_account_keys
import_accounts
list_betting_market_groups
list_betting_markets
list_buy_offers
list_core_accounts
list_event_groups
list_events_in_group
list_offer_history
list_offers
list_sell_offers
list_sports
network_add_nodes
network_get_connected_peers
nft_lottery_buy_ticket
propose_create_betting_market
propose_create_betting_market_group
propose_create_betting_market_rules
propose_create_event
propose_create_event_group
propose_create_sport
propose_delete_event_group
propose_delete_sport
propose_resolve_betting_market_group
propose_update_betting_market
propose_update_betting_market_group
propose_update_betting_market_rules
propose_update_event
propose_update_event_group
propose_update_sport
set_key_label
update_account_role
update_custom_account_authority
update_custom_permission
Updated list of undocumented functions ``` buy_ticket cancel_bet cancel_offer create_account_role create_bid create_custom_account_authority create_custom_permission create_lottery create_offer dbg_generate_blocks dbg_make_mia dbg_make_uia dbg_push_blocks dbg_stream_json_objects dbg_update_object delete_account_role delete_custom_account_authority delete_custom_permission flood_network get_account_lotteries get_account_roles_by_owner get_active_custom_account_authorities_by_operation get_all_matched_bets_for_bettor get_all_unmatched_bets_for_bettor get_block get_blocks get_call_orders get_custom_account_authorities get_custom_account_authorities_by_permission_id get_custom_account_authorities_by_permission_name get_custom_permission_by_name get_custom_permissions get_events_containing_sub_string get_global_betting_statistics get_key_label get_limit_orders get_lotteries get_lottery_balance get_market_history get_matched_bets_for_bettor get_offer_history_by_bidder get_offer_history_by_issuer get_offer_history_by_item get_offers_by_issuer get_offers_by_item get_order_book get_public_key get_settle_orders get_son_listener_log get_total_matched_bet_amount_for_betting_market_group get_tournaments get_tournaments_by_state get_unmatched_bets_for_bettor import_account_keys import_accounts list_betting_market_groups list_betting_markets list_buy_offers list_core_accounts list_event_groups list_events_in_group list_offer_history list_offers list_sell_offers list_sports network_add_nodes network_get_connected_peers nft_lottery_buy_ticket propose_create_betting_market propose_create_betting_market_group propose_create_betting_market_rules propose_create_event propose_create_event_group propose_create_sport propose_delete_event_group propose_delete_sport propose_resolve_betting_market_group propose_update_betting_market propose_update_betting_market_group propose_update_betting_market_rules propose_update_event propose_update_event_group propose_update_sport set_key_label update_account_role update_custom_account_authority update_custom_permission ```
serkixenos commented 2022-10-02 13:59:05 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #460

mentioned in issue #460
serkixenos commented 2022-10-03 17:48:03 +00:00 (Migrated from gitlab.com)
Copy link

Some fixes applied throught this ticket https://gitlab.com/PBSA/peerplays/-/issues/460 MRs https://gitlab.com/PBSA/peerplays/-/merge_requests/161 and https://gitlab.com/PBSA/peerplays/-/merge_requests/162

Some fixes applied throught this ticket https://gitlab.com/PBSA/peerplays/-/issues/460 MRs https://gitlab.com/PBSA/peerplays/-/merge_requests/161 and https://gitlab.com/PBSA/peerplays/-/merge_requests/162
serkixenos commented 2022-10-14 18:43:50 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @milo_peerplays

assigned to @milo_peerplays
milo_peerplays commented 2022-10-20 12:00:45 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !167

mentioned in merge request !167
milo_peerplays commented 2022-10-25 10:49:00 +00:00 (Migrated from gitlab.com)
Copy link

Additional fixes added as part of !168 MR.

Additional fixes added as part of !168 MR.
milo_peerplays commented 2022-10-25 10:50:10 +00:00 (Migrated from gitlab.com)
Copy link

The updated state of methods missing the documentation and the reason for missing:

buy_ticket - missing in PP
cancel_bet - missing in PP
cancel_offer - missing in PP
create_account_role - missing in PP
create_bid - missing in PP
create_custom_account_authority - missing in PP
create_custom_permission - missing in PP
create_lottery - missing in PP
create_offer - missing in PP
dbg_generate_blocks - missing in both
dbg_make_mia - missing in both
dbg_make_uia - missing in both
dbg_push_blocks - missing in both
dbg_stream_json_objects - missing in both
dbg_update_object - missing in both
delete_account_role - missing in PP
delete_custom_account_authority - missing in PP
delete_custom_permission  - missing in both
flood_network  - missing in both
get_account_lotteries  - missing in PP
get_account_roles_by_owner  - missing in PP
get_active_custom_account_authorities_by_operation  - missing in PP
get_all_matched_bets_for_bettor  - missing in PP
get_all_unmatched_bets_for_bettor - missing in PP
get_custom_account_authorities - missing in PP
get_custom_account_authorities_by_permission_id - missing in PP
get_custom_account_authorities_by_permission_name - missing in PP
get_custom_permission_by_name - missing in PP
get_custom_permissions - missing in PP
get_events_containing_sub_string - missing in PP
get_global_betting_statistics - missing in PP
get_key_label - not displayed
get_lotteries - missing in PP
get_lottery_balance - missing in PP
get_matched_bets_for_bettor - missing in PP
get_offer_history_by_bidder - missing in PP
get_offer_history_by_issuer - missing in PP
get_offer_history_by_item - missing in PP
get_offers_by_issuer - missing in PP
get_offers_by_item - missing in PP
get_total_matched_bet_amount_for_betting_market_group - missing in PP
get_tournaments - missing in PP
get_tournaments_by_state - missing in PP
get_unmatched_bets_for_bettor - missing in PP
list_betting_market_groups - missing in PP
list_betting_markets - missing in PP
list_buy_offers - missing in PP
list_core_accounts - missing in PP
list_event_groups - missing in PP
list_events_in_group - missing in PP
list_offer_history - missing in PP
list_offers - missing in PP
list_sell_offers - missing in PP
list_sports - missing in PP
network_add_nodes - missing in both
network_get_connected_peers - missing in both
nft_lottery_buy_ticket - missing in PP
propose_create_betting_market - missing in PP
propose_create_betting_market_group - missing in PP
propose_create_betting_market_rules - missing in PP
propose_create_event - missing in PP
propose_create_event_group - missing in PP
propose_create_sport - missing in PP
propose_delete_event_group - missing in PP
propose_delete_sport - missing in PP
propose_resolve_betting_market_group - missing in PP
propose_update_betting_market - missing in PP
propose_update_betting_market_group - missing in PP
propose_update_betting_market_rules - missing in PP
propose_update_event - missing in PP
propose_update_event_group - missing in PP
propose_update_sport - missing in PP
set_key_label - not displayed
update_account_role - missing in PP
update_custom_account_authority - missing in PP
update_custom_permission - missing in PP
The updated state of methods missing the documentation and the reason for missing: ``` buy_ticket - missing in PP cancel_bet - missing in PP cancel_offer - missing in PP create_account_role - missing in PP create_bid - missing in PP create_custom_account_authority - missing in PP create_custom_permission - missing in PP create_lottery - missing in PP create_offer - missing in PP dbg_generate_blocks - missing in both dbg_make_mia - missing in both dbg_make_uia - missing in both dbg_push_blocks - missing in both dbg_stream_json_objects - missing in both dbg_update_object - missing in both delete_account_role - missing in PP delete_custom_account_authority - missing in PP delete_custom_permission - missing in both flood_network - missing in both get_account_lotteries - missing in PP get_account_roles_by_owner - missing in PP get_active_custom_account_authorities_by_operation - missing in PP get_all_matched_bets_for_bettor - missing in PP get_all_unmatched_bets_for_bettor - missing in PP get_custom_account_authorities - missing in PP get_custom_account_authorities_by_permission_id - missing in PP get_custom_account_authorities_by_permission_name - missing in PP get_custom_permission_by_name - missing in PP get_custom_permissions - missing in PP get_events_containing_sub_string - missing in PP get_global_betting_statistics - missing in PP get_key_label - not displayed get_lotteries - missing in PP get_lottery_balance - missing in PP get_matched_bets_for_bettor - missing in PP get_offer_history_by_bidder - missing in PP get_offer_history_by_issuer - missing in PP get_offer_history_by_item - missing in PP get_offers_by_issuer - missing in PP get_offers_by_item - missing in PP get_total_matched_bet_amount_for_betting_market_group - missing in PP get_tournaments - missing in PP get_tournaments_by_state - missing in PP get_unmatched_bets_for_bettor - missing in PP list_betting_market_groups - missing in PP list_betting_markets - missing in PP list_buy_offers - missing in PP list_core_accounts - missing in PP list_event_groups - missing in PP list_events_in_group - missing in PP list_offer_history - missing in PP list_offers - missing in PP list_sell_offers - missing in PP list_sports - missing in PP network_add_nodes - missing in both network_get_connected_peers - missing in both nft_lottery_buy_ticket - missing in PP propose_create_betting_market - missing in PP propose_create_betting_market_group - missing in PP propose_create_betting_market_rules - missing in PP propose_create_event - missing in PP propose_create_event_group - missing in PP propose_create_sport - missing in PP propose_delete_event_group - missing in PP propose_delete_sport - missing in PP propose_resolve_betting_market_group - missing in PP propose_update_betting_market - missing in PP propose_update_betting_market_group - missing in PP propose_update_betting_market_rules - missing in PP propose_update_event - missing in PP propose_update_event_group - missing in PP propose_update_sport - missing in PP set_key_label - not displayed update_account_role - missing in PP update_custom_account_authority - missing in PP update_custom_permission - missing in PP ```
milo_peerplays commented 2022-10-26 12:14:24 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !170

mentioned in merge request !170
milo_peerplays commented 2022-10-29 17:42:33 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 43ce3f517b1a18bf8373f3cd37f04dbcbcb5645a

mentioned in commit 43ce3f517b1a18bf8373f3cd37f04dbcbcb5645a
serkixenos commented 2022-10-29 17:42:33 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 034c7e83fc15295eb7a00fcf7d9d6cf44a5a6306

mentioned in commit 034c7e83fc15295eb7a00fcf7d9d6cf44a5a6306
serkixenos commented 2022-10-30 02:28:07 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 06bc65cc79

mentioned in commit 06bc65cc7929074bffe6acc63f5ad95178351241
serkixenos commented 2022-10-30 02:43:35 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @wsalloum and @prandnum

assigned to @wsalloum and @prandnum
prandnum commented 2022-11-05 14:31:47 +00:00 (Migrated from gitlab.com)
Copy link

@milo_peerplays what is the expected behavior? get_key_label and set_key_label help is not proper.

unlocked >>> gethelp get_key_label 
gethelp get_key_label 
6 key_not_found_exception: Key Not Found
No entry for method get_key_label
    {"name":"get_key_label"}
    th_a  api_documentation.hpp:66 get_detailed_description
unlocked >>> gethelp  set_key_label 
gethelp  set_key_label 
6 key_not_found_exception: Key Not Found
No entry for method set_key_label
    {"name":"set_key_label"}
    th_a  api_documentation.hpp:66 get_detailed_description
unlocked >>>

Following is the current behavior:

unlocked >>> gethelp  buy_ticket
gethelp  buy_ticket

No help defined for method buy_ticket

unlocked >>> gethelp  cancel_bet
gethelp  cancel_bet

No help defined for method cancel_bet

unlocked >>> gethelp  cancel_offer
gethelp  cancel_offer

No help defined for method cancel_offer

unlocked >>> gethelp  create_account_role
gethelp  create_account_role

No help defined for method create_account_role

unlocked >>> gethelp  create_bid
gethelp  create_bid

No help defined for method create_bid

unlocked >>> gethelp  create_custom_account_authority
gethelp  create_custom_account_authority

No help defined for method create_custom_account_authority

unlocked >>> gethelp  create_custom_permission
gethelp  create_custom_permission

No help defined for method create_custom_permission

unlocked >>> gethelp  create_lottery
gethelp  create_lottery

No help defined for method create_lottery

unlocked >>> gethelp  create_offer
gethelp  create_offer

No help defined for method create_offer

unlocked >>> gethelp  dbg_generate_blocks
gethelp  dbg_generate_blocks

No help defined for method dbg_generate_blocks

unlocked >>> gethelp  dbg_make_mia
gethelp  dbg_make_mia

No help defined for method dbg_make_mia

unlocked >>> gethelp  dbg_make_uia
gethelp  dbg_make_uia

No help defined for method dbg_make_uia

unlocked >>> gethelp  dbg_push_blocks
gethelp  dbg_push_blocks

No help defined for method dbg_push_blocks

unlocked >>> gethelp  dbg_stream_json_objects
gethelp  dbg_stream_json_objects

No help defined for method dbg_stream_json_objects

unlocked >>> gethelp  dbg_update_object
gethelp  dbg_update_object

No help defined for method dbg_update_object

unlocked >>> gethelp  delete_account_role
gethelp  delete_account_role

No help defined for method delete_account_role

unlocked >>> gethelp  delete_custom_account_authority
gethelp  delete_custom_account_authority

No help defined for method delete_custom_account_authority

unlocked >>> gethelp  delete_custom_permission
gethelp  delete_custom_permission

No help defined for method delete_custom_permission

unlocked >>> gethelp  flood_network
gethelp  flood_network

No help defined for method flood_network

unlocked >>> gethelp  get_account_lotteries
gethelp  get_account_lotteries

No help defined for method get_account_lotteries

unlocked >>> gethelp  get_account_roles_by_owner
gethelp  get_account_roles_by_owner

No help defined for method get_account_roles_by_owner

unlocked >>> gethelp  get_active_custom_account_authorities_by_operation
gethelp  get_active_custom_account_authorities_by_operation

No help defined for method get_active_custom_account_authorities_by_operation

unlocked >>> gethelp  get_all_matched_bets_for_bettor
gethelp  get_all_matched_bets_for_bettor

No help defined for method get_all_matched_bets_for_bettor

unlocked >>> gethelp  get_all_unmatched_bets_for_bettor
gethelp  get_all_unmatched_bets_for_bettor

No help defined for method get_all_unmatched_bets_for_bettor

unlocked >>> gethelp  get_custom_account_authorities
gethelp  get_custom_account_authorities

No help defined for method get_custom_account_authorities

unlocked >>> gethelp  get_custom_account_authorities_by_permission_id
gethelp  get_custom_account_authorities_by_permission_id

No help defined for method get_custom_account_authorities_by_permission_id

unlocked >>> gethelp  get_custom_account_authorities_by_permission_name
gethelp  get_custom_account_authorities_by_permission_name

No help defined for method get_custom_account_authorities_by_permission_name

unlocked >>> gethelp  get_custom_permission_by_name
gethelp  get_custom_permission_by_name

No help defined for method get_custom_permission_by_name

unlocked >>> gethelp  get_custom_permissions
gethelp  get_custom_permissions

No help defined for method get_custom_permissions

unlocked >>> gethelp  get_events_containing_sub_string
gethelp  get_events_containing_sub_string

No help defined for method get_events_containing_sub_string

unlocked >>> gethelp  get_global_betting_statistics
gethelp  get_global_betting_statistics

No help defined for method get_global_betting_statistics

unlocked >>> gethelp  get_key_label
gethelp  get_key_label
6 key_not_found_exception: Key Not Found
No entry for method get_key_label
    {"name":"get_key_label"}
    th_a  api_documentation.hpp:66 get_detailed_description
unlocked >>> gethelp  get_lotteries
gethelp  get_lotteries

No help defined for method get_lotteries

unlocked >>> gethelp  get_lottery_balance
gethelp  get_lottery_balance

No help defined for method get_lottery_balance

unlocked >>> gethelp  get_matched_bets_for_bettor
gethelp  get_matched_bets_for_bettor

No help defined for method get_matched_bets_for_bettor

unlocked >>> gethelp  get_offer_history_by_bidder
gethelp  get_offer_history_by_bidder

No help defined for method get_offer_history_by_bidder

unlocked >>> gethelp  get_offer_history_by_issuer
gethelp  get_offer_history_by_issuer

No help defined for method get_offer_history_by_issuer

unlocked >>> gethelp  get_offer_history_by_item
gethelp  get_offer_history_by_item

No help defined for method get_offer_history_by_item

unlocked >>> gethelp  get_offers_by_issuer
gethelp  get_offers_by_issuer

No help defined for method get_offers_by_issuer

unlocked >>> gethelp  get_offers_by_item
gethelp  get_offers_by_item

No help defined for method get_offers_by_item

unlocked >>> gethelp  get_total_matched_bet_amount_for_betting_market_group
gethelp  get_total_matched_bet_amount_for_betting_market_group

No help defined for method get_total_matched_bet_amount_for_betting_market_group

unlocked >>> gethelp  get_tournaments
gethelp  get_tournaments

No help defined for method get_tournaments

unlocked >>> gethelp  get_tournaments_by_state
gethelp  get_tournaments_by_state

No help defined for method get_tournaments_by_state

unlocked >>> gethelp  get_unmatched_bets_for_bettor
gethelp  get_unmatched_bets_for_bettor

No help defined for method get_unmatched_bets_for_bettor

unlocked >>> gethelp  list_betting_market_groups
gethelp  list_betting_market_groups

No help defined for method list_betting_market_groups

unlocked >>> gethelp  list_betting_markets
gethelp  list_betting_markets

No help defined for method list_betting_markets

unlocked >>> gethelp  list_buy_offers
gethelp  list_buy_offers

No help defined for method list_buy_offers

unlocked >>> gethelp  list_core_accounts
gethelp  list_core_accounts

No help defined for method list_core_accounts

unlocked >>> gethelp  list_event_groups
gethelp  list_event_groups

No help defined for method list_event_groups

unlocked >>> gethelp  list_events_in_group
gethelp  list_events_in_group

No help defined for method list_events_in_group

unlocked >>> gethelp  list_offer_history
gethelp  list_offer_history

No help defined for method list_offer_history

unlocked >>> gethelp  list_offers
gethelp  list_offers

No help defined for method list_offers

unlocked >>> gethelp  list_sell_offers
gethelp  list_sell_offers

No help defined for method list_sell_offers

unlocked >>> gethelp  list_sports
gethelp  list_sports

No help defined for method list_sports

unlocked >>> gethelp  network_add_nodes
gethelp  network_add_nodes

No help defined for method network_add_nodes

unlocked >>> gethelp  network_get_connected_peers
gethelp  network_get_connected_peers

No help defined for method network_get_connected_peers

unlocked >>> gethelp  nft_lottery_buy_ticket
gethelp  nft_lottery_buy_ticket

No help defined for method nft_lottery_buy_ticket

unlocked >>> gethelp  propose_create_betting_market
gethelp  propose_create_betting_market

No help defined for method propose_create_betting_market

unlocked >>> gethelp  propose_create_betting_market_group
gethelp  propose_create_betting_market_group

No help defined for method propose_create_betting_market_group

unlocked >>> gethelp  propose_create_betting_market_rules
gethelp  propose_create_betting_market_rules

No help defined for method propose_create_betting_market_rules

unlocked >>> gethelp  propose_create_event
gethelp  propose_create_event

No help defined for method propose_create_event

unlocked >>> gethelp  propose_create_event_group
gethelp  propose_create_event_group

No help defined for method propose_create_event_group

unlocked >>> gethelp  propose_create_sport
gethelp  propose_create_sport

No help defined for method propose_create_sport

unlocked >>> gethelp  propose_delete_event_group
gethelp  propose_delete_event_group

No help defined for method propose_delete_event_group

unlocked >>> gethelp  propose_delete_sport
gethelp  propose_delete_sport

No help defined for method propose_delete_sport

unlocked >>> gethelp  propose_resolve_betting_market_group
gethelp  propose_resolve_betting_market_group

No help defined for method propose_resolve_betting_market_group

unlocked >>> gethelp  propose_update_betting_market
gethelp  propose_update_betting_market

No help defined for method propose_update_betting_market

unlocked >>> gethelp  propose_update_betting_market_group
gethelp  propose_update_betting_market_group

No help defined for method propose_update_betting_market_group

unlocked >>> gethelp  propose_update_betting_market_rules
gethelp  propose_update_betting_market_rules

No help defined for method propose_update_betting_market_rules

unlocked >>> gethelp  propose_update_event
gethelp  propose_update_event

No help defined for method propose_update_event

unlocked >>> gethelp  propose_update_event_group
gethelp  propose_update_event_group

No help defined for method propose_update_event_group

unlocked >>> gethelp  propose_update_sport
gethelp  propose_update_sport

No help defined for method propose_update_sport

unlocked >>> gethelp  set_key_label
gethelp  set_key_label
6 key_not_found_exception: Key Not Found
No entry for method set_key_label
    {"name":"set_key_label"}
    th_a  api_documentation.hpp:66 get_detailed_description
unlocked >>> gethelp  update_account_role
gethelp  update_account_role

No help defined for method update_account_role

unlocked >>> gethelp  update_custom_account_authority
gethelp  update_custom_account_authority

No help defined for method update_custom_account_authority

unlocked >>> gethelp  update_custom_permission
gethelp  update_custom_permission

No help defined for method update_custom_permission

unlocked >>>
@milo_peerplays what is the expected behavior? get_key_label and set_key_label help is not proper. ``` unlocked >>> gethelp get_key_label gethelp get_key_label 6 key_not_found_exception: Key Not Found No entry for method get_key_label {"name":"get_key_label"} th_a api_documentation.hpp:66 get_detailed_description unlocked >>> gethelp set_key_label gethelp set_key_label 6 key_not_found_exception: Key Not Found No entry for method set_key_label {"name":"set_key_label"} th_a api_documentation.hpp:66 get_detailed_description unlocked >>> ``` Following is the current behavior: ``` unlocked >>> gethelp buy_ticket gethelp buy_ticket No help defined for method buy_ticket unlocked >>> gethelp cancel_bet gethelp cancel_bet No help defined for method cancel_bet unlocked >>> gethelp cancel_offer gethelp cancel_offer No help defined for method cancel_offer unlocked >>> gethelp create_account_role gethelp create_account_role No help defined for method create_account_role unlocked >>> gethelp create_bid gethelp create_bid No help defined for method create_bid unlocked >>> gethelp create_custom_account_authority gethelp create_custom_account_authority No help defined for method create_custom_account_authority unlocked >>> gethelp create_custom_permission gethelp create_custom_permission No help defined for method create_custom_permission unlocked >>> gethelp create_lottery gethelp create_lottery No help defined for method create_lottery unlocked >>> gethelp create_offer gethelp create_offer No help defined for method create_offer unlocked >>> gethelp dbg_generate_blocks gethelp dbg_generate_blocks No help defined for method dbg_generate_blocks unlocked >>> gethelp dbg_make_mia gethelp dbg_make_mia No help defined for method dbg_make_mia unlocked >>> gethelp dbg_make_uia gethelp dbg_make_uia No help defined for method dbg_make_uia unlocked >>> gethelp dbg_push_blocks gethelp dbg_push_blocks No help defined for method dbg_push_blocks unlocked >>> gethelp dbg_stream_json_objects gethelp dbg_stream_json_objects No help defined for method dbg_stream_json_objects unlocked >>> gethelp dbg_update_object gethelp dbg_update_object No help defined for method dbg_update_object unlocked >>> gethelp delete_account_role gethelp delete_account_role No help defined for method delete_account_role unlocked >>> gethelp delete_custom_account_authority gethelp delete_custom_account_authority No help defined for method delete_custom_account_authority unlocked >>> gethelp delete_custom_permission gethelp delete_custom_permission No help defined for method delete_custom_permission unlocked >>> gethelp flood_network gethelp flood_network No help defined for method flood_network unlocked >>> gethelp get_account_lotteries gethelp get_account_lotteries No help defined for method get_account_lotteries unlocked >>> gethelp get_account_roles_by_owner gethelp get_account_roles_by_owner No help defined for method get_account_roles_by_owner unlocked >>> gethelp get_active_custom_account_authorities_by_operation gethelp get_active_custom_account_authorities_by_operation No help defined for method get_active_custom_account_authorities_by_operation unlocked >>> gethelp get_all_matched_bets_for_bettor gethelp get_all_matched_bets_for_bettor No help defined for method get_all_matched_bets_for_bettor unlocked >>> gethelp get_all_unmatched_bets_for_bettor gethelp get_all_unmatched_bets_for_bettor No help defined for method get_all_unmatched_bets_for_bettor unlocked >>> gethelp get_custom_account_authorities gethelp get_custom_account_authorities No help defined for method get_custom_account_authorities unlocked >>> gethelp get_custom_account_authorities_by_permission_id gethelp get_custom_account_authorities_by_permission_id No help defined for method get_custom_account_authorities_by_permission_id unlocked >>> gethelp get_custom_account_authorities_by_permission_name gethelp get_custom_account_authorities_by_permission_name No help defined for method get_custom_account_authorities_by_permission_name unlocked >>> gethelp get_custom_permission_by_name gethelp get_custom_permission_by_name No help defined for method get_custom_permission_by_name unlocked >>> gethelp get_custom_permissions gethelp get_custom_permissions No help defined for method get_custom_permissions unlocked >>> gethelp get_events_containing_sub_string gethelp get_events_containing_sub_string No help defined for method get_events_containing_sub_string unlocked >>> gethelp get_global_betting_statistics gethelp get_global_betting_statistics No help defined for method get_global_betting_statistics unlocked >>> gethelp get_key_label gethelp get_key_label 6 key_not_found_exception: Key Not Found No entry for method get_key_label {"name":"get_key_label"} th_a api_documentation.hpp:66 get_detailed_description unlocked >>> gethelp get_lotteries gethelp get_lotteries No help defined for method get_lotteries unlocked >>> gethelp get_lottery_balance gethelp get_lottery_balance No help defined for method get_lottery_balance unlocked >>> gethelp get_matched_bets_for_bettor gethelp get_matched_bets_for_bettor No help defined for method get_matched_bets_for_bettor unlocked >>> gethelp get_offer_history_by_bidder gethelp get_offer_history_by_bidder No help defined for method get_offer_history_by_bidder unlocked >>> gethelp get_offer_history_by_issuer gethelp get_offer_history_by_issuer No help defined for method get_offer_history_by_issuer unlocked >>> gethelp get_offer_history_by_item gethelp get_offer_history_by_item No help defined for method get_offer_history_by_item unlocked >>> gethelp get_offers_by_issuer gethelp get_offers_by_issuer No help defined for method get_offers_by_issuer unlocked >>> gethelp get_offers_by_item gethelp get_offers_by_item No help defined for method get_offers_by_item unlocked >>> gethelp get_total_matched_bet_amount_for_betting_market_group gethelp get_total_matched_bet_amount_for_betting_market_group No help defined for method get_total_matched_bet_amount_for_betting_market_group unlocked >>> gethelp get_tournaments gethelp get_tournaments No help defined for method get_tournaments unlocked >>> gethelp get_tournaments_by_state gethelp get_tournaments_by_state No help defined for method get_tournaments_by_state unlocked >>> gethelp get_unmatched_bets_for_bettor gethelp get_unmatched_bets_for_bettor No help defined for method get_unmatched_bets_for_bettor unlocked >>> gethelp list_betting_market_groups gethelp list_betting_market_groups No help defined for method list_betting_market_groups unlocked >>> gethelp list_betting_markets gethelp list_betting_markets No help defined for method list_betting_markets unlocked >>> gethelp list_buy_offers gethelp list_buy_offers No help defined for method list_buy_offers unlocked >>> gethelp list_core_accounts gethelp list_core_accounts No help defined for method list_core_accounts unlocked >>> gethelp list_event_groups gethelp list_event_groups No help defined for method list_event_groups unlocked >>> gethelp list_events_in_group gethelp list_events_in_group No help defined for method list_events_in_group unlocked >>> gethelp list_offer_history gethelp list_offer_history No help defined for method list_offer_history unlocked >>> gethelp list_offers gethelp list_offers No help defined for method list_offers unlocked >>> gethelp list_sell_offers gethelp list_sell_offers No help defined for method list_sell_offers unlocked >>> gethelp list_sports gethelp list_sports No help defined for method list_sports unlocked >>> gethelp network_add_nodes gethelp network_add_nodes No help defined for method network_add_nodes unlocked >>> gethelp network_get_connected_peers gethelp network_get_connected_peers No help defined for method network_get_connected_peers unlocked >>> gethelp nft_lottery_buy_ticket gethelp nft_lottery_buy_ticket No help defined for method nft_lottery_buy_ticket unlocked >>> gethelp propose_create_betting_market gethelp propose_create_betting_market No help defined for method propose_create_betting_market unlocked >>> gethelp propose_create_betting_market_group gethelp propose_create_betting_market_group No help defined for method propose_create_betting_market_group unlocked >>> gethelp propose_create_betting_market_rules gethelp propose_create_betting_market_rules No help defined for method propose_create_betting_market_rules unlocked >>> gethelp propose_create_event gethelp propose_create_event No help defined for method propose_create_event unlocked >>> gethelp propose_create_event_group gethelp propose_create_event_group No help defined for method propose_create_event_group unlocked >>> gethelp propose_create_sport gethelp propose_create_sport No help defined for method propose_create_sport unlocked >>> gethelp propose_delete_event_group gethelp propose_delete_event_group No help defined for method propose_delete_event_group unlocked >>> gethelp propose_delete_sport gethelp propose_delete_sport No help defined for method propose_delete_sport unlocked >>> gethelp propose_resolve_betting_market_group gethelp propose_resolve_betting_market_group No help defined for method propose_resolve_betting_market_group unlocked >>> gethelp propose_update_betting_market gethelp propose_update_betting_market No help defined for method propose_update_betting_market unlocked >>> gethelp propose_update_betting_market_group gethelp propose_update_betting_market_group No help defined for method propose_update_betting_market_group unlocked >>> gethelp propose_update_betting_market_rules gethelp propose_update_betting_market_rules No help defined for method propose_update_betting_market_rules unlocked >>> gethelp propose_update_event gethelp propose_update_event No help defined for method propose_update_event unlocked >>> gethelp propose_update_event_group gethelp propose_update_event_group No help defined for method propose_update_event_group unlocked >>> gethelp propose_update_sport gethelp propose_update_sport No help defined for method propose_update_sport unlocked >>> gethelp set_key_label gethelp set_key_label 6 key_not_found_exception: Key Not Found No entry for method set_key_label {"name":"set_key_label"} th_a api_documentation.hpp:66 get_detailed_description unlocked >>> gethelp update_account_role gethelp update_account_role No help defined for method update_account_role unlocked >>> gethelp update_custom_account_authority gethelp update_custom_account_authority No help defined for method update_custom_account_authority unlocked >>> gethelp update_custom_permission gethelp update_custom_permission No help defined for method update_custom_permission unlocked >>> ```
prandnum commented 2022-11-07 19:05:13 +00:00 (Migrated from gitlab.com)
Copy link

@milo_peerplays could you please provide your comments on the above.

@milo_peerplays could you please provide your comments on the above.
milo_peerplays commented 2022-11-08 12:22:42 +00:00 (Migrated from gitlab.com)
Copy link

That is expected. We have been discussing it in the daily. These 3 methods do not have documentation:
set_key_label, get_key_label and get_public_key.

That is expected. We have been discussing it in the daily. These 3 methods do not have documentation: `set_key_label`, `get_key_label` and `get_public_key`.
prandnum commented 2022-11-09 17:28:04 +00:00 (Migrated from gitlab.com)
Copy link

closing this ticket with above comments.

closing this ticket with above comments.
prandnum (Migrated from gitlab.com) closed this issue 2022-11-09 17:28:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/579-enable-hardfork-check
develop
beatrice
feature/577-sidechain-plugin
hotfix/bookie2024
feature/568-static-libbitcoin
567-update-dockerfile
docs/readme-build-subdirectory
local_dev_subscribe_address
feature/release-automation-changelogs
feature/remove-image-e2e-tests
feature/installer-script
local_dev_manual_zmq_socet
local_test_block_events
develop-clang17-wip
feature/python-e2e-tests
bug/501-on_connection_closed
bug/513-num_son_init
bug/513-num_son_extension
docker-build-fix
libbitcoin-build-dependencies-cicd
feature/cicd-deployments-and-upgrades
feature/limit-NFT-objs-returned
sonarcloud-coverage
bug/api-doc-generation-hotfix
test/hot-fix-hardfork-changed
mint-testnet-sidechain-address-fix
hotfix/sidechain-address
feature/limits-for-nft_get_all_tokens
debug-transaction-signing
feature/libbitcoin-son
revert-1a160275
revert-f7aab6a8
peerup-clang14-new
feature/son-for-ethereum
peerup-clang14
feature/420-ethereum-unit-tests
bug/issue416_corrected
bug/issue-416
cicd-test
test/enable_disconnect_non_compatible_witness_nodes
395-verify-delayed_node-plugin
431-verify-debug_witness-plugin
461-handle-boost-system-system_error-exception
local_enable_logs_for_irona
merge-develop-to-beatrice-2022-06
bug/378/fix_for_restarting_node_without_replay_option
feature/368/implement_the_witness_capability_to_overwrite_last_hardfork
bug/issue317
issue317-traces
dapp-support
feature/274/redirect_transaction_fees_to_dividends
bug/issue34
bug/issue229
bug-235-update-2
Feature-Enable-parallel-build-testnet-mainnet-cmake
231-docker-with-artifacts
325-refactor-importing-btc-addresses-into-son-wallet
bug/235-stop_corrupts_chain_file-1
bug/empty-json-parsing-failure-2
bug/failure-on-son-related-test-1
bug/issue50
230-docker-image-from-ci-should-be-pushed-to-gitlab-registry-2
bug/issue-50-4
bug/issue50-trace-tid
bug/issue-50-2
bug/issue-50-3
bug/94-docker-build
bug/issue-50
bug/empty-json-parsing-failure
bug/rpc-client-crashes-on-empty-response
bug_fix_warnings
feature/all-in-one-build
feature/cli-activate-deregistered-son
hotfix/fix-sidechain-address-generation
revert-b875f0b8
hotfix/fix-memo-field-encryption
issue/son-for-hive-rpc-connection
hotfix/fix-plugin-cli-option
bug/35-blockchain_replay
merge-beatrice-to-master-2021-11
feature/son-for-hive
feature/son-for-hive-https-support
revert-b806eb85
feature/rel-mainnet-jul21
feature/mainnet-release-jul21
feature/reserve-tokens
feature/beatrice-changes-to-develop
feature/testnet-release-jun2021
feature/add-cliwallet-version
feature/son-wrong-weights
support/sonarcloud
feature/add-get-blocks
feature/sidechain-throttling
63-doc-son-docker-mainnet
issue/dex-crash
feature/port-dex-fixes
feature/hf-btc-flags-change
hotfix/build-warnings-210210
hotfix/master-son-vb-checks
hotfix/check-vesting-balances-for-son
feature/nft_lottery
hotfix/master-hotfixes
hotfix/gitlab
support/ci
hotfix/fix-get-full-accounts
feature/flush-db-during-replay
feature/cli-change-account-keys
feature/gpos-vesting-performance-decay-test
bugfix/374
hotfix/fix-witness-sons-multiple-ids-reading
feature/es-improvements
hotfix/cli-buy-sell-fix
merge_beatrice_to_develop_202012
merge_beatrice_to_master_202012
merge/master-to-beatrice-20201203
tests/code-coverage
feature/build-optimizations
hotfix/build-executables
merge/beatrice2develop
feature/sync-fc-OCT
hotfix/remove_fc_smart_ref
hotfix/remove_smart_ref
hotfix/remove_fc_smart_ref_develop
feature/api_limit_error_msg
hotfix/beatrice_compilation
feature/rl-editline
hotfix/release_build_fix_develop
hotfix/release_build_fix
feature/editline
hotfix/son_maxcount_fix
hotfix/son_fixes
hotfix/son_chain_params
merge/develop2beatrice
feature/SONs-base
feature/bts-210
feature/account_roles
issue375/public_key_type_fix
ws-updates
feature/rng
feature/beatrice_nft_merge
feature/marketplace
issue/mainnet_chain_halt_5050
issue/gpos_rolling_period_issue
issue/beatrice_chain_halt_gpos
feature/nft_market_rbac
feature/nft
feature/rbac
feature/GRPH-45
lottery_crash_reproduction
master_chain_halt_issue
son_deposit_address_enhancements
bitcoin_networktype_fix
SON-314
SON-363
SON-359
fix_tests
hotfix-rawtransaction
feature/SON-135
SON-215_SigningFix
issue_a_gitlab
SON-315
feature/SON-349
SON-BTCPxPlex-Tryouts
feature/SON-347
feature/SON-354
feature/SON-349_SON-350
feature/SON-353
beatrice_master_mar19
feature/SON-134-v4
feature/SON-333-gladcow
feature/beatrice_winner_id
feature/nh5050_winner_id
SON-337
SON-333-v2-sk
feature/SON-333-v2
feature/SON-348
feature/SON-346
feature/SON-344
feature/SON-341
feature/SON-325
feature/SON-320
feature/SON-322_SON-324
SON-291
SON-339
feature/SON-333
feature/SON-305
SON-297_SON-336
feature/SON-307
SON-313
feature/SON-134-alternate
son_account_fix_SON329
feature/SON-332
gitlab_test_clean_build
feature/SON-321_SON-323
feature/SON-288-update
feature/SON-271
feature/SON-311
SON-318_SON-319
feature/SON-312
feature/SON-304
feature/SON-295
SON-122
revert-312-sons_gpos_merge_mar19
SON-24
feature/SON-134
sons_gpos_merge_mar19
sons_gpos_merge_mar18
sons_gpos_merge_mar2
SON127
release/1.5.02
feature/SON-49
SON276
SON275
sync_fc_beatrice
plugins_enable_fix1
SON202_Update
SON118_Add_tx_metrics
feature/SON-270
SON269
SON200_Fix
es_update1
GRPH-160/fix
sync_fc_dev
feature/SON-264
SON261
feature/SON-260
feature/SON-242
unit_test_fixes
feature/SON-209-add
feature/SON-209
feature/SON-238
feature/snapshot
feature/GRPH-155
feature/GRPH-163
updates_from_mainnet
SON131
issue_github_277
2020_1_sync_fix
mainnet-sync-fix
mainet-sync
feature/SON-231
feature/SON-202-fix
SON214
feature/SON-98
SON233
SON232
SON165
SON206_Plugin_CrashFix_Reorg
GPOS-66
feature/SON-214
SON199-TestFailureFix
pbattu123-patch-1
feature/SON-202
feature/GRPH-205
support/gitlab-SONs-base
SON217
SON212_SON213_BuildError
SON212
SON206
SON194
sync-develop
hf-update
feature/SON-208
GPOS-1
beatrice_hf_1.4.1
SON207
feature/SON-203
GRPH-170
feature/GRPH-166
feature/SON-205
feature/BLOCKBACK-186-Bug-Fix
feature/GRPH-169
SON193
BLOCKBACK-186
feature/GRPH-152
BLOCKBACK-183
BLOCKCBACK-187
BLOCKBACK-187
feature/GRPH-168
feature/GRPH-167
feature/SON-196
203
feature/SON-195
feature/SON-158
GRPH-46
feature/GRPH-92
feature/GRPH-162
GRPH-159
feature/GRPH-160
update-submodule
BLOCKBACK-181
feature/BLOCKBACK-182
feature/GRPH-49-test-case
support/gitlab-develop
BLOCKBACK-177
GRPH-81
SON130
feature/GRPH-150
feature/SON-167
feature/SON-150
fc-commit-update
GRPH134
feature/GRPH-99
GRPH134_#198-HighCPU_Usage
qa_gpos_18.04
feature/BLOCKBACK-162
son_165
feature/SON-113-fix
feature/SON-160-fix
son_168
BLOCKBACK-155
feature/SON-142
BLOCKBACK-174
fix_flag
feature/BLOCKBACK-166
BLOCKBACK_164
feature/BLOCKBACK-165
SON126
feature/SON-113
BLOCKBACK-164
BLOCKBACK--164
oxarbitrage-patch-1
feature/SON-17
son_vesting
feature/GRPH-131
support/docker
SON118
feature/SON-115
son_wallet_clean
feature/GRPH-126
feature/GRPH-127
son_objects_operations
feature/SON-109
feature/SON-108
feature/SON-110
feature/SON-operations
feature/SON-137-GitModule-Update
feature/SON-83
feature/SON-107
feature/GRPH-2-GitModule-Update
jira-163-fix
153/fix-add-on
feature/GRPH-2-Git-Module-Update
feature/GRPH-79-Bug-Fix
feature/GRPH-3
feature/GRPH-117
gpos-testfix
feature/GRPH-90
feature/SON-84
feature/GRPH-114
feature/GRPH-95
118
feature/GRPH-112
issue/154-fix
GRPH-50-network_broadcast_api-fix-v2
BLOCKBACK-153
BLOCKBACK-154
feature/GRPH-94
feature/GRPH-111
feature/GRPH-83
feature/SON-5
feature/GRPH-93-v2
feature/GRPH-106
feature/GRPH-64
feature/GRPH-86
SON11
graphene-release1
GRPH-75
feature/GRPH-79
GRPH-73-fix-block-id-forks
feature/GRPH-88
pbsa-github-patch-1
feature/GRPH-80
feature/GRPH-93
feature/GRPH-87
feature/test-grph-3
feature/SON-83-plugins-option
GRPH-89
feature/SON-83-SON-plugin
support/gitlab-master
feature/SONs-base-build-1804
support/gitlab-beatrice
GRPH-4-update-submodule
feature/tweakes-README
GRPH-56-implement-tx-size-check-18.04
GRPH-56-implement-tx-size-check-master
github-issue-template1
support/gitlab
review-fixes
hardfork-50/50
cli_wallet_tests
rng_api
feature/GRPH-76
feature/GRPH-78
GRPH-59-Proposal-failure-handling
GRPH-71
feature/GRPH-61
feature/GRPH-77
issue-154
feature/GRPH-63
GRPH-3-cli-tests-18.04
GRPH-63-Authorize-Tx-Bug-18.04
GRPH-70
GRPH-51
pp_travis
WASM-49
GRPH-4
GRPH-53
feature/GRPH-54
GRPH-60
feature/GRPH-48
GRPH-48-Object-Database-18.04
GRPH-66
qa_gpos_18.04_gcc7_fix
GRPH-60-ProposalNestedRecursionGuard
GRPH-64-Variable-fix-18.04
GRPH-57-CompilerWarningFixesDBTests
GRPH-54-sign-transaction-fix-master
GRPH-54-sign-transaction-fix-18.04
qa_gpos_18.04_docker_img
GRPH-50-network_broadcast_api-fix
beatrice-5050-merge
Issue23-check-transaction-size
issue23-check-transaction-size
feature/5050
hotfix/readme
hotfix/readme-branch-from-gitlab
hotfix/docker
hotfix/docker-branch-from-gitlab
hotfix/unit-tests
hotfix/unit-tests-branch-from-gitlab
feature/manager-for-sports-and-underlying
feature-sidechain
1.6.1
1.6.0
1.5.25-beta
1.5.24-beta
1.5.23-beta
1.5.22-alpha
1.5.21-alpha
1.5.20-alpha
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
test-1.5.5
test-1.5.4
test-1.5.3
1.5.11
1.5.10
test-1.5.2
test-1.5.1
test-1.5.0
test-1.4.5
1.4.4
1.4.3
test-1.4.4
1.5.05
1.5.04
1.5.03
1.5.02
test-1.4.3
SON0.0.1
1.5.01
1.4.2
test-1.4.2
1.4.2-alpha
test-1.4.1
1.4.1-alpha
test-1.4.0
1.3.1
Ignore
1.3.0
1.2.0
1.1.0
1.0.0
Labels
Clear labels   
confirmed

   
DevOps

   
documentation

   
enhancement

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
Medium

   
priority::Critical

(optional) Issues that are marked as critical priority. Should be taken care of ASAP.

  
priority::High

(optional) Issues that are marked as high priority.

  
priority::Low

(optional) Issues that are marked as low priority.

  
priority::Medium

(optional) Issues that are marked as medium priority.

  
QA-TestCases::Done

QA-Labels

  
QA-TestCases::InProgress

QA-Labels

  
RNG

   
security

(optional) Issues that relate to the security of the project.

  
severity:: Critical

   
severity:: High

   
severity:: Low

   
severity:: Medium

   
state:: Accepted

Issues that are newly created and have been accepted after review.

  
state:: Blocked

Issues that cannot be worked on due to other factors linked to it.

  
state:: Done

Issues that are closed with a working solution.

  
state:: in progress

Issues that are currently being worked on.

  
state:: in review

Issues that require a proposed solution to be reviewed.

  
state:: on hold

Issues that were at least accepted, that should not be worked on at the moment.

  
state:: Pending

Issues that are newly created and haven't been reviewed.

  
state:: Pushed to Prod

Tickets are verified in the stage infra and needs to be deployed in the production

  
state:: Revision Needed

Issues that need to be revised before being accepted.

  
state::out-of-scope

Task and issues which are out of scope due to change in requirements

  
suggestion

   
support

   
To Do

   
type :: Discussion

   
type :: Duplicate

(optional) Issues that are duplicates of existing issues in the same project.

  
type:: interaction-design

   
type:: New Feature

Issues that bring new functionality to the project.

  
type::bug

BUG

  
type::documentation

Issues that relate to the documentation of the project.

  
type::incident

severe issues that require immediate response

  
type::maintenance

Issues that require maintenance on the project.

  
type::question

Issues that are questions related to the project.

  
type::recurring-tasks

This label is used to track recurring tasks which may repeat daily, weekly or monthly.

  
vulnerability
No labels
confirmed
DevOps
documentation
enhancement
incident
Medium
priority::Critical
priority::High
priority::Low
priority::Medium
QA-TestCases::Done
QA-TestCases::InProgress
RNG
security
severity:: Critical
severity:: High
severity:: Low
severity:: Medium
state:: Accepted
state:: Blocked
state:: Done
state:: in progress
state:: in review
state:: on hold
state:: Pending
state:: Pushed to Prod
state:: Revision Needed
state::out-of-scope
suggestion
support
To Do
type :: Discussion
type :: Duplicate
type:: interaction-design
type:: New Feature
type::bug
type::documentation
type::incident
type::maintenance
type::question
type::recurring-tasks
vulnerability
Milestone
Clear milestone
No items
No milestone
Peerplays Improvements and Bugfixes OCT 10 - NOV 06
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#450
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?