Peerplays_Blockchain/peerplays_migrated

Fork 0

Handle `boost::system::system_error` exception. #461

New issue

Closed

opened 2022-10-04 11:18:56 +00:00 by vampik · 10 comments

vampik commented

2022-10-04 11:18:56 +00:00

(Migrated from gitlab.com)

When we start witness_node and have error in POST request, boost library throw exception:

terminate called after throwing an instance of 'boost::wrapexcept<boost::system::system_error>'
  what():  connect: No route to host

Need to handle it and gracefully shutdown.
Now we just have unhandled exception.

When we start `witness_node` and have error in POST request, `boost` library throw exception: ``` terminate called after throwing an instance of 'boost::wrapexcept<boost::system::system_error>' what(): connect: No route to host ``` Need to handle it and gracefully shutdown. Now we just have unhandled exception.

vampik commented

2022-10-04 11:18:56 +00:00

(Migrated from gitlab.com)

assigned to @vampik

vampik commented

2022-10-18 07:19:20 +00:00

(Migrated from gitlab.com)

mentioned in commit 283fbd28f7

mentioned in commit 283fbd28f7e4e69af3617eb56d39216ab554841f

vampik commented

2022-10-19 06:18:32 +00:00

(Migrated from gitlab.com)

created branch 461-handle-boost-system-system_error-exception to address this issue

created branch [`461-handle-boost-system-system_error-exception`](/PBSA/peerplays/-/compare/master...461-handle-boost-system-system_error-exception) to address this issue

vampik commented

2022-10-19 06:23:21 +00:00

(Migrated from gitlab.com)

mentioned in merge request !165

vampik commented

2022-10-19 06:23:53 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

serkixenos commented

2022-10-19 20:53:42 +00:00

(Migrated from gitlab.com)

mentioned in issue #465

prandnum commented

2022-10-20 15:19:50 +00:00

(Migrated from gitlab.com)

mentioned in issue #464

serkixenos commented

2022-10-30 02:30:59 +00:00

(Migrated from gitlab.com)

mentioned in commit d5d6390030

mentioned in commit d5d6390030c91e7596ae55886d8adf8aa41a7def

serkixenos commented

2022-10-30 02:39:58 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and @wsalloum

prandnum commented

2022-10-31 18:35:47 +00:00

(Migrated from gitlab.com)

No boost exception seen when witness nodes are run

root@ad5eb81eb7ff:~/src/peerplays# git log -5
commit d5d6390030c91e7596ae55886d8adf8aa41a7def (HEAD -> develop, origin/develop)
Merge: 400c3cfb 283fbd28
Author: serkixenos <serki.xenos@gmail.com>
Date:   Sun Oct 30 02:30:59 2022 +0000

    Merge branch 'bug/461-system_error-exception' into 'develop'
    
    #461 - handle exception when execute POST request
    
    See merge request PBSA/peerplays!165

commit 400c3cfb8907c47c2b4d9dccdd2330d98c1839fd
Merge: c3b2a598 aa90f715
Author: serkixenos <serki.xenos@gmail.com>
Date:   Sun Oct 30 02:30:22 2022 +0000

    Merge branch 'bug/467-prev-set-active-sons' into 'develop'
    
    #467 - fix create_primary_wallet_transaction signers
    
    See merge request PBSA/peerplays!169

commit aa90f715fdb6395f6ea1e9086cb381a3005ff860
Author: Vlad Dobromyslov <vdobrik@peerplays.com>
Date:   Sun Oct 30 02:30:21 2022 +0000

    #467 - fix create_primary_wallet_transaction signers

commit c3b2a598b46c2668b9d2eecdb874768796e20cba
Author: Davor Hirunda <mdmdavor@gmail.com>
Date:   Sun Oct 30 01:35:43 2022 +0000

    Fix for undo crash

commit 06bc65cc7929074bffe6acc63f5ad95178351241
Author: serkixenos <serki.xenos@gmail.com>
Date:   Sun Oct 30 03:21:18 2022 +0100

    #450 Add documentation for undocumented methods
root@ad5eb81eb7ff:~/src/peerplays#

logs: ad5eb81eb7ffb-json.log

No boost exception seen when witness nodes are run ``` root@ad5eb81eb7ff:~/src/peerplays# git log -5 commit d5d6390030c91e7596ae55886d8adf8aa41a7def (HEAD -> develop, origin/develop) Merge: 400c3cfb 283fbd28 Author: serkixenos <serki.xenos@gmail.com> Date: Sun Oct 30 02:30:59 2022 +0000 Merge branch 'bug/461-system_error-exception' into 'develop' #461 - handle exception when execute POST request See merge request PBSA/peerplays!165 commit 400c3cfb8907c47c2b4d9dccdd2330d98c1839fd Merge: c3b2a598 aa90f715 Author: serkixenos <serki.xenos@gmail.com> Date: Sun Oct 30 02:30:22 2022 +0000 Merge branch 'bug/467-prev-set-active-sons' into 'develop' #467 - fix create_primary_wallet_transaction signers See merge request PBSA/peerplays!169 commit aa90f715fdb6395f6ea1e9086cb381a3005ff860 Author: Vlad Dobromyslov <vdobrik@peerplays.com> Date: Sun Oct 30 02:30:21 2022 +0000 #467 - fix create_primary_wallet_transaction signers commit c3b2a598b46c2668b9d2eecdb874768796e20cba Author: Davor Hirunda <mdmdavor@gmail.com> Date: Sun Oct 30 01:35:43 2022 +0000 Fix for undo crash commit 06bc65cc7929074bffe6acc63f5ad95178351241 Author: serkixenos <serki.xenos@gmail.com> Date: Sun Oct 30 03:21:18 2022 +0100 #450 Add documentation for undocumented methods root@ad5eb81eb7ff:~/src/peerplays# ``` logs: [ad5eb81eb7ffb-json.log](/uploads/f2921f6377bd6d80f4d5acbf05e4b84e/ad5eb81eb7ffb-json.log)

prandnum (Migrated from gitlab.com) closed this issue

2022-10-31 18:38:34 +00:00