Peerplays_Blockchain/peerplays_migrated

Fork 0

verfifation of SON primary wallet switching - Bitcoin #472

New issue

Open

opened 2022-11-05 05:37:56 +00:00 by bobinson · 10 comments

bobinson commented

2022-11-05 05:37:56 +00:00

(Migrated from gitlab.com)

Scenario 1:

Setup the environment with 7 Bitcoin SONs
5 of the Bitcoin SONs must be active SONs
Trigger change in the Bitcoin SONs by either stopping one of the SONs or voting one out
Make sure that there are BTC available with the Bitcoin SONs & Primary wallet
Observe change to the primary wallet
Verify that the funds moved to the new primary wallet address & capture/note the fees used

Scenario 2:

Setup the environment with 7 Bitcoin SONs
5 of the Bitcoin SONs must be active SONs
Trigger change in the Bitcoin SONs by either stopping one of the SONs or voting one out
Make sure that there are NO BTC available with the Bitcoin SONs
Make sure that the funds available in BTC Primary wallet is not enough to pay for the fees
Observe change to the primary wallet

In general the idea is to verify the primary wallet switchover scenarios with and without necessary funds in the addressees of SONs and Primary wallet multi-sig address.

cc : @elynch1 : This might be one of the crash scenarios you mentioned about. We should verify this scenario for Hive as well.

Scenario 1: - Setup the environment with 7 Bitcoin SONs - 5 of the Bitcoin SONs must be active SONs - Trigger change in the Bitcoin SONs by either stopping one of the SONs or voting one out - Make sure that there are BTC available with the Bitcoin SONs & Primary wallet - Observe change to the primary wallet - Verify that the funds moved to the new primary wallet address & capture/note the fees used Scenario 2: - Setup the environment with 7 Bitcoin SONs - 5 of the Bitcoin SONs must be active SONs - Trigger change in the Bitcoin SONs by either stopping one of the SONs or voting one out - Make sure that there are NO BTC available with the Bitcoin SONs - Make sure that the funds available in BTC Primary wallet is not enough to pay for the fees - Observe change to the primary wallet In general the idea is to verify the primary wallet switchover scenarios with and without necessary funds in the addressees of SONs and Primary wallet multi-sig address. cc : @elynch1 : This might be one of the crash scenarios you mentioned about. We should verify this scenario for Hive as well.

bobinson commented

2022-11-05 05:37:56 +00:00

(Migrated from gitlab.com)

assigned to @wsalloum

wsalloum commented

2022-11-05 20:56:14 +00:00

(Migrated from gitlab.com)

unlocked >>> get_active_sons_by_sidechain bitcoin
get_active_sons_by_sidechain bitcoin
[{
    "son_id": "1.33.0",
    "weight": 1,
    "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275"
  },{
    "son_id": "1.33.1",
    "weight": 1,
    "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs",
    "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4"
  },{
    "son_id": "1.33.2",
    "weight": 1,
    "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r",
    "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61"
  },{
    "son_id": "1.33.3",
    "weight": 1,
    "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22",
    "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866"
  },{
    "son_id": "1.33.4",
    "weight": 1,
    "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU",
    "public_key": "037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666"
  }
]
unlocked >>> vote_for_son account01 sonaccount07 bitcoin true true
vote_for_son account01 sonaccount07 bitcoin true true
{
  "ref_block_num": 348,
  "ref_block_prefix": 3119541731,
  "expiration": "2022-11-05T20:50:18",
  "operations": [[
      6,{
        "fee": {
          "amount": 0,
          "asset_id": "1.3.0"
        },
        "account": "1.2.52",
        "new_options": {
          "memo_key": "TEST73rCkGNinnNSqJprEf6vXb6fiH9opF2DHVjbq2kutF8BH2n12a",
          "voting_account": "1.2.5",
          "num_witness": 0,
          "num_committee": 0,
          "votes": [
            "3:56"
          ],
          "extensions": {
            "num_son": [[
                "bitcoin",
                0
              ],[
                "ethereum",
                0
              ],[
                "hive",
                0
              ]
            ]
          }
        },
        "extensions": {}
      }
    ]
  ],
  "extensions": [],
  "signatures": [
    "20639f4dcf785713ab0bf378be36dc0135138b664508c3eea297799d3f95e5e6df0c87b095444d1b5ff7b3931380eaea29eafd242a6b9e5a06a47cb87155f87725"
  ]
}
unlocked >>> get_active_sons_by_sidechain bitcoin                  
get_active_sons_by_sidechain bitcoin
[{
    "son_id": "1.33.6",
    "weight": 1,
    "signing_key": "TEST7RMDnipLkFaQ4vtDyVvgyCedRoxyT9JWpAoM9mrE7rwVSyezoB",
    "public_key": "0317941e4219548682fb8d8e172f0a8ce4d83ce21272435c85d598558c8e060b7f"
  },{
    "son_id": "1.33.0",
    "weight": 1,
    "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
    "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275"
  },{
    "son_id": "1.33.1",
    "weight": 1,
    "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs",
    "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4"
  },{
    "son_id": "1.33.2",
    "weight": 1,
    "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r",
    "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61"
  },{
    "son_id": "1.33.3",
    "weight": 1,
    "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22",
    "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866"
  }
]

@bobinson How can I make 7 bitcoin sons active? when I have 5 active sons and vote for one more, one of the active sons will be inactive and the new one will be active, but in total it stays 5 active sons ``` unlocked >>> get_active_sons_by_sidechain bitcoin get_active_sons_by_sidechain bitcoin [{ "son_id": "1.33.0", "weight": 1, "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275" },{ "son_id": "1.33.1", "weight": 1, "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs", "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4" },{ "son_id": "1.33.2", "weight": 1, "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r", "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61" },{ "son_id": "1.33.3", "weight": 1, "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22", "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866" },{ "son_id": "1.33.4", "weight": 1, "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU", "public_key": "037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666" } ] unlocked >>> vote_for_son account01 sonaccount07 bitcoin true true vote_for_son account01 sonaccount07 bitcoin true true { "ref_block_num": 348, "ref_block_prefix": 3119541731, "expiration": "2022-11-05T20:50:18", "operations": [[ 6,{ "fee": { "amount": 0, "asset_id": "1.3.0" }, "account": "1.2.52", "new_options": { "memo_key": "TEST73rCkGNinnNSqJprEf6vXb6fiH9opF2DHVjbq2kutF8BH2n12a", "voting_account": "1.2.5", "num_witness": 0, "num_committee": 0, "votes": [ "3:56" ], "extensions": { "num_son": [[ "bitcoin", 0 ],[ "ethereum", 0 ],[ "hive", 0 ] ] } }, "extensions": {} } ] ], "extensions": [], "signatures": [ "20639f4dcf785713ab0bf378be36dc0135138b664508c3eea297799d3f95e5e6df0c87b095444d1b5ff7b3931380eaea29eafd242a6b9e5a06a47cb87155f87725" ] } unlocked >>> get_active_sons_by_sidechain bitcoin get_active_sons_by_sidechain bitcoin [{ "son_id": "1.33.6", "weight": 1, "signing_key": "TEST7RMDnipLkFaQ4vtDyVvgyCedRoxyT9JWpAoM9mrE7rwVSyezoB", "public_key": "0317941e4219548682fb8d8e172f0a8ce4d83ce21272435c85d598558c8e060b7f" },{ "son_id": "1.33.0", "weight": 1, "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275" },{ "son_id": "1.33.1", "weight": 1, "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs", "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4" },{ "son_id": "1.33.2", "weight": 1, "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r", "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61" },{ "son_id": "1.33.3", "weight": 1, "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22", "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866" } ] ```

bobinson commented

2022-11-07 05:14:48 +00:00

(Migrated from gitlab.com)

Hi @wsalloum - It was a mistake from my side, What I meant was 5 out of 7 SONs becomes active and then one of the 5 active witnesses are made to switchover via votes. Upon voting one of the inactive 2 must replace one of the active from the original 5 active SONs.

bobinson commented

2022-11-07 05:16:34 +00:00

(Migrated from gitlab.com)

changed the description

wsalloum commented

2022-11-08 11:58:59 +00:00

(Migrated from gitlab.com)

Hi @bobinson , can you explain to me how to d the following please? it is not clear to me

Make sure that there are BTC available with the Bitcoin SONs & Primary wallet
Observe change to the primary wallet
Verify that the funds moved to the new primary wallet address & capture/note the fees used

Hi @bobinson , can you explain to me how to d the following please? it is not clear to me * Make sure that there are BTC available with the Bitcoin SONs & Primary wallet * Observe change to the primary wallet * Verify that the funds moved to the new primary wallet address & capture/note the fees used

bobinson commented

2022-11-08 12:59:00 +00:00

(Migrated from gitlab.com)

Make sure that there are BTC available with the Bitcoin SONs & Primary wallet

Send some funds to the Bitcoin addresses belonging to the Bitcoin SONs and also to the primary wallet.

Observe change to the primary wallet

When the set of active SONs changes, a new (Bitcoin) Primary Wallet (PW) will be created and the funds from the older account will be moved to the new one.

Verify that the funds moved to the new primary wallet address & capture/note the fees used

When the primary wallet address (PW) changes, the funds will be moved from the old address to the new address and there will be a fee paid to the network to facilitate this operation. We need to keep track of these funds to figure out any more edge cases remaining that went unchecked. I would urge you to come up with more scenarios including the active SONs set change and thus primary wallet change.

> Make sure that there are BTC available with the Bitcoin SONs & Primary wallet Send some funds to the Bitcoin addresses belonging to the Bitcoin SONs and also to the primary wallet. > Observe change to the primary wallet When the set of active SONs changes, a new (Bitcoin) Primary Wallet (PW) will be created and the funds from the older account will be moved to the new one. > Verify that the funds moved to the new primary wallet address & capture/note the fees used When the primary wallet address (PW) changes, the funds will be moved from the old address to the new address and there will be a fee paid to the network to facilitate this operation. We need to keep track of these funds to figure out any more edge cases remaining that went unchecked. I would urge you to come up with more scenarios including the active SONs set change and thus primary wallet change.

wsalloum commented

2023-03-22 10:11:08 +00:00

(Migrated from gitlab.com)

I am not able to unvote for any active sons, it is always saying has already unvoted for son, although I have not voted for any son.
However, when I vote then unvote, it is ok, but then the active sons stays the same and not able to stop any of them.

unlocked >>> get_active_son_wallet
get_active_son_wallet
{
  "id": "1.35.0",
  "valid_from": "2023-03-21T15:10:00",
  "expires": "2106-02-07T06:28:15",
  "addresses": [[
      "bitcoin",
      "{\n    \"address\": \"2NCE3hT55hXeT9P4VWW7uazgmFsQFvtpULW\",\n    \"redeemScript\": \"007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac6351936854a2\"\n}\n"
    ],[
      "ethereum",
      "0x56316f7354845275F28478d53F8dd423E42cfCe6"
    ],[
      "hive",
      "son-account"
    ]
  ],
  "sons": [[
      "bitcoin",[{
          "son_id": "1.33.0",
          "weight": 1,
          "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
          "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275"
        },{
          "son_id": "1.33.1",
          "weight": 1,
          "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs",
          "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4"
        },{
          "son_id": "1.33.2",
          "weight": 1,
          "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r",
          "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61"
        },{
          "son_id": "1.33.3",
          "weight": 1,
          "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22",
          "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866"
        },{
          "son_id": "1.33.4",
          "weight": 1,
          "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU",
          "public_key": "037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666"
        }
      ]
    ],[
      "ethereum",[{
          "son_id": "1.33.0",
          "weight": 1,
          "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
          "public_key": "5fbbb31be52608d2f52247e8400b7fcaa9e0bc12"
        },{
          "son_id": "1.33.1",
          "weight": 1,
          "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs",
          "public_key": "76ce31bd03f601c3fc13732def921c5bac282676"
        },{
          "son_id": "1.33.2",
          "weight": 1,
          "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r",
          "public_key": "09ee460834498a4ee361beb819470061b7381b49"
        },{
          "son_id": "1.33.3",
          "weight": 1,
          "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22",
          "public_key": "6aefbd09209e1ee2e0a589d31e732f69b77713d2"
        },{
          "son_id": "1.33.4",
          "weight": 1,
          "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU",
          "public_key": "631e128b16f9adcf1bb6385112b1519c917d77a7"
        }
      ]
    ],[
      "hive",[{
          "son_id": "1.33.0",
          "weight": 1,
          "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL",
          "public_key": "sonaccount01"
        },{
          "son_id": "1.33.1",
          "weight": 1,
          "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs",
          "public_key": "sonaccount02"
        },{
          "son_id": "1.33.2",
          "weight": 1,
          "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r",
          "public_key": "sonaccount03"
        },{
          "son_id": "1.33.3",
          "weight": 1,
          "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22",
          "public_key": "sonaccount04"
        },{
          "son_id": "1.33.4",
          "weight": 1,
          "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU",
          "public_key": "sonaccount05"
        }
      ]
    ]
  ]
}


locked >>> vote_for_son account01 sonaccount01 bitcoin false true
vote_for_son account01 sonaccount01 bitcoin false true
0 exception: unspecified
Account account01 has already unvoted for son sonaccount01 for sidechain bitcoin
    {"account":"account01","son":"sonaccount01","sidechain":"bitcoin"}
    th_a  wallet.cpp:2788 vote_for_son

    {"voting_account":"account01","son":"sonaccount01","approve":false,"broadcast":true}
    th_a  wallet.cpp:2800 vote_for_son
locked >>> vote_for_son account01 sonaccount04 bitcoin false true 
vote_for_son account01 sonaccount04 bitcoin false true
0 exception: unspecified
Account account01 has already unvoted for son sonaccount04 for sidechain bitcoin
    {"account":"account01","son":"sonaccount04","sidechain":"bitcoin"}
    th_a  wallet.cpp:2788 vote_for_son

    {"voting_account":"account01","son":"sonaccount04","approve":false,"broadcast":true}
    th_a  wallet.cpp:2800 vote_for_son
locked >>> vote_for_son account01 sonaccount07 bitcoin false true 
vote_for_son account01 sonaccount07 bitcoin false true
0 exception: unspecified
Account account01 has already unvoted for son sonaccount07 for sidechain bitcoin
    {"account":"account01","son":"sonaccount07","sidechain":"bitcoin"}
    th_a  wallet.cpp:2788 vote_for_son

    {"voting_account":"account01","son":"sonaccount07","approve":false,"broadcast":true}
    th_a  wallet.cpp:2800 vote_for_son

I am not able to unvote for any active sons, it is always saying `has already unvoted for son`, although I have not voted for any son. However, when I vote then unvote, it is ok, but then the active sons stays the same and not able to stop any of them. ``` unlocked >>> get_active_son_wallet get_active_son_wallet { "id": "1.35.0", "valid_from": "2023-03-21T15:10:00", "expires": "2106-02-07T06:28:15", "addresses": [[ "bitcoin", "{\n \"address\": \"2NCE3hT55hXeT9P4VWW7uazgmFsQFvtpULW\",\n \"redeemScript\": \"007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac6351936854a2\"\n}\n" ],[ "ethereum", "0x56316f7354845275F28478d53F8dd423E42cfCe6" ],[ "hive", "son-account" ] ], "sons": [[ "bitcoin",[{ "son_id": "1.33.0", "weight": 1, "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "public_key": "03456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275" },{ "son_id": "1.33.1", "weight": 1, "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs", "public_key": "02d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4" },{ "son_id": "1.33.2", "weight": 1, "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r", "public_key": "025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61" },{ "son_id": "1.33.3", "weight": 1, "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22", "public_key": "0228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866" },{ "son_id": "1.33.4", "weight": 1, "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU", "public_key": "037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666" } ] ],[ "ethereum",[{ "son_id": "1.33.0", "weight": 1, "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "public_key": "5fbbb31be52608d2f52247e8400b7fcaa9e0bc12" },{ "son_id": "1.33.1", "weight": 1, "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs", "public_key": "76ce31bd03f601c3fc13732def921c5bac282676" },{ "son_id": "1.33.2", "weight": 1, "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r", "public_key": "09ee460834498a4ee361beb819470061b7381b49" },{ "son_id": "1.33.3", "weight": 1, "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22", "public_key": "6aefbd09209e1ee2e0a589d31e732f69b77713d2" },{ "son_id": "1.33.4", "weight": 1, "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU", "public_key": "631e128b16f9adcf1bb6385112b1519c917d77a7" } ] ],[ "hive",[{ "son_id": "1.33.0", "weight": 1, "signing_key": "TEST8TCQFzyYDp3DPgWZ24261fMPSCzXxVyoF3miWeTj6JTi2DZdrL", "public_key": "sonaccount01" },{ "son_id": "1.33.1", "weight": 1, "signing_key": "TEST82qv1LKFvwVKD9pg5JQf6qqwLcoeqUniQjWJ3wKTodyWa7gHUs", "public_key": "sonaccount02" },{ "son_id": "1.33.2", "weight": 1, "signing_key": "TEST6xdp7MrEPnaNK9GuF3KTeTizgGN6JC5nPmxx81higFepSZ8N7r", "public_key": "sonaccount03" },{ "son_id": "1.33.3", "weight": 1, "signing_key": "TEST55j32Up75gHCxJBPN18vEytL9anDgEVFtsaCii38keGQG71X22", "public_key": "sonaccount04" },{ "son_id": "1.33.4", "weight": 1, "signing_key": "TEST68bX5bB16GkEAig6w2WTh9NbM9nHa66CemnDRx2njRY9bbWXhU", "public_key": "sonaccount05" } ] ] ] } locked >>> vote_for_son account01 sonaccount01 bitcoin false true vote_for_son account01 sonaccount01 bitcoin false true 0 exception: unspecified Account account01 has already unvoted for son sonaccount01 for sidechain bitcoin {"account":"account01","son":"sonaccount01","sidechain":"bitcoin"} th_a wallet.cpp:2788 vote_for_son {"voting_account":"account01","son":"sonaccount01","approve":false,"broadcast":true} th_a wallet.cpp:2800 vote_for_son locked >>> vote_for_son account01 sonaccount04 bitcoin false true vote_for_son account01 sonaccount04 bitcoin false true 0 exception: unspecified Account account01 has already unvoted for son sonaccount04 for sidechain bitcoin {"account":"account01","son":"sonaccount04","sidechain":"bitcoin"} th_a wallet.cpp:2788 vote_for_son {"voting_account":"account01","son":"sonaccount04","approve":false,"broadcast":true} th_a wallet.cpp:2800 vote_for_son locked >>> vote_for_son account01 sonaccount07 bitcoin false true vote_for_son account01 sonaccount07 bitcoin false true 0 exception: unspecified Account account01 has already unvoted for son sonaccount07 for sidechain bitcoin {"account":"account01","son":"sonaccount07","sidechain":"bitcoin"} th_a wallet.cpp:2788 vote_for_son {"voting_account":"account01","son":"sonaccount07","approve":false,"broadcast":true} th_a wallet.cpp:2800 vote_for_son ```

prandnum commented

2023-04-16 19:26:13 +00:00

(Migrated from gitlab.com)

@vampik the sidechain bitcoin deposit address generated is not proper.

unlocked >>> get_sidechain_addresses_by_account kiran
get_sidechain_addresses_by_account kiran
[{
    "id": "1.38.64",
    "sidechain_address_account": "1.2.68",
    "sidechain": "bitcoin",
    "deposit_public_key": "030904554bcc267de361ddacdf03ede9b594fd998bd0df9a4d9d4780392477a26f",
    "deposit_address": "37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY",
    "deposit_address_data": "{ \"redeemScript\": \"21030904554bcc267de361ddacdf03ede9b594fd998bd0df9a4d9d4780392477a26fac635167007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac6351936854a268\", \"witnessScript\": \"00206046f2ce50ed7ef1bd5f6af82885e98c30dcaac2a5ac842cbc5b11b44de27619\" }",
    "withdraw_public_key": "02508cff368262b1738294619c5f4fb8b965373edf4069bf0c6aaf5b9dbcfe6912",
    "withdraw_address": "bcrt1qn80jqkj4a3hxy6s3agwcmulc0l7auu4x0cw4x9",
    "valid_from": "2023-04-16T19:20:00",
    "expires": "2106-02-07T06:28:15"
  }
]
unlocked >>> 

root@ff5f3a9e6b45:~/bitcoin-network# ./bitcoin-cli -rpcconnect=127.0.0.1 -rpcport=8332 -rpcuser=1 -rpcpassword=1 -rpcwallet="default" sendtoaddress "37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY" 5 "" "" false
error code: -5
error message:
Invalid Bitcoin address: 37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY
root@ff5f3a9e6b45:~/bitcoin-network#

@vampik the sidechain bitcoin deposit address generated is not proper. ``` unlocked >>> get_sidechain_addresses_by_account kiran get_sidechain_addresses_by_account kiran [{ "id": "1.38.64", "sidechain_address_account": "1.2.68", "sidechain": "bitcoin", "deposit_public_key": "030904554bcc267de361ddacdf03ede9b594fd998bd0df9a4d9d4780392477a26f", "deposit_address": "37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY", "deposit_address_data": "{ \"redeemScript\": \"21030904554bcc267de361ddacdf03ede9b594fd998bd0df9a4d9d4780392477a26fac635167007c2103456772301e221026269d3095ab5cb623fc239835b583ae4632f99a15107ef275ac635193687c2102d67c26cf20153fe7625ca1454222d3b3aeb53b122d8a0f7d32a3dd4b2c2016f4ac635193687c21025f7cfda933516fd590c5a34ad4a68e3143b6f4155a64b3aab2c55fb851150f61ac635193687c210228155bb1ddcd11c7f14a2752565178023aa963f84ea6b6a052bddebad6fe9866ac635193687c21037500441cfb4484da377073459511823b344f1ef0d46bac1efd4c7c466746f666ac6351936854a268\", \"witnessScript\": \"00206046f2ce50ed7ef1bd5f6af82885e98c30dcaac2a5ac842cbc5b11b44de27619\" }", "withdraw_public_key": "02508cff368262b1738294619c5f4fb8b965373edf4069bf0c6aaf5b9dbcfe6912", "withdraw_address": "bcrt1qn80jqkj4a3hxy6s3agwcmulc0l7auu4x0cw4x9", "valid_from": "2023-04-16T19:20:00", "expires": "2106-02-07T06:28:15" } ] unlocked >>> root@ff5f3a9e6b45:~/bitcoin-network# ./bitcoin-cli -rpcconnect=127.0.0.1 -rpcport=8332 -rpcuser=1 -rpcpassword=1 -rpcwallet="default" sendtoaddress "37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY" 5 "" "" false error code: -5 error message: Invalid Bitcoin address: 37qdjY8uqRmnwqaJYU5Vtv83EediJF2qBY root@ff5f3a9e6b45:~/bitcoin-network# ```

vampik commented

2023-04-17 10:52:50 +00:00

(Migrated from gitlab.com)

Tested this on the previous week, and everything works fine.
What is the commit of QA env and witness_node you are using?

Tested this on the previous week, and everything works fine. What is the commit of QA env and `witness_node` you are using?

prandnum commented

2023-04-17 12:05:03 +00:00

(Migrated from gitlab.com)

i have the following code

root@e7ec40f919da:~/src/peerplays# git log -1
commit 948e7dd5e4e9ec0d237638a3c79559d3ab5f51fc (HEAD -> develop, origin/develop)
Merge: 1586531e b21f9c42
Author: Vlad Dobromyslov <vdobrik@peerplays.com>
Date:   Wed Mar 29 09:38:55 2023 +0000

    Merge branch 'bug/524-eth-mainnet-tr' into 'develop'
    
    Bug/524-eth-mainnet-tr
    
    See merge request PBSA/peerplays!219
root@e7ec40f919da:~/src/peerplays#

i have the following code ``` root@e7ec40f919da:~/src/peerplays# git log -1 commit 948e7dd5e4e9ec0d237638a3c79559d3ab5f51fc (HEAD -> develop, origin/develop) Merge: 1586531e b21f9c42 Author: Vlad Dobromyslov <vdobrik@peerplays.com> Date: Wed Mar 29 09:38:55 2023 +0000 Merge branch 'bug/524-eth-mainnet-tr' into 'develop' Bug/524-eth-mainnet-tr See merge request PBSA/peerplays!219 root@e7ec40f919da:~/src/peerplays# ```