Fix calculating v value for ETH transaction signing #476

New issue

Closed

opened 2022-11-07 10:15:19 +00:00 by vampik · 8 comments

vampik commented

2022-11-07 10:15:19 +00:00

(Migrated from gitlab.com)

Now, we wrongly assume that v value can be only 1 byte long.
It leads that we have wrong signing with big chain ID (like Sepolia where chain id = 11155111)

Now, we wrongly assume that v value can be only 1 byte long. It leads that we have wrong signing with big chain ID (like Sepolia where chain id = 11155111)

vampik commented

2022-11-07 10:15:19 +00:00

(Migrated from gitlab.com)

assigned to @vampik

vampik commented

2022-11-07 10:17:08 +00:00

(Migrated from gitlab.com)

mentioned in commit 759dac5d41

mentioned in commit 759dac5d413d70226683ce9176dbf305249a6f21

vampik commented

2022-11-07 10:18:19 +00:00

(Migrated from gitlab.com)

mentioned in merge request !174

serkixenos commented

2022-11-10 11:35:15 +00:00

(Migrated from gitlab.com)

mentioned in commit 3ebcd29e10

mentioned in commit 3ebcd29e10b0574584032cfe1eddc4d8c9b28a77

serkixenos commented

2022-11-10 13:13:21 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and @wsalloum

prandnum commented

2022-11-13 15:40:13 +00:00

(Migrated from gitlab.com)

@vampik please provide the test steps

vampik commented

2022-11-14 04:50:13 +00:00

(Migrated from gitlab.com)

@prandnum
Check that transaction with ETH container execute without any errors with the latest changes

@prandnum Check that transaction with ETH container execute without any errors with the latest changes

prandnum commented

2022-11-15 19:22:42 +00:00

(Migrated from gitlab.com)

able to deposit and withdraw ETHER with the latest build.

root@248ea1bb8863:~/src/peerplays# git log -3
commit f209ab8ee6a1e973f06a29fc9757ac8ce2014d4f (HEAD -> develop, origin/develop)
Merge: 3ebcd29e 9620e3c2
Author: serkixenos <serki.xenos@gmail.com>
Date:   Mon Nov 14 13:42:24 2022 +0000

    Merge branch 'bug/481-ethereum-listener' into 'develop'
    
    #481 ethereum listener
    
    See merge request PBSA/peerplays!178

commit 9620e3c21187c6fa5385a72a7651634a4b126fa6
Author: Vlad Dobromyslov <vdobrik@peerplays.com>
Date:   Mon Nov 14 13:42:23 2022 +0000

    #481 ethereum listener

commit 3ebcd29e10b0574584032cfe1eddc4d8c9b28a77
Merge: d5b2b7ae 759dac5d
Author: serkixenos <serki.xenos@gmail.com>
Date:   Thu Nov 10 11:35:14 2022 +0000

    Merge branch 'bug/476-fix-v-signing-value' into 'develop'
    
    #476 - fix calculating v value from chain id
    
    See merge request PBSA/peerplays!174
root@248ea1bb8863:~/src/peerplays#

able to deposit and withdraw ETHER with the latest build. ``` root@248ea1bb8863:~/src/peerplays# git log -3 commit f209ab8ee6a1e973f06a29fc9757ac8ce2014d4f (HEAD -> develop, origin/develop) Merge: 3ebcd29e 9620e3c2 Author: serkixenos <serki.xenos@gmail.com> Date: Mon Nov 14 13:42:24 2022 +0000 Merge branch 'bug/481-ethereum-listener' into 'develop' #481 ethereum listener See merge request PBSA/peerplays!178 commit 9620e3c21187c6fa5385a72a7651634a4b126fa6 Author: Vlad Dobromyslov <vdobrik@peerplays.com> Date: Mon Nov 14 13:42:23 2022 +0000 #481 ethereum listener commit 3ebcd29e10b0574584032cfe1eddc4d8c9b28a77 Merge: d5b2b7ae 759dac5d Author: serkixenos <serki.xenos@gmail.com> Date: Thu Nov 10 11:35:14 2022 +0000 Merge branch 'bug/476-fix-v-signing-value' into 'develop' #476 - fix calculating v value from chain id See merge request PBSA/peerplays!174 root@248ea1bb8863:~/src/peerplays# ```

prandnum (Migrated from gitlab.com) closed this issue

2022-11-15 19:22:46 +00:00