Ethereum listener - get data from all previous blocks #481

New issue

Closed

opened 2022-11-10 09:50:48 +00:00 by vampik · 9 comments

vampik commented

2022-11-10 09:50:48 +00:00

(Migrated from gitlab.com)

Currently due to block production in ETH container in QA environment can be faster, we can skip some blocks in ethereum_listener_loop.

We need to fetch all blocks that has passed after previous one and see whether there are events in these blocks.

Currently due to block production in ETH container in QA environment can be faster, we can skip some blocks in `ethereum_listener_loop`. We need to fetch all blocks that has passed after previous one and see whether there are events in these blocks.

vampik commented

2022-11-10 09:50:48 +00:00

(Migrated from gitlab.com)

assigned to @vampik

vampik commented

2022-11-11 06:21:54 +00:00

(Migrated from gitlab.com)

mentioned in commit b0150da6484ded285cd49e9b1e2b97882b40c363

vampik commented

2022-11-11 06:50:16 +00:00

(Migrated from gitlab.com)

mentioned in merge request !178

vampik commented

2022-11-11 06:50:48 +00:00

(Migrated from gitlab.com)

assigned to @serkixenos

vampik commented

2022-11-14 13:42:24 +00:00

(Migrated from gitlab.com)

mentioned in commit 9620e3c211

mentioned in commit 9620e3c21187c6fa5385a72a7651634a4b126fa6

serkixenos commented

2022-11-14 13:42:24 +00:00

(Migrated from gitlab.com)

mentioned in commit f209ab8ee6

mentioned in commit f209ab8ee6a1e973f06a29fc9757ac8ce2014d4f

serkixenos commented

2022-11-14 13:42:47 +00:00

(Migrated from gitlab.com)

assigned to @prandnum and @wsalloum

vampik commented

2022-11-15 14:22:30 +00:00

(Migrated from gitlab.com)

@prandnum @wsalloum

After start of ETH container, it mine block very fast, and can mine it faster than we fetch block info from Ethereum.
So in some cases some deposits from ETH can be lost.

With this change, all deposits should proceed, and we shouldn't lose any.

@prandnum @wsalloum After start of ETH container, it mine block very fast, and can mine it faster than we fetch block info from Ethereum. So in some cases some deposits from ETH can be lost. With this change, all deposits should proceed, and we shouldn't lose any.

prandnum commented

2022-11-15 19:24:58 +00:00

(Migrated from gitlab.com)

Tested with 10 simultaneous deposits and all of them were detected without and deposited into peerplays user account.

root@248ea1bb8863:~/src/peerplays# git log -3
commit f209ab8ee6a1e973f06a29fc9757ac8ce2014d4f (HEAD -> develop, origin/develop)
Merge: 3ebcd29e 9620e3c2
Author: serkixenos <serki.xenos@gmail.com>
Date:   Mon Nov 14 13:42:24 2022 +0000

    Merge branch 'bug/481-ethereum-listener' into 'develop'
    
    #481 ethereum listener
    
    See merge request PBSA/peerplays!178

commit 9620e3c21187c6fa5385a72a7651634a4b126fa6
Author: Vlad Dobromyslov <vdobrik@peerplays.com>
Date:   Mon Nov 14 13:42:23 2022 +0000

    #481 ethereum listener

commit 3ebcd29e10b0574584032cfe1eddc4d8c9b28a77
Merge: d5b2b7ae 759dac5d
Author: serkixenos <serki.xenos@gmail.com>
Date:   Thu Nov 10 11:35:14 2022 +0000

    Merge branch 'bug/476-fix-v-signing-value' into 'develop'
    
    #476 - fix calculating v value from chain id
    
    See merge request PBSA/peerplays!174
root@248ea1bb8863:~/src/peerplays#

Tested with 10 simultaneous deposits and all of them were detected without and deposited into peerplays user account. ``` root@248ea1bb8863:~/src/peerplays# git log -3 commit f209ab8ee6a1e973f06a29fc9757ac8ce2014d4f (HEAD -> develop, origin/develop) Merge: 3ebcd29e 9620e3c2 Author: serkixenos <serki.xenos@gmail.com> Date: Mon Nov 14 13:42:24 2022 +0000 Merge branch 'bug/481-ethereum-listener' into 'develop' #481 ethereum listener See merge request PBSA/peerplays!178 commit 9620e3c21187c6fa5385a72a7651634a4b126fa6 Author: Vlad Dobromyslov <vdobrik@peerplays.com> Date: Mon Nov 14 13:42:23 2022 +0000 #481 ethereum listener commit 3ebcd29e10b0574584032cfe1eddc4d8c9b28a77 Merge: d5b2b7ae 759dac5d Author: serkixenos <serki.xenos@gmail.com> Date: Thu Nov 10 11:35:14 2022 +0000 Merge branch 'bug/476-fix-v-signing-value' into 'develop' #476 - fix calculating v value from chain id See merge request PBSA/peerplays!174 root@248ea1bb8863:~/src/peerplays# ```

vampik (Migrated from gitlab.com) closed this issue

2022-11-21 04:32:36 +00:00