direct test was written: https://gitlab.com/PBSA/tools-libs/peerplays-utils/-/blob/bug/issue50/peerplays-qa-environment/peerplays/init-network-test-issue50.sh

pavel.baykov commented

2021-12-13 10:55:28 +00:00

(Migrated from gitlab.com)

Bug is reproduced only with 2 cli_wallet, with concurrent execution
missing required active authority but looks like is only about loading key
Can not repro the bug with other scenarios
not sure if log level affect bug (means timings), just got increased disk space from Robert for Docker to test with 16 nodes
https://github.com/facebook/folly/blob/main/folly/concurrency/ConcurrentHashMap.h
Have concurrentHashMap with erase support, and fast
However thread id is the same for accessing _new_inventory
Accessing items could be from different Fibers, however based on my understanding of FC library , Fibers are working not on top of any thread pool, so that’s most probably not needed

So if you OK I can use Folly that was part of the ticket

I checked maintaince flag, does not affect the bug 50
Based on the description it could be related to peer_needs_sync_items_from_us
However not sure how to reproduce it

github.com
folly/ConcurrentHashMap.h at main · facebook/folly
An open-source C++ library developed and used at Facebook. - folly/ConcurrentHashMap.h at main · facebook/folly

1. Bug is reproduced only with 2 cli_wallet, with concurrent execution missing required active authority but looks like is only about loading key Can not repro the bug with other scenarios 2. not sure if log level affect bug (means timings), just got increased disk space from Robert for Docker to test with 16 nodes 3. https://github.com/facebook/folly/blob/main/folly/concurrency/ConcurrentHashMap.h Have concurrentHashMap with erase support, and fast However thread id is the same for accessing _new_inventory Accessing items could be from different Fibers, however based on my understanding of FC library , Fibers are working not on top of any thread pool, so that’s most probably not needed So if you OK I can use Folly that was part of the ticket 4. I checked maintaince flag, does not affect the bug 50 5. Based on the description it could be related to peer_needs_sync_items_from_us However not sure how to reproduce it github.com folly/ConcurrentHashMap.h at main · facebook/folly An open-source C++ library developed and used at Facebook. - folly/ConcurrentHashMap.h at main · facebook/folly

pavel.baykov commented

2021-12-13 11:00:12 +00:00

(Migrated from gitlab.com)

there is a potential problem with skip_block_size_check
however, according to
get_global_properties

"maximum_transaction_size": 2048,
"maximum_block_size": 1228800000,

which means maximum number of transaction per block is 600k, so most likely was not a case here

to address the issue i propose TODO resolving:
f61ae7e5ba

there is a potential problem with skip_block_size_check however, according to get_global_properties "maximum_transaction_size": 2048, "maximum_block_size": 1228800000, which means maximum number of transaction per block is 600k, so most likely was not a case here to address the issue i propose TODO resolving: https://gitlab.com/PBSA/peerplays/-/commit/f61ae7e5ba8afaf1e148d60caf23f3415bca18bd

serkixenos commented

2021-12-27 03:34:51 +00:00

(Migrated from gitlab.com)