verify run.sh / docker installation script

bobinson commented

2023-10-09 09:12:09 +00:00

(Migrated from gitlab.com)

Please verify whether the run.sh works with the release 1.6.0
@robert.hedler please provide feedback on the documentation at https://infra.peerplays.com/witnesses/installation-guides/docker-install to @Bharathi-Chandrasekaran

@Bharathi-Chandrasekaran : Based on the input from @robert.hedler , please update the documentation if necessary.

- Please verify whether the `run.sh` works with the release 1.6.0 - @robert.hedler please provide feedback on the documentation at https://infra.peerplays.com/witnesses/installation-guides/docker-install to @Bharathi-Chandrasekaran @Bharathi-Chandrasekaran : Based on the input from @robert.hedler , please update the documentation if necessary.

bobinson commented

2023-10-09 09:12:09 +00:00

(Migrated from gitlab.com)

added #497 as parent issue

bobinson commented

2023-10-09 09:12:37 +00:00

(Migrated from gitlab.com)

assigned to @robert.hedler and @Bharathi-Chandrasekaran

bobinson commented

2023-10-09 09:13:52 +00:00

(Migrated from gitlab.com)

changed the description

bobinson commented

2023-10-13 13:42:37 +00:00

(Migrated from gitlab.com)

Hello @robert.hedler - Did you verify the run.sh against the new release ?

robert.hedler commented

2023-10-16 19:39:15 +00:00

(Migrated from gitlab.com)

Steps:

1.2. Installing the required dependencies _ Working fine.
2. Installing Docker _ Working fine.
2.1. Setting up the .env file _ Working fine.
3. Installing the Peerplays image _ The image was retrieved from another repo (peerplays/peerplays-mainnet:latest) rather than: peerplays/peerplays:1.6.0 or peerplays/peerplays:latest located at dockerhub. I tagged the image like this and worked fine.
4. Start the Container _ Working fine.
5. Update the config.ini File _ Working fine.
6.2. Use the cli_wallet to set a password and unlock the wallet: sudo ./run.sh remote_wallet _ Didnt worked.

Steps: - **1.2. Installing the required dependencies** _ Working fine. - **2. Installing Docker** _ Working fine. - **2.1. Setting up the .env file** _ Working fine. - **3. Installing the Peerplays image** _ The image was retrieved from another repo (peerplays/peerplays-mainnet:latest) rather than: peerplays/peerplays:1.6.0 or peerplays/peerplays:latest located at dockerhub. I tagged the image like this and worked fine. ![image](/uploads/8037176149714022dae7cf6665262e3b/image.png) - **4. Start the Container** _ Working fine. - **5. Update the config.ini File** _ Working fine. - **6.2. Use the cli_wallet to set a password and unlock the wallet: sudo ./run.sh remote_wallet** _ Didnt worked. ![image](/uploads/19969d641530e3499f4f529c9f2ace4d/image.png)

robert.hedler commented

2023-10-16 23:57:21 +00:00

(Migrated from gitlab.com)

When building the docker image, I had to set this 3 workaround again:

1. ENV PATH="${PATH}:/home/peerplays/peerplays-network"
2. RUN sed -i '/^oid_section.*/a openssl_conf=default_conf' /etc/ssl/openssl.cnf
3. RUN sed -i '/^ess_cert_id_alg.*/a[default_conf]\nssl_conf=ssl_sect\n[ssl_sect]\nsystem_default=system_default_sect\n[system_default_sect]\nMinProtocol=TLSv1\nCipherString=DEFAULT@SECLEVEL=1' /etc/ssl/openssl.cnf
Without workaround 1, when running the image we got the error: /witness_node can not be found on $PATH
Without workaround 2 and 3 we can not connect on cli_wallet using WSS protocol. Tested on Ubuntu 18.04

When building the docker image, I had to set this 3 workaround again: - **1. ENV PATH="${PATH}:/home/peerplays/peerplays-network"** - **2. RUN sed -i '/^oid_section.*/a openssl_conf=default_conf' /etc/ssl/openssl.cnf** - **3. RUN sed -i '/^ess_cert_id_alg.*/a\[default_conf]\nssl_conf=ssl_sect\n[ssl_sect]\nsystem_default=system_default_sect\n[system_default_sect]\nMinProtocol=TLSv1\nCipherString=DEFAULT@SECLEVEL=1' /etc/ssl/openssl.cnf** - Without **workaround 1**, when running the image we got the error: /witness_node can not be found on $PATH - Without **workaround 2 and 3** we can not connect on cli_wallet using WSS protocol. Tested on Ubuntu 18.04 ![image](/uploads/835678bc0d7103b38deb03e5ec4650fd/image.png)

bobinson commented

2023-10-17 13:30:51 +00:00

(Migrated from gitlab.com)

Hi @Bharathi-Chandrasekaran Can you update the installation script as per the above inputs from @robert.hedler ?

Bharathi-Chandrasekaran commented

2023-10-17 13:40:23 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

Sure. I discussed with Robert already and will begin the document update.

Hi @bobinson , Sure. I discussed with Robert already and will begin the document update.

Bharathi-Chandrasekaran commented

2023-10-18 14:16:47 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler ,

As you have mentioned, the verification is done on Ubuntu 18.04.
Could you please confirm the verification for docker installation execution on ubuntu 20.04 ? Also, the work around is required for Ubuntu 20.04 too?

The steps for running on Ubuntu 18.04 and 20.04 is same and there is only one generic document. If you could confirm both version is having the same workaround then the same can be added in the doc or else it should be documented separately.

Hi @robert.hedler , As you have mentioned, the verification is done on Ubuntu 18.04. Could you please confirm the verification for docker installation execution on ubuntu 20.04 ? Also, the work around is required for Ubuntu 20.04 too? The steps for running on Ubuntu 18.04 and 20.04 is same and there is only one generic document. If you could confirm both version is having the same workaround then the same can be added in the doc or else it should be documented separately.

robert.hedler commented

2023-10-19 18:27:35 +00:00

(Migrated from gitlab.com)

Both versions have the same workaround. This needs to be done inside the docker image, no matter the Ubuntu version. But, the images available in docker hub already have this fix enable. just download them and try again.

Bharathi-Chandrasekaran commented

2023-10-23 20:35:39 +00:00

(Migrated from gitlab.com)

Thanks for your confirmation @robert.hedler

Bharathi-Chandrasekaran commented

2023-10-23 20:37:14 +00:00

(Migrated from gitlab.com)

Based on the input from @robert.hedler, the workaround is already merged in the docker image.
No update is required in the docker install document.

Based on the input from @robert.hedler, the workaround is already merged in the docker image. No update is required in the docker install document.

bobinson commented

2023-10-24 06:00:09 +00:00

(Migrated from gitlab.com)

Hi @Bharathi-Chandrasekaran - Which document is this workaround documented and how will a user who is manually running run.sh build will be able to get this work around ?

Hi @Bharathi-Chandrasekaran - Which document is this workaround documented and how will a user who is manually running `run.sh build` will be able to get this work around ?

Bharathi-Chandrasekaran commented

2023-10-24 12:31:15 +00:00

(Migrated from gitlab.com)

Hi @bobinson,

The 3 work around mentioned above is already been added to the docker image itself. So, the user doesn't have to apply the workaround separately.
When the user is installing the docker, they will be having the latest docker image with workaround.

I am verifying the docker installation on a testnet node and I will update the findings.

Hi @bobinson, The 3 work around mentioned above is already been added to the docker image itself. So, the user doesn't have to apply the workaround separately. When the user is installing the docker, they will be having the latest docker image with workaround. I am verifying the docker installation on a testnet node and I will update the findings.

bobinson commented

2023-10-24 13:24:31 +00:00

(Migrated from gitlab.com)

The 3 work around mentioned above is already been added to the docker image itself. So, the user doesn't have to apply the workaround separately.

But when you execute the command run.sh build a new docker image is built. So anything included in the already published docker images will not present unless the configuration required is in the Dockerfiles themselves. Please check with Robert whether all the scenarios are verified.

> The 3 work around mentioned above is already been added to the docker image itself. So, the user doesn't have to apply the workaround separately. But when you execute the command `run.sh build` a new docker image is built. So anything included in the already published docker images will not present unless the configuration required is in the Dockerfiles themselves. Please check with Robert whether all the scenarios are verified.

robert.hedler commented

2023-10-24 21:37:33 +00:00

(Migrated from gitlab.com)

Hi Bobinson, I got the point now, you are correct. We need to edit the Dockerfile from and include these 3 lines on it:

ENV PATH="${PATH}:/home/peerplays/peerplays-network"
RUN sed -i '/^oid_section.*/a openssl_conf=default_conf' /etc/ssl/openssl.cnf
RUN sed -i '/^ess_cert_id_alg.*/a\[default_conf]\nssl_conf=ssl_sect\n[ssl_sect]\nsystem_default=system_default_sect\n[system_default_sect]\nMinProtocol=TLSv1\nCipherString=DEFAULT@SECLEVEL=1' /etc/ssl/openssl.cnf

So when the customer will build it will have the corrections.

Hi Bobinson, I got the point now, you are correct. We need to edit the Dockerfile from and include these 3 lines on it: ``` ENV PATH="${PATH}:/home/peerplays/peerplays-network" RUN sed -i '/^oid_section.*/a openssl_conf=default_conf' /etc/ssl/openssl.cnf RUN sed -i '/^ess_cert_id_alg.*/a\[default_conf]\nssl_conf=ssl_sect\n[ssl_sect]\nsystem_default=system_default_sect\n[system_default_sect]\nMinProtocol=TLSv1\nCipherString=DEFAULT@SECLEVEL=1' /etc/ssl/openssl.cnf ``` So when the customer will build it will have the corrections.

bobinson commented

2023-10-25 05:20:19 +00:00

(Migrated from gitlab.com)

ok @robert.hedler

@Bharathi-Chandrasekaran - Please update the documentation accordingly.

ok @robert.hedler @Bharathi-Chandrasekaran - Please update the documentation accordingly.

Bharathi-Chandrasekaran commented

2023-10-25 12:15:36 +00:00

(Migrated from gitlab.com)

Okay @bobinson.

robert.hedler commented

2023-10-25 21:45:29 +00:00

(Migrated from gitlab.com)

I can confirma that all steps in the run.sh used in the docs for installation worked fine, including connect on remote wallet.

Bharathi-Chandrasekaran commented

2023-10-26 16:18:29 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

Robert confirmed that all the steps in the document are working fine and there will be no need for any document update.

However, the work around has to be added into the docker file -> https://gitlab.com/PBSA/peerplays/-/blob/master/Dockerfile through a merge request.

Do you suggest me to create a merge request to update the changes?

or

The merge request has to be submitted by specific team?

Please confirm.

Hi @bobinson , Robert confirmed that all the steps in the document are working fine and there will be no need for any document update. However, the work around has to be added into the docker file -> https://gitlab.com/PBSA/peerplays/-/blob/master/Dockerfile through a merge request. Do you suggest me to create a merge request to update the changes? or The merge request has to be submitted by specific team? Please confirm.

bobinson commented

2023-10-27 05:35:27 +00:00

(Migrated from gitlab.com)

Hi @Bharathi-Chandrasekaran -

I am confused by your statements "Robert confirmed that all the steps in the document are working fine and there will be no need for any document update." How's this possible when the change to the Dockerfile is not documented anywhere ?

you can create an issue in the repo https://gitlab.com/PBSA/peerplays/ & then create an MR with the correct fix. (This will be picked up for the next mainnet release)
For the short term, document the changes required in Dockerfile in the documentation.

Hi @Bharathi-Chandrasekaran - I am confused by your statements "Robert confirmed that all the steps in the document are working fine and there will be no need for any document update." How's this possible when the change to the Dockerfile is not documented anywhere ? 1. you can create an issue in the repo https://gitlab.com/PBSA/peerplays/ & then create an MR with the correct fix. (This will be picked up for the next mainnet release) 2. For the short term, document the changes required in `Dockerfile` in the documentation.

Bharathi-Chandrasekaran commented

2023-10-27 11:04:55 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

In the existing document, there is no section specific to DockerFile and the user is not performing any steps using _DockerFile_.
Robert confirmed that the change is not specific to document and workaround should added into master branch using merge request.
So, I have mentioned that there is no update required in the document.

Since the user has nothing to update manually, Do you still suggest to add workaround into the document?

Hi @bobinson , In the existing document, there is no section specific to __DockerFile__ and the user is not performing any steps using `_DockerFile_`. Robert confirmed that the change is not specific to document and workaround should added into master branch using merge request. So, I have mentioned that there is no update required in the document. Since the user has nothing to update manually, Do you still suggest to add workaround into the document?

bobinson commented

2023-10-27 11:59:28 +00:00

(Migrated from gitlab.com)

Hi @Bharathi-Chandrasekaran

Robert did steps that's not mentioned in any of the documents
Point 1 means no one will be able to get the software working without the steps that Robert did and those steps must be either documented or changed must be made to the software
We are not going to do a release any time soon --> This means the only way to get users use the software until a new release is available is to capture the steps to make cahnges to the Dockerfile in the documentation.

Hi @Bharathi-Chandrasekaran 1. Robert did steps that's not mentioned in any of the documents 2. Point 1 means no one will be able to get the software working without the steps that Robert did and those steps must be either documented or changed must be made to the software 3. We are not going to do a release any time soon --> This means the only way to get users use the software until a new release is available is to capture the steps to make cahnges to the `Dockerfile` in the documentation.

Bharathi-Chandrasekaran commented

2023-10-27 12:18:06 +00:00

(Migrated from gitlab.com)

Okay @bobinson
I will update the steps.

Okay @bobinson I will update the steps.

Bharathi-Chandrasekaran commented

2023-10-27 23:41:38 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler ,

I have added the workaround in the docker installation steps. Could you please review and provide your feedback ?

https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install#1.3-workaround-for-mainnet-release-1.6.0

Hi @bobinson ,

I will create an Merge request for the issue and update the details.

Hi @robert.hedler , I have added the workaround in the docker installation steps. Could you please review and provide your feedback ? https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install#1.3-workaround-for-mainnet-release-1.6.0 Hi @bobinson , I will create an Merge request for the issue and update the details.

bobinson commented

2023-10-28 09:15:57 +00:00

(Migrated from gitlab.com)

@Bharathi-Chandrasekaran ,

Where is this Dockerfile ?

I cloned as per "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" There are no Dockerfiles in the root directory and there are multiple dockerfiles in the subfolders. You must mention which dockerfile needs to be edited and at which line the content you suggested for workaround should go in.

The screen shot you have included seems to be the peerplays repository & not peerplays-docker repository. There is nothing called peerplays 1.6.0 bundle. It looks like you are mixing up between the installation script , ie run.sh and downloading the gitlab artifact.

@Bharathi-Chandrasekaran , 1. Where is this Dockerfile ? I cloned as per "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" There are no Dockerfiles in the root directory and there are multiple dockerfiles in the subfolders. You must mention which dockerfile needs to be edited and at which line the content you suggested for workaround should go in. ![image](/uploads/afe6f4930b31b69fa6b21742b8f7eff6/image.png) 2. The screen shot you have included seems to be the peerplays repository & not peerplays-docker repository. There is nothing called peerplays 1.6.0 bundle. It looks like you are mixing up between the installation script , ie `run.sh` and downloading the gitlab artifact.

Bharathi-Chandrasekaran commented

2023-10-28 15:24:13 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

Where is Dockerfile?

The DockerFile is present in the Peerplays repository only. I have downloaded the 1.6.0 bundle and extracted the same.
Including the picture for reference.

I have mentioned in the draft that the DockerFile will be present in the Mainnet bundle (Peerplays repository as mentioned by you) and included diagram for file location. I can changes the name from Mainnet bundle to Peerplays repository.

The picture in the document was shared by @robert.hedler and I have confirmed that the workaround must be included in the DockerFile in the Peerplays repository. Attaching the same here

@robert.hedler , could you please confirm the location of the DockerFile whether Peerplays repository or Peerplays-docker repository (Please share the location to download)?

I believe the section where the workaround included must be moved as the initial step before installing the dependencies. I have updated the draft and attaching for review

https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install#1.2-workaround-for-peerplays-1.6.0-mainnet-release

Hi @bobinson , Where is Dockerfile? The DockerFile is present in the Peerplays repository only. I have downloaded the 1.6.0 bundle and extracted the same. Including the picture for reference. ![DockerFile_location](/uploads/e87a0de0aef919373777fa772acf4f4e/DockerFile_location.JPG) I have mentioned in the draft that the DockerFile will be present in the Mainnet bundle (Peerplays repository as mentioned by you) and included diagram for file location. I can changes the name from Mainnet bundle to Peerplays repository. The picture in the document was shared by @robert.hedler and I have confirmed that the workaround must be included in the DockerFile in the Peerplays repository. Attaching the same here![1_Dockerfile_update](/uploads/a526b94353a455726d32e39685a19dae/1_Dockerfile_update.JPG) @robert.hedler , could you please confirm the location of the DockerFile whether Peerplays repository or Peerplays-docker repository (Please share the location to download)? I believe the section where the workaround included must be moved as the initial step before installing the dependencies. I have updated the draft and attaching for review https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install#1.2-workaround-for-peerplays-1.6.0-mainnet-release

bobinson commented

2023-10-30 06:09:51 +00:00

(Migrated from gitlab.com)

@Bharathi-Chandrasekaran -

I have mentioned in the draft that the DockerFile will be present in the Mainnet bundle (Peerplays repository as mentioned by you) and included diagram for file location. I can changes the name from Mainnet bundle to Peerplays repository.

There is no such bundle anywhere in our software distribution method. Also the screen shot you have shown is of the peerplays source code and not peerplays-docker.

@Bharathi-Chandrasekaran - > I have mentioned in the draft that the DockerFile will be present in the Mainnet bundle (Peerplays repository as mentioned by you) and included diagram for file location. I can changes the name from Mainnet bundle to Peerplays repository. There is no such bundle anywhere in our software distribution method. Also the screen shot you have shown is of the `peerplays` source code and not `peerplays-docker`.

Bharathi-Chandrasekaran commented

2023-10-30 13:15:39 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,
Noted. I will remove "bundle" from the document.
To confirm about Peerplays or Peerplays-docker, I will discuss with Robert and update the same.
Thank you!

Hi @bobinson , Noted. I will remove "bundle" from the document. To confirm about Peerplays or Peerplays-docker, I will discuss with Robert and update the same. Thank you!

robert.hedler commented

2023-10-30 17:39:30 +00:00

(Migrated from gitlab.com)

I am using this repo and instructions to build the docker images: https://gitlab.com/PBSA/peerplays#docker-images

Bharathi-Chandrasekaran commented

2023-10-30 18:35:45 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler ,

From the above response, Could you please confirm that the "DockerFile" is from the Peerplays repository and the workaround has to be added to it?

Hi @robert.hedler , From the above response, Could you please confirm that the "DockerFile" is from the Peerplays repository and the workaround has to be added to it?

Bharathi-Chandrasekaran commented

2023-10-30 18:37:06 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler ,

Next, If the existing User has to apply the workaround while upgrading to Mainnet 1.6.0, where exactly it has to be added? Please give me a clarity on this.

Could you please give your review and comments in the draft below?

https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install#1.2-workaround-for-peerplays-1.6.0-mainnet-release

Hi @robert.hedler , Next, If the existing User has to apply the workaround while upgrading to Mainnet 1.6.0, where exactly it has to be added? Please give me a clarity on this. Could you please give your review and comments in the draft below? https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/\~/changes/185/witnesses/installation-guides/docker-install#1.2-workaround-for-peerplays-1.6.0-mainnet-release

bobinson commented

2023-10-31 08:32:48 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler - Why are you using a different repository when this task is about the run.sh script ?

@Bharathi-Chandrasekaran - Make sure that we are documenting the steps about using the run.sh script and its documentation mentioned in https://peerplays.gitbook.io/peerplays-infrastructure-docs/witnesses/installation-guides/docker-install

@robert.hedler and @Bharathi-Chandrasekaran

I am surprised by the time taken to complete this task and discussing about things which are in no way related to the task. Can you both jump on a call and make sure this task completed within the next 2 days including today ?

Hi @robert.hedler - Why are you using a different repository when this task is about the run.sh script ? @Bharathi-Chandrasekaran - Make sure that we are documenting the steps about using the `run.sh` script and its documentation mentioned in https://peerplays.gitbook.io/peerplays-infrastructure-docs/witnesses/installation-guides/docker-install @robert.hedler and @Bharathi-Chandrasekaran I am surprised by the time taken to complete this task and discussing about things which are in no way related to the task. Can you both jump on a call and make sure this task completed within the next 2 days including today ?

Bharathi-Chandrasekaran commented

2023-10-31 12:30:21 +00:00

(Migrated from gitlab.com)

okay @bobinson

I will discuss with Robert over the call and complete the task.

okay @bobinson I will discuss with Robert over the call and complete the task.

Bharathi-Chandrasekaran commented

2023-11-03 18:24:29 +00:00

(Migrated from gitlab.com)

mentioned in merge request !253

Bharathi-Chandrasekaran commented

2023-11-03 19:39:13 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

Please find the issue and MR created.

Issue: https://gitlab.com/PBSA/peerplays/-/issues/567
MR: https://gitlab.com/PBSA/peerplays/-/merge_requests/253

@robert.hedler Please review the MR and provide additional comments (if any)

Thank you @christophersanborn for issue analysis and guiding me in creating the tickets.

Hi @bobinson , Please find the issue and MR created. **Issue:** https://gitlab.com/PBSA/peerplays/-/issues/567 **MR:** https://gitlab.com/PBSA/peerplays/-/merge_requests/253 @robert.hedler Please review the MR and provide additional comments (if any) Thank you @christophersanborn for issue analysis and guiding me in creating the tickets.

Bharathi-Chandrasekaran commented

2023-11-03 21:15:57 +00:00

(Migrated from gitlab.com)

Hi @bobinson ,

I have question regarding the documentation update.

As per my understanding and analysis, the user will not be performing build operation using run.sh and in the existing document there is no section about "Build --> ./run.sh build".

As Robert already pushed the changes into docker hub, the user will get updated image while cloning docker repository.
For your reference: https://hub.docker.com/r/peerplays/peerplays/tags

The fix should be done in the Peerplays core which has been addressed with MR.

So, Do you still suggest to add Build section & workaround in the document?

Note:

Internally, for building docker "docker build --no-cache -f Dockerfile -t peerplays" is used and "./run.sh build" is not preferred.
In the document, I have updated the Docker repository location from "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" to "git clone -b release https://gitlab.com/PBSA/peerplays-1.0/tools-libs/peerplays-docker.git".
Finally, I did "run.sh" verification in a Testnet node without adding workaround. The image install command, remote wallet access worked fine.

Hi @bobinson , I have question regarding the documentation update. As per my understanding and analysis, the user will not be performing build operation using run.sh and in the existing document there is no section about "Build --> ./run.sh build". As Robert already pushed the changes into docker hub, the user will get updated image while cloning docker repository. For your reference: https://hub.docker.com/r/peerplays/peerplays/tags The fix should be done in the Peerplays core which has been addressed with MR. So, Do you still suggest to add Build section & workaround in the document? **Note:** 1. Internally, for building docker "`docker build --no-cache -f Dockerfile -t peerplays`" is used and "./run.sh build" is not preferred. 2. In the document, I have updated the Docker repository location from "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" to "git clone -b release https://gitlab.com/PBSA/peerplays-1.0/tools-libs/peerplays-docker.git". 3. Finally, I did "run.sh" verification in a Testnet node without adding workaround. The image install command, remote wallet access worked fine.

bobinson commented

2023-11-04 07:30:36 +00:00

(Migrated from gitlab.com)

Hi @Bharathi-Chandrasekaran

As per my understanding and analysis, the user will not be performing build operation using run.sh and in the existing document there is no section about "Build --> ./run.sh build".

This is not correct as the user may choose to build in many cases. A common scenario is when the architecture type of the user's server is different and the user will use run.sh build

The build option etc is shown by run.sh help. This is script is a very popular tool and people in old Steem, Hive etc are familiar with tool.

As Robert already pushed the changes into docker hub, the user will get updated image while cloning docker repository. For your reference:

Docker container registries doesn't support git clone. Docker images from the registries should be pulled using a docker compatible command. In this context, when a user execute the command run.sh install without specific tag names, the latest docker images published by Robert will be pulled by the script.

The fix should be done in the Peerplays core which has been addressed with MR.

Which is the MR that addressed the issue ?

Hi @Bharathi-Chandrasekaran > As per my understanding and analysis, the user will not be performing build operation using run.sh and in the existing document there is no section about "Build --> ./run.sh build". This is not correct as the user may choose to build in many cases. A common scenario is when the architecture type of the user's server is different and the user will use `run.sh build` ![image](/uploads/22ce553aa75effecc23d92135077c950/image.png) The build option etc is shown by `run.sh help`. This is script is a very popular tool and people in old Steem, Hive etc are familiar with tool. > As Robert already pushed the changes into docker hub, the user will get updated image while cloning docker repository. For your reference: Docker container registries doesn't support `git clone`. Docker images from the registries should be pulled using a docker compatible command. In this context, when a user execute the command `run.sh install` without specific tag names, the latest docker images published by Robert will be pulled by the script. 3. > The fix should be done in the Peerplays core which has been addressed with MR. Which is the MR that addressed the issue ?

bobinson commented

2023-11-04 07:34:49 +00:00

(Migrated from gitlab.com)

Internally, for building docker "docker build --no-cache -f Dockerfile -t peerplays" is used and "./run.sh build" is not preferred.

What you mean by this ? The purpose of creating the run.sh tool itself was to avoid directly accessing the docker commands.

In the document, I have updated the Docker repository location from "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" to "git clone -b release https://gitlab.com/PBSA/peerplays-1.0/tools-libs/peerplays-docker.git".

Thanks.

Finally, I did "run.sh" verification in a Testnet node without adding workaround. The image install command, remote wallet access worked fine.

The published docker image is built by Robert with the necessary workarounds ? The install option is just pulling the docker images from docker hub. As I indicated weeks ago, capture the steps for build option for now & create an MR in the peerplays repository to change the docker build options so that the steps are documented for anyone manually building docker.

> Internally, for building docker "`docker build --no-cache -f Dockerfile -t peerplays`" is used and "./run.sh build" is not preferred. What you mean by this ? The purpose of creating the `run.sh` tool itself was to avoid directly accessing the docker commands. > In the document, I have updated the Docker repository location from "git clone -b release https://gitlab.com/PBSA/tools-libs/peerplays-docker.git" to "git clone -b release https://gitlab.com/PBSA/peerplays-1.0/tools-libs/peerplays-docker.git". Thanks. > Finally, I did "run.sh" verification in a Testnet node without adding workaround. The image install command, remote wallet access worked fine. The published docker image is built by Robert with the necessary workarounds ? The `install` option is just pulling the docker images from docker hub. As I indicated weeks ago, capture the steps for build option for now & create an MR in the peerplays repository to change the docker build options so that the steps are documented for anyone manually building docker.

Bharathi-Chandrasekaran commented

2023-11-04 12:43:19 +00:00

(Migrated from gitlab.com)

What you mean by this ? The purpose of creating the run.sh tool itself was to avoid directly accessing the docker commands.

I wanted to convey that the steps which Robert shared to build the docker image uses "docker build --no-cache -f Dockerfile -t peerplays" command and not "./run.sh build".

The published docker image is built by Robert with the necessary workarounds ? The install option is just pulling the docker images from docker hub. As I indicated weeks ago, capture the steps for build option for now & create an MR in the peerplays repository to change the docker build options so that the steps are documented for anyone manually building docker.

Okay I will capture the build option steps and add into the document.
I have added in my previous comment about the Issue and MR created for this issue.
Please find the issue and MR created.
Issue: https://gitlab.com/PBSA/peerplays/-/issues/567 MR: https://gitlab.com/PBSA/peerplays/-/merge_requests/253

> What you mean by this ? The purpose of creating the `run.sh` tool itself was to avoid directly accessing the docker commands. I wanted to convey that the steps which Robert shared to build the docker image uses "**docker build --no-cache -f Dockerfile -t peerplays**" command and not "**./run.sh build**". > The published docker image is built by Robert with the necessary workarounds ? The `install` option is just pulling the docker images from docker hub. As I indicated weeks ago, capture the steps for build option for now & create an MR in the peerplays repository to change the docker build options so that the steps are documented for anyone manually building docker. Okay I will capture the build option steps and add into the document. I have added in my previous comment about the Issue and MR created for this issue. Please find the issue and MR created. **Issue:** https://gitlab.com/PBSA/peerplays/-/issues/567 **MR:** https://gitlab.com/PBSA/peerplays/-/merge_requests/253

Bharathi-Chandrasekaran commented

2023-11-04 12:52:34 +00:00

(Migrated from gitlab.com)

This is not correct as the user may choose to build in many cases. A common scenario is when the architecture type of the user's server is different and the user will use run.sh build

Okay Bobinson. I understand the necessity. All I wanted to convey was there is no section that explain about "./run.sh build" except "build" in the command list.
I will collect the details about "build" and document the steps.

Which is the MR that addressed the issue ?
Please find the issue and MR created.

Issue: https://gitlab.com/PBSA/peerplays/-/issues/567 MR: https://gitlab.com/PBSA/peerplays/-/merge_requests/253

> This is not correct as the user may choose to build in many cases. A common scenario is when the architecture type of the user's server is different and the user will use `run.sh build` Okay Bobinson. I understand the necessity. All I wanted to convey was there is no section that explain about "./run.sh build" except "build" in the command list. I will collect the details about "build" and document the steps. >Which is the MR that addressed the issue ? Please find the issue and MR created. **Issue:** https://gitlab.com/PBSA/peerplays/-/issues/567 **MR:** https://gitlab.com/PBSA/peerplays/-/merge_requests/253

Bharathi-Chandrasekaran commented

2023-11-07 13:42:10 +00:00

(Migrated from gitlab.com)

Hi @robert.hedler ,

Based on your input, the Docker installation document is updated. Could you please review and provide your commands/feedback?

https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install

Hi @robert.hedler , Based on your input, the Docker installation document is updated. Could you please review and provide your commands/feedback? https://app.gitbook.com/o/-Lpj4bCPw8iNnqCwrLCQ/s/-McxuwdOwK1wrj2xdejn/~/changes/185/witnesses/installation-guides/docker-install

bobinson commented

2023-11-07 14:22:15 +00:00

(Migrated from gitlab.com)

@Bharathi-Chandrasekaran - once again you are mixing up between 2 different projects. The project/product run.sh is the script to automatically install the peerplays software & it doesn't need to download the peerplays source code.

Hi @christophersanborn : Can you help @Bharathi-Chandrasekaran this one as it seems there are lots of confusions. In general all that we need to do is to verify whether run.sh install is working & second, verify run.sh build is working. The install option should work out of the box and for build option, we may need to update the Dockerfiles.

New Peerplays docker files for 1.6.0 is available
Verify whether the run install options works
For the run.sh build - Please do the verification and if changes are required lets create an issue in the correct repository to avoid the issues.

![image](/uploads/60d10692859cec2d1a721673c34efc73/image.png) @Bharathi-Chandrasekaran - once again you are mixing up between 2 different projects. The project/product `run.sh` is the script to automatically install the peerplays software & it doesn't need to download the peerplays source code. Hi @christophersanborn : Can you help @Bharathi-Chandrasekaran this one as it seems there are lots of confusions. In general all that we need to do is to verify whether `run.sh install` is working & second, verify `run.sh build` is working. The `install` option should work out of the box and for `build` option, we may need to update the Dockerfiles. 1. New Peerplays docker files for 1.6.0 is available 2. Verify whether the `run install` options works 3. For the `run.sh build` - Please do the verification and if changes are required lets create an issue in the correct repository to avoid the issues.

bobinson commented

2023-11-07 14:22:57 +00:00

(Migrated from gitlab.com)

assigned to @christophersanborn and unassigned @robert.hedler

Bharathi-Chandrasekaran commented

2023-11-07 14:58:17 +00:00

(Migrated from gitlab.com)

Hi @bobinson

The steps are shared by Robert and I have updated the same.
I will check with Robert based on your suggestions.

Hi @bobinson The steps are shared by Robert and I have updated the same. I will check with Robert based on your suggestions.

bobinson commented

2023-11-07 15:00:32 +00:00