[bug] RPC `lookup_vote_ids` returns error on worker proposal votes. #574

New issue

Closed

opened 2023-12-07 16:53:21 +00:00 by christophersanborn · 7 comments

christophersanborn commented

2023-12-07 16:53:21 +00:00

(Migrated from gitlab.com)

Function database_api_impl::lookup_vote_ids() in libraries/app/database_api.cpp exceeds recursion depth when passed a worker-proposal vote ID.

Affects: As a result of this, the RPC get_full_accounts will fail when querying accounts that have voted for (or against) any worker proposals. As a second order result, login to NEX for these accounts is also broken, as NEX uses get_full_accounts for account name validation in the login screen.

Solution: The solution is increase the static variant recursion depth in the cases where the vote_id_type is worker.

Function `database_api_impl::lookup_vote_ids()` in libraries/app/database_api.cpp exceeds recursion depth when passed a worker-proposal vote ID. Affects: As a result of this, the RPC `get_full_accounts` will fail when querying accounts that have voted for (or against) any worker proposals. As a second order result, login to NEX for these accounts is also broken, as NEX uses `get_full_accounts` for account name validation in the login screen. Solution: The solution is increase the static variant recursion depth in the cases where the vote_id_type is `worker`. ![Screen Shot 2023-12-07 at 11.16.17 AM.png](/uploads/95d74fafca46521a7faaaed47486418f/Screen_Shot_2023-12-07_at_11.16.17_AM.png) ![Screen Shot 2023-12-07 at 11.16.42 AM.png](/uploads/8fa696785d2ec134a84cf5a3b92e23de/Screen_Shot_2023-12-07_at_11.16.42_AM.png)

[bug] RPC lookup_vote_ids returns error on worker proposal votes. #574

[bug] RPC `lookup_vote_ids` returns error on worker proposal votes. #574