Enable witness hardfork check #579

Open
opened 2024-01-18 06:46:20 +00:00 by vampik · 8 comments
vampik commented 2024-01-18 06:46:20 +00:00 (Migrated from gitlab.com)

Enable witness hardfork check

Enable witness hardfork check
vampik commented 2024-01-18 06:46:20 +00:00 (Migrated from gitlab.com)

assigned to @vampik

assigned to @vampik
vampik commented 2024-01-19 10:05:20 +00:00 (Migrated from gitlab.com)

mentioned in commit 87b4f4a242

mentioned in commit 87b4f4a242ee2f5f80abf90fb667153b3f8b7571
vampik commented 2024-01-19 10:06:19 +00:00 (Migrated from gitlab.com)

mentioned in merge request !264

mentioned in merge request !264
vampik commented 2024-01-22 06:09:38 +00:00 (Migrated from gitlab.com)

mentioned in commit d787d754ec

mentioned in commit d787d754ec714e6173384f468016d4b4c54679b0
prandnum commented 2024-01-23 19:50:16 +00:00 (Migrated from gitlab.com)

@vampik as discussed verified the following:

Steps Executed:

  1. Build the new peerplays witness node(commit d787d754ec (HEAD -> 579-enable-hardfork-check, origin/feature/579-enable-hardfork-check))
  2. Build existing peerplays witness node(commit d3d967a2d7 (HEAD -> master, tag: 1.6.1, origin/master, origin/HEAD))
  3. Created two directories(copied the binary created in step 1) and ran witness nodes
  4. Witnesses from both the processes were successfully creating blocks
  5. Created a new directory(copied the binary created in step 2) and ran the witness node with new witness id.
  6. The new witness node started creating blocks from #1(didn't join the existing blockchain)

This is done with only enabling witness configurations. Does this fix need to be tested by enabling son configurations also?

@vampik as discussed verified the following: Steps Executed: 1) Build the new peerplays witness node(commit d787d754ec714e6173384f468016d4b4c54679b0 (HEAD -> 579-enable-hardfork-check, origin/feature/579-enable-hardfork-check)) 2) Build existing peerplays witness node(commit d3d967a2d76792c95aa62a27961294dd7bff07c8 (HEAD -> master, tag: 1.6.1, origin/master, origin/HEAD)) 3) Created two directories(copied the binary created in step 1) and ran witness nodes 4) Witnesses from both the processes were successfully creating blocks 5) Created a new directory(copied the binary created in step 2) and ran the witness node with new witness id. 6) The new witness node started creating blocks from #1(didn't join the existing blockchain) This is done with only enabling witness configurations. Does this fix need to be tested by enabling son configurations also?
vampik commented 2024-01-24 04:16:13 +00:00 (Migrated from gitlab.com)

This functionality is about P2P connection and doesn't relate to SON.

This functionality is about P2P connection and doesn't relate to SON.
bobinson commented 2024-01-25 07:40:30 +00:00 (Migrated from gitlab.com)

Hi @prandnum - I think you ran the inverse scenario ? The scenario is, a network with few older versions of software running, lets say something from 2021 and then new nodes still syncing or attempting to sync from them. What we are attempting is to ignore/avoid all the older nodes and use only latest software. Is this what you tested ? Just making sure ...

Hi @prandnum - I think you ran the inverse scenario ? The scenario is, a network with few older versions of software running, lets say something from 2021 and then new nodes still syncing or attempting to sync from them. What we are attempting is to ignore/avoid all the older nodes and use only latest software. Is this what you tested ? Just making sure ...
prandnum commented 2024-01-25 15:31:06 +00:00 (Migrated from gitlab.com)

@bobinson yes. The test done was to see whether the blockchain nodes with new software is able to sync and when an old node is introduced it is unable to join.

@bobinson yes. The test done was to see whether the blockchain nodes with new software is able to sync and when an old node is introduced it is unable to join.
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#579
No description provided.