son accounts of sidechain nodes getting depleted when the primary wallet has insufficient funds

prandnum commented

2021-04-14 12:39:21 +00:00

(Migrated from gitlab.com)

Yesterday, the primary wallet account balance went below the fee(20 TEST tokens) and the nodes were continuously running this state.

By the time I got hold of the funds and put the network back in a stable state, I could see that the son accounts of the sidechain nodes(sonaccount01,sonaccount02...) the funds were depleted(in single digits). Each of them had 40+ test tokens with them.

The issue I believe is because sidechain nodes continuously generating proposals thereby losing funds to fees. It may not be a real-world scenario but good to have a protection mechanism.

Yesterday, the primary wallet account balance went below the fee(20 TEST tokens) and the nodes were continuously running this state. By the time I got hold of the funds and put the network back in a stable state, I could see that the son accounts of the sidechain nodes(sonaccount01,sonaccount02...) the funds were depleted(in single digits). Each of them had 40+ test tokens with them. The issue I believe is because sidechain nodes continuously generating proposals thereby losing funds to fees. It may not be a real-world scenario but good to have a protection mechanism.

prandnum commented

2021-04-14 12:39:52 +00:00

(Migrated from gitlab.com)

@bobinson @serkixenos @sierra19XX

CC: @hbelakon

@bobinson @serkixenos @sierra19XX CC: @hbelakon

prandnum commented

2021-04-14 12:40:23 +00:00

(Migrated from gitlab.com)

changed the description

bobinson commented

2021-04-14 12:55:04 +00:00

(Migrated from gitlab.com)

assigned to @sierra19XX

hbelakon commented

2021-04-16 13:11:50 +00:00

(Migrated from gitlab.com)

@sierra19XX what is the status of this issue? Is is still "pending" or it is already "in progress"?

serkixenos commented

2021-04-18 00:32:20 +00:00

(Migrated from gitlab.com)

There is no protection for spending without earning. Most of the SON operations have 0 fee. Running SON has its cost, but it also earns something, which may or may not work with QA use cases, because there is not enough transaction processing. What would be your expectations/suggestions on what to do when SON have 0 balance?

prandnum commented

2021-04-18 16:19:32 +00:00

(Migrated from gitlab.com)

Each cycle the selected SON checks for PW balance and marks the Primary Wallet as active OR inactive(when there are no funds) and only when the PW is active, the active SON creates a proposal?

sierra19XX commented

2021-04-20 11:25:50 +00:00

(Migrated from gitlab.com)

changed time estimate to 32h

sierra19XX commented

2021-04-28 10:26:36 +00:00

(Migrated from gitlab.com)

Time spent identifying the proposals that fail and come up with a design to mitigate core token loss.
Design doc published at https://peerplays.atlassian.net/wiki/spaces/PIX/pages/1865678849/SON+Plugin+Rate+Limiting+for+Proposal+Failures?streamsSourceProduct=jira

Time spent identifying the proposals that fail and come up with a design to mitigate core token loss. Design doc published at https://peerplays.atlassian.net/wiki/spaces/PIX/pages/1865678849/SON+Plugin+Rate+Limiting+for+Proposal+Failures?streamsSourceProduct=jira

sierra19XX commented

2021-04-28 10:26:37 +00:00

(Migrated from gitlab.com)

added 28h of time spent at 2021-04-28

sierra19XX commented

2021-04-28 10:27:47 +00:00

(Migrated from gitlab.com)

Coding in progress.

sierra19XX commented

2021-05-03 09:30:07 +00:00

(Migrated from gitlab.com)

https://gitlab.com/PBSA/peerplays/-/merge_requests/17

hbelakon commented

2021-05-06 17:54:59 +00:00

(Migrated from gitlab.com)

@sierra19XX who is reviewing this ticket? Can you please assign to Bobinson (or Kiran- if more appropriate) for review? Thanks!

sierra19XX commented

2021-05-07 11:39:20 +00:00

(Migrated from gitlab.com)

assigned to @bobinson

sierra19XX commented

2021-05-07 11:39:24 +00:00

(Migrated from gitlab.com)

unassigned @sierra19XX

prandnum commented

2021-06-18 19:54:54 +00:00

(Migrated from gitlab.com)

Kept the system in a degraded state(son-account didn't have sufficient TEST tokens) for more than 3hrs and the fund's depletion issues was not seen. But a new issue is seen #131

Closing this issue.

Kept the system in a degraded state(son-account didn't have sufficient TEST tokens) for more than 3hrs and the fund's depletion issues was not seen. But a new issue is seen #131 Closing this issue.

prandnum (Migrated from gitlab.com) closed this issue

2021-06-18 19:54:55 +00:00

sierra19XX commented

2021-07-27 05:00:45 +00:00

(Migrated from gitlab.com)

mentioned in merge request !25

son accounts of sidechain nodes getting depleted when the primary wallet has insufficient funds #70