Clarification the flow diagram #98

Closed
opened 2021-05-12 20:42:40 +00:00 by prandnum · 9 comments
prandnum commented 2021-05-12 20:42:40 +00:00 (Migrated from gitlab.com)

Reference: https://peerplays.gitbook.io/community-project-docs/son/hive-sons/functional-specs/hive-deposit-handling

In the penultimate step rather than being "Compile data, convert and send to Hive network" shouldn't it be "Compile data, convert and send Hive to Peerplays network"?

image

Reference: https://peerplays.gitbook.io/community-project-docs/son/hive-sons/functional-specs/hive-deposit-handling In the penultimate step rather than being "Compile data, convert and send to Hive network" shouldn't it be "Compile data, convert and send Hive to Peerplays network"? ![image](/uploads/e0db049a7237895e14d29ded0abf820a/image.png)
prandnum commented 2021-05-12 20:42:40 +00:00 (Migrated from gitlab.com)

added to epic &113

added to epic &113
prandnum commented 2021-05-12 20:43:34 +00:00 (Migrated from gitlab.com)

cc: @bobinson @hbelakon

cc: @bobinson @hbelakon
bobinson commented 2021-05-12 21:29:53 +00:00 (Migrated from gitlab.com)

yes - it should be to Peerplays network.

HIVE is debited from an account on the Hive blockchain (sender) and pHIVE is credited to an account on the Peerplays blockchain (receiver).

yes - it should be to Peerplays network. HIVE is debited from an account on the Hive blockchain (sender) and pHIVE is credited to an account on the Peerplays blockchain (receiver).
prandnum commented 2021-05-14 09:42:29 +00:00 (Migrated from gitlab.com)

@Hiltos1 please correct the text also

"When scheduled SON detects that a sidechain transaction object has been completed, it must collect all data from the sidechain transaction object, compile it, convert to a format that is ready for transmission to Hive network, and send this transaction to the Hive network."

@Hiltos1 please correct the text also `"When scheduled SON detects that a sidechain transaction object has been completed, it must collect all data from the sidechain transaction object, compile it, convert to a format that is ready for transmission to Hive network, and send this transaction to the Hive network."`
bobinson commented 2021-05-17 12:07:43 +00:00 (Migrated from gitlab.com)

marked this issue as related to #80

marked this issue as related to #80
Hiltos1 commented 2021-05-17 12:30:39 +00:00 (Migrated from gitlab.com)

assigned to @bobinson

assigned to @bobinson
Hiltos1 commented 2021-05-17 12:32:28 +00:00 (Migrated from gitlab.com)

Hi @bobinson and @prandnum
I have made the suggested updates. Please review and let me know if this issue is good to close.
Thanks!

Hi @bobinson and @prandnum I have made the suggested updates. Please review and let me know if this issue is good to close. Thanks!
Hiltos1 commented 2021-05-17 12:34:03 +00:00 (Migrated from gitlab.com)

mentioned in issue #80

mentioned in issue #80
Hiltos1 commented 2021-05-18 20:15:47 +00:00 (Migrated from gitlab.com)

Bobinson agreed in rocket chat that this issue has been reviewed and is good to close.
Thanks!

Bobinson agreed in rocket chat that this issue has been reviewed and is good to close. Thanks!
Hiltos1 (Migrated from gitlab.com) closed this issue 2021-05-18 20:15:48 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#98
No description provided.