Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

Draft: Redirect operation fee to dividend #653

Closed
hirunda wants to merge 3 commits from feature/274/redirect_transaction_fees_to_dividends into develop
pull from: feature/274/redirect_transaction_fees_to_dividends
merge into: Peerplays_Blockchain:develop
Conversation 12 Commits 3 Files changed 3 +99 -2
hirunda commented 2022-02-21 20:23:54 +00:00 (Migrated from gitlab.com)
Copy link
No description provided.
hirunda commented 2022-02-21 20:23:54 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @serkixenos

requested review from @serkixenos
hirunda commented 2022-02-21 20:23:54 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @hirunda

assigned to @hirunda
serkixenos commented 2022-02-21 20:35:34 +00:00 (Migrated from gitlab.com)
Copy link

>= instead of >

`>=` instead of `>`
serkixenos commented 2022-02-21 20:37:53 +00:00 (Migrated from gitlab.com)
Copy link

dividend_distribution_account is not optional. Why using fc::optional? If using fc::optional, you also need to check it for validity before using it, as it might be uninitialized. Checkout fc::optional::valid()

         /// The account which collects pending payouts
         account_id_type dividend_distribution_account;
dividend_distribution_account is not optional. Why using fc::optional? If using fc::optional, you also need to check it for validity before using it, as it might be uninitialized. Checkout fc::optional::valid() ``` /// The account which collects pending payouts account_id_type dividend_distribution_account; ```
hirunda commented 2022-02-22 12:54:16 +00:00 (Migrated from gitlab.com)
Copy link

I will provide the fix with next commit

I will provide the fix with next commit
hirunda commented 2022-02-22 12:56:54 +00:00 (Migrated from gitlab.com)
Copy link

OK. You are right ... There should be check.
Would be much simpler to stay only with account_id_type dividend_distribution_account;, without introducing fc::optional ?

OK. You are right ... There should be check. Would be much simpler to stay only with `account_id_type dividend_distribution_account;`, without introducing fc::optional ?
hirunda commented 2022-03-01 11:35:42 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/PBSA/peerplays/-/merge_requests/73/diffs?diff_id=341684797&start_sha=c729b247eda16f050c94629b91fa0cc2f4ef68ac#083cdba5f9f8df3588de47b22d2d380d6efc205f_135_131)
hirunda commented 2022-03-01 11:35:42 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/PBSA/peerplays/-/merge_requests/73/diffs?diff_id=341684797&start_sha=c729b247eda16f050c94629b91fa0cc2f4ef68ac#083cdba5f9f8df3588de47b22d2d380d6efc205f_138_131)
hirunda commented 2022-03-01 11:35:42 +00:00 (Migrated from gitlab.com)
Copy link

added 9 commits

  • c729b247...7d255894 - 7 commits from branch develop
  • b703b12c - Merge branch 'develop' into feature/274/redirect_transaction_fees_to_dividends
  • e8d8cf91 - redirect some fee to dividend account

Compare with previous version

added 9 commits <ul><li>c729b247...7d255894 - 7 commits from branch <code>develop</code></li><li>b703b12c - Merge branch &#39;develop&#39; into feature/274/redirect_transaction_fees_to_dividends</li><li>e8d8cf91 - redirect some fee to dividend account</li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/73/diffs?diff_id=341684797&start_sha=c729b247eda16f050c94629b91fa0cc2f4ef68ac)
hirunda commented 2022-03-01 13:11:55 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #274

mentioned in issue #274
serkixenos commented 2022-03-04 19:15:42 +00:00 (Migrated from gitlab.com)
Copy link

marked this merge request as draft

marked this merge request as **draft**
serkixenos commented 2022-09-14 17:02:18 +00:00 (Migrated from gitlab.com)
Copy link

Closing MR as obsolete, but keep the branch as wee might need these changes sooner or later.

Closing MR as obsolete, but keep the branch as wee might need these changes sooner or later.
serkixenos (Migrated from gitlab.com) closed this pull request 2022-09-14 17:02:20 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
confirmed

   
DevOps

   
documentation

   
enhancement

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
Medium

   
priority::Critical

(optional) Issues that are marked as critical priority. Should be taken care of ASAP.

  
priority::High

(optional) Issues that are marked as high priority.

  
priority::Low

(optional) Issues that are marked as low priority.

  
priority::Medium

(optional) Issues that are marked as medium priority.

  
QA-TestCases::Done

QA-Labels

  
QA-TestCases::InProgress

QA-Labels

  
RNG

   
security

(optional) Issues that relate to the security of the project.

  
severity:: Critical

   
severity:: High

   
severity:: Low

   
severity:: Medium

   
state:: Accepted

Issues that are newly created and have been accepted after review.

  
state:: Blocked

Issues that cannot be worked on due to other factors linked to it.

  
state:: Done

Issues that are closed with a working solution.

  
state:: in progress

Issues that are currently being worked on.

  
state:: in review

Issues that require a proposed solution to be reviewed.

  
state:: on hold

Issues that were at least accepted, that should not be worked on at the moment.

  
state:: Pending

Issues that are newly created and haven't been reviewed.

  
state:: Pushed to Prod

Tickets are verified in the stage infra and needs to be deployed in the production

  
state:: Revision Needed

Issues that need to be revised before being accepted.

  
state::out-of-scope

Task and issues which are out of scope due to change in requirements

  
suggestion

   
support

   
To Do

   
type :: Discussion

   
type :: Duplicate

(optional) Issues that are duplicates of existing issues in the same project.

  
type:: interaction-design

   
type:: New Feature

Issues that bring new functionality to the project.

  
type::bug

BUG

  
type::documentation

Issues that relate to the documentation of the project.

  
type::incident

severe issues that require immediate response

  
type::maintenance

Issues that require maintenance on the project.

  
type::question

Issues that are questions related to the project.

  
type::recurring-tasks

This label is used to track recurring tasks which may repeat daily, weekly or monthly.

  
vulnerability
No labels
confirmed
DevOps
documentation
enhancement
incident
Medium
priority::Critical
priority::High
priority::Low
priority::Medium
QA-TestCases::Done
QA-TestCases::InProgress
RNG
security
severity:: Critical
severity:: High
severity:: Low
severity:: Medium
state:: Accepted
state:: Blocked
state:: Done
state:: in progress
state:: in review
state:: on hold
state:: Pending
state:: Pushed to Prod
state:: Revision Needed
state::out-of-scope
suggestion
support
To Do
type :: Discussion
type :: Duplicate
type:: interaction-design
type:: New Feature
type::bug
type::documentation
type::incident
type::maintenance
type::question
type::recurring-tasks
vulnerability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#653
No description provided.
Delete branch "feature/274/redirect_transaction_fees_to_dividends"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?