Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

Ready : Bug 417 fix for Failing Unit test cases #722

Closed
mkhan17 wants to merge 3 commits from bug/issue416_corrected into feature/son-for-ethereum
pull from: bug/issue416_corrected
merge into: Peerplays_Blockchain:feature/son-for-ethereum
Conversation 17 Commits 3 Files changed 1 +163 -147
mkhan17 commented 2022-08-25 09:00:09 +00:00 (Migrated from gitlab.com)
Copy link
  1. To solve the issue in son_cli/update_son_votes_test, added two maintainance blocks.
  2. To solve the issue in son_cli/son_voting, added two maintainance blocks.
  3. To solve the issue in son_cli/cli_list_active_sons, corrected the for loop

Additionally added debug messages which could help in future debugging too

1. To solve the issue in son_cli/update_son_votes_test, added two maintainance blocks. 2. To solve the issue in son_cli/son_voting, added two maintainance blocks. 3. To solve the issue in son_cli/cli_list_active_sons, corrected the for loop Additionally added debug messages which could help in future debugging too
mkhan17 commented 2022-08-25 09:00:10 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @serkixenos and @bobinson

requested review from @serkixenos and @bobinson
mkhan17 commented 2022-08-25 09:00:10 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @mkhan17

assigned to @mkhan17
mkhan17 (Migrated from gitlab.com) changed target branch from master to feature/son-for-ethereum 2022-08-25 09:00:22 +00:00
mkhan17 commented 2022-08-25 12:53:17 +00:00 (Migrated from gitlab.com)
Copy link

changed title from {-Draft-} : Bug 417 fix for Failing Unit test cases to {+Ready+} : Bug 417 fix for Failing Unit test cases

changed title from **{-Draft-} : Bug 417 fix for Failing Unit test cases** to **{+Ready+} : Bug 417 fix for Failing Unit test cases**
serkixenos commented 2022-08-29 11:38:28 +00:00 (Migrated from gitlab.com)
Copy link

Remove these logs.

Remove these logs.
serkixenos commented 2022-08-29 11:38:28 +00:00 (Migrated from gitlab.com)
Copy link

Remove this log.

Remove this log.
serkixenos commented 2022-08-29 11:38:28 +00:00 (Migrated from gitlab.com)
Copy link

This call should be placed near calls that change state of the chain. Put it right before this line

BOOST_TEST_MESSAGE("Vote for 2 accounts with update_son_votes");

This call should be placed near calls that change state of the chain. Put it right before this line ```BOOST_TEST_MESSAGE("Vote for 2 accounts with update_son_votes");```
mkhan17 commented 2022-08-29 12:14:30 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/PBSA/peerplays/-/merge_requests/142/diffs?diff_id=471656777&start_sha=068e1b4107647e5994229547191528615cf43d6b#eeeba3563ed792900d1cb1563604db87ecd8fdd8_2875_2874)
mkhan17 commented 2022-08-29 12:14:31 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/PBSA/peerplays/-/merge_requests/142/diffs?diff_id=471656777&start_sha=068e1b4107647e5994229547191528615cf43d6b#eeeba3563ed792900d1cb1563604db87ecd8fdd8_2880_2878)
mkhan17 commented 2022-08-29 12:14:31 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/PBSA/peerplays/-/merge_requests/142/diffs?diff_id=471656777&start_sha=068e1b4107647e5994229547191528615cf43d6b#a043a52ed19e072f5a39e0cc7b72ea1e0431405b_487_485)
mkhan17 commented 2022-08-29 12:14:31 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>88ffbabd - Unit tests fail fix</li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/142/diffs?diff_id=471656777&start_sha=068e1b4107647e5994229547191528615cf43d6b)
mkhan17 commented 2022-08-29 12:15:42 +00:00 (Migrated from gitlab.com)
Copy link

Done

Done
mkhan17 commented 2022-08-29 12:16:06 +00:00 (Migrated from gitlab.com)
Copy link

Done

Done
mkhan17 commented 2022-08-29 12:17:44 +00:00 (Migrated from gitlab.com)
Copy link

Done

Done
mkhan17 commented 2022-08-29 12:17:47 +00:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
serkixenos commented 2022-08-29 22:43:56 +00:00 (Migrated from gitlab.com)
Copy link

added 8 commits

  • 88ffbabd...44589656 - 6 commits from branch feature/son-for-ethereum
  • 27c8126b - Merge branch 'feature/son-for-ethereum' into bug/issue416_corrected
  • 2871da5d - Add more debug messages to failing test

Compare with previous version

added 8 commits <ul><li>88ffbabd...44589656 - 6 commits from branch <code>feature/son-for-ethereum</code></li><li>27c8126b - Merge branch &#39;feature/son-for-ethereum&#39; into bug/issue416_corrected</li><li>2871da5d - Add more debug messages to failing test</li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/142/diffs?diff_id=472145860&start_sha=88ffbabd757ccba7b3ea81115c50d3105ecdcda5)
serkixenos commented 2022-09-04 22:09:55 +00:00 (Migrated from gitlab.com)
Copy link

Obsoleted by https://gitlab.com/PBSA/peerplays/-/merge_requests/148

Obsoleted by https://gitlab.com/PBSA/peerplays/-/merge_requests/148
serkixenos (Migrated from gitlab.com) closed this pull request 2022-09-04 22:09:57 +00:00
serkixenos commented 2022-09-05 13:11:14 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #416

mentioned in issue #416

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
confirmed

   
DevOps

   
documentation

   
enhancement

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
Medium

   
priority::Critical

(optional) Issues that are marked as critical priority. Should be taken care of ASAP.

  
priority::High

(optional) Issues that are marked as high priority.

  
priority::Low

(optional) Issues that are marked as low priority.

  
priority::Medium

(optional) Issues that are marked as medium priority.

  
QA-TestCases::Done

QA-Labels

  
QA-TestCases::InProgress

QA-Labels

  
RNG

   
security

(optional) Issues that relate to the security of the project.

  
severity:: Critical

   
severity:: High

   
severity:: Low

   
severity:: Medium

   
state:: Accepted

Issues that are newly created and have been accepted after review.

  
state:: Blocked

Issues that cannot be worked on due to other factors linked to it.

  
state:: Done

Issues that are closed with a working solution.

  
state:: in progress

Issues that are currently being worked on.

  
state:: in review

Issues that require a proposed solution to be reviewed.

  
state:: on hold

Issues that were at least accepted, that should not be worked on at the moment.

  
state:: Pending

Issues that are newly created and haven't been reviewed.

  
state:: Pushed to Prod

Tickets are verified in the stage infra and needs to be deployed in the production

  
state:: Revision Needed

Issues that need to be revised before being accepted.

  
state::out-of-scope

Task and issues which are out of scope due to change in requirements

  
suggestion

   
support

   
To Do

   
type :: Discussion

   
type :: Duplicate

(optional) Issues that are duplicates of existing issues in the same project.

  
type:: interaction-design

   
type:: New Feature

Issues that bring new functionality to the project.

  
type::bug

BUG

  
type::documentation

Issues that relate to the documentation of the project.

  
type::incident

severe issues that require immediate response

  
type::maintenance

Issues that require maintenance on the project.

  
type::question

Issues that are questions related to the project.

  
type::recurring-tasks

This label is used to track recurring tasks which may repeat daily, weekly or monthly.

  
vulnerability
No labels
confirmed
DevOps
documentation
enhancement
incident
Medium
priority::Critical
priority::High
priority::Low
priority::Medium
QA-TestCases::Done
QA-TestCases::InProgress
RNG
security
severity:: Critical
severity:: High
severity:: Low
severity:: Medium
state:: Accepted
state:: Blocked
state:: Done
state:: in progress
state:: in review
state:: on hold
state:: Pending
state:: Pushed to Prod
state:: Revision Needed
state::out-of-scope
suggestion
support
To Do
type :: Discussion
type :: Duplicate
type:: interaction-design
type:: New Feature
type::bug
type::documentation
type::incident
type::maintenance
type::question
type::recurring-tasks
vulnerability
Milestone
Clear milestone
No items
No milestone
Peerplays Improvements and Bugfixes AUG 15 - SEP 11
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#722
No description provided.
Delete branch "bug/issue416_corrected"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?