Peerplays_Blockchain/peerplays_migrated
1
0
Fork 0
Code Issues 35 Pull requests 4 Projects Releases 20 Packages Wiki Activity Actions

Draft: Draft: Slimmed Ubuntu 2004 image, ubuntu base image, and directory restructure #780

Closed
rilesdun wants to merge 5 commits from docker-build-fix into develop
pull from: docker-build-fix
merge into: Peerplays_Blockchain:develop
Conversation 8 Commits 5 Files changed 6 +400 -194
rilesdun commented 2023-01-17 12:36:07 +00:00 (Migrated from gitlab.com)
Copy link
  • Isolated each Dockerfile into its own directory under the main directory docker
  • Created a base ubuntu image to use to avoid repeated dependency installations (pushed to dockerhub)

The new image size:

updated-version          latest    fbb2a16fb3fd   2 hours ago   296MB

Previous image size:

old-version              latest    6dcfbebc9bc1   8 hours ago    2.38GB

Ubuntu 18 Image still requires updating

- Isolated each Dockerfile into its own directory under the main directory `docker` - Created a base ubuntu image to use to avoid repeated dependency installations (pushed to dockerhub) The new image size: ``` updated-version latest fbb2a16fb3fd 2 hours ago 296MB ``` Previous image size: ``` old-version latest 6dcfbebc9bc1 8 hours ago 2.38GB ``` Ubuntu 18 Image still requires updating
rilesdun commented 2023-01-17 12:36:08 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @serkixenos and @timur.5

requested review from @serkixenos and @timur.5
rilesdun commented 2023-01-17 12:36:08 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @rilesdun

assigned to @rilesdun
rilesdun commented 2023-01-17 12:36:18 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
rilesdun commented 2023-01-17 12:38:40 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @bobinson

requested review from @bobinson
rilesdun commented 2023-01-17 15:21:51 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • d1cc5355 - Update Dockerfile - added mainnet genesis.json file to final runtime image

Compare with previous version

added 1 commit <ul><li>d1cc5355 - Update Dockerfile - added mainnet genesis.json file to final runtime image</li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/200/diffs?diff_id=579643489&start_sha=e4a8764259b55acf311dc75a2508682c9a644c77)
bobinson commented 2023-01-18 07:51:57 +00:00 (Migrated from gitlab.com)
Copy link

The build instruction for 20.04 is the one given below right ? I have never used building in docker.

docker build --no-cache -f docker/ubuntu20/Dockerfile -t peerplays .

The build instruction for 20.04 is the one given below right ? I have never used building in docker. `docker build --no-cache -f docker/ubuntu20/Dockerfile -t peerplays .`
rilesdun commented 2023-01-18 19:05:32 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e5c1c3cd - added example.config.ini </li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/200/diffs?diff_id=581036513&start_sha=d1cc535579f0f18267f5bc49da19ac45b4ee4c8f)
rilesdun commented 2023-01-18 20:05:59 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • f1f969b2 - Update Dockerfile - Creating witness_node_data_dir and taking example...

Compare with previous version

added 1 commit <ul><li>f1f969b2 - Update Dockerfile - Creating witness_node_data_dir and taking example...</li></ul> [Compare with previous version](/PBSA/peerplays/-/merge_requests/200/diffs?diff_id=581075864&start_sha=e5c1c3cd1b68da39156d450ccb6c6eaccecfa2b9)
rilesdun (Migrated from gitlab.com) closed this pull request 2023-03-01 16:53:12 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
confirmed

   
DevOps

   
documentation

   
enhancement

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
Medium

   
priority::Critical

(optional) Issues that are marked as critical priority. Should be taken care of ASAP.

  
priority::High

(optional) Issues that are marked as high priority.

  
priority::Low

(optional) Issues that are marked as low priority.

  
priority::Medium

(optional) Issues that are marked as medium priority.

  
QA-TestCases::Done

QA-Labels

  
QA-TestCases::InProgress

QA-Labels

  
RNG

   
security

(optional) Issues that relate to the security of the project.

  
severity:: Critical

   
severity:: High

   
severity:: Low

   
severity:: Medium

   
state:: Accepted

Issues that are newly created and have been accepted after review.

  
state:: Blocked

Issues that cannot be worked on due to other factors linked to it.

  
state:: Done

Issues that are closed with a working solution.

  
state:: in progress

Issues that are currently being worked on.

  
state:: in review

Issues that require a proposed solution to be reviewed.

  
state:: on hold

Issues that were at least accepted, that should not be worked on at the moment.

  
state:: Pending

Issues that are newly created and haven't been reviewed.

  
state:: Pushed to Prod

Tickets are verified in the stage infra and needs to be deployed in the production

  
state:: Revision Needed

Issues that need to be revised before being accepted.

  
state::out-of-scope

Task and issues which are out of scope due to change in requirements

  
suggestion

   
support

   
To Do

   
type :: Discussion

   
type :: Duplicate

(optional) Issues that are duplicates of existing issues in the same project.

  
type:: interaction-design

   
type:: New Feature

Issues that bring new functionality to the project.

  
type::bug

BUG

  
type::documentation

Issues that relate to the documentation of the project.

  
type::incident

severe issues that require immediate response

  
type::maintenance

Issues that require maintenance on the project.

  
type::question

Issues that are questions related to the project.

  
type::recurring-tasks

This label is used to track recurring tasks which may repeat daily, weekly or monthly.

  
vulnerability
No labels
confirmed
DevOps
documentation
enhancement
incident
Medium
priority::Critical
priority::High
priority::Low
priority::Medium
QA-TestCases::Done
QA-TestCases::InProgress
RNG
security
severity:: Critical
severity:: High
severity:: Low
severity:: Medium
state:: Accepted
state:: Blocked
state:: Done
state:: in progress
state:: in review
state:: on hold
state:: Pending
state:: Pushed to Prod
state:: Revision Needed
state::out-of-scope
suggestion
support
To Do
type :: Discussion
type :: Duplicate
type:: interaction-design
type:: New Feature
type::bug
type::documentation
type::incident
type::maintenance
type::question
type::recurring-tasks
vulnerability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#780
No description provided.
Delete branch "docker-build-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?