#577 - add additional cmake flag for disabling sidechain plugin #843

Open
vampik wants to merge 1 commit from feature/577-sidechain-plugin into develop
vampik commented 2024-01-18 06:44:17 +00:00 (Migrated from gitlab.com)

#577 - add additional cmake flag for disabling sidechain plugin

#577 - add additional cmake flag for disabling sidechain plugin
vampik commented 2024-01-18 06:44:17 +00:00 (Migrated from gitlab.com)

requested review from @vampik, @christophersanborn, and @bobinson

requested review from @vampik, @christophersanborn, and @bobinson
vampik commented 2024-01-18 06:44:17 +00:00 (Migrated from gitlab.com)

assigned to @vampik

assigned to @vampik
bobinson (Migrated from gitlab.com) approved these changes 2024-01-18 06:44:17 +00:00
prandnum commented 2024-01-26 07:47:17 +00:00 (Migrated from gitlab.com)

After building with -DDISABLE_PEERPLAYS_SIDECHAIN_PLUGIN=1 peerplays_sidechain plugin is not recognized as expected.

root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# grep plugins witness_node_data_dir/config.ini 
# Space-separated list of plugins to activate
plugins = account_history accounts_list affiliate_stats bookie market_history witness peerplays_sidechain
root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# ./programs/witness_node/witness_node 
2740626ms th_a       main.cpp:194                  main                 ] Exiting with error:
10 assert_exception: Assert Exception
my->_available_plugins[name]: Unknown plugin 'peerplays_sidechain'
    {}
    th_a  application.cpp:990 enable_plugin
root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# 
After building with `-DDISABLE_PEERPLAYS_SIDECHAIN_PLUGIN=1` peerplays_sidechain plugin is not recognized as expected. ``` root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# grep plugins witness_node_data_dir/config.ini # Space-separated list of plugins to activate plugins = account_history accounts_list affiliate_stats bookie market_history witness peerplays_sidechain root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# ./programs/witness_node/witness_node 2740626ms th_a main.cpp:194 main ] Exiting with error: 10 assert_exception: Assert Exception my->_available_plugins[name]: Unknown plugin 'peerplays_sidechain' {} th_a application.cpp:990 enable_plugin root@c909bf971c5e:/home/peerplays/peerplays/build-testnet# ```
vampik commented 2024-01-26 08:03:15 +00:00 (Migrated from gitlab.com)

This plugin is disabled and not known. So it shouldn't be present in config.ini file.

This plugin is disabled and not known. So it shouldn't be present in `config.ini` file.
prandnum commented 2024-01-26 15:09:53 +00:00 (Migrated from gitlab.com)

correct, even if it is present it isn't recognized as expected.

correct, even if it is present it isn't recognized as expected.
vampik commented 2024-01-31 06:48:53 +00:00 (Migrated from gitlab.com)

If you disable sidechain plugin, you shouldn't specify it in the list of plugins in config file.
The same way, if you specify in this list any other not known name, you would have the same error.

If you disable sidechain plugin, you shouldn't specify it in the list of plugins in config file. The same way, if you specify in this list any other not known name, you would have the same error.
vampik commented 2024-01-31 07:01:28 +00:00 (Migrated from gitlab.com)

In I enable this plugin, peerplays_sidechain is recognized in config file.

In I enable this plugin, `peerplays_sidechain` is recognized in config file.
bobinson commented 2024-04-03 06:30:43 +00:00 (Migrated from gitlab.com)

approved this merge request

approved this merge request
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/577-sidechain-plugin:feature/577-sidechain-plugin
git checkout feature/577-sidechain-plugin

Merge

Merge the changes and update on Forgejo.
git checkout develop
git merge --no-ff feature/577-sidechain-plugin
git checkout develop
git merge --ff-only feature/577-sidechain-plugin
git checkout feature/577-sidechain-plugin
git rebase develop
git checkout develop
git merge --no-ff feature/577-sidechain-plugin
git checkout develop
git merge --squash feature/577-sidechain-plugin
git checkout develop
git merge --ff-only feature/577-sidechain-plugin
git checkout develop
git merge feature/577-sidechain-plugin
git push origin develop
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Peerplays_Blockchain/peerplays_migrated#843
No description provided.