* fix rng and get_winner_numbers implemented * coipied code for bitshares fixing 429 and 433 isuues * ticket_purchase_operation implemented. added lottery_options to asset * lottery end implemented * minor logic changes. added db_api and cli_wallet methods * fix reindex on peerplays network * fix some tests. add gitlab-ci.yml * add pull to gitlab-ci * fix * fix and comment some tests * added owner to lottery_asset_options. commented async call in on_applied_block callback * added get_account_lotteries method to db_api and cli, lottery end_date and ticket_price verification * merge get_account_lotteries branch. fix create_witness test * fix test genesis and end_date verification * fixed indices sorting and lottery end checking by date * update db_version for replay and removed duplicate include files * Added ntp and upgraded boost version * Revert "GPOS protocol" * need to remove backup files * virtual-op-fix for deterministic virtual_op number * Merged beatrice into 5050 * Updated gitmodules, changes to allow voting on lottery fee * Removed submodule libraries/fc * Added libraries/fc * added missing , in types.hpp * Added sweeps parameters to parameter_extension * added missing comma in operations.hpp, small changes to config.hpp * fixed returntype in chain_parameters.hpp * removed sweeps_parameter_extensions * Changed fc library * fixed asset_object * Changed peerplays-fc submodule * Changed fc submodule to ubuntu 18.04 upgrade * Removed submodule libraries/fc * Added fc library back * fix casting in overloaded function * Removed blind_sign and unblind_signature functions * Added new lottery_asset_create_operation * Changed sweeps hardfork time * Removed redundant if from asset_evaluator and fixed db_notify * fixed duplicate code in fee_tests * removed redundant tgenesis file * Enable building on Ubuntu 18.04 using GCC 7 compiler * fix: is_benefactor_reward had the default value of true when not set * Docker file for Ubuntu 18.04 Base image updated to Unbuntu 18.04 Prerequisite list updated Basic configuration updated * Quick fix: Added missing package pkg-config * Docker file updates * 5050 fee update and compilation error fix * Dockerfile, set system locale Prevents locale::facet::_S_create_c_locale name error * Update README.md Fix typo * Update README.md * Changed hardfork time for SWEEPS and Core-429 * revert master changes that were brought in previous commit * Fixed error when account_history_object with id 0 doesnt exist * Fixed error while loading object database * test for zero id object in account history * Reorder operations in Dockerfile, to make image creation faster - Reorder prevents unnecessary building of Boost libraries * Fix for irrelevant signature included issue * fix copyrigth messages order * remove double empty lines * Backport fix for `get_account_history` from https://github.com/bitshares/bitshares-core/pull/628 and add additional account history test case * NTP client back * GRPH-53-Log_format_error * Merge pull request #1036 from jmjatlanta/issue_730 Add fail_reason to proposal_object * Unit test case fixes and prepared SONs base * Use offsetof instead of custom macro * Hide some compiler warnings * Make all the tests compile * Add nullptr check in api.cpp for easier testing * Add test case for broadcast_trx_with_callback API * Unit test case fixes and prepared SONs base * Merge pull request #714 from pmconrad/json_fix JSON fix * Increase max depth for trx confirmation callback * Adapt to variant API with `max_depth` argument * Update fc submodule * Created unit test for #325 * remove needless find() * GRPH-4-CliWallet_crash_ctrlD * fix copyright message * Make all the tests compile * increase delay for node connection * Increase block creation timeout to 2500ms * remove cache from cli get_account * add cli tests framework * Adjust newly merged code to new API * Improved resilience of block database against corruption * Merged changes from Bitshares PR 1036 * GRPH-76 - Short-cut long sequences of missed blocks Fixes database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.) * Moved reindex logic into database / chain_database, make use of additional blocks in block_database Fixed tests wrt db.open * Enable undo + fork database for final blocks in a replay Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests * Log starting block number of replay * Prevent unsigned integer underflow * Fixed lock detection * Dont leave _data_dir empty if db is locked * Writing the object_database is now almost atomic * Improved consistency check for block_log * Cut back block_log index file if inconsistent * Fixed undo_database * Added test case for broken merge on empty undo_db * Merge pull request #938 from bitshares/fix-block-storing Store correct block ID when switching forks * exclude second undo_db.enable() call in some cases * Add missing change * change bitshares to core in message * Fixed integer overflow issue * Fix for for history ID mismatch ( Bitshares PR #875 ) * Update the FC submodule with the changes for GRPH-4 * Fix #436 object_database created outside of witness data directory * supplement more comments on database::_opened variable * prevent segfault when destructing application obj * Fixed duplicate ops returned from get_account_history * minor performance improvement * Added comment * Merged Bitshares PR #1462 and compilation fixes * Support/gitlab (#123) * Updated gitlab process * Fix undefined references in cli test * Fixed test failures and compilation issue * Fixed account_history_pagination test * Fix compilation in debug mode * Removed unrelated comment * Skip auth check when pushing self-generated blocks * Extract public keys before pushing a transaction * Dereference chain_database shared_ptr * Updated transaction::signees to mutable and * updated get_signature_keys() to return a const reference, * get_signature_keys() will update signees on first call, * modified test cases and wallet.cpp accordingly, * no longer construct a new signed_transaction object before pushing * Added get_asset_count API * Allow sufficient space for new undo_session * Throw for deep nesting * No longer extract public keys before pushing a trx and removed unused new added constructor and _get_signature_keys() function from signed_transaction struct * Added cli_test to CI * use random port numbers in app_test (#154) * proposal fail_reason bug fixed (#157) * Added Sonarcloud code_quality to CI (#159) * Added sonarcloud analysis (#158) * fix for lottery end * fix declarations * fix declarations * fix boost integer * fix compilation * fix chain tests * fix app_test * try to fix cli test * fix incorrect max_depth param * working cli test * correct fc version
316 lines
14 KiB
C++
316 lines
14 KiB
C++
/*
|
|
* Copyright (c) 2015 Cryptonomex, Inc., and contributors.
|
|
*
|
|
* The MIT License
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
#include <graphene/chain/hardfork.hpp>
|
|
#include <graphene/chain/proposal_evaluator.hpp>
|
|
#include <graphene/chain/proposal_object.hpp>
|
|
#include <graphene/chain/account_object.hpp>
|
|
#include <graphene/chain/protocol/account.hpp>
|
|
#include <graphene/chain/protocol/fee_schedule.hpp>
|
|
#include <graphene/chain/protocol/tournament.hpp>
|
|
#include <graphene/chain/exceptions.hpp>
|
|
#include <graphene/chain/hardfork.hpp>
|
|
|
|
#include <fc/smart_ref_impl.hpp>
|
|
|
|
namespace graphene { namespace chain {
|
|
|
|
struct proposal_operation_hardfork_visitor
|
|
{
|
|
typedef void result_type;
|
|
const fc::time_point_sec block_time;
|
|
|
|
proposal_operation_hardfork_visitor( const fc::time_point_sec bt ) : block_time(bt) {}
|
|
|
|
template<typename T>
|
|
void operator()(const T &v) const {}
|
|
|
|
void operator()(const committee_member_update_global_parameters_operation &op) const {
|
|
if( block_time < HARDFORK_1000_TIME ) // TODO: remove after hf
|
|
FC_ASSERT( !op.new_parameters.extensions.value.min_bet_multiplier.valid()
|
|
&& !op.new_parameters.extensions.value.max_bet_multiplier.valid()
|
|
&& !op.new_parameters.extensions.value.betting_rake_fee_percentage.valid()
|
|
&& !op.new_parameters.extensions.value.permitted_betting_odds_increments.valid()
|
|
&& !op.new_parameters.extensions.value.live_betting_delay_time.valid(),
|
|
"Parameter extensions are not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const graphene::chain::tournament_payout_operation &o) const {
|
|
// TODO: move check into tournament_payout_operation::validate after HARDFORK_999_TIME
|
|
FC_ASSERT( block_time < HARDFORK_999_TIME, "Not allowed!" );
|
|
}
|
|
|
|
void operator()(const graphene::chain::asset_settle_cancel_operation &o) const {
|
|
// TODO: move check into asset_settle_cancel_operation::validate after HARDFORK_999_TIME
|
|
FC_ASSERT( block_time < HARDFORK_999_TIME, "Not allowed!" );
|
|
}
|
|
|
|
void operator()(const graphene::chain::account_create_operation &aco) const {
|
|
// TODO: remove after HARDFORK_999_TIME
|
|
if (block_time < HARDFORK_999_TIME)
|
|
FC_ASSERT( !aco.extensions.value.affiliate_distributions.valid(), "Affiliate reward distributions not allowed yet" );
|
|
}
|
|
|
|
void operator()(const sport_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "sport_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const event_group_create_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_group_create_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const event_group_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_group_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const event_create_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_create_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const event_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_rules_create_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_rules_create_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_rules_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_rules_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_group_create_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_create_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_create_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_create_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const bet_place_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "bet_place_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_group_resolve_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_resolve_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_group_cancel_unmatched_bets_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_cancel_unmatched_bets_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const bet_cancel_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_resolve_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_group_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_group_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const betting_market_update_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "betting_market_update_operation not allowed yet!" );
|
|
}
|
|
|
|
void operator()(const event_update_status_operation &v) const {
|
|
FC_ASSERT( block_time >= HARDFORK_1000_TIME, "event_update_status_operation not allowed yet!" );
|
|
}
|
|
|
|
// loop and self visit in proposals
|
|
void operator()(const proposal_create_operation &v) const {
|
|
for (const op_wrapper &op : v.proposed_ops)
|
|
op.op.visit(*this);
|
|
}
|
|
};
|
|
|
|
void_result proposal_create_evaluator::do_evaluate(const proposal_create_operation& o)
|
|
{ try {
|
|
const database& d = db();
|
|
|
|
proposal_operation_hardfork_visitor vtor( d.head_block_time() );
|
|
vtor( o );
|
|
|
|
const auto& global_parameters = d.get_global_properties().parameters;
|
|
|
|
FC_ASSERT( o.expiration_time > d.head_block_time(), "Proposal has already expired on creation." );
|
|
FC_ASSERT( o.expiration_time <= d.head_block_time() + global_parameters.maximum_proposal_lifetime,
|
|
"Proposal expiration time is too far in the future.");
|
|
FC_ASSERT( !o.review_period_seconds || fc::seconds(*o.review_period_seconds) < (o.expiration_time - d.head_block_time()),
|
|
"Proposal review period must be less than its overall lifetime." );
|
|
|
|
{
|
|
// If we're dealing with the committee authority, make sure this transaction has a sufficient review period.
|
|
flat_set<account_id_type> auths;
|
|
vector<authority> other;
|
|
for( auto& op : o.proposed_ops )
|
|
{
|
|
operation_get_required_authorities(op.op, auths, auths, other);
|
|
}
|
|
|
|
FC_ASSERT( other.size() == 0 ); // TODO: what about other???
|
|
|
|
if( auths.find(GRAPHENE_COMMITTEE_ACCOUNT) != auths.end() )
|
|
{
|
|
GRAPHENE_ASSERT(
|
|
o.review_period_seconds.valid(),
|
|
proposal_create_review_period_required,
|
|
"Review period not given, but at least ${min} required",
|
|
("min", global_parameters.committee_proposal_review_period)
|
|
);
|
|
GRAPHENE_ASSERT(
|
|
*o.review_period_seconds >= global_parameters.committee_proposal_review_period,
|
|
proposal_create_review_period_insufficient,
|
|
"Review period of ${t} specified, but at least ${min} required",
|
|
("t", *o.review_period_seconds)
|
|
("min", global_parameters.committee_proposal_review_period)
|
|
);
|
|
}
|
|
}
|
|
|
|
for( const op_wrapper& op : o.proposed_ops )
|
|
_proposed_trx.operations.push_back(op.op);
|
|
_proposed_trx.validate();
|
|
|
|
return void_result();
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
object_id_type proposal_create_evaluator::do_apply(const proposal_create_operation& o)
|
|
{ try {
|
|
database& d = db();
|
|
|
|
const proposal_object& proposal = d.create<proposal_object>([&](proposal_object& proposal) {
|
|
_proposed_trx.expiration = o.expiration_time;
|
|
proposal.proposed_transaction = _proposed_trx;
|
|
proposal.proposer = o.fee_paying_account;
|
|
proposal.expiration_time = o.expiration_time;
|
|
if( o.review_period_seconds )
|
|
proposal.review_period_time = o.expiration_time - *o.review_period_seconds;
|
|
|
|
//Populate the required approval sets
|
|
flat_set<account_id_type> required_active;
|
|
vector<authority> other;
|
|
|
|
// TODO: consider caching values from evaluate?
|
|
for( auto& op : _proposed_trx.operations )
|
|
operation_get_required_authorities(op, required_active, proposal.required_owner_approvals, other);
|
|
|
|
//All accounts which must provide both owner and active authority should be omitted from the active authority set;
|
|
//owner authority approval implies active authority approval.
|
|
std::set_difference(required_active.begin(), required_active.end(),
|
|
proposal.required_owner_approvals.begin(), proposal.required_owner_approvals.end(),
|
|
std::inserter(proposal.required_active_approvals, proposal.required_active_approvals.begin()));
|
|
});
|
|
|
|
return proposal.id;
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
void_result proposal_update_evaluator::do_evaluate(const proposal_update_operation& o)
|
|
{ try {
|
|
database& d = db();
|
|
|
|
_proposal = &o.proposal(d);
|
|
|
|
if( _proposal->review_period_time && d.head_block_time() >= *_proposal->review_period_time )
|
|
FC_ASSERT( o.active_approvals_to_add.empty() && o.owner_approvals_to_add.empty(),
|
|
"This proposal is in its review period. No new approvals may be added." );
|
|
|
|
for( account_id_type id : o.active_approvals_to_remove )
|
|
{
|
|
FC_ASSERT( _proposal->available_active_approvals.find(id) != _proposal->available_active_approvals.end(),
|
|
"", ("id", id)("available", _proposal->available_active_approvals) );
|
|
}
|
|
for( account_id_type id : o.owner_approvals_to_remove )
|
|
{
|
|
FC_ASSERT( _proposal->available_owner_approvals.find(id) != _proposal->available_owner_approvals.end(),
|
|
"", ("id", id)("available", _proposal->available_owner_approvals) );
|
|
}
|
|
|
|
return void_result();
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
void_result proposal_update_evaluator::do_apply(const proposal_update_operation& o)
|
|
{ try {
|
|
database& d = db();
|
|
|
|
// Potential optimization: if _executed_proposal is true, we can skip the modify step and make push_proposal skip
|
|
// signature checks. This isn't done now because I just wrote all the proposals code, and I'm not yet 100% sure the
|
|
// required approvals are sufficient to authorize the transaction.
|
|
d.modify(*_proposal, [&o, &d](proposal_object& p) {
|
|
p.available_active_approvals.insert(o.active_approvals_to_add.begin(), o.active_approvals_to_add.end());
|
|
p.available_owner_approvals.insert(o.owner_approvals_to_add.begin(), o.owner_approvals_to_add.end());
|
|
for( account_id_type id : o.active_approvals_to_remove )
|
|
p.available_active_approvals.erase(id);
|
|
for( account_id_type id : o.owner_approvals_to_remove )
|
|
p.available_owner_approvals.erase(id);
|
|
for( const auto& id : o.key_approvals_to_add )
|
|
p.available_key_approvals.insert(id);
|
|
for( const auto& id : o.key_approvals_to_remove )
|
|
p.available_key_approvals.erase(id);
|
|
});
|
|
|
|
// If the proposal has a review period, don't bother attempting to authorize/execute it.
|
|
// Proposals with a review period may never be executed except at their expiration.
|
|
if( _proposal->review_period_time )
|
|
return void_result();
|
|
|
|
if( _proposal->is_authorized_to_execute(d) )
|
|
{
|
|
// All required approvals are satisfied. Execute!
|
|
_executed_proposal = true;
|
|
try {
|
|
_processed_transaction = d.push_proposal(*_proposal);
|
|
} catch(fc::exception& e) {
|
|
d.modify(*_proposal, [&e](proposal_object& p) {
|
|
p.fail_reason = e.to_string(fc::log_level(fc::log_level::all));
|
|
});
|
|
wlog("Proposed transaction ${id} failed to apply once approved with exception:\n----\n${reason}\n----\nWill try again when it expires.",
|
|
("id", o.proposal)("reason", e.to_detail_string()));
|
|
_proposal_failed = true;
|
|
}
|
|
}
|
|
|
|
return void_result();
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
void_result proposal_delete_evaluator::do_evaluate(const proposal_delete_operation& o)
|
|
{ try {
|
|
database& d = db();
|
|
|
|
_proposal = &o.proposal(d);
|
|
|
|
auto required_approvals = o.using_owner_authority? &_proposal->required_owner_approvals
|
|
: &_proposal->required_active_approvals;
|
|
FC_ASSERT( required_approvals->find(o.fee_paying_account) != required_approvals->end(),
|
|
"Provided authority is not authoritative for this proposal.",
|
|
("provided", o.fee_paying_account)("required", *required_approvals));
|
|
|
|
return void_result();
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
void_result proposal_delete_evaluator::do_apply(const proposal_delete_operation& o)
|
|
{ try {
|
|
db().remove(*_proposal);
|
|
|
|
return void_result();
|
|
} FC_CAPTURE_AND_RETHROW( (o) ) }
|
|
|
|
} } // graphene::chain
|